74339 2011-12-12 14:33:25 -0800 Add destroy method to MethodTable 2011-12-18 12:22:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74331 74341 1 mhahnenberg mhahnenberg oldest_to_newest 519478 0 mhahnenberg 2011-12-12 14:33:25 -0800 In order to have dynamic dispatch for our destructors, we will add a destroy function pointer to the MethodTable, which will be responsible for doing the same thing that the old virtual destructor did. We will also change the code in MarkedBlock::callDestructor to use this new destroy function rather than calling the virtual destructor directly. Initially the destroy function will just call the old virtual destructor. 519513 1 118862 mhahnenberg 2011-12-12 14:51:44 -0800 Created attachment 118862 Add destroy to MethodTable No changelog (see bug 74331). 519541 2 118862 ggaren 2011-12-12 15:03:25 -0800 Comment on attachment 118862 Add destroy to MethodTable You can use your Bugzilla comments in your ChangeLog. 118862 2011-12-12 14:51:44 -0800 2011-12-12 15:03:25 -0800 Add destroy to MethodTable 0006-Added-destroy-method-to-MethodTable-which-calls-the-.patch text/plain 4168 mhahnenberg RnJvbSBhODk3NDVkYzVjNjQ0MWM5YzYzZDgwMTk2OWNjYWJhYjliY2QyMGJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIEhhaG5lbmJlcmcgPG1oYWhuZW5iZXJnQGFwcGxlLmNv bT4KRGF0ZTogVHVlLCA2IERlYyAyMDExIDEwOjE0OjI3IC0wODAwClN1YmplY3Q6IFtQQVRDSCAw Ni8xOF0gQWRkZWQgZGVzdHJveSBtZXRob2QgdG8gTWV0aG9kVGFibGUsIHdoaWNoIGNhbGxzIHRo ZQogdmlydHVhbCBkZXN0cnVjdG9yLiAgVGhpcyBpcyBub3cgY2FsbGVkIGluCiBNYXJrZWRCbG9j azo6Y2FsbERlc3RydWN0b3IgaW5zdGVhZCBvZiB0aGUgdmlydHVhbAogZGVzdHJ1Y3Rvci4KCi0t LQogU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cCAgIHwgICAgMSArCiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAgfCAgICAyICstCiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DbGFzc0luZm8uaCAgfCAgICA0ICsrKysKIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5jcHAgICB8ICAgIDUgKysrKysKIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oICAgICB8ICAgIDEgKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaCAgIHwgICAgMiArLQogNiBmaWxlcyBjaGFu Z2VkLCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUuZXhwCmluZGV4IDdlMTY2MTcuLmEyZTI2MmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cApAQCAtMjYzLDYgKzI2Myw3IEBAIF9fWk4z SlNDNFlhcnI5aW50ZXJwcmV0RVBOUzBfMTVCeXRlY29kZVBhdHRlcm5FUktOU183VVN0cmluZ0Vq alBpCiBfX1pOM0pTQzRjYWxsRVBOU185RXhlY1N0YXRlRU5TXzdKU1ZhbHVlRU5TXzhDYWxsVHlw ZUVSS05TXzhDYWxsRGF0YUVTMl9SS05TXzdBcmdMaXN0RQogX19aTjNKU0M2SlNDZWxsMTFnZXRD YWxsRGF0YUVQUzBfUk5TXzhDYWxsRGF0YUUKIF9fWk4zSlNDNkpTQ2VsbDE2Z2V0Q29uc3RydWN0 RGF0YUVQUzBfUk5TXzEzQ29uc3RydWN0RGF0YUUKK19fWk4zSlNDNkpTQ2VsbDdkZXN0cm95RVBT MF8KIF9fWk4zSlNDNkpTQ2VsbDlnZXRPYmplY3RFdgogX19aTjNKU0M2SlNMb2NrMTJEcm9wQWxs TG9ja3NDMUVOU18xNEpTTG9ja0JlaGF2aW9yRQogX19aTjNKU0M2SlNMb2NrMTJEcm9wQWxsTG9j a3NDMUVQTlNfOUV4ZWNTdGF0ZUUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL01hcmtlZEJsb2NrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJs b2NrLmNwcAppbmRleCBjODA2ZjlkLi4zZmNhYTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya2VkQmxvY2suY3BwCkBAIC03MCw3ICs3MCw3IEBAIGlubGluZSB2b2lkIE1hcmtl ZEJsb2NrOjpjYWxsRGVzdHJ1Y3RvcihKU0NlbGwqIGNlbGwpCiAgICAgbV9oZWFwLT5tX2Rlc3Ry b3llZFR5cGVDb3VudHMuY291bnRWUHRyKHZwdHIpOwogI2VuZGlmCiAgICAgaWYgKGNlbGwtPnVu dmFsaWRhdGVkQ2xhc3NJbmZvKCkgIT0gJkpTRmluYWxPYmplY3Q6OnNfaW5mbykKLSAgICAgICAg Y2VsbC0+fkpTQ2VsbCgpOworICAgICAgICBjZWxsLT5tZXRob2RUYWJsZSgpLT5kZXN0cm95KGNl bGwpOwogCiAgICAgY2VsbC0+emFwKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9DbGFzc0luZm8uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NsYXNzSW5mby5oCmluZGV4IDA5ZmVkYjMuLjlmZmY2NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0NsYXNzSW5mby5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NsYXNzSW5mby5oCkBAIC0zMyw2ICszMyw5IEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgIHN0cnVjdCBIYXNoVGFibGU7CiAKICAgICBzdHJ1Y3QgTWV0aG9kVGFibGUgeworICAg ICAgICB0eXBlZGVmIHZvaWQgKCpEZXN0cm95RnVuY3Rpb25QdHIpKEpTQ2VsbCopOworICAgICAg ICBEZXN0cm95RnVuY3Rpb25QdHIgZGVzdHJveTsKKwogICAgICAgICB0eXBlZGVmIHZvaWQgKCpW aXNpdENoaWxkcmVuRnVuY3Rpb25QdHIpKEpTQ2VsbCosIFNsb3RWaXNpdG9yJik7CiAgICAgICAg IFZpc2l0Q2hpbGRyZW5GdW5jdGlvblB0ciB2aXNpdENoaWxkcmVuOwogCkBAIC0xMTQsNiArMTE3 LDcgQEAgc3RydWN0IE1lbWJlckNoZWNrIyNtZW1iZXIgeyBcCiAjZGVmaW5lIEhBU19NRU1CRVJf TkFNRUQoa2xhc3MsIG5hbWUpIChNZW1iZXJDaGVjayMjbmFtZTxrbGFzcz46OmhhcykKIAogI2Rl ZmluZSBDUkVBVEVfTUVUSE9EX1RBQkxFKENsYXNzTmFtZSkgeyBcCisgICAgICAgICZDbGFzc05h bWU6OmRlc3Ryb3ksIFwKICAgICAgICAgJkNsYXNzTmFtZTo6dmlzaXRDaGlsZHJlbiwgXAogICAg ICAgICAmQ2xhc3NOYW1lOjpnZXRDYWxsRGF0YSwgXAogICAgICAgICAmQ2xhc3NOYW1lOjpnZXRD b25zdHJ1Y3REYXRhLCBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NlbGwuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmNwcApp bmRleCA0OTFlZjA4Li4xMzIyNGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0NlbGwuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT Q2VsbC5jcHAKQEAgLTMxLDYgKzMxLDExIEBACiAKIG5hbWVzcGFjZSBKU0MgewogCit2b2lkIEpT Q2VsbDo6ZGVzdHJveShKU0NlbGwqIGNlbGwpCit7CisgICAgY2VsbC0+fkpTQ2VsbCgpOworfQor CiBib29sIEpTQ2VsbDo6Z2V0U3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgVVN0cmluZyZzdHJpbmdW YWx1ZSkgY29uc3QKIHsKICAgICBpZiAoIWlzU3RyaW5nKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTQ2VsbC5oCmluZGV4IDE2MzgwZDQuLmRiMThiYmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTQ2VsbC5oCkBAIC03NCw2ICs3NCw3IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgIHByb3RlY3RlZDoKICAgICAgICAgSlNDZWxsKEpTR2xvYmFsRGF0YSYsIFN0cnVjdHVyZSop OwogICAgICAgICB2aXJ0dWFsIH5KU0NlbGwoKTsgLy8gSW52b2tlZCBieSBHQyBmaW5hbGl6YXRp b24uCisgICAgICAgIHN0YXRpYyB2b2lkIGRlc3Ryb3koSlNDZWxsKik7CiAKICAgICBwdWJsaWM6 CiAgICAgICAgIC8vIFF1ZXJ5aW5nIHRoZSB0eXBlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTT2JqZWN0LmgKaW5kZXggMmNjMDAwMS4uYzVkZWEyZCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09iamVjdC5oCkBAIC01MTksNyArNTE5LDcgQEAgaW5saW5lIGJvb2wg SlNDZWxsOjppbmhlcml0cyhjb25zdCBDbGFzc0luZm8qIGluZm8pIGNvbnN0CiAKIGlubGluZSBj b25zdCBNZXRob2RUYWJsZSogSlNDZWxsOjptZXRob2RUYWJsZSgpIGNvbnN0CiB7Ci0gICAgcmV0 dXJuICZjbGFzc0luZm8oKS0+bWV0aG9kVGFibGU7CisgICAgcmV0dXJuICZ1bnZhbGlkYXRlZENs YXNzSW5mbygpLT5tZXRob2RUYWJsZTsKIH0KIAogLy8gdGhpcyBtZXRob2QgaXMgaGVyZSB0byBi ZSBhZnRlciB0aGUgaW5saW5lIGRlY2xhcmF0aW9uIG9mIEpTQ2VsbDo6aW5oZXJpdHMKLS0gCjEu Ny40LjQKCg==