74320 2011-12-12 12:44:44 -0800 Chromium Windows (Tests) is failing to build 2011-12-15 21:21:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa tony dpranke kbr maruel tony webkit.review.bot oldest_to_newest 519382 0 rniwa 2011-12-12 12:44:44 -0800 http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/21854/steps/compile-webkit/logs/stdio 4>e:\google-windows-2\chromium-win-release-tests\build\Source\WebKit\chromium\build\Release\obj\global_intermediate\webkit\third_party/WebKit/Source/WebKit/chromium/public/platform/WebSocketStreamHandleClient.h(2) : fatal error C1083: Cannot open include file: '../../../../../../../../../../../..\public\platform\WebSocketStreamHandleClient.h': No such file or directory http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29 Interestingly enough, Chromium Win Release is building fine: http://build.webkit.org/builders/Chromium%20Win%20Release 519782 1 tony 2011-12-12 19:05:01 -0800 I rdesktop'ed into the machine. The file is there and the path is correct. I tried a debug build and it works fine. The error doesn't show up in Error List. My best guess is that the filename is too long for Visual Studios? 519785 2 tony 2011-12-12 19:09:42 -0800 I renamed the build directory from chromium-win-release-tests to 'c' and I was able to build the file in Visual Studio :( 519787 3 maruel 2011-12-12 19:11:42 -0800 e:\google-windows-2\chromium-win-release-tests\build\Source\WebKit\chromium\build\Release\obj\global_intermediate\webkit\third_party/WebKit/Source/WebKit/chromium/public/platform/../../../../../../../../../../../..\public\platform\WebSocketStreamHandleClient.h is 261 chars. Bingo! Use slavebuilddir property in the build master to rename the slave checkout to a shorter name as a temporary (e.g. permanent) workaround. That requires a master restart though. 519794 4 rniwa 2011-12-12 19:17:45 -0800 We can just rename google-windows-2 to something else. 519796 5 maruel 2011-12-12 19:20:49 -0800 We use e:\b\ It'll help for 15 chars but I would also do the slavebuilddir trick to shorten the name even more. 520135 6 tony 2011-12-13 09:45:00 -0800 Ok, I will rename google-windows-2 to b and I think I can change the generated include path to be 'public\platform\WebSocketStreamHandleClient.h'. I think Source/WebKit/chromium is in the include path already. That saves 36 characters. 522135 7 119481 tony 2011-12-15 12:24:19 -0800 Created attachment 119481 Patch 522136 8 119481 kbr 2011-12-15 12:27:06 -0800 Comment on attachment 119481 Patch Looks good to me as long as it's been tested. 522137 9 tony 2011-12-15 12:27:56 -0800 (In reply to comment #8) > (From update of attachment 119481 [details]) > Looks good to me as long as it's been tested. I tested on my machine, but I want to make sure this makes it through EWS too. 522502 10 119481 webkit.review.bot 2011-12-15 21:21:17 -0800 Comment on attachment 119481 Patch Clearing flags on attachment: 119481 Committed r103021: <http://trac.webkit.org/changeset/103021> 522503 11 webkit.review.bot 2011-12-15 21:21:24 -0800 All reviewed patches have been landed. Closing bug. 119481 2011-12-15 12:24:19 -0800 2011-12-15 21:21:17 -0800 Patch bug-74320-20111215122434.patch text/plain 1289 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNkMDYxYTgzZWY1YmFkMWYxNTUzNjY2NTU5NzQwN2I0OWQzYTdlYjguLjcyNzBlMWQxODgyMWRk MmRjZDMzM2U2YjA5MWYwOTUyMzBlOTZhOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTItMTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBDaHJvbWl1bSBXaW5kb3dzIChUZXN0cykgaXMgZmFpbGluZyB0byBidWls ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQzMjAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSb2xsIGNo cm9taXVtIGRlcHMgdG8gcjExNDY4NiB0byBwdWxsIGluIGEgY2hhbmdlIHRvIGhvdyBnZW5lcmF0 ZWQKKyAgICAgICAgaGVhZGVycyBpbmNsdWRlIGZpbGVzIGZyb20gdGhpcmRfcGFydHkvV2ViS2l0 LiAgVGhpcyBzaG91bGQgbWFrZSB0aGUKKyAgICAgICAgZmlsZSBwYXRoIHNob3J0ZXIsIHJlZHVj aW5nIHRoZSBjaGFuY2Ugb2YgaGl0dGluZyB0aGUgMjYwIGNoYXIgcGF0aAorICAgICAgICBsaW1p dCBvbiBXaW5kb3dzLgorCisgICAgICAgICogREVQUzogcm9sbCB0byByMTE0Njg2CisKIDIwMTEt MTItMTUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMjk1Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCA0 MzRmZmM2NDk3OTRkZDQzMTlmNjM1MTRmMTA3MTE4MWQyOGY0M2E2Li5jNTJkNWY3ZDA0Y2EwYzY5 OWUzNDY5NDU3ZDcxNGNlODI4MjFjYjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3 IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5v cmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnMTE0MzU2JywKKyAgJ2Nocm9t aXVtX3Jldic6ICcxMTQ2ODYnLAogfQogCiBkZXBzID0gewo=