74278 2011-12-12 02:39:58 -0800 Specialize isLoading() method in HTMLLinkelement.h 2011-12-21 02:21:34 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rhodovan.u-szeged rhodovan.u-szeged darin dglazkov kling oldest_to_newest 519084 0 rhodovan.u-szeged 2011-12-12 02:39:58 -0800 Fulfill FIXME with renaming isLoading() method to isStyleSheetLoading(). 519085 1 118757 rhodovan.u-szeged 2011-12-12 02:42:40 -0800 Created attachment 118757 Proposed patch 519158 2 118757 kling 2011-12-12 06:20:44 -0800 Comment on attachment 118757 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=118757&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=74278 > + > + Specialize isLoading() method for stylesheets. None of this tells us what's being changed. "Rename HTMLLinkElement::isLoading() to isStyleSheetLoading()." would be better. 519164 3 rhodovan.u-szeged 2011-12-12 06:33:54 -0800 (In reply to comment #2) > (From update of attachment 118757 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118757&action=review > > > Source/WebCore/ChangeLog:6 > > + https://bugs.webkit.org/show_bug.cgi?id=74278 > > + > > + Specialize isLoading() method for stylesheets. > > None of this tells us what's being changed. > > "Rename HTMLLinkElement::isLoading() to isStyleSheetLoading()." would be better. All right, thanks :) 519310 4 118757 ap 2011-12-12 10:23:39 -0800 Comment on attachment 118757 Proposed patch We usually try for code to have correct grammar when possible. Compare "if (isLoading())" to "if (isStyleSheetLoading())". This patch makes this aspect worse. Maybe "styleSheetIsLoading" would be better? 519323 5 kling 2011-12-12 10:35:55 -0800 (In reply to comment #4) > (From update of attachment 118757 [details]) > We usually try for code to have correct grammar when possible. Compare "if (isLoading())" to "if (isStyleSheetLoading())". This patch makes this aspect worse. > > Maybe "styleSheetIsLoading" would be better? Yes, you're right. I thought of suggesting isLoadingStyleSheet(), but decided against it since it sort-of implies that the link element is responsible the actual loading. styleSheetIsLoading() is a better name indeed. 519333 6 rhodovan.u-szeged 2011-12-12 10:44:26 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 118757 [details] [details]) > > We usually try for code to have correct grammar when possible. Compare "if (isLoading())" to "if (isStyleSheetLoading())". This patch makes this aspect worse. > > > > Maybe "styleSheetIsLoading" would be better? > > Yes, you're right. I thought of suggesting isLoadingStyleSheet(), but decided against it since it sort-of implies that the link element is responsible the actual loading. styleSheetIsLoading() is a better name indeed. Okay guys. I guess you are right indeed. I just followed the idea in the FIXME. But i'll rename it in a sec if styleSheetIsLoading() fits for everyone :) 519567 7 darin 2011-12-12 15:17:20 -0800 Names for members with boolean type or boolean return type are supposed to finish a phrase “link element <xxx>” for clarity. The phrase “link element is style sheet loading” is nonsense. I think that “link element style sheet is loading” is OK; perhaps we could do even better. 520830 8 119192 rhodovan.u-szeged 2011-12-14 03:47:31 -0800 Created attachment 119192 Proposed patch According to Darin's advice I made the renaming: isStyleSheetLoading() -> linkElementStyleSheetIsLoading(). Any objections? 521071 9 darin 2011-12-14 10:53:39 -0800 (In reply to comment #8) > According to Darin's advice I made the renaming: isStyleSheetLoading() -> linkElementStyleSheetIsLoading(). Oops. That’s a misunderstanding. The words “link element” are the class name, and implicit because this is a member function. Like this: linkElement->styleSheetIsLoading(). Sorry to steer you wrong there. 524001 10 118757 eric 2011-12-19 10:48:03 -0800 Comment on attachment 118757 Proposed patch Cleared Andreas Kling's review+ from obsolete attachment 118757 so that this bug does not appear in http://webkit.org/pending-commit. 524039 11 119890 rhodovan.u-szeged 2011-12-19 11:13:37 -0800 Created attachment 119890 Proposed patch (In reply to comment #9) > (In reply to comment #8) > > According to Darin's advice I made the renaming: isStyleSheetLoading() -> linkElementStyleSheetIsLoading(). > > Oops. That’s a misunderstanding. The words “link element” are the class name, and implicit because this is a member function. Like this: > > linkElement->styleSheetIsLoading(). > > Sorry to steer you wrong there. Ohh, sorry for being late with this update. I'm on holiday to get ready for my exams and I'm a bit lost :) 525201 12 rhodovan.u-szeged 2011-12-21 02:21:34 -0800 Committed r103401: <http://trac.webkit.org/changeset/103401> 118757 2011-12-12 02:42:40 -0800 2011-12-19 10:48:03 -0800 Proposed patch 0001-fixme-in-htmllinkelement.patch text/plain 3971 rhodovan.u-szeged RnJvbSA5MTI4MmQxMGE5YjA5ZGEzZmQzOTBiYzc2YTlhNGJmYTMyYjc3MjgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdGEgSG9kb3ZhbiA8cmVuaUB3ZWJraXQub3JnPgpEYXRl OiBNb24sIDEyIERlYyAyMDExIDExOjQwOjE3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZml4bWUg aW4gaHRtbGxpbmtlbGVtZW50CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcCAgICAgICAgIHwgICAgMiArLQogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlu a0VsZW1lbnQuY3BwIHwgICAgNiArKystLS0KIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtF bGVtZW50LmggICB8ICAgIDMgKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyks IDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGExMGVhMDcuLjFmMTFjZjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMS0xMi0xMiAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdl YmtpdC5vcmc+CisKKyAgICAgICAgRnVsZmlsbCBGSVhNRSBpbiAgSFRNTExpbmtFbGVtZW50Lmgu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDI3OAor CisgICAgICAgIFNwZWNpYWxpemUgaXNMb2FkaW5nKCkgbWV0aG9kIGZvciBzdHlsZXNoZWV0cy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgYmVjYXVzZSB0aGUgZnVuY3Rpb25hbGl0eSByZW1haW5zIHRoZSBzYW1lLgorCisgICAg ICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpyZWNh bGNTdHlsZVNlbGVjdG9yKToKKyAgICAgICAgKiBodG1sL0hUTUxMaW5rRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MTGlua0VsZW1lbnQ6OnNldERpc2FibGVkU3RhdGUpOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTExpbmtFbGVtZW50Ojppc1N0eWxlU2hlZXRMb2FkaW5nKToKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6c2hlZXRMb2FkZWQpOgorICAgICAgICAq IGh0bWwvSFRNTExpbmtFbGVtZW50Lmg6CisKIDIwMTEtMTItMTEgIFpvbHRhbiBIZXJjemVnICA8 emhlcmN6ZWdAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgbmV3IENTUyBudGgtY2hpbGRyZW4g cGFyc2luZyB0ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggNjg5M2Q5NC4uOTY3NmEx MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0zMTA0LDcgKzMxMDQsNyBAQCB2b2lkIERv Y3VtZW50OjpyZWNhbGNTdHlsZVNlbGVjdG9yKCkKICAgICAgICAgICAgICAgICBpZiAobGlua0Vs ZW1lbnQtPmlzRGlzYWJsZWQoKSkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgICAgICAgICAgZW5hYmxlZFZpYVNjcmlwdCA9IGxpbmtFbGVtZW50LT5pc0VuYWJsZWRWaWFT Y3JpcHQoKTsKLSAgICAgICAgICAgICAgICBpZiAobGlua0VsZW1lbnQtPmlzTG9hZGluZygpKSB7 CisgICAgICAgICAgICAgICAgaWYgKGxpbmtFbGVtZW50LT5pc1N0eWxlU2hlZXRMb2FkaW5nKCkp IHsKICAgICAgICAgICAgICAgICAgICAgLy8gaXQgaXMgbG9hZGluZyBidXQgd2Ugc2hvdWxkIHN0 aWxsIGRlY2lkZSB3aGljaCBzdHlsZSBzaGVldCBzZXQgdG8gdXNlCiAgICAgICAgICAgICAgICAg ICAgIGlmICghZW5hYmxlZFZpYVNjcmlwdCAmJiAhdGl0bGUuaXNFbXB0eSgpICYmIG1fcHJlZmVy cmVkU3R5bGVzaGVldFNldC5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGNv bnN0IEF0b21pY1N0cmluZyYgcmVsID0gZS0+Z2V0QXR0cmlidXRlKHJlbEF0dHIpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCmluZGV4IDI4MThiZGIuLmViM2M3ZmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKQEAgLTkwLDcgKzkwLDcgQEAg dm9pZCBIVE1MTGlua0VsZW1lbnQ6OnNldERpc2FibGVkU3RhdGUoYm9vbCBkaXNhYmxlZCkKICAg ICBpZiAob2xkRGlzYWJsZWRTdGF0ZSAhPSBtX2Rpc2FibGVkU3RhdGUpIHsKICAgICAgICAgLy8g SWYgd2UgY2hhbmdlIHRoZSBkaXNhYmxlZCBzdGF0ZSB3aGlsZSB0aGUgc2hlZXQgaXMgc3RpbGwg bG9hZGluZywgdGhlbiB3ZSBoYXZlIHRvCiAgICAgICAgIC8vIHBlcmZvcm0gdGhyZWUgY2hlY2tz OgotICAgICAgICBpZiAoaXNMb2FkaW5nKCkpIHsKKyAgICAgICAgaWYgKGlzU3R5bGVTaGVldExv YWRpbmcoKSkgewogICAgICAgICAgICAgLy8gQ2hlY2sgIzE6IFRoZSBzaGVldCBiZWNvbWVzIGRp c2FibGVkIHdoaWxlIGxvYWRpbmcuCiAgICAgICAgICAgICBpZiAobV9kaXNhYmxlZFN0YXRlID09 IERpc2FibGVkKQogICAgICAgICAgICAgICAgIHJlbW92ZVBlbmRpbmdTaGVldCgpOwpAQCAtMzMz LDcgKzMzMyw3IEBAIHZvaWQgSFRNTExpbmtFbGVtZW50OjpzZXRDU1NTdHlsZVNoZWV0KGNvbnN0 IFN0cmluZyYgaHJlZiwgY29uc3QgS1VSTCYgYmFzZVVSTCwKICAgICBtX3NoZWV0LT5jaGVja0xv YWRlZCgpOwogfQogCi1ib29sIEhUTUxMaW5rRWxlbWVudDo6aXNMb2FkaW5nKCkgY29uc3QKK2Jv b2wgSFRNTExpbmtFbGVtZW50Ojppc1N0eWxlU2hlZXRMb2FkaW5nKCkgY29uc3QKIHsKICAgICBp ZiAobV9sb2FkaW5nKQogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTM1NCw3ICszNTQsNyBAQCB2 b2lkIEhUTUxMaW5rRWxlbWVudDo6bGlua0xvYWRpbmdFcnJvcmVkKCkKIAogYm9vbCBIVE1MTGlu a0VsZW1lbnQ6OnNoZWV0TG9hZGVkKCkKIHsKLSAgICBpZiAoIWlzTG9hZGluZygpKSB7CisgICAg aWYgKCFpc1N0eWxlU2hlZXRMb2FkaW5nKCkpIHsKICAgICAgICAgcmVtb3ZlUGVuZGluZ1NoZWV0 KCk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5r RWxlbWVudC5oCmluZGV4IDZlMDVmMmMuLjExNjNhMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TGlua0VsZW1lbnQuaApAQCAtNTMsOCArNTMsNyBAQCBwdWJsaWM6CiAKICAgICBDU1NTdHlsZVNo ZWV0KiBzaGVldCgpIGNvbnN0IHsgcmV0dXJuIG1fc2hlZXQuZ2V0KCk7IH0KIAotICAgIC8vIEZJ WE1FOiBUaGlzIHNob3VsZCBiZSByZW5hbWVkIGlzU3R5bGVTaGVldExvYWRpbmcgYXMgdGhpcyBp cyBvbmx5IHVzZWQgZm9yIHN0eWxlc2hlZXRzLgotICAgIGJvb2wgaXNMb2FkaW5nKCkgY29uc3Q7 CisgICAgYm9vbCBpc1N0eWxlU2hlZXRMb2FkaW5nKCkgY29uc3Q7CiAKICAgICBib29sIGlzRGlz YWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2Rpc2FibGVkU3RhdGUgPT0gRGlzYWJsZWQ7IH0KICAg ICBib29sIGlzRW5hYmxlZFZpYVNjcmlwdCgpIGNvbnN0IHsgcmV0dXJuIG1fZGlzYWJsZWRTdGF0 ZSA9PSBFbmFibGVkVmlhU2NyaXB0OyB9Ci0tIAoxLjcuNS40Cgo= 119192 2011-12-14 03:47:31 -0800 2011-12-19 11:13:37 -0800 Proposed patch 0001-rename2.patch text/plain 4128 rhodovan.u-szeged RnJvbSA0ZmM2ZjQwM2Y0N2JmZTRlZTNlZjAwNmNiZjQxYTBmOWY1NjQwODk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdGEgSG9kb3ZhbiA8cmVuaUB3ZWJraXQub3JnPgpEYXRl OiBXZWQsIDE0IERlYyAyMDExIDEyOjQzOjE3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gcmVuYW1l MgoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAgIDIwICsr KysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwICAgICAg ICAgfCAgICAyICstCiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAgfCAg ICA2ICsrKy0tLQogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaCAgIHwgICAg MiArLQogNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZWM1MTI1Li5lYzY1NzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMTItMTQgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUB3ZWJraXQub3JnPgorCisgICAg ICAgIEZ1bGZpbGwgRklYTUUgaW4gIEhUTUxMaW5rRWxlbWVudC5oLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyNzgKKworICAgICAgICBSZW5hbWUg aXNTdHlsZVNoZWV0TG9hZGluZygpIG1ldGhvZCB0byBsaW5rRWxlbWVudFN0eWxlU2hlZXRJc0xv YWRpbmcoKS4KKyAgICAgICAgVGhpcyBuZXcgb25lIGhhcyB0aGUgY29ycmVjdCBncmFtbWFyIGFu ZCByZWZlcnMgdG8gaXRzIHVzYWdlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZSBmdW5jdGlvbmFsaXR5IHJl bWFpbnMgdGhlIHNhbWUuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RG9jdW1lbnQ6OnJlY2FsY1N0eWxlU2VsZWN0b3IpOgorICAgICAgICAqIGh0bWwv SFRNTExpbmtFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6 c2V0RGlzYWJsZWRTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTGlua0VsZW1lbnQ6Omxp bmtFbGVtZW50U3R5bGVTaGVldElzTG9hZGluZyk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTGlu a0VsZW1lbnQ6OnNoZWV0TG9hZGVkKToKKyAgICAgICAgKiBodG1sL0hUTUxMaW5rRWxlbWVudC5o OgorCiAyMDExLTEyLTEzICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRyZWVPdXRsaW5lJ3MgaXMgYnJva2VuIHdoZW4gbGkg ZWxlbWVudHMgaGF2ZSBwYWRkaW5nLWxlZnQgZGlmZmVyZW50IGZyb20gMTRweC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IDEyZTMxYTYuLmRkNTc1ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcApAQCAtMzExNCw3ICszMTE0LDcgQEAgdm9pZCBEb2N1bWVudDo6cmVjYWxjU3R5bGVTZWxl Y3RvcigpCiAgICAgICAgICAgICAgICAgaWYgKGxpbmtFbGVtZW50LT5pc0Rpc2FibGVkKCkpCiAg ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIGVuYWJsZWRWaWFT Y3JpcHQgPSBsaW5rRWxlbWVudC0+aXNFbmFibGVkVmlhU2NyaXB0KCk7Ci0gICAgICAgICAgICAg ICAgaWYgKGxpbmtFbGVtZW50LT5pc1N0eWxlU2hlZXRMb2FkaW5nKCkpIHsKKyAgICAgICAgICAg ICAgICBpZiAobGlua0VsZW1lbnQtPmxpbmtFbGVtZW50U3R5bGVTaGVldElzTG9hZGluZygpKSB7 CiAgICAgICAgICAgICAgICAgICAgIC8vIGl0IGlzIGxvYWRpbmcgYnV0IHdlIHNob3VsZCBzdGls bCBkZWNpZGUgd2hpY2ggc3R5bGUgc2hlZXQgc2V0IHRvIHVzZQogICAgICAgICAgICAgICAgICAg ICBpZiAoIWVuYWJsZWRWaWFTY3JpcHQgJiYgIXRpdGxlLmlzRW1wdHkoKSAmJiBtX3ByZWZlcnJl ZFN0eWxlc2hlZXRTZXQuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBBdG9taWNTdHJpbmcmIHJlbCA9IGUtPmdldEF0dHJpYnV0ZShyZWxBdHRyKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcAppbmRleCBlYjNjN2ZiLi4wYTdkNTY3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCkBAIC05MCw3ICs5MCw3IEBAIHZv aWQgSFRNTExpbmtFbGVtZW50OjpzZXREaXNhYmxlZFN0YXRlKGJvb2wgZGlzYWJsZWQpCiAgICAg aWYgKG9sZERpc2FibGVkU3RhdGUgIT0gbV9kaXNhYmxlZFN0YXRlKSB7CiAgICAgICAgIC8vIElm IHdlIGNoYW5nZSB0aGUgZGlzYWJsZWQgc3RhdGUgd2hpbGUgdGhlIHNoZWV0IGlzIHN0aWxsIGxv YWRpbmcsIHRoZW4gd2UgaGF2ZSB0bwogICAgICAgICAvLyBwZXJmb3JtIHRocmVlIGNoZWNrczoK LSAgICAgICAgaWYgKGlzU3R5bGVTaGVldExvYWRpbmcoKSkgeworICAgICAgICBpZiAobGlua0Vs ZW1lbnRTdHlsZVNoZWV0SXNMb2FkaW5nKCkpIHsKICAgICAgICAgICAgIC8vIENoZWNrICMxOiBU aGUgc2hlZXQgYmVjb21lcyBkaXNhYmxlZCB3aGlsZSBsb2FkaW5nLgogICAgICAgICAgICAgaWYg KG1fZGlzYWJsZWRTdGF0ZSA9PSBEaXNhYmxlZCkKICAgICAgICAgICAgICAgICByZW1vdmVQZW5k aW5nU2hlZXQoKTsKQEAgLTMzMyw3ICszMzMsNyBAQCB2b2lkIEhUTUxMaW5rRWxlbWVudDo6c2V0 Q1NTU3R5bGVTaGVldChjb25zdCBTdHJpbmcmIGhyZWYsIGNvbnN0IEtVUkwmIGJhc2VVUkwsCiAg ICAgbV9zaGVldC0+Y2hlY2tMb2FkZWQoKTsKIH0KIAotYm9vbCBIVE1MTGlua0VsZW1lbnQ6Omlz U3R5bGVTaGVldExvYWRpbmcoKSBjb25zdAorYm9vbCBIVE1MTGlua0VsZW1lbnQ6OmxpbmtFbGVt ZW50U3R5bGVTaGVldElzTG9hZGluZygpIGNvbnN0CiB7CiAgICAgaWYgKG1fbG9hZGluZykKICAg ICAgICAgcmV0dXJuIHRydWU7CkBAIC0zNTQsNyArMzU0LDcgQEAgdm9pZCBIVE1MTGlua0VsZW1l bnQ6OmxpbmtMb2FkaW5nRXJyb3JlZCgpCiAKIGJvb2wgSFRNTExpbmtFbGVtZW50OjpzaGVldExv YWRlZCgpCiB7Ci0gICAgaWYgKCFpc1N0eWxlU2hlZXRMb2FkaW5nKCkpIHsKKyAgICBpZiAoIWxp bmtFbGVtZW50U3R5bGVTaGVldElzTG9hZGluZygpKSB7CiAgICAgICAgIHJlbW92ZVBlbmRpbmdT aGVldCgpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TGlua0VsZW1lbnQuaAppbmRleCAxMTYzYTFiLi4xYjBiOWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTExpbmtFbGVtZW50LmgKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogCiAgICAgQ1NTU3R5 bGVTaGVldCogc2hlZXQoKSBjb25zdCB7IHJldHVybiBtX3NoZWV0LmdldCgpOyB9CiAKLSAgICBi b29sIGlzU3R5bGVTaGVldExvYWRpbmcoKSBjb25zdDsKKyAgICBib29sIGxpbmtFbGVtZW50U3R5 bGVTaGVldElzTG9hZGluZygpIGNvbnN0OwogCiAgICAgYm9vbCBpc0Rpc2FibGVkKCkgY29uc3Qg eyByZXR1cm4gbV9kaXNhYmxlZFN0YXRlID09IERpc2FibGVkOyB9CiAgICAgYm9vbCBpc0VuYWJs ZWRWaWFTY3JpcHQoKSBjb25zdCB7IHJldHVybiBtX2Rpc2FibGVkU3RhdGUgPT0gRW5hYmxlZFZp YVNjcmlwdDsgfQotLSAKMS43LjUuNAoK 119890 2011-12-19 11:13:37 -0800 2011-12-19 11:15:08 -0800 Proposed patch 0001-rename2.patch text/plain 4027 rhodovan.u-szeged RnJvbSA0ZmM2ZjQwM2Y0N2JmZTRlZTNlZjAwNmNiZjQxYTBmOWY1NjQwODk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdGEgSG9kb3ZhbiA8cmVuaUB3ZWJraXQub3JnPgpEYXRl OiBXZWQsIDE0IERlYyAyMDExIDEyOjQzOjE3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gcmVuYW1l MgoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAgIDIwICsr KysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwICAgICAg ICAgfCAgICAyICstCiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAgfCAg ICA2ICsrKy0tLQogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaCAgIHwgICAg MiArLQogNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZWM1MTI1Li5lYzY1NzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMTItMTQgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUB3ZWJraXQub3JnPgorCisgICAg ICAgIEZ1bGZpbGwgRklYTUUgaW4gIEhUTUxMaW5rRWxlbWVudC5oLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyNzgKKworICAgICAgICBSZW5hbWUg aXNTdHlsZVNoZWV0TG9hZGluZygpIG1ldGhvZCB0byBzdHlsZVNoZWV0SXNMb2FkaW5nKCkuCisg ICAgICAgIFRoaXMgbmV3IG9uZSBoYXMgdGhlIGNvcnJlY3QgZ3JhbW1hci4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVz ZSB0aGUgZnVuY3Rpb25hbGl0eSByZW1haW5zIHRoZSBzYW1lLgorCisgICAgICAgICogZG9tL0Rv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpyZWNhbGNTdHlsZVNlbGVj dG9yKToKKyAgICAgICAgKiBodG1sL0hUTUxMaW5rRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpIVE1MTGlua0VsZW1lbnQ6OnNldERpc2FibGVkU3RhdGUpOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTExpbmtFbGVtZW50OjpzdHlsZVNoZWV0SXNMb2FkaW5nKToKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxMaW5rRWxlbWVudDo6c2hlZXRMb2FkZWQpOgorICAgICAgICAqIGh0bWwvSFRNTExp bmtFbGVtZW50Lmg6CisKIDIwMTEtMTItMTMgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVHJlZU91dGxpbmUncyBpcyBicm9r ZW4gd2hlbiBsaSBlbGVtZW50cyBoYXZlIHBhZGRpbmctbGVmdCBkaWZmZXJlbnQgZnJvbSAxNHB4 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMTJlMzFhNi4uZGQ1NzVmMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCkBAIC0zMTE0LDcgKzMxMTQsNyBAQCB2b2lkIERvY3VtZW50OjpyZWNh bGNTdHlsZVNlbGVjdG9yKCkKICAgICAgICAgICAgICAgICBpZiAobGlua0VsZW1lbnQtPmlzRGlz YWJsZWQoKSkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAg ZW5hYmxlZFZpYVNjcmlwdCA9IGxpbmtFbGVtZW50LT5pc0VuYWJsZWRWaWFTY3JpcHQoKTsKLSAg ICAgICAgICAgICAgICBpZiAobGlua0VsZW1lbnQtPmlzU3R5bGVTaGVldExvYWRpbmcoKSkgewor ICAgICAgICAgICAgICAgIGlmIChsaW5rRWxlbWVudC0+c3R5bGVTaGVldElzTG9hZGluZygpKSB7 CiAgICAgICAgICAgICAgICAgICAgIC8vIGl0IGlzIGxvYWRpbmcgYnV0IHdlIHNob3VsZCBzdGls bCBkZWNpZGUgd2hpY2ggc3R5bGUgc2hlZXQgc2V0IHRvIHVzZQogICAgICAgICAgICAgICAgICAg ICBpZiAoIWVuYWJsZWRWaWFTY3JpcHQgJiYgIXRpdGxlLmlzRW1wdHkoKSAmJiBtX3ByZWZlcnJl ZFN0eWxlc2hlZXRTZXQuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBBdG9taWNTdHJpbmcmIHJlbCA9IGUtPmdldEF0dHJpYnV0ZShyZWxBdHRyKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcAppbmRleCBlYjNjN2ZiLi4wYTdkNTY3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCkBAIC05MCw3ICs5MCw3IEBAIHZv aWQgSFRNTExpbmtFbGVtZW50OjpzZXREaXNhYmxlZFN0YXRlKGJvb2wgZGlzYWJsZWQpCiAgICAg aWYgKG9sZERpc2FibGVkU3RhdGUgIT0gbV9kaXNhYmxlZFN0YXRlKSB7CiAgICAgICAgIC8vIElm IHdlIGNoYW5nZSB0aGUgZGlzYWJsZWQgc3RhdGUgd2hpbGUgdGhlIHNoZWV0IGlzIHN0aWxsIGxv YWRpbmcsIHRoZW4gd2UgaGF2ZSB0bwogICAgICAgICAvLyBwZXJmb3JtIHRocmVlIGNoZWNrczoK LSAgICAgICAgaWYgKGlzU3R5bGVTaGVldExvYWRpbmcoKSkgeworICAgICAgICBpZiAoc3R5bGVT aGVldElzTG9hZGluZygpKSB7CiAgICAgICAgICAgICAvLyBDaGVjayAjMTogVGhlIHNoZWV0IGJl Y29tZXMgZGlzYWJsZWQgd2hpbGUgbG9hZGluZy4KICAgICAgICAgICAgIGlmIChtX2Rpc2FibGVk U3RhdGUgPT0gRGlzYWJsZWQpCiAgICAgICAgICAgICAgICAgcmVtb3ZlUGVuZGluZ1NoZWV0KCk7 CkBAIC0zMzMsNyArMzMzLDcgQEAgdm9pZCBIVE1MTGlua0VsZW1lbnQ6OnNldENTU1N0eWxlU2hl ZXQoY29uc3QgU3RyaW5nJiBocmVmLCBjb25zdCBLVVJMJiBiYXNlVVJMLAogICAgIG1fc2hlZXQt PmNoZWNrTG9hZGVkKCk7CiB9CiAKLWJvb2wgSFRNTExpbmtFbGVtZW50Ojppc1N0eWxlU2hlZXRM b2FkaW5nKCkgY29uc3QKK2Jvb2wgSFRNTExpbmtFbGVtZW50OjpzdHlsZVNoZWV0SXNMb2FkaW5n KCkgY29uc3QKIHsKICAgICBpZiAobV9sb2FkaW5nKQogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAg LTM1NCw3ICszNTQsNyBAQCB2b2lkIEhUTUxMaW5rRWxlbWVudDo6bGlua0xvYWRpbmdFcnJvcmVk KCkKIAogYm9vbCBIVE1MTGlua0VsZW1lbnQ6OnNoZWV0TG9hZGVkKCkKIHsKLSAgICBpZiAoIWlz U3R5bGVTaGVldExvYWRpbmcoKSkgeworICAgIGlmICghc3R5bGVTaGVldElzTG9hZGluZygpKSB7 CiAgICAgICAgIHJlbW92ZVBlbmRpbmdTaGVldCgpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5oIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaAppbmRleCAxMTYzYTFiLi4xYjBi OWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmgKQEAgLTUzLDcgKzUzLDcg QEAgcHVibGljOgogCiAgICAgQ1NTU3R5bGVTaGVldCogc2hlZXQoKSBjb25zdCB7IHJldHVybiBt X3NoZWV0LmdldCgpOyB9CiAKLSAgICBib29sIGlzU3R5bGVTaGVldExvYWRpbmcoKSBjb25zdDsK KyAgICBib29sIHN0eWxlU2hlZXRJc0xvYWRpbmcoKSBjb25zdDsKIAogICAgIGJvb2wgaXNEaXNh YmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fZGlzYWJsZWRTdGF0ZSA9PSBEaXNhYmxlZDsgfQogICAg IGJvb2wgaXNFbmFibGVkVmlhU2NyaXB0KCkgY29uc3QgeyByZXR1cm4gbV9kaXNhYmxlZFN0YXRl ID09IEVuYWJsZWRWaWFTY3JpcHQ7IH0KLS0gCjEuNy41LjQKCg==