74268 2011-12-12 00:15:51 -0800 prepare-ChangeLog should not include a reference file ('xxx-expected.html') used by reftests as a test file. 2012-05-06 23:52:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato rniwa webkit.review.bot oldest_to_newest 519057 0 hayato 2011-12-12 00:15:51 -0800 If a change contains reftests, the output of prepare-changelog includes both a test file (xxx.html) and a reference file (xxx-expected.html) as follows: Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html fast/dom/shadow/dynamically-created-shadow-root.html: That should be: Tests: fast/dom/shadow/dynamically-created-shadow-root.html: 519062 1 118749 hayato 2011-12-12 01:04:56 -0800 Created attachment 118749 exclude reffile 521571 2 118749 rniwa 2011-12-14 18:47:50 -0800 Comment on attachment 118749 exclude reffile View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review > Tools/Scripts/prepare-ChangeLog:1619 > && !scalar(grep(/^resources$/i, @components)) This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests. 521577 3 hayato 2011-12-14 19:24:06 -0800 Thank you for the review. (In reply to comment #2) > (From update of attachment 118749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review > > > Tools/Scripts/prepare-ChangeLog:1619 > > && !scalar(grep(/^resources$/i, @components)) > > This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests. Yeah, this is not perfect. But I'd like to delay handling such names as '-ref, -noref, etc' since there is no strict usable rule to detect these names in easy way. It might be better to file another bug to handle such cases. As for '-expected.html' and '-expected-mismatch.html', this is clear and present issue. So this must be fixed. Later we might have to handle such cases, '-ref, ...etc'. 521587 4 hayato 2011-12-14 19:42:26 -0800 I've filed another bug in https://bugs.webkit.org/show_bug.cgi?id=74579. 617400 5 140481 hayato 2012-05-06 22:46:33 -0700 Created attachment 140481 Patch for landing 617421 6 140481 webkit.review.bot 2012-05-06 23:52:04 -0700 Comment on attachment 140481 Patch for landing Clearing flags on attachment: 140481 Committed r116279: <http://trac.webkit.org/changeset/116279> 617422 7 webkit.review.bot 2012-05-06 23:52:09 -0700 All reviewed patches have been landed. Closing bug. 118749 2011-12-12 01:04:56 -0800 2012-05-06 22:46:26 -0700 exclude reffile bug-74268-20111212180455.patch text/plain 1360 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNTQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWQxNTlmNGI0NDhhZGVjZTczMjJjMDYyM2Q3NWJhOTQ2 MWQ1MDdkYi4uZWRkNTQ4NmFmNDA3N2RiN2U2NGY0YzEwNTZiZTE5MmVmNTcyNDY4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTEyLTEyICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbcHJlcGFyZS1DaGFuZ2VMb2ddIEV4Y2x1ZGVzIGEgcmVmZXJlbmNlIGZpbGUgdXNlZCBi eSByZWZ0ZXN0cyBmcm9tIHRlc3QgZmlsZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NDI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAgICAgICAg KGdlbmVyYXRlRmlsZUxpc3QpOgorCiAyMDExLTEyLTExICBLZW50YXJvIEhhcmEgIDxoYXJha2Vu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbUmVmYWN0b3JpbmddIE1vdmUgdG9wLWxldmVsIGNv ZGUgdG8gZ2VuZXJhdGUgYSBuZXcgQ2hhbmdlTG9nIGludG8gYSBtZXRob2QKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUt Q2hhbmdlTG9nCmluZGV4IDZmOWJhZDI3ZWY5ZjU1NTlkNDc4NzYzYzEzMmRjZjJlNTdlOGU0ODgu LjA4NzY3ZmNjYzJiNDNiNWM3NmVhYWY3OGFkM2FjMWVmMDU1MDNjM2QgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJl LUNoYW5nZUxvZwpAQCAtMTYxNSw2ICsxNjE1LDcgQEAgc3ViIGdlbmVyYXRlRmlsZUxpc3QoXEBc QFwlKQogICAgICAgICAgICAgICAgICAgICBpZiBpc0FkZGVkU3RhdHVzKCRzdGF0dXMpCiAgICAg ICAgICAgICAgICAgICAgICAgICYmICRmaWxlID1+IC9cLihbYS16QS1aXSspJC8KICAgICAgICAg ICAgICAgICAgICAgICAgJiYgJHN1cHBvcnRlZFRlc3RFeHRlbnNpb25ze2xjKCQxKX0KKyAgICAg ICAgICAgICAgICAgICAgICAgJiYgJGZpbGUgIX4gLy1leHBlY3RlZCgtbWlzbWF0Y2gpP1wuaHRt bCQvCiAgICAgICAgICAgICAgICAgICAgICAgICYmICFzY2FsYXIoZ3JlcCgvXnJlc291cmNlcyQv aSwgQGNvbXBvbmVudHMpKQogICAgICAgICAgICAgICAgICAgICAgICAmJiAhc2NhbGFyKGdyZXAo L15zY3JpcHQtdGVzdHMkL2ksIEBjb21wb25lbnRzKSk7CiAgICAgICAgICAgICB9Cg== 140481 2012-05-06 22:46:33 -0700 2012-05-06 23:52:03 -0700 Patch for landing bug-74268-20120507144631.patch text/plain 1318 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWY3YTg4NDY4YjgwNzk0OGQ3ZDA1YzVkM2MyMTQxZjA1 YmVmNjhiMS4uOTA1YmMzODlhOTFhMWZmNzQ2M2E0ZjM4Y2I1NjY0YWVmZjgyMjM5NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA1LTA2ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbcHJlcGFyZS1DaGFuZ2VMb2ddIEV4Y2x1ZGVzIGEgcmVmZXJlbmNlIGZpbGUgdXNlZCBi eSByZWZ0ZXN0cyBmcm9tIHRlc3QgZmlsZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NDI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2Ug Tml3YS4KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2c6CisgICAgICAgIChn ZW5lcmF0ZUZpbGVMaXN0KToKKwogMjAxMi0wNS0wNiAgTWFyeSBXdSAgPG1hcnkud3VAdG9yY2ht b2JpbGUuY29tLmNuPgogCiAgICAgICAgIEFkZCBhIGNvbnRyaWJ1dG9yIHRvIGNvbW1pdHRlcnMu cHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9T Y3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGExMGI5MmY5YmJiNjEyY2NiZjE3MGI4ZTk3 ZDMyOTU1NzI4ODY2ZGMuLjhhNDhlNTY3ZWM1OGMzYThjODU2OWUwMzRjM2E4YTA2M2M5YWJiN2Ug MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMv U2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMTc1OSw2ICsxNzU5LDcgQEAgc3ViIGdlbmVy YXRlRmlsZUxpc3QoXCUkJCQpCiAgICAgICAgICAgICAgICAgICAgIGlmIGlzQWRkZWRTdGF0dXMo JHN0YXR1cykKICAgICAgICAgICAgICAgICAgICAgICAgJiYgJGZpbGUgPX4gL1wuKFthLXpBLVpd KykkLwogICAgICAgICAgICAgICAgICAgICAgICAmJiBTdXBwb3J0ZWRUZXN0RXh0ZW5zaW9ucy0+ e2xjKCQxKX0KKyAgICAgICAgICAgICAgICAgICAgICAgJiYgJGZpbGUgIX4gLy1leHBlY3RlZCgt bWlzbWF0Y2gpP1wuaHRtbCQvCiAgICAgICAgICAgICAgICAgICAgICAgICYmICFzY2FsYXIoZ3Jl cCgvXnJlc291cmNlcyQvaSwgQGNvbXBvbmVudHMpKQogICAgICAgICAgICAgICAgICAgICAgICAm JiAhc2NhbGFyKGdyZXAoL15zY3JpcHQtdGVzdHMkL2ksIEBjb21wb25lbnRzKSk7CiAgICAgICAg ICAgICB9Cg==