74247 2011-12-10 16:17:06 -0800 Web Inspector: [protocol] alter some type names generated from Inspector.json 2011-12-11 12:44:52 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 peter.rybin webkit-unassigned apavlov bweinstein joepeck keishi loislo peter.rybin pfeldman pmuellr rik timothy yurys oldest_to_newest 518835 0 peter.rybin 2011-12-10 16:17:06 -0800 CodeGeneratorInspector.py takes type names straight from Inspector.json. However it should be more careful with some of them because they may conflict with already existing names (notable defines that are namespace-agnostic). See commend about RGBA in https://bugs.webkit.org/show_bug.cgi?id=72835 518837 1 118697 peter.rybin 2011-12-10 16:30:07 -0800 Created attachment 118697 Patch 518919 2 118697 loislo 2011-12-11 12:44:44 -0800 Comment on attachment 118697 Patch Clearing flags on attachment: 118697 Committed r102541: <http://trac.webkit.org/changeset/102541> 518920 3 loislo 2011-12-11 12:44:52 -0800 All reviewed patches have been landed. Closing bug. 118697 2011-12-10 16:30:07 -0800 2011-12-11 12:44:44 -0800 Patch bug-74247-20111211043004.patch text/plain 5934 peter.rybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNlN2EwOWI5YzRlNjRi YmFhNGJkZWQ4ZjZkZWQ2ODUzYmUxYWJjOS4uNDkyNTFlNmViYjI2NjlhMTc2NDk2MTM4MGQ1ODll ZTk5MDlkYjE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDExLTEyLTEwICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBbcHJvdG9jb2xdIGFsdGVyIHNvbWUgdHlwZSBuYW1lcyBnZW5lcmF0ZWQgZnJvbSBJbnNwZWN0 b3IuanNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzQyNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YW51YWxseS1maWxsZWQgbWFwIGFkZGVkIHRoYXQgY29udGFpbnMgcHJvYmxlbSB0eXBlIG5hbWVz IGFuZCBpdHMgcmVwbGFjZW1lbnQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRv ckluc3BlY3Rvci5weToKKyAgICAgICAgKGZpeF90eXBlX25hbWUuUmVzdWx0KToKKyAgICAgICAg KGZpeF90eXBlX25hbWUuUmVzdWx0Lm91dHB1dF9jb21tZW50KToKKyAgICAgICAgKGZpeF90eXBl X25hbWUpOgorICAgICAgICAoVHlwZUJpbmRpbmdzLmNyZWF0ZV9mb3JfbmFtZWRfdHlwZV9kZWNs YXJhdGlvbi53cml0ZV9kb2MpOgorICAgICAgICAoVHlwZUJpbmRpbmdzLmNyZWF0ZV9mb3JfbmFt ZWRfdHlwZV9kZWNsYXJhdGlvbi5FbnVtQmluZGluZy5nZW5lcmF0ZV90eXBlX2J1aWxkZXIpOgor ICAgICAgICAoVHlwZUJpbmRpbmdzLmNyZWF0ZV9mb3JfbmFtZWRfdHlwZV9kZWNsYXJhdGlvbi5Q bGFpblN0cmluZy5nZW5lcmF0ZV90eXBlX2J1aWxkZXIpOgorICAgICAgICAoVHlwZUJpbmRpbmdz KToKKyAgICAgICAgKFR5cGVCaW5kaW5ncy5jcmVhdGVfZm9yX25hbWVkX3R5cGVfZGVjbGFyYXRp b24uQ2xhc3NCaW5kaW5nLmdlbmVyYXRlX3R5cGVfYnVpbGRlcik6CisgICAgICAgIChHZW5lcmF0 b3IucHJvY2Vzc190eXBlcyk6CisKIDIwMTEtMTItMTAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgTWFjIGJ1aWxkIGZpeC4gUmVtb3ZlIGFuIGVycm9uZW91cyBP VkVSUklERS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJh dG9ySW5zcGVjdG9yLnB5IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJ bnNwZWN0b3IucHkKaW5kZXggOWJiNmM0ZGZmMzI2NmI4NDI2NDQ0OGM3MDIzYjAwZTQxZDliMTJj Yy4uYzE5NWNiNjcwMTFmZmNjNDkzYmIzYjI5ZGMxMmEyOWU0MjE5MDMzYSAxMDA3NTUKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHkKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHkKQEAgLTQ4 LDYgKzQ4LDEyIEBAIERPTUFJTl9ERUZJTkVfTkFNRV9NQVAgPSB7CiB9CiAKIAorIyBNYW51YWxs eS1maWxsZWQgbWFwIG9mIHR5cGUgbmFtZSByZXBsYWNlbWVudHMuCitUWVBFX05BTUVfRklYX01B UCA9IHsKKyAgICAiUkdCQSI6ICJSZ2JhIiwgICMgUkdCQSBpcyByZXBvcnRlZCB0byBiZSBjb25m bGljdGluZyB3aXRoIGEgZGVmaW5lIG5hbWUgaW4gV2luZG93cyBDRS4KK30KKworCiBjbWRsaW5l X3BhcnNlciA9IG9wdHBhcnNlLk9wdGlvblBhcnNlcigpCiBjbWRsaW5lX3BhcnNlci5hZGRfb3B0 aW9uKCItLWRlZmluZXMiKQogY21kbGluZV9wYXJzZXIuYWRkX29wdGlvbigiLS1vdXRwdXRfaF9k aXIiKQpAQCAtNDM5LDkgKzQ0NSw0MCBAQCBjbGFzcyBQYXJhbVR5cGUob2JqZWN0KToKIElOU1BF Q1RPUl9PQkpFQ1RfU0VUVEVSX05BTUVTID0gZnJvemVuc2V0KFsic2V0VmFsdWUiLCAic2V0Qm9v bGVhbiIsICJzZXROdW1iZXIiLCAic2V0U3RyaW5nIiwgInNldFZhbHVlIiwgInNldE9iamVjdCIs ICJzZXRBcnJheSJdKQogCiAKK2RlZiBmaXhfdHlwZV9uYW1lKGpzb25fbmFtZSk6CisgICAgaWYg anNvbl9uYW1lIGluIFRZUEVfTkFNRV9GSVhfTUFQOgorICAgICAgICBmaXhlZCA9IFRZUEVfTkFN RV9GSVhfTUFQW2pzb25fbmFtZV0KKworICAgICAgICBjbGFzcyBSZXN1bHQob2JqZWN0KToKKyAg ICAgICAgICAgIGNsYXNzX25hbWUgPSBmaXhlZAorCisgICAgICAgICAgICBAc3RhdGljbWV0aG9k CisgICAgICAgICAgICBkZWYgb3V0cHV0X2NvbW1lbnQob3V0cHV0KToKKyAgICAgICAgICAgICAg ICBvdXRwdXQuYXBwZW5kKCIvLyBUeXBlIG9yaWdpbmFsbHkgd2FzIG5hbWVkICclcycuXG4iICUg anNvbl9uYW1lKQorICAgIGVsc2U6CisKKyAgICAgICAgY2xhc3MgUmVzdWx0KG9iamVjdCk6Cisg ICAgICAgICAgICBjbGFzc19uYW1lID0ganNvbl9uYW1lCisKKyAgICAgICAgICAgIEBzdGF0aWNt ZXRob2QKKyAgICAgICAgICAgIGRlZiBvdXRwdXRfY29tbWVudChvdXRwdXQpOgorICAgICAgICAg ICAgICAgIHBhc3MKKworICAgIHJldHVybiBSZXN1bHQKKworCisKIGNsYXNzIFR5cGVCaW5kaW5n czoKICAgICBAc3RhdGljbWV0aG9kCiAgICAgZGVmIGNyZWF0ZV9mb3JfbmFtZWRfdHlwZV9kZWNs YXJhdGlvbihqc29uX3R5cGUsIGNvbnRleHRfZG9tYWluX25hbWUpOgorICAgICAgICBmaXhlZF90 eXBlX25hbWUgPSBmaXhfdHlwZV9uYW1lKGpzb25fdHlwZVsiaWQiXSkKKworICAgICAgICBkZWYg d3JpdGVfZG9jKG91dHB1dCk6CisgICAgICAgICAgICBpZiAiZGVzY3JpcHRpb24iIGluIGpzb25f dHlwZToKKyAgICAgICAgICAgICAgICBvdXRwdXQuYXBwZW5kKCIvKiAiKQorICAgICAgICAgICAg ICAgIG91dHB1dC5hcHBlbmQoanNvbl90eXBlWyJkZXNjcmlwdGlvbiJdKQorICAgICAgICAgICAg ICAgIG91dHB1dC5hcHBlbmQoIiAqL1xuIikKKwogICAgICAgICBpZiBqc29uX3R5cGVbInR5cGUi XSA9PSAic3RyaW5nIjoKICAgICAgICAgICAgIGlmICJlbnVtIiBpbiBqc29uX3R5cGU6CiAKQEAg LTQ0OSw5ICs0ODYsMTEgQEAgY2xhc3MgVHlwZUJpbmRpbmdzOgogICAgICAgICAgICAgICAgICAg ICBAc3RhdGljbWV0aG9kCiAgICAgICAgICAgICAgICAgICAgIGRlZiBnZW5lcmF0ZV90eXBlX2J1 aWxkZXIob3V0cHV0LCBmb3J3YXJkX2xpc3RlbmVyKToKICAgICAgICAgICAgICAgICAgICAgICAg IGVudW0gPSBqc29uX3R5cGVbImVudW0iXQotICAgICAgICAgICAgICAgICAgICAgICAgIyBUT0RP OiBkb2MKKyAgICAgICAgICAgICAgICAgICAgICAgIHdyaXRlX2RvYyhvdXRwdXQpCisgICAgICAg ICAgICAgICAgICAgICAgICBlbnVtX25hbWUgPSBmaXhlZF90eXBlX25hbWUuY2xhc3NfbmFtZQor ICAgICAgICAgICAgICAgICAgICAgICAgZml4ZWRfdHlwZV9uYW1lLm91dHB1dF9jb21tZW50KG91 dHB1dCkKICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIm5hbWVzcGFjZSAi KQotICAgICAgICAgICAgICAgICAgICAgICAgb3V0cHV0LmFwcGVuZChqc29uX3R5cGVbImlkIl0p CisgICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQuYXBwZW5kKGVudW1fbmFtZSkKICAgICAg ICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIiB7XG4iKQogICAgICAgICAgICAgICAg ICAgICAgICAgZm9yIGVudW1faXRlbSBpbiBlbnVtOgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGl0ZW1fY19uYW1lID0gZW51bV9pdGVtLnJlcGxhY2UoJy0nLCAnXycpCkBAIC00NjEsNyAr NTAwLDcgQEAgY2xhc3MgVHlwZUJpbmRpbmdzOgogICAgICAgICAgICAgICAgICAgICAgICAgICAg IG91dHB1dC5hcHBlbmQoZW51bV9pdGVtKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG91 dHB1dC5hcHBlbmQoIlwiO1xuIikKICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBl bmQoIn0gLy8gbmFtZXNwYWNlICIpCi0gICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQuYXBw ZW5kKGpzb25fdHlwZVsiaWQiXSkKKyAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBl bmQoZW51bV9uYW1lKQogICAgICAgICAgICAgICAgICAgICAgICAgb3V0cHV0LmFwcGVuZCgiXG5c biIpCiAKICAgICAgICAgICAgICAgICByZXR1cm4gRW51bUJpbmRpbmcKQEAgLTQ3MCwxMiArNTA5 LDEwIEBAIGNsYXNzIFR5cGVCaW5kaW5nczoKICAgICAgICAgICAgICAgICBjbGFzcyBQbGFpblN0 cmluZzoKICAgICAgICAgICAgICAgICAgICAgQHN0YXRpY21ldGhvZAogICAgICAgICAgICAgICAg ICAgICBkZWYgZ2VuZXJhdGVfdHlwZV9idWlsZGVyKG91dHB1dCwgZm9yd2FyZF9saXN0ZW5lcik6 Ci0gICAgICAgICAgICAgICAgICAgICAgICBpZiAiZGVzY3JpcHRpb24iIGluIGpzb25fdHlwZToK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQuYXBwZW5kKCIvKiAiKQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoanNvbl90eXBlWyJkZXNjcmlwdGlv biJdKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIiAqL1xuIikK KyAgICAgICAgICAgICAgICAgICAgICAgIHdyaXRlX2RvYyhvdXRwdXQpCisgICAgICAgICAgICAg ICAgICAgICAgICBmaXhlZF90eXBlX25hbWUub3V0cHV0X2NvbW1lbnQob3V0cHV0KQogICAgICAg ICAgICAgICAgICAgICAgICAgb3V0cHV0LmFwcGVuZCgidHlwZWRlZiBTdHJpbmcgIikKLSAgICAg ICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoanNvbl90eXBlWyJpZCJdKQorICAgICAg ICAgICAgICAgICAgICAgICAgb3V0cHV0LmFwcGVuZChmaXhlZF90eXBlX25hbWUuY2xhc3NfbmFt ZSkKICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIjtcblxuIikKICAgICAg ICAgICAgICAgICByZXR1cm4gUGxhaW5TdHJpbmcKIApAQCAtNDg1LDkgKzUyMiwxMCBAQCBjbGFz cyBUeXBlQmluZGluZ3M6CiAgICAgICAgICAgICAgICAgY2xhc3MgQ2xhc3NCaW5kaW5nOgogICAg ICAgICAgICAgICAgICAgICBAc3RhdGljbWV0aG9kCiAgICAgICAgICAgICAgICAgICAgIGRlZiBn ZW5lcmF0ZV90eXBlX2J1aWxkZXIob3V0cHV0LCBmb3J3YXJkX2xpc3RlbmVyKToKLSAgICAgICAg ICAgICAgICAgICAgICAgICMgVE9ETzogZG9jCisgICAgICAgICAgICAgICAgICAgICAgICB3cml0 ZV9kb2Mob3V0cHV0KQorICAgICAgICAgICAgICAgICAgICAgICAgY2xhc3NfbmFtZSA9IGZpeGVk X3R5cGVfbmFtZS5jbGFzc19uYW1lCisgICAgICAgICAgICAgICAgICAgICAgICBmaXhlZF90eXBl X25hbWUub3V0cHV0X2NvbW1lbnQob3V0cHV0KQogICAgICAgICAgICAgICAgICAgICAgICAgb3V0 cHV0LmFwcGVuZCgiY2xhc3MgIikKLSAgICAgICAgICAgICAgICAgICAgICAgIGNsYXNzX25hbWUg PSBqc29uX3R5cGVbImlkIl0KICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQo Y2xhc3NfbmFtZSkKICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIiA6IHB1 YmxpYyBJbnNwZWN0b3JPYmplY3Qge1xuIikKICAgICAgICAgICAgICAgICAgICAgICAgIG91dHB1 dC5hcHBlbmQoInB1YmxpYzpcbiIpCkBAIC0xNDkzLDcgKzE1MzEsNyBAQCBjbGFzcyBHZW5lcmF0 b3I6CiAKICAgICAgICAgICAgIG91dHB1dC5hcHBlbmQoIn0gLy8gIikKICAgICAgICAgICAgIG91 dHB1dC5hcHBlbmQoZG9tYWluX2RhdGEubmFtZSgpKQotICAgICAgICAgICAgb3V0cHV0LmFwcGVu ZCgiXG4iKQorICAgICAgICAgICAgb3V0cHV0LmFwcGVuZCgiXG5cbiIpCiAKIEdlbmVyYXRvci5n bygpCiAK