74239 2011-12-10 11:09:12 -0800 REGRESSION (r80438): First word on a line or after collapsed space may not be hyphenated even though it should 2011-12-12 17:00:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz rniwa oldest_to_newest 518809 0 mitz 2011-12-10 11:09:12 -0800 REGRESSION (r80438): First word on a line or after collapsed space may not be hyphenated even though it should 518810 1 mitz 2011-12-10 11:10:55 -0800 <rdar://problem/10561285> 518811 2 118693 mitz 2011-12-10 11:16:35 -0800 Created attachment 118693 Check whether the first character of the prefix before the hyphen is a space when deciding if the prefix is long enough 518908 3 mitz 2011-12-11 11:07:14 -0800 Fixed in <http://trac.webkit.org/r102538>. 519692 4 rniwa 2011-12-12 16:56:40 -0800 The test is failing on SL: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102627%20(35418)/fast/text/hyphenate-limit-lines-pretty-diff.html Should we just rebaseline? The diff looks similar to the change you made. 519698 5 mitz 2011-12-12 17:00:47 -0800 (In reply to comment #4) > The test is failing on SL: > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102627%20(35418)/fast/text/hyphenate-limit-lines-pretty-diff.html > > Should we just rebaseline? The diff looks similar to the change you made. Yeah, the new results seem right. 118693 2011-12-10 11:16:35 -0800 2011-12-11 10:58:48 -0800 Check whether the first character of the prefix before the hyphen is a space when deciding if the prefix is long enough bug-74239-20111210111633.patch text/plain 6891 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjUyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTEwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwNTYx Mjg1PiBSRUdSRVNTSU9OIChyODA0MzgpOiBGaXJzdCB3b3JkIG9uIGEgbGluZSBvciBhZnRlciBj b2xsYXBzZWQgc3BhY2UgbWF5IG5vdCBiZSBoeXBoZW5hdGVkIGV2ZW4gdGhvdWdoIGl0IHNob3Vs ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyMzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0czog ZmFzdC90ZXh0L2h5cGhlbmF0ZS1maXJzdC13b3JkLWFmdGVyLXNraXBwZWQtc3BhY2UtZXhwZWN0 ZWQuaHRtbAorICAgICAgICAgICAgICAgZmFzdC90ZXh0L2h5cGhlbmF0ZS1maXJzdC13b3JkLWFm dGVyLXNraXBwZWQtc3BhY2UuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr TGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0cnlIeXBoZW5hdGluZyk6IFJlcGxh Y2VkIHRoZSBhc3N1bXB0aW9uIHRoYXQgdGhlIGNoYXJhY3RlciBhdCBsYXN0U3BhY2UgaXMgYSBz cGFjZQorICAgICAgICBpZmYgbGFzdFNwYWNlIGlzIG5vbi16ZXJvIHdpdGggYSB0ZXN0IG9mIHdo ZXRoZXIgaXQgaXMgYSBzcGFjZSwgaW4gdGhlIHNlbnNlIHRoYXQgaXQgc2hvdWxkCisgICAgICAg IG5vdCBiZSBjb3VudGVkIGFzIHBhcnQgb2YgdGhlIHByZWZpeCB3aGVuIGNvbXBhcmluZyBpdCB0 byB0aGUgdmFsdWUgb2YgaHlwaGVuYXRlLWxpbWl0LWJlZm9yZS4KKwogMjAxMS0xMi0xMCAgIEFy a28gU2FoYSAgPGFya29AbW90b3JvbGEuY29tPgogCiAgICAgICAgIE1pY3JvZGF0YTogRml4IGNv bXBpbGF0aW9uIGVycm9yIGluIE1JQ1JPREFUQSBlbmFibGVkIGJ1aWxkLgpJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAJKHJl dmlzaW9uIDEwMjUxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xp bmVMYXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTQwLDEyICsxOTQwLDE3IEBAIHN0YXRp YyB2b2lkIHRyeUh5cGhlbmF0aW5nKFJlbmRlclRleHQqIHQKICAgICAgICAgcmV0dXJuOwogCiAg ICAgcHJlZml4TGVuZ3RoID0gbGFzdEh5cGhlbkxvY2F0aW9uKHRleHQtPmNoYXJhY3RlcnMoKSAr IGxhc3RTcGFjZSwgcG9zIC0gbGFzdFNwYWNlLCBtaW4ocHJlZml4TGVuZ3RoLCBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4ocG9zIC0gbGFzdFNwYWNlIC0gbWluaW11bVN1ZmZpeExlbmd0aCkpICsgMSwg bG9jYWxlSWRlbnRpZmllcik7Ci0gICAgLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcgYXNzdW1lcyB0 aGF0IHRoZSBjaGFyYWN0ZXIgYXQgbGFzdFNwYWNlIGlzIGEgc3BhY2UgKGFuZCB0aGVyZWZvcmUg c2hvdWxkIG5vdCBmYWN0b3IKLSAgICAvLyBpbnRvIGh5cGhlbmF0ZS1saW1pdC1iZWZvcmUpIHVu bGVzcyBsYXN0U3BhY2UgaXMgMC4gVGhpcyBpcyB3cm9uZyBpbiB0aGUgcmFyZSBjYXNlIG9mIGh5 cGhlbmF0aW5nCi0gICAgLy8gdGhlIGZpcnN0IHdvcmQgaW4gYSB0ZXh0IG5vZGUgd2hpY2ggaGFz IGxlYWRpbmcgd2hpdGVzcGFjZS4KLSAgICBpZiAoIXByZWZpeExlbmd0aCB8fCBwcmVmaXhMZW5n dGggLSAobGFzdFNwYWNlID8gMSA6IDApIDwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1pbmltdW1Q cmVmaXhMZW5ndGgpKQorICAgIGlmICghcHJlZml4TGVuZ3RoIHx8IHByZWZpeExlbmd0aCA8IHN0 YXRpY19jYXN0PHVuc2lnbmVkPihtaW5pbXVtUHJlZml4TGVuZ3RoKSkKICAgICAgICAgcmV0dXJu OwogCisgICAgLy8gV2hlbiBsYXN0U2FwY2UgaXMgYSBzcGFjZSwgd2hpY2ggaXQgYWx3YXlzIGlz IGV4Y2VwdCBzb21ldGltZXMgYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxpbmUgb3IgYWZ0ZXIgY29s bGFwc2VkCisgICAgLy8gc3BhY2UsIGl0IHNob3VsZCBub3QgY291bnQgdG93YXJkcyBoeXBoZW5h dGUtbGltaXQtYmVmb3JlLgorICAgIGlmIChwcmVmaXhMZW5ndGggPT0gc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KG1pbmltdW1QcmVmaXhMZW5ndGgpKSB7CisgICAgICAgIFVDaGFyIGNoYXJhY3RlckF0 TGFzdFNwYWNlID0gdGV4dC0+Y2hhcmFjdGVycygpW2xhc3RTcGFjZV07CisgICAgICAgIGlmIChj aGFyYWN0ZXJBdExhc3RTcGFjZSA9PSAnICcgfHwgY2hhcmFjdGVyQXRMYXN0U3BhY2UgPT0gJ1xu JyB8fCBjaGFyYWN0ZXJBdExhc3RTcGFjZSA9PSAnXHQnIHx8IGNoYXJhY3RlckF0TGFzdFNwYWNl ID09IG5vQnJlYWtTcGFjZSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBBU1NF UlQocG9zIC0gbGFzdFNwYWNlIC0gcHJlZml4TGVuZ3RoID49IHN0YXRpY19jYXN0PHVuc2lnbmVk PihtaW5pbXVtU3VmZml4TGVuZ3RoKSk7CiAKICNpZiAhQVNTRVJUX0RJU0FCTEVECkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMDI1MjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMi0xMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgorCisgICAgICAgIFRlc3QgYW5kIHVwZGF0ZWQgcmVzdWx0cyBmb3IgPHJkYXI6Ly9w cm9ibGVtLzEwNTYxMjg1PiBSRUdSRVNTSU9OIChyODA0MzgpOiBGaXJzdCB3b3JkIG9uIGEgbGlu ZSBvciBhZnRlciBjb2xsYXBzZWQgc3BhY2UgbWF5IG5vdCBiZSBoeXBoZW5hdGVkIGV2ZW4gdGhv dWdoIGl0IHNob3VsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvdGV4dC9oeXBoZW5hdGUtZmlyc3Qtd29yZC1hZnRlci1za2lwcGVkLXNwYWNl LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9oeXBoZW5hdGUtZmly c3Qtd29yZC1hZnRlci1za2lwcGVkLXNwYWNlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9mYXN0L3RleHQvaHlwaGVuYXRlLWxpbWl0LWxpbmVzLWV4cGVjdGVkLnR4dDoKKwog MjAxMS0xMi0wOSAgIEFya28gU2FoYSAgPGFya29AbW90b3JvbGEuY29tPgogCiAgICAgICAgIE5h bWVOb2RlTGlzdENhY2hlIHNob3VsZCBiZSBpbnZhbGlkYXRlZCB3aGVuIG5hbWUgYXR0cmlidXRl IGNoYW5nZXMvbW9kaWZpZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaHlwaGVuYXRl LWZpcnN0LXdvcmQtYWZ0ZXItc2tpcHBlZC1zcGFjZS1leHBlY3RlZC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC9oeXBoZW5hdGUtZmlyc3Qtd29yZC1hZnRlci1za2lw cGVkLXNwYWNlLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L3RleHQvaHlwaGVuYXRlLWZpcnN0LXdvcmQtYWZ0ZXItc2tpcHBlZC1zcGFjZS1leHBlY3RlZC5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACis8c3R5bGU+CisgICAgZGl2IHsKKyAg ICAgICAgLXdlYmtpdC1sb2NhbGU6ICJlbl9VUyI7CisgICAgICAgIC13ZWJraXQtaHlwaGVuczog YXV0bzsKKyAgICAgICAgLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQtYmVmb3JlOiAyOworICAgICAg ICB3aWR0aDogNDBweDsKKyAgICAgICAgYm9yZGVyOiBzb2xpZDsKKyAgICAgICAgbWFyZ2luOiA4 cHg7CisgICAgfQorPC9zdHlsZT4KKzxkaXY+VW5kb25lLjwvZGl2PgorPGRpdj5VbmRvbmUuPC9k aXY+Cis8ZGl2PlNpbXBseSA8IS0tIC0tPnVuZG9uZS48L2Rpdj4KKzxkaXY+SSB1bmRpZCBpdC48 L2Rpdj4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9oeXBoZW5hdGUtZmlyc3Qtd29yZC1h ZnRlci1za2lwcGVkLXNwYWNlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L2h5cGhlbmF0ZS1maXJzdC13b3JkLWFmdGVyLXNraXBwZWQtc3BhY2UuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGV4dC9oeXBoZW5hdGUtZmlyc3Qtd29yZC1hZnRl ci1za2lwcGVkLXNwYWNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTYgQEAKKzxzdHls ZT4KKyAgICBkaXYgeworICAgICAgICAtd2Via2l0LWxvY2FsZTogImVuX1VTIjsKKyAgICAgICAg LXdlYmtpdC1oeXBoZW5zOiBhdXRvOworICAgICAgICAtd2Via2l0LWh5cGhlbmF0ZS1saW1pdC1i ZWZvcmU6IDI7CisgICAgICAgIHdpZHRoOiA0MHB4OworICAgICAgICBib3JkZXI6IHNvbGlkOwor ICAgICAgICBtYXJnaW46IDhweDsKKyAgICB9Cis8L3N0eWxlPgorPGRpdj5VbmRvbmUuPC9kaXY+ Cis8ZGl2PgorICAgIFVuZG9uZS4KKzwvZGl2PgorPGRpdj5TaW1wbHkgdW5kb25lLjwvZGl2Pgor PGRpdj5JICB1bmRpZCBpdC48L2Rpdj4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L3RleHQvaHlwaGVuYXRlLWxpbWl0LWxpbmVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC90ZXh0L2h5cGhlbmF0ZS1saW1pdC1saW5l cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEwMjUxNSkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9mYXN0L3RleHQvaHlwaGVuYXRlLWxpbWl0LWxpbmVzLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtNzgsMTUgKzc4LDE2IEBAIGxheWVyIGF0ICgwLDApIHNpemUgNzg1eDEwNjYK ICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxMjUpIHdpZHRoIDIwMDogImVsZW1lbnRzLCBvciBv ZiIKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxNTYpIHdpZHRoIDIwMDogInBsZWFzdXJlcyBh bmQgZGUiICsgaHlwaGVuIHN0cmluZyAiLSIKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxODcp IHdpZHRoIDIwMDogInNpcmVzIGludG8iCi0gICAgICAgICAgdGV4dCBydW4gYXQgKDEsMjE4KSB3 aWR0aCAyMDA6ICJuZWNlc3NhcnkgYW5kIgotICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDI0OSkg d2lkdGggMTU1OiAidW5uZWNlc3NhcnlceHsyMDE0fSIKLSAgICAgICAgICB0ZXh0IHJ1biBhdCAo MSwyODApIHdpZHRoIDIwMDogInRoZXNlIGFuZCBvdGhlciIKLSAgICAgICAgICB0ZXh0IHJ1biBh dCAoMSwzMTEpIHdpZHRoIDIwMDogImdyZWF0IGZvcm1zIG9mIgotICAgICAgICAgIHRleHQgcnVu IGF0ICgxLDM0Mikgd2lkdGggMjAwOiAidGhvdWdodCBhcmUgYWxsIG9mIgotICAgICAgICAgIHRl eHQgcnVuIGF0ICgxLDM3Mykgd2lkdGggNjY6ICJ0aGVtICIKLSAgICAgICAgICB0ZXh0IHJ1biBh dCAoNjcsMzczKSB3aWR0aCAxMzQ6ICJ0byBiZSBmb3VuZCIKLSAgICAgICAgICB0ZXh0IHJ1biBh dCAoMSw0MDQpIHdpZHRoIDIwMDogImluIHRoZSBSZXB1YmxpYywiCi0gICAgICAgICAgdGV4dCBy dW4gYXQgKDEsNDM1KSB3aWR0aCAyMDA6ICJhbmQgd2VyZSBwcm9iYWJseSIKKyAgICAgICAgICB0 ZXh0IHJ1biBhdCAoMSwyMTgpIHdpZHRoIDE2NTogIm5lY2Vzc2FyeSBhbmQgIgorICAgICAgICAg IHRleHQgcnVuIGF0ICgxNjYsMjE4KSB3aWR0aCAzNTogInVuIiArIGh5cGhlbiBzdHJpbmcgIi0i CisgICAgICAgICAgdGV4dCBydW4gYXQgKDEsMjQ5KSB3aWR0aCAxODM6ICJuZWNlc3NhcnlceHsy MDE0fXRoZXNlIgorICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDI4MCkgd2lkdGggMjAwOiAiYW5k IG90aGVyIGdyZWF0IgorICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDMxMSkgd2lkdGggMjAwOiAi Zm9ybXMgb2YgdGhvdWdodCIKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwzNDIpIHdpZHRoIDE4 MDogImFyZSBhbGwgb2YgdGhlbSAiCisgICAgICAgICAgdGV4dCBydW4gYXQgKDE4MSwzNDIpIHdp ZHRoIDIwOiAidG8iCisgICAgICAgICAgdGV4dCBydW4gYXQgKDEsMzczKSB3aWR0aCAyMDA6ICJi ZSBmb3VuZCBpbiB0aGUiCisgICAgICAgICAgdGV4dCBydW4gYXQgKDEsNDA0KSB3aWR0aCAyMDA6 ICJSZXB1YmxpYywgYW5kIgorICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDQzNSkgd2lkdGggMjAw OiAid2VyZSBwcm9iYWJseSIKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSw0NjYpIHdpZHRoIDIw MDogImZpcnN0IGludmVudGVkIGJ5IgogICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDQ5Nykgd2lk dGggNjA6ICJQbGF0by4iCiAgICAgICBSZW5kZXJCbG9jayAoZmxvYXRpbmcpIHtESVZ9IGF0ICgy MTQsNTI5KSBzaXplIDIwMng1MjkgW2JvcmRlcjogKDFweCBzb2xpZCAjQUREOEU2KV0K