74235 2011-12-10 00:11:22 -0800 [Microdata] Fix compilation error in MICRODATA enabled build. 2011-12-10 10:46:49 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 arko webkit-unassigned rniwa webkit.review.bot oldest_to_newest 518759 0 arko 2011-12-10 00:11:22 -0800 MICRODATA enabled builds are now failing with following error, CXX Source/WebCore/dom/libWebCore_la-Document.lo /bin/mkdir -p ./.deps/DerivedSources ../../Source/WebCore/dom/Document.cpp: In member function ‘WTF::PassRefPtr<WebCore::NodeList> WebCore::Document::getItems(const WTF::String&)’: ../../Source/WebCore/dom/Document.cpp:5213:70: error: no matching function for call to ‘WebCore::NodeRareData::ensureNodeLists()’ ../../Source/WebCore/dom/NodeRareData.h:130:24: note: candidate is: WebCore::NodeListsNodeData* WebCore::NodeRareData::ensureNodeLists(WebCore::Node*) make[1]: *** [Source/WebCore/dom/libWebCore_la-Document.lo] Error 1 make[1]: Leaving directory `/home/arko/Workstation/WebKit/WebKitBuild/Release' make: *** [all] Error 2 Failed to build WebKit using 'make'! 518761 1 arko 2011-12-10 00:16:00 -0800 This error is due to the changes committed in changeset: http://trac.webkit.org/changeset/102208. The signature of 'WebCore::NodeRareData::ensureNodeLists()' is changed. Now it takes Node as first parameter, hence resulting the error. 518763 2 118686 arko 2011-12-10 00:20:15 -0800 Created attachment 118686 Patch 518804 3 118686 webkit.review.bot 2011-12-10 10:46:45 -0800 Comment on attachment 118686 Patch Clearing flags on attachment: 118686 Committed r102523: <http://trac.webkit.org/changeset/102523> 518805 4 webkit.review.bot 2011-12-10 10:46:49 -0800 All reviewed patches have been landed. Closing bug. 118686 2011-12-10 00:20:15 -0800 2011-12-10 10:46:45 -0800 Patch bug-74235-20111210135012.patch text/plain 1300 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjUxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTEwICAgQXJrbyBT YWhhICA8YXJrb0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgTWljcm9kYXRhOiBGaXggY29tcGls YXRpb24gZXJyb3IgaW4gTUlDUk9EQVRBIGVuYWJsZWQgYnVpbGQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDIzNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRvY3VtZW50OjpnZXRJdGVtcyk6CisKIDIwMTEtMTItMDkgIEJlbmphbWlu IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHRoZSBGaWxlU3lz dGVtIGZ1bmN0aW9ucyBvZiBpT1MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNp b24gMTAyNTE4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTIxMCw3ICs1MjEwLDcgQEAgRG9jdW1lbnRMb2FkZXIqIERvY3VtZW50Ojpsb2Fk ZXIoKSBjb25zdAogI2lmIEVOQUJMRShNSUNST0RBVEEpCiBQYXNzUmVmUHRyPE5vZGVMaXN0PiBE b2N1bWVudDo6Z2V0SXRlbXMoY29uc3QgU3RyaW5nJiB0eXBlTmFtZXMpCiB7Ci0gICAgTm9kZUxp c3RzTm9kZURhdGEqIG5vZGVMaXN0cyA9IGVuc3VyZVJhcmVEYXRhKCktPmVuc3VyZU5vZGVMaXN0 cygpOworICAgIE5vZGVMaXN0c05vZGVEYXRhKiBub2RlTGlzdHMgPSBlbnN1cmVSYXJlRGF0YSgp LT5lbnN1cmVOb2RlTGlzdHModGhpcyk7CiAKICAgICAvLyBTaW5jZSBkb2N1bWV0LmdldEl0ZW0o KSBpcyBhbGxvd2VkIGZvciBtaWNyb2RhdGEsIHR5cGVOYW1lcyB3aWxsIGJlIG51bGwgc3RyaW5n LgogICAgIC8vIEluIHRoaXMgY2FzZSB3ZSBuZWVkIHRvIGNyZWF0ZSBhbiB1bmlxdWUgc3RyaW5n IGlkZW50aWZpZXIgdG8gbWFwIHN1Y2ggcmVxdWVzdCBpbiB0aGUgY2FjaGUuCg==