74226 2011-12-09 16:40:38 -0800 [chromium] Always use border texels on platforms using pageScaleDelta 2011-12-21 20:56:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aelias aelias aelias cc-bugs enne jamesr sievers webkit.review.bot wjmaclean oldest_to_newest 518631 0 aelias 2011-12-09 16:40:38 -0800 [chromium] Always use border texels on platforms using pageScaleDelta 518634 1 118665 aelias 2011-12-09 16:43:35 -0800 Created attachment 118665 Patch 518636 2 aelias 2011-12-09 16:44:56 -0800 cc'ing wjmaclean@ as you'll likely run into the same problem. 518657 3 118665 jamesr 2011-12-09 17:08:46 -0800 Comment on attachment 118665 Patch R=me 518701 4 aelias 2011-12-09 17:56:54 -0800 cq- as it causes compositing/checkerboard.html layout test to fail. I'll see if I can set GL_NEAREST conditionally on whether there's a transform. 518715 5 118665 webkit.review.bot 2011-12-09 18:18:32 -0800 Comment on attachment 118665 Patch Rejecting attachment 118665 from commit-queue. aelias@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 518717 6 aelias 2011-12-09 18:20:33 -0800 OK, the GL_NEAREST fix is proving more trouble than it's worth (the data isn't easily available from CCTiledLayerImpl::drawTiles(), and GL_NEAREST in the presence of border texels causes other tests to fail for some reason), so I guess we can submit this and I'll disable the checkerboard layout test downstream. 525962 7 118665 webkit.review.bot 2011-12-21 20:56:54 -0800 Comment on attachment 118665 Patch Clearing flags on attachment: 118665 Committed r103490: <http://trac.webkit.org/changeset/103490> 525963 8 webkit.review.bot 2011-12-21 20:56:58 -0800 All reviewed patches have been landed. Closing bug. 118665 2011-12-09 16:43:35 -0800 2011-12-21 20:56:54 -0800 Patch bug-74226-20111209164334.patch text/plain 2136 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NmMmNiM2YzNDEzNGVm OWUxNzYyYjBhNWQzZjZiMTZmZTE1MTE5YS4uMWQ4ODllMjI4MWMyNDk3NjNlNmVlZTMzYzQ0NmFj N2ZjOGMzZWE4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTA5ICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEFs d2F5cyB1c2UgYm9yZGVyIHRleGVscyBvbiBwbGF0Zm9ybXMgdXNpbmcgcGFnZVNjYWxlRGVsdGEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MjI2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gcGxhdGZv cm1zIHdoZXJlIHRoZSByb290IGxheWVyIGNhbiBiZSB6b29tZWQgaW4gYXQgZHJhdyB0aW1lCisg ICAgICAgIChwYWdlU2NhbGVEZWx0YSksIHdlIHdhbnQgdG8gdHVybiBvbiBib3JkZXIgdGV4ZWxz IGluIG9yZGVyIGZvcgorICAgICAgICBzY2FsaW5nIHRvIHVzZSBHTF9MSU5FQVIgaW5zdGVhZCBv ZiBHTF9ORUFSRVNULgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKEZsYWcgZmxpcC4pCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9taXVtOjpwcmVwYXJlVG9VcGRhdGUp OgorCiAyMDExLTEyLTA4ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ29kZUdlbmVyYXRvclY4OiBGaXggaXNzdWUgd2l0aCBvdmVybG9hZGVkIHN0YXRpYyBj b25kaXRpb25hbCBtZXRob2RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNwcAppbmRleCA1 YzU1ZjU5YmYzZTczNzJmZTllYzUxMmVmNjM2MTEwMWFjNWEwNWU1Li5hNGQ5ZmE3YzBjZDhlM2U3 YWNhZGMwYTNjZWU0MjZiN2E1ZDY0YzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTM0NCw4ICszNDQsMTYgQEAgdm9pZCBUaWxlZExheWVyQ2hyb21pdW06OnByb3RlY3RU aWxlVGV4dHVyZXMoY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QpCiAKIHZvaWQgVGlsZWRMYXll ckNocm9taXVtOjpwcmVwYXJlVG9VcGRhdGUoY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QpCiB7 Ci0gICAgaWYgKCFtX3RpbGVyKQotICAgICAgICBjcmVhdGVUaWxlcihpc05vbkNvbXBvc2l0ZWRD b250ZW50KCkgPyBDQ0xheWVyVGlsaW5nRGF0YTo6Tm9Cb3JkZXJUZXhlbHMgOiBDQ0xheWVyVGls aW5nRGF0YTo6SGFzQm9yZGVyVGV4ZWxzKTsKKyAgICBpZiAoIW1fdGlsZXIpIHsKKyAgICAgICAg Q0NMYXllclRpbGluZ0RhdGE6OkJvcmRlclRleGVsT3B0aW9uIGJvcmRlclRleGVsT3B0aW9uOwor I2lmIE9TKEFORFJPSUQpCisgICAgICAgIC8vIEFsd2F5cyB3YW50IGJvcmRlciB0ZXhlbHMgYW5k IEdMX0xJTkVBUiBkdWUgdG8gcGluY2ggem9vbS4KKyAgICAgICAgYm9yZGVyVGV4ZWxPcHRpb24g PSBDQ0xheWVyVGlsaW5nRGF0YTo6SGFzQm9yZGVyVGV4ZWxzOworI2Vsc2UKKyAgICAgICAgYm9y ZGVyVGV4ZWxPcHRpb24gPSBpc05vbkNvbXBvc2l0ZWRDb250ZW50KCkgPyBDQ0xheWVyVGlsaW5n RGF0YTo6Tm9Cb3JkZXJUZXhlbHMgOiBDQ0xheWVyVGlsaW5nRGF0YTo6SGFzQm9yZGVyVGV4ZWxz OworI2VuZGlmCisgICAgICAgIGNyZWF0ZVRpbGVyKGJvcmRlclRleGVsT3B0aW9uKTsKKyAgICB9 CiAKICAgICBBU1NFUlQobV90aWxlcik7CiAK