74225 2011-12-09 16:01:08 -0800 chromium win build: revert build_webkit_exes_from_webkit_gyp change 2011-12-09 16:41:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke oldest_to_newest 518612 0 dpranke 2011-12-09 16:01:08 -0800 chromium win build: revert build_webkit_exes_from_webkit_gyp change 518613 1 118661 dpranke 2011-12-09 16:02:07 -0800 Created attachment 118661 Patch 518617 2 118661 tony 2011-12-09 16:04:19 -0800 Comment on attachment 118661 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118661&action=review > Tools/Scripts/webkitdirs.pm:2084 > $result = buildXCodeProject("Source/WebKit/chromium/All", $clean, "-configuration", configuration(), @options); What about mac? Doesn't it also need to build WebKit instead of All? 518619 3 118662 dpranke 2011-12-09 16:06:57 -0800 Created attachment 118662 fix mac target as well 518620 4 dpranke 2011-12-09 16:07:12 -0800 good catch. please take another look? 518632 5 118662 dpranke 2011-12-09 16:41:49 -0800 Comment on attachment 118662 fix mac target as well Clearing flags on attachment: 118662 Committed r102490: <http://trac.webkit.org/changeset/102490> 518633 6 dpranke 2011-12-09 16:41:52 -0800 All reviewed patches have been landed. Closing bug. 118661 2011-12-09 16:02:07 -0800 2011-12-09 16:06:55 -0800 Patch bug-74225-20111209160206.patch text/plain 3516 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU3NTBjNjg4MTkzZDg1YWM1ZWRiMzkxMzhiYTU3ZDk3YWIyYjI4YWEuLmY1YzY1OTY1ZmFlN2Ew ZTk1NGVmNzgxYWEzYmFlODA3NzYyM2FkYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTcgQEAKIDIwMTEtMTItMDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgY2hyb21pdW0gd2luIGJ1aWxkOiByZXZlcnQgYnVpbGRfd2Via2l0 X2V4ZXNfZnJvbV93ZWJraXRfZ3lwIGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBzZXRzIGJ1aWxkX3dlYmtpdF9leGVzX2Zy b21fd2Via2l0X2d5cCBiYWNrIHRvIDE7CisgICAgICAgIHRoZSAiQWxsLmd5cCIgc29sdXRpb24g ZG9lc24ndCB3b3JrIG9uIHdpbmRvd3MuCisKKyAgICAgICAgKiBneXBfd2Via2l0OgorCisyMDEx LTEyLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIGNo cm9taXVtOiB2aXN1YWwgc3R1ZGlvIHByb2plY3RzIGFyZSBidXN0ZWQgd2hlbiBidWlsZF93ZWJr aXRfZXhlc19mcm9tX3dlYmtpdF9neXA9PTAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc0MjEyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vZ3lwX3dlYmtpdCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdAppbmRl eCA2OWZhY2ZmMjU1N2NkOTJjOWUzOWE5YzI1MzlmNzkxMWUwNmMxYTNlLi40YmUzMzQwZGZjZTkz ZWUzYjI2OTVkMjNkM2MxN2E2NWYzNzE0YTVhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL2d5cF93ZWJraXQKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0 CkBAIC0xMjAsNyArMTIwLDcgQEAgaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICAgICAg ICAgICAgICctRHY4X3VzZV9zbmFwc2hvdD1mYWxzZScsCiAgICAgICAgICAgICAgICAnLURtc3Zz X3VzZV9jb21tb25fcmVsZWFzZT0wJywKICAgICAgICAgICAgICAgICctRGRpc2FibGVfbmFjbD0x JywKLSAgICAgICAgICAgICAgICctRGJ1aWxkX3dlYmtpdF9leGVzX2Zyb21fd2Via2l0X2d5cD0w JywKKyAgICAgICAgICAgICAgICctRGJ1aWxkX3dlYmtpdF9leGVzX2Zyb21fd2Via2l0X2d5cD0x JywKIAogICAgICAgICAgICAgICAgIyBXZWJLaXQgZG9lc24ndCB1c2UgdGhlIGNocm9taXVtIHN0 eWxlIGNoZWNrZXIuCiAgICAgICAgICAgICAgICAnLURtYWtlX2NsYW5nX2Rpcj1Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3RoaXJkX3BhcnR5L2xsdm0tYnVpbGQvUmVsZWFzZStBc3NlcnRzJywKQEAg LTEzMCw3ICsxMzAsNyBAQCBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgICAgICAgICAg ICAgJy0tZGVwdGg9Li8nLAogCiAgICAgICAgICAgICAgICAjIGd5cCBmaWxlIHRvIGV4ZWN1dGUu Ci0gICAgICAgICAgICAgICAnQWxsLmd5cCddKQorICAgICAgICAgICAgICAgJ1dlYktpdC5neXAn XSkKIAogICBwcmludCAnVXBkYXRpbmcgd2Via2l0IHByb2plY3RzIGZyb20gZ3lwIGZpbGVzLi4u JwogICBzeXMuc3Rkb3V0LmZsdXNoKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCAyZjVlMTNhNGU5OGQwYzE3MDIzOTYzOThkOTVmYWEwZDAzNGFj MzNiLi5iN2ZjOTc3ZDA4ZmJmMjg1Nzk2YzU2MGUxZWQyMWJkZjIxNTM5NmEwIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTEtMTItMDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgY2hyb21pdW0gd2luIGJ1aWxkOiByZXZlcnQgYnVpbGRfd2Via2l0X2V4ZXNfZnJvbV93ZWJr aXRfZ3lwIGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQyMjUKKworICAgICAgICBUaGlzIGNoYW5nZSBzZXRzIGJ1aWxkX3dlYmtpdF9leGVz X2Zyb21fd2Via2l0X2d5cCBiYWNrIHRvIDE7CisgICAgICAgIHRoZSAiQWxsLmd5cCIgc29sdXRp b24gZG9lc24ndCB3b3JrIG9uIHdpbmRvd3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgIChidWlsZENocm9taXVtKToKKworMjAxMS0xMi0wOSAgRGlyayBQcmFu a2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBjaHJvbWl1bTogdmlzdWFsIHN0 dWRpbyBwcm9qZWN0cyBhcmUgYnVzdGVkIHdoZW4gYnVpbGRfd2Via2l0X2V4ZXNfZnJvbV93ZWJr aXRfZ3lwPT0wCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NDIxMgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggY2E0NDY2ZDJhMDllZmY0OTE4MjM0YjY5ZDcx ZGM3ZTE1MDUzODVlMy4uNDFiM2RkMWQxYmQyNGUwOWQ4NmM2MWFlMjYwOWEyYzJiZmRjMTQwMCAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQpAQCAtMjA4NCw3ICsyMDg0LDcgQEAgc3ViIGJ1aWxkQ2hyb21pdW0o JEApCiAgICAgICAgICRyZXN1bHQgPSBidWlsZFhDb2RlUHJvamVjdCgiU291cmNlL1dlYktpdC9j aHJvbWl1bS9BbGwiLCAkY2xlYW4sICItY29uZmlndXJhdGlvbiIsIGNvbmZpZ3VyYXRpb24oKSwg QG9wdGlvbnMpOwogICAgIH0gZWxzaWYgKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpIHsKICAg ICAgICAgIyBXaW5kb3dzIGJ1aWxkIC0gYnVpbGRzIHRoZSByb290IHZpc3VhbCBzdHVkaW8gc29s dXRpb24uCi0gICAgICAgICRyZXN1bHQgPSBidWlsZENocm9taXVtVmlzdWFsU3R1ZGlvUHJvamVj dCgiU291cmNlL1dlYktpdC9jaHJvbWl1bS9BbGwuc2xuIiwgJGNsZWFuKTsKKyAgICAgICAgJHJl c3VsdCA9IGJ1aWxkQ2hyb21pdW1WaXN1YWxTdHVkaW9Qcm9qZWN0KCJTb3VyY2UvV2ViS2l0L2No cm9taXVtL1dlYktpdC5zbG4iLCAkY2xlYW4pOwogICAgIH0gZWxzaWYgKGlzTGludXgoKSB8fCBp c0Nocm9taXVtQW5kcm9pZCgpIHx8IGlzQ2hyb21pdW1NYWNNYWtlKSB7CiAgICAgICAgICMgTGlu dXggYnVpbGQgLSBidWlsZCB1c2luZyBtYWtlLgogICAgICAgICAkcmVzdWx0ID0gYnVpbGRDaHJv bWl1bU1ha2VmaWxlKCJhbGwiLCAkY2xlYW4sIEBvcHRpb25zKTsK 118662 2011-12-09 16:06:57 -0800 2011-12-09 16:41:49 -0800 fix mac target as well bug-74225-20111209160656.patch text/plain 3788 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU3NTBjNjg4MTkzZDg1YWM1ZWRiMzkxMzhiYTU3ZDk3YWIyYjI4YWEuLmY1YzY1OTY1ZmFlN2Ew ZTk1NGVmNzgxYWEzYmFlODA3NzYyM2FkYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTcgQEAKIDIwMTEtMTItMDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgY2hyb21pdW0gd2luIGJ1aWxkOiByZXZlcnQgYnVpbGRfd2Via2l0 X2V4ZXNfZnJvbV93ZWJraXRfZ3lwIGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBzZXRzIGJ1aWxkX3dlYmtpdF9leGVzX2Zy b21fd2Via2l0X2d5cCBiYWNrIHRvIDE7CisgICAgICAgIHRoZSAiQWxsLmd5cCIgc29sdXRpb24g ZG9lc24ndCB3b3JrIG9uIHdpbmRvd3MuCisKKyAgICAgICAgKiBneXBfd2Via2l0OgorCisyMDEx LTEyLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIGNo cm9taXVtOiB2aXN1YWwgc3R1ZGlvIHByb2plY3RzIGFyZSBidXN0ZWQgd2hlbiBidWlsZF93ZWJr aXRfZXhlc19mcm9tX3dlYmtpdF9neXA9PTAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc0MjEyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vZ3lwX3dlYmtpdCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdAppbmRl eCA2OWZhY2ZmMjU1N2NkOTJjOWUzOWE5YzI1MzlmNzkxMWUwNmMxYTNlLi40YmUzMzQwZGZjZTkz ZWUzYjI2OTVkMjNkM2MxN2E2NWYzNzE0YTVhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL2d5cF93ZWJraXQKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0 CkBAIC0xMjAsNyArMTIwLDcgQEAgaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICAgICAg ICAgICAgICctRHY4X3VzZV9zbmFwc2hvdD1mYWxzZScsCiAgICAgICAgICAgICAgICAnLURtc3Zz X3VzZV9jb21tb25fcmVsZWFzZT0wJywKICAgICAgICAgICAgICAgICctRGRpc2FibGVfbmFjbD0x JywKLSAgICAgICAgICAgICAgICctRGJ1aWxkX3dlYmtpdF9leGVzX2Zyb21fd2Via2l0X2d5cD0w JywKKyAgICAgICAgICAgICAgICctRGJ1aWxkX3dlYmtpdF9leGVzX2Zyb21fd2Via2l0X2d5cD0x JywKIAogICAgICAgICAgICAgICAgIyBXZWJLaXQgZG9lc24ndCB1c2UgdGhlIGNocm9taXVtIHN0 eWxlIGNoZWNrZXIuCiAgICAgICAgICAgICAgICAnLURtYWtlX2NsYW5nX2Rpcj1Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3RoaXJkX3BhcnR5L2xsdm0tYnVpbGQvUmVsZWFzZStBc3NlcnRzJywKQEAg LTEzMCw3ICsxMzAsNyBAQCBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgICAgICAgICAg ICAgJy0tZGVwdGg9Li8nLAogCiAgICAgICAgICAgICAgICAjIGd5cCBmaWxlIHRvIGV4ZWN1dGUu Ci0gICAgICAgICAgICAgICAnQWxsLmd5cCddKQorICAgICAgICAgICAgICAgJ1dlYktpdC5neXAn XSkKIAogICBwcmludCAnVXBkYXRpbmcgd2Via2l0IHByb2plY3RzIGZyb20gZ3lwIGZpbGVzLi4u JwogICBzeXMuc3Rkb3V0LmZsdXNoKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCAyZjVlMTNhNGU5OGQwYzE3MDIzOTYzOThkOTVmYWEwZDAzNGFj MzNiLi5iN2ZjOTc3ZDA4ZmJmMjg1Nzk2YzU2MGUxZWQyMWJkZjIxNTM5NmEwIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTEtMTItMDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgY2hyb21pdW0gd2luIGJ1aWxkOiByZXZlcnQgYnVpbGRfd2Via2l0X2V4ZXNfZnJvbV93ZWJr aXRfZ3lwIGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQyMjUKKworICAgICAgICBUaGlzIGNoYW5nZSBzZXRzIGJ1aWxkX3dlYmtpdF9leGVz X2Zyb21fd2Via2l0X2d5cCBiYWNrIHRvIDE7CisgICAgICAgIHRoZSAiQWxsLmd5cCIgc29sdXRp b24gZG9lc24ndCB3b3JrIG9uIHdpbmRvd3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgIChidWlsZENocm9taXVtKToKKworMjAxMS0xMi0wOSAgRGlyayBQcmFu a2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBjaHJvbWl1bTogdmlzdWFsIHN0 dWRpbyBwcm9qZWN0cyBhcmUgYnVzdGVkIHdoZW4gYnVpbGRfd2Via2l0X2V4ZXNfZnJvbV93ZWJr aXRfZ3lwPT0wCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NDIxMgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggY2E0NDY2ZDJhMDllZmY0OTE4MjM0YjY5ZDcx ZGM3ZTE1MDUzODVlMy4uOGNlZDRmM2M5M2ZiMTlmN2Q4OTlkZjNkZWJmOGIzNjJlNzZjOGM2ZCAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQpAQCAtMjA4MSwxMCArMjA4MSwxMCBAQCBzdWIgYnVpbGRDaHJvbWl1 bSgkQCkKICAgICBteSAkcmVzdWx0ID0gMTsKICAgICBpZiAoaXNEYXJ3aW4oKSAmJiAhaXNDaHJv bWl1bUFuZHJvaWQoKSAmJiAhaXNDaHJvbWl1bU1hY01ha2UoKSkgewogICAgICAgICAjIE1hYyBi dWlsZCAtIGJ1aWxkcyB0aGUgcm9vdCB4Y29kZSBwcm9qZWN0LgotICAgICAgICAkcmVzdWx0ID0g YnVpbGRYQ29kZVByb2plY3QoIlNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQWxsIiwgJGNsZWFuLCAi LWNvbmZpZ3VyYXRpb24iLCBjb25maWd1cmF0aW9uKCksIEBvcHRpb25zKTsKKyAgICAgICAgJHJl c3VsdCA9IGJ1aWxkWENvZGVQcm9qZWN0KCJTb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdCIs ICRjbGVhbiwgIi1jb25maWd1cmF0aW9uIiwgY29uZmlndXJhdGlvbigpLCBAb3B0aW9ucyk7CiAg ICAgfSBlbHNpZiAoaXNDeWd3aW4oKSB8fCBpc1dpbmRvd3MoKSkgewogICAgICAgICAjIFdpbmRv d3MgYnVpbGQgLSBidWlsZHMgdGhlIHJvb3QgdmlzdWFsIHN0dWRpbyBzb2x1dGlvbi4KLSAgICAg ICAgJHJlc3VsdCA9IGJ1aWxkQ2hyb21pdW1WaXN1YWxTdHVkaW9Qcm9qZWN0KCJTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0FsbC5zbG4iLCAkY2xlYW4pOworICAgICAgICAkcmVzdWx0ID0gYnVpbGRD aHJvbWl1bVZpc3VhbFN0dWRpb1Byb2plY3QoIlNvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0 LnNsbiIsICRjbGVhbik7CiAgICAgfSBlbHNpZiAoaXNMaW51eCgpIHx8IGlzQ2hyb21pdW1BbmRy b2lkKCkgfHwgaXNDaHJvbWl1bU1hY01ha2UpIHsKICAgICAgICAgIyBMaW51eCBidWlsZCAtIGJ1 aWxkIHVzaW5nIG1ha2UuCiAgICAgICAgICRyZXN1bHQgPSBidWlsZENocm9taXVtTWFrZWZpbGUo ImFsbCIsICRjbGVhbiwgQG9wdGlvbnMpOwo=