74224 2011-12-09 15:49:21 -0800 [GStreamer] webkitwebsrc: pad template is leaked 2012-01-09 12:18:32 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 judy.liqiong-hao webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 518601 0 judy.liqiong-hao 2011-12-09 15:49:21 -0800 There is a memory leak in function "webkit_web_src_init" of "WebKitWebSourceGStreamer.cpp" with setting pad-templates for ghostpads. gst_static_pad_template_get() is used to get a GstPadTemplate out of static pad template. This is then passed as a parameter to gst_ghost_pad_new_from_template, which does a ref, but does not take ownership. Attached is a patch that unrefs the pad template after it's used. 518625 1 118663 judy.liqiong-hao 2011-12-09 16:14:40 -0800 Created attachment 118663 proposed patch 519064 2 pnormand 2011-12-12 01:24:42 -0800 Thanks for spotting this! The pad template is still leaked in the case where appsrc is not created though? Can you use GRefPtr for this GstPadTemplate pointer? You'd need to add support for it in GRefPtrGStreamer. 520949 3 118663 pnormand 2011-12-14 08:41:12 -0800 Comment on attachment 118663 proposed patch r- as per above remarks, some of which I applied in the patch of bug 74495 529476 4 pnormand 2012-01-04 05:28:12 -0800 Ping Judy? 529582 5 judy.liqiong-hao 2012-01-04 09:59:41 -0800 (In reply to comment #4) > Ping Judy? Yes? 530061 6 pnormand 2012-01-05 00:30:51 -0800 (In reply to comment #5) > (In reply to comment #4) > > Ping Judy? > > Yes? Do you mind updating this patch? 530817 7 judy.liqiong-hao 2012-01-05 17:19:14 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Ping Judy? > > > > Yes? > Do you mind updating this patch? Will send out a new patch for review ... 532307 8 121685 judy.liqiong-hao 2012-01-09 10:46:41 -0800 Created attachment 121685 Patch 532413 9 121685 webkit.review.bot 2012-01-09 12:18:28 -0800 Comment on attachment 121685 Patch Clearing flags on attachment: 121685 Committed r104475: <http://trac.webkit.org/changeset/104475> 532415 10 webkit.review.bot 2012-01-09 12:18:32 -0800 All reviewed patches have been landed. Closing bug. 118663 2011-12-09 16:14:40 -0800 2012-01-09 10:46:24 -0800 proposed patch gst_memeory_leak.txt text/plain 1388 judy.liqiong-hao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjQ4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA5ICBKdWR5IEhh byAgPGp1ZHkubGlxaW9uZy1oYW9Abm9raWEuY29tPgorCisgICAgICAgIEJ1ZyA3NDIyNDogW0dT dHJlYW1lcl13ZWJraXR3ZWJzcmM6cGFkIHRlbXBsYXRlIGlzIGxlYWtlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyMjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgbWVtb3J5IGxlYWtzLiBT byBuZXcgdGVzdCBjYXNlcyBhcmUgaW50cm9kdWNlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAo d2Via2l0X3dlYl9zcmNfaW5pdCk6CisKIDIwMTEtMTItMDkgIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBhZGQgY3NzIHBhcnNpbmcgZm9yIGZsZXgtZmxvdzogd3Jh cCBhbmQgd3JhcC1yZXZlcnNlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcAkocmV2aXNpb24gMTAyNDcyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIzNiw2ICsyMzYsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NyY19p bml0KFdlYktpdFdlCiAKICAgICBnc3RfZWxlbWVudF9hZGRfcGFkKEdTVF9FTEVNRU5UKHNyYyks IHByaXYtPnNyY3BhZCk7CiAgICAgZ3N0X3BhZF9zZXRfcXVlcnlfZnVuY3Rpb24ocHJpdi0+c3Jj cGFkLCB3ZWJLaXRXZWJTcmNRdWVyeSk7CisgICAgZ3N0X29iamVjdF91bnJlZihwYWRUZW1wbGF0 ZSk7CiAKICAgICBnc3RfYXBwX3NyY19zZXRfY2FsbGJhY2tzKHByaXYtPmFwcHNyYywgJmFwcHNy Y0NhbGxiYWNrcywgc3JjLCAwKTsKICAgICBnc3RfYXBwX3NyY19zZXRfZW1pdF9zaWduYWxzKHBy aXYtPmFwcHNyYywgRkFMU0UpOwo= 121685 2012-01-09 10:46:41 -0800 2012-01-09 12:18:28 -0800 Patch bug-74224-20120109104638.patch text/plain 1994 judy.liqiong-hao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDM2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTA2ICBKdWR5IEhh byAgPGp1ZHkubGlxaW9uZy1oYW9Abm9raWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIHdl YmtpdHdlYnNyYzogcGFkIHRlbXBsYXRlIGlzIGxlYWtlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBQ aGlsaXBwZSBOb3JtYW5kLgorCisgICAgICAgIFVzZSBhIEdzdFBhZFRlbXBsYXRlIHNtYXJ0IHBv aW50ZXIgaW4gd2Via2l0X3dlYl9zcmNfaW5pdCB0bworICAgICAgICBhdm9pZCBhIG1lbW9yeSBs ZWFrLgorCisgICAgICAgIEZpeGluZyBtZW1vcnkgbGVha3MuIFNvLCBubyBuZXcgdGVzdCBjYXNl IGlzIGludHJvZHVjZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfc3JjX2lu aXQpOgorCiAyMDEyLTAxLTA2ICBHcmVnIEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgog CiAgICAgICAgIFdlYkNvcmUgaW1wbGVtZW50YXRpb24gb2YgdGhlIEludGVudCBvYmplY3QKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJT b3VyY2VHU3RyZWFtZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCShyZXZpc2lv biAxMDQyMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEyLDcgKzIx Miw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc3JjX2NsYXNzX2luaXQoV2UKIAogc3RhdGlj IHZvaWQgd2Via2l0X3dlYl9zcmNfaW5pdChXZWJLaXRXZWJTcmMqIHNyYykKIHsKLSAgICBHc3RQ YWRUZW1wbGF0ZSogcGFkVGVtcGxhdGUgPSBnc3Rfc3RhdGljX3BhZF90ZW1wbGF0ZV9nZXQoJnNy Y1RlbXBsYXRlKTsKKyAgICBHUmVmUHRyPEdzdFBhZFRlbXBsYXRlPiBwYWRUZW1wbGF0ZSA9IGFk b3B0R1JlZihnc3Rfc3RhdGljX3BhZF90ZW1wbGF0ZV9nZXQoJnNyY1RlbXBsYXRlKSk7CiAgICAg V2ViS2l0V2ViU3JjUHJpdmF0ZSogcHJpdiA9IFdFQktJVF9XRUJfU1JDX0dFVF9QUklWQVRFKHNy Yyk7CiAKICAgICBzcmMtPnByaXYgPSBwcml2OwpAQCAtMjMyLDcgKzIzMiw3IEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF93ZWJfc3JjX2luaXQoV2ViS2l0V2UKIAogCiAgICAgR1JlZlB0cjxHc3RQYWQ+ IHRhcmdldFBhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChHU1RfRUxF TUVOVChwcml2LT5hcHBzcmMpLCAic3JjIikpOwotICAgIHByaXYtPnNyY3BhZCA9IGdzdF9naG9z dF9wYWRfbmV3X2Zyb21fdGVtcGxhdGUoInNyYyIsIHRhcmdldFBhZC5nZXQoKSwgcGFkVGVtcGxh dGUpOworICAgIHByaXYtPnNyY3BhZCA9IGdzdF9naG9zdF9wYWRfbmV3X2Zyb21fdGVtcGxhdGUo InNyYyIsIHRhcmdldFBhZC5nZXQoKSwgcGFkVGVtcGxhdGUuZ2V0KCkpOwogCiAgICAgZ3N0X2Vs ZW1lbnRfYWRkX3BhZChHU1RfRUxFTUVOVChzcmMpLCBwcml2LT5zcmNwYWQpOwogICAgIGdzdF9w YWRfc2V0X3F1ZXJ5X2Z1bmN0aW9uKHByaXYtPnNyY3BhZCwgd2ViS2l0V2ViU3JjUXVlcnkpOwo=