7422 2006-02-22 12:30:57 -0800 Setting a frame name to the same value resets it to a generated one 2006-03-10 19:16:35 -0800 1 1 1 Unclassified WebKit Frames 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 opendarwin.org darin ap oldest_to_newest 33719 0 opendarwin.org 2006-02-22 12:30:57 -0800 It appears that one cannot set the name of a frame using Javascript in Safari (both 417.8 and the latest nightly build, r12930); trying to do so results in the frame getting a name that appears to be some sort of underlying code comment ("<!--framePath //<!--frame2-->-->"). I'll attach a test case showing the bug, and I've already set up the same test case at the following URL: http://jzone.queso.org/safariframes/ (I ran into this bug for the first time yesterday, when the latest release candidate of phpMyAdmin was released and broke; it relies on being able to set the main content frame's name in order to target links appropriately, and now they are all opening in new windows as a result! Because of the popularity of phpMyAdmin, I've set the severity of the bug to major -- apologies in advance if this was presumptive of me.) 33720 1 6670 opendarwin.org 2006-02-22 12:31:44 -0800 Created attachment 6670 test case showing frame name bug 33721 2 opendarwin.org 2006-02-22 12:34:19 -0800 I forgot to mention in my report -- searching through prior bug reports, bug #6751 might be related (or the same). 33761 3 6675 ap 2006-02-23 02:01:00 -0800 Created attachment 6675 reduced test case 33762 4 ap 2006-02-23 02:12:33 -0800 Setting the frame name normally works, but if the new name is already taken, a generated one is used instead, to avoid duplicate names. Here, a frame named 'frame_content' is renamed to 'frame_content', thus renaming fails. Working around the problem should be trivial: just don't try to set the frame name if it's already correct. So, I'm downgrading the severity to normal (though setting it to major originally was perfectly fine IMO). This special case can be easily fixed in WebCore; however, the general problem of exposing generated names is not clear to me. 33766 5 opendarwin.org 2006-02-23 06:59:26 -0800 Thanks for the clarification, Alexey -- I hadn't thought forward enough to test whether it was a universal issue (setting ANY frame's name, regardless of what the frame's current name is). It turns out that 90+ percent of the time, phpMyAdmin is trying to set the name of the frame when it's already the right thing, hence me seeing the bug there... and you're right, wrapping the attempt in an if statement testing the frame's current name works around the problem. 35756 6 6993 ap 2006-03-10 11:50:49 -0800 Created attachment 6993 proposed fix 35821 7 6993 darin 2006-03-10 14:53:32 -0800 Comment on attachment 6993 proposed fix This is fixed in a different way by my patch for bug 3308 -- I'd like to use your layout test but my fix. 6670 2006-02-22 12:31:44 -0800 2006-02-22 12:31:44 -0800 test case showing frame name bug safariframes.zip application/zip 3156 opendarwin.org UEsDBAoAAAAAAG56VjQAAAAAAAAAAAAAAAANABAAc2FmYXJpZnJhbWVzL1VYDAAXuPxDUMf8Q/UB 9QFQSwMEFAAIAAgAbnpWNAAAAAAAAAAAAAAAABYAEABzYWZhcmlmcmFtZXMvLkRTX1N0b3JlVVgM AGLH/ENQx/xD9QH1Ae2YzU4CMRRGv1tnUWJiunRZX8CEN2gILli7cyWIPySDsADDcp7NF9N2+qGE qYmuIHJP0pxJem/bmUXbOwBksJ72AQfAIlvSQwHL1sHQVUpux9jgGku8YDmqy2MdHWntPczwiike d9e/eJjUiwnyp7mL7eqjpc2yqGP0E1bleLnoxM8xbmcpx7/vxfdi1BjPcY5+OcO87WUoiqIoym+R LHt+2GUoinKEpP3B04FusoX9hq52chzt6UA32cI4Q1e0pR3t6UA32dy0hMWHcOZt8SKO9nT40ysr yslwluXS+X/zc/2vKMo/Rqrh7XCAr4KgQzprfWz32wTwNEf3EmDyz8JLfPd7OtBNtl4EFOVQfAJQ SwcIckjmOg8BAAAEGAAAUEsDBAoAAAAAAHd6VjQAAAAAAAAAAAAAAAAJABAAX19NQUNPU1gvVVgM AGLH/ENix/xD9QH1AVBLAwQKAAAAAAB3elY0AAAAAAAAAAAAAAAAFgAQAF9fTUFDT1NYL3NhZmFy aWZyYW1lcy9VWAwAYsf8Q2LH/EP1AfUBUEsDBBQACAAIAG56VjQAAAAAAAAAAAAAAAAhABAAX19N QUNPU1gvc2FmYXJpZnJhbWVzLy5fLkRTX1N0b3JlVVgMAGLH/ENQx/xD9QH1AWNgFWNnYGLABCAx TiA2AmIFKD8IWYEDFk0gAABQSwcIDY4jdxwAAABSAAAAUEsDBBQACAAIAGp5VjQAAAAAAAAAAAAA AAAWABAAc2FmYXJpZnJhbWVzL2luZGV4LnBocFVYDABix/xDZ8X8Q/UB9QGNUDtPwzAQnttfcXhE JNfQhZY4A2kRSAUqCAImZBqnsZQ4wbk25d/jvGCgA4t1vvse951/sngIo7f1ElLKM1g/X61uQ2AO 4ss0RFxEC3i9ie5W4LkTuDYil5UkxOU9A5YSlXPEuq7deuoWZovRIx4aHa8h9qWT9Cw3ppgFY781 OuSZrvgRCW82m3VM1oDmmdBbzqRm8FvFynCWkWnVpIiD8cgnRZkMnkQijAKSFfnYtewslySgsXLk 507tOQsLTVKTE32VksGm+3FG8kDYWF/CJhXG7sx3lDgXDNA64WA1BLLEzGY4n0zOThmYorYfW6iY s1woPVzLbjnqSdC+H4WJpU3gddi2967FXm0FqcLmq8zG5pMJuWVaMtB2fgyG/xLu0/WqzWJ/VX8w jaSPQ8A2tD1HMP4GUEsHCOTMFnc2AQAAJwIAAFBLAwQUAAgACADleVY0AAAAAAAAAAAAAAAAFQAQ AHNhZmFyaWZyYW1lcy9sZWZ0LnBocFVYDABix/xDTsb8Q/UB9QFtUl1v00AQfE5+xXI8kEiND6sv pLH9QFIEUigVBAFCqLrY6w/qnM15XadC/Hf27lxFRDzYutudnZkdO3q2+bDefbu9hpIONdx+fr19 twaxkPLL5VrKzW4DX9/u3m8hDF7CG6MO2CFJeX0jQJRE7ZWUwzAEw2XQmELuPsqj5Qnt4Hhc5ONU kFEmkmnkhI6HWnfxfyjC5XLpJ4UFXdVKF7FALeB0yioTi5qMY0OVJdNJRBXVmNSYEzjBSPoKtw5I CqzSAn/11UMs1o0m1LTYPbYoIPW3WBAeSVrlFaSlMmw57ilfvBIgLc1edQikTMF14TTuxtER0KWm agmIWUeyn+pB+SpbnUzyXqdUNRqY2mV5w89sDr+5NxkqnTVD0CrDjIEP7Xv4I9B8gBjOFFd2RNVo aCYOqtJ+aXBgZhdzBzBIveGeqju0hT/sUnpDHJ302UX7Jnu0/ssw2XJ+XA/ttU0ijs1gHotWFRgG bdmKZF1X6T1QA0Vj37YDYSRVArOubPo6g6ZFDeyISoSTtXkQydbTegqOgfmf8rzrsM7FKPdccDe1 qFj8G9XKRk1l1UFd6XsnyyYYc6bmg+DWWWwnE5+QqNKFm3OYF92Ynt9CN2T/As3rDSUadEC/rdN2 a3YrUDmhAWf2iW7fE/F2rD4SnGtccKXpi/LCz9koztlVwbt4t5H0Hyhy/2Yy/QtQSwcIKeuJvQoC AACzAwAAUEsDBBQACAAIAJh5VjQAAAAAAAAAAAAAAAAVABAAc2FmYXJpZnJhbWVzL21haW4ucGhw VVgMAGLH/EO/xfxD9QH1AW1QTU/DMAw9b7/ChAPs0JqKC2NpD3QgkGAgVAQIcQhttgbStKQeHUL8 d5J2EhLiEMl5tt+H+c78Os0eb06hpErDzd3J5UUKLEC8P0wR59kcHs6zq0uIwgM4s6KSrSTE0wUD VhI1x4hd14XdYVjbFWa3uPE8kV/clsFyuxUWVLBkzHuhTaVNG/9DEU2n02GT+aFjLcwqZtIw+K0K ZWOmyfZsUhTJeMRJkZZJJZSBXpDjgLhWJUmAVwrk+1p9xCytDUlDQfbZSAb58IsZyQ2hV55BXgrr LMdrWgZHDNDTtLlVDQG5pe3sq/gQA+qcjEbLtclJ1Qbasu76Wy3c25/Al2uOhJaW9jtliroLG2Gd ZDic5il6Do0rJjM/ZyWtrQshdCs98O2kcVBxcXHIy1/q4tObKqPkymV2eOS/TZJqlb8Bd4GtXMZs l0Ftco/F7I+tGUuoVC1oZd44igSo7p1Dj/bW9lrwxkKOjdceRHl/o2T8A1BLBwiAIvrpcQEAADsC AABQSwMEFAAIAAgAwnlWNAAAAAAAAAAAAAAAABYAEABzYWZhcmlmcmFtZXMvcGFnZTEucGhwVVgM AGLH/EMLxvxD9QH1AW2OTU+DQBCGz/IrxrnDSHqRustBqNGkKjEY9biWKZDwJZ0K/feyhcRLb+/s 7Ps8o67j1yj9SjZQSF1B8n6/fYoAXaKPVUQUpzF8PqbPW/C9G3joTc0HFqLNCwIWIt2aaBgGb1h5 bZ9T+kaj5fi2uER3v7S8TDIMHXUWjXXVHPQFhB8EwdxE+2ldmSbXyA3Cf8rKXmMl/ZnGJgudKyWl VBx2JmfwFc3T9FyzGLAWl3+O5a/GqG2EG3HTU8cIu3nSKDwKWesd7ArTT+fqo+zdWwSaJDRb1Heb nSy18MNkMU1x2s8LdSaEzh9QSwcID5O6g+gAAABVAQAAUEsBAhUDCgAAAAAAbnpWNAAAAAAAAAAA AAAAAA0ADAAAAAAAAAAAQO1BAAAAAHNhZmFyaWZyYW1lcy9VWAgAF7j8Q1DH/ENQSwECFQMUAAgA CABuelY0ckjmOg8BAAAEGAAAFgAMAAAAAAAAAABApIE7AAAAc2FmYXJpZnJhbWVzLy5EU19TdG9y ZVVYCABix/xDUMf8Q1BLAQIVAwoAAAAAAHd6VjQAAAAAAAAAAAAAAAAJAAwAAAAAAAAAAED9QZ4B AABfX01BQ09TWC9VWAgAYsf8Q2LH/ENQSwECFQMKAAAAAAB3elY0AAAAAAAAAAAAAAAAFgAMAAAA AAAAAABA/UHVAQAAX19NQUNPU1gvc2FmYXJpZnJhbWVzL1VYCABix/xDYsf8Q1BLAQIVAxQACAAI AG56VjQNjiN3HAAAAFIAAAAhAAwAAAAAAAAAAECkgRkCAABfX01BQ09TWC9zYWZhcmlmcmFtZXMv Ll8uRFNfU3RvcmVVWAgAYsf8Q1DH/ENQSwECFQMUAAgACABqeVY05MwWdzYBAAAnAgAAFgAMAAAA AAAAAABApIGUAgAAc2FmYXJpZnJhbWVzL2luZGV4LnBocFVYCABix/xDZ8X8Q1BLAQIVAxQACAAI AOV5VjQp64m9CgIAALMDAAAVAAwAAAAAAAAAAECkgR4EAABzYWZhcmlmcmFtZXMvbGVmdC5waHBV WAgAYsf8Q07G/ENQSwECFQMUAAgACACYeVY0gCL66XEBAAA7AgAAFQAMAAAAAAAAAABApIF7BgAA c2FmYXJpZnJhbWVzL21haW4ucGhwVVgIAGLH/EO/xfxDUEsBAhUDFAAIAAgAwnlWNA+TuoPoAAAA VQEAABYADAAAAAAAAAAAQKSBPwgAAHNhZmFyaWZyYW1lcy9wYWdlMS5waHBVWAgAYsf8QwvG/ENQ SwUGAAAAAAkACQDDAgAAewkAAAAA 6675 2006-02-23 02:01:00 -0800 2006-02-23 02:01:00 -0800 reduced test case reset-frame-name.html text/html 755 ap PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgRnJhbWVzZXQvL0VO IiAiaHR0cDovL3d3dy53My5vcmcvVFIveGh0bWwxL0RURC94aHRtbDEtZnJhbWVzZXQuZHRkIj4K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIg bGFuZz0iZW4iIGRpcj0ibHRyIj4KPGhlYWQ+Cgk8dGl0bGU+U2FmYXJpIHRlc3Q8L3RpdGxlPgoJ PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJz ZXQ9dXRmLTgiIC8+CjwvaGVhZD4KCTxmcmFtZXNldCBjb2xzPSIyMDAsKiIgcm93cz0iKiIgaWQ9 Im1haW5GcmFtZXNldCI+CgkJPGZyYW1lIGZyYW1lYm9yZGVyPSIxIiBpZD0iZnJhbWVfMSIgc3Jj PSJkYXRhOnRleHQvaHRtbCwgZnJhbWVfMSIgbmFtZT0iZnJhbWVfMSIgLz4KCQk8ZnJhbWUgZnJh bWVib3JkZXI9IjEiIHNyYz0iamF2YXNjcmlwdDoKCQkJCgkJCXZhciBvbGROYW1lID0gd2luZG93 LnBhcmVudC5mcmFtZXNbMF0ubmFtZTsKCQkJd2luZG93LnBhcmVudC5mcmFtZXNbMF0ubmFtZSA9 IG9sZE5hbWU7CgkJCWlmICh3aW5kb3cucGFyZW50LmZyYW1lc1swXS5uYW1lID09IG9sZE5hbWUp IHsKCQkJCWFsZXJ0KCdTVUNDRVNTJyk7CgkJCX0gZWxzZSB7CgkJCQlhbGVydCgnRkFJTFVSRTog JyArIHdpbmRvdy5wYXJlbnQuZnJhbWVzWzBdLm5hbWUpOwoJCQl9CgkJCgkJIiAvPgoJPC9mcmFt ZXNldD4KPC9odG1sPgo= 6993 2006-03-10 11:50:49 -0800 2006-03-10 14:53:32 -0800 proposed fix 7422r1_patch.txt text/plain 2262 ap SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLW5hbWUtcmVzZXQuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1uYW1lLXJlc2V0Lmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1uYW1lLXJlc2V0 Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjQgQEAKKzwhRE9DVFlQRSBodG1sIFBVQkxJ QyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4wIEZyYW1lc2V0Ly9FTiIgImh0dHA6Ly93d3cudzMub3Jn L1RSL3hodG1sMS9EVEQveGh0bWwxLWZyYW1lc2V0LmR0ZCI+Cis8aHRtbCB4bWxucz0iaHR0cDov L3d3dy53My5vcmcvMTk5OS94aHRtbCIgeG1sOmxhbmc9ImVuIiBsYW5nPSJlbiIgZGlyPSJsdHIi PgorPGhlYWQ+CisJPHRpdGxlPkJ1ZyA3NDIyPC90aXRsZT4KKwk8c2NyaXB0PgorCQlpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorCQkgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworCTwvc2NyaXB0PgorPC9oZWFkPgorCTxmcmFtZXNldCBjb2xzPSI0MDAsKiIg cm93cz0iKiIgaWQ9Im1haW5GcmFtZXNldCI+CisJCTxmcmFtZSBmcmFtZWJvcmRlcj0iMSIgbmFt ZT0iZnJhbWVfMSIgaWQ9ImZyYW1lXzEiIHNyYz0iZGF0YTp0ZXh0L2h0bWwsIFRlc3QgZm9yIDxh IGhyZWY9J2h0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQy MicgdGFyZ2V0PSdfdG9wJz4gYnVnIDc0MjI8L2E+OiBzZXR0aW5nIGEgZnJhbWUgbmFtZSB0byB0 aGUgc2FtZSB2YWx1ZSByZXNldHMgaXQgdG8gYSBnZW5lcmF0ZWQgb25lLiIgLz4KKwkJPGZyYW1l IGZyYW1lYm9yZGVyPSIxIiBzcmM9ImphdmFzY3JpcHQ6CisJCQkKKwkJCXZhciBvbGROYW1lID0g d2luZG93LnBhcmVudC5mcmFtZXNbMF0ubmFtZTsKKwkJCXdpbmRvdy5wYXJlbnQuZnJhbWVzWzBd Lm5hbWUgPSBvbGROYW1lOworCQkJaWYgKHdpbmRvdy5wYXJlbnQuZnJhbWVzWzBdLm5hbWUgPT0g b2xkTmFtZSkgeworCQkJCWFsZXJ0KCdTVUNDRVNTJyk7CisJCQl9IGVsc2UgeworCQkJCWFsZXJ0 KCdGQUlMVVJFOiAnICsgd2luZG93LnBhcmVudC5mcmFtZXNbMF0ubmFtZSk7CisJCQl9CisJCQor CQkiIC8+CisJPC9mcmFtZXNldD4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZnJh bWVzL2ZyYW1lLW5hbWUtcmVzZXQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLW5hbWUtcmVzZXQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtbmFtZS1yZXNldC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorQUxFUlQ6IFNVQ0NFU1MKKwpJbmRleDog V2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Zy YW1lVHJlZS5jcHAJKHJldmlzaW9uIDEzMjQ3KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDEzICszOSwxNCBAQCBGcmFtZVRyZWU6On5GcmFtZVRy ZWUoKQogCiB2b2lkIEZyYW1lVHJlZTo6c2V0TmFtZShjb25zdCBET01TdHJpbmcmIG5hbWUpIAog eyAKLSAgICBET01TdHJpbmcgbiA9IG5hbWU7CisgICAgaWYgKG1fbmFtZSA9PSBuYW1lKQorICAg ICAgICByZXR1cm47CiAgICAgICAgIAogICAgIC8vIEZJWE1FOiBpcyB0aGUgYmxhbmsgcnVsZSBu ZWVkZWQgb3IgdXNlZnVsPwogICAgIGlmIChwYXJlbnQoKSAmJiAobmFtZS5pc0VtcHR5KCkgfHwg cGFyZW50KCktPmZyYW1lRXhpc3RzKG5hbWUucXN0cmluZygpKSB8fCBuYW1lID09ICJfYmxhbmsi KSkKLSAgICAgICAgbiA9IHBhcmVudCgpLT5yZXF1ZXN0RnJhbWVOYW1lKCk7Ci0gICAgCi0gICAg bV9uYW1lID0gbjsKKyAgICAgICAgbV9uYW1lID0gcGFyZW50KCktPnJlcXVlc3RGcmFtZU5hbWUo KTsKKyAgICBlbHNlCisgICAgICAgIG1fbmFtZSA9IG5hbWU7CiB9CiAKIHZvaWQgRnJhbWVUcmVl OjphcHBlbmRDaGlsZChQYXNzUmVmUHRyPEZyYW1lPiBjaGlsZCkK