74208 2011-12-09 13:20:28 -0800 Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console 2011-12-15 05:26:39 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein keishi loislo pfeldman pmuellr yurys oldest_to_newest 518444 0 caseq 2011-12-09 13:20:28 -0800 Extension tests run in a context of their own, so to interface them with inspector test suite, we just log to console and pick test execution results from console in the front-end context. 518446 1 118622 caseq 2011-12-09 13:22:37 -0800 Created attachment 118622 Patch 518899 2 118622 pfeldman 2011-12-11 09:39:20 -0800 Comment on attachment 118622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review > Source/WebKit/chromium/src/js/Tests.js:561 > +TestSuite.prototype.testWaitForResultsInConsole = function() Could you elaborate on how you intend to use this? 518903 3 118622 pfeldman 2011-12-11 09:44:36 -0800 Comment on attachment 118622 Patch Clearing the r? while waiting for the clarification to remote it from the dashboard. 518906 4 caseq 2011-12-11 10:10:11 -0800 (In reply to comment #3) > (From update of attachment 118622 [details]) > Clearing the r? while waiting for the clarification to remote it from the dashboard. See http://codereview.chromium.org/8899008/ for context. Basically, we use console as a poor man's IPC here: the test actually runs asynchronously in another context and reports the results to the inspector console. 519175 5 118622 yurys 2011-12-12 07:14:29 -0800 Comment on attachment 118622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review >> Source/WebKit/chromium/src/js/Tests.js:561 >> +TestSuite.prototype.testWaitForResultsInConsole = function() > > Could you elaborate on how you intend to use this? Could you pick a more specific name for the test method? > Source/WebKit/chromium/src/js/Tests.js:568 > + else if (/^FAIL/.test(text)) If there are several failures you may want to print all of them. 519179 6 pfeldman 2011-12-12 07:19:08 -0800 (In reply to comment #5) > (From update of attachment 118622 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review > > >> Source/WebKit/chromium/src/js/Tests.js:561 > >> +TestSuite.prototype.testWaitForResultsInConsole = function() > > > > Could you elaborate on how you intend to use this? > > Could you pick a more specific name for the test method? Sounds like this is not a method, but rather is a part of the harness. It would be great to get a bigger picture in the ChangeLog... > > > Source/WebKit/chromium/src/js/Tests.js:568 > > + else if (/^FAIL/.test(text)) > > If there are several failures you may want to print all of them. 521844 7 caseq 2011-12-15 05:25:28 -0800 renamed to TestSuite.prototype.waitForTestResultsInConsole, added a ChangeLog with a reference to usage. 521845 8 caseq 2011-12-15 05:26:39 -0800 Committed r102928: <http://trac.webkit.org/changeset/102928> 118622 2011-12-09 13:22:37 -0800 2011-12-12 07:14:29 -0800 Patch bug-74208-20111209132236.patch text/plain 2080 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY5YmNhY2VkMzVjY2FmZDU0OGExYTZjMzk2ZGNhMGUxYzMxMTE5ZWQuLmJjODZlZGMyYTRiYWI3 YTVmMDZlMmExZGE4YWVlY2U2MGFmMzU5NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMTItMDkgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIGFkZCBzdXBwb3J0 IHRvIGluc3BlY3RvciB0ZXN0IHN1aXRlIHRvIGZldGNoIHRlc3QgZXhlY3V0aW9uIHJlc3VsdHMg ZnJvbSBjb25zb2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NDIwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL2pzL1Rlc3RzLmpzOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUudGVz dFdhaXRGb3JSZXN1bHRzSW5Db25zb2xlLm9uQ29uc29sZU1lc3NhZ2UpOgorICAgICAgICAoLlRl c3RTdWl0ZS5wcm90b3R5cGUudGVzdFdhaXRGb3JSZXN1bHRzSW5Db25zb2xlKToKKwogMjAxMS0x Mi0wOCAgRWxsaW90IFBvZ2VyICA8ZXBvZ2VyQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ2hyb21p dW0gREVQUyByb2xsIDExMjk3NCAtPiAxMTM2MDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL2pzL1Rlc3RzLmpzIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMv VGVzdHMuanMKaW5kZXggYzUzODI2OTEyY2E2NTkwZTdkMTQ2YzVlZTBkZDRkYTFmMGJjZmEyZC4u MTE3OGE0YjNiN2Q5ZWQ3ZmQzMDUwOGFlMDBmYjEwZDEwMThlMDkwNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvanMvVGVzdHMuanMKQEAgLTU1OCw2ICs1NTgsMzEgQEAgVGVzdFN1aXRlLnBy b3RvdHlwZS50ZXN0UGF1c2VJblNoYXJlZFdvcmtlckluaXRpYWxpemF0aW9uID0gZnVuY3Rpb24o KQogfTsKIAogCitUZXN0U3VpdGUucHJvdG90eXBlLnRlc3RXYWl0Rm9yUmVzdWx0c0luQ29uc29s ZSA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgbWVzc2FnZXMgPSBXZWJJbnNwZWN0b3IuY29uc29s ZS5tZXNzYWdlczsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IG1lc3NhZ2VzLmxlbmd0aDsgKytp KSB7CisgICAgICAgIHZhciB0ZXh0ID0gbWVzc2FnZXNbaV0udGV4dDsKKyAgICAgICAgaWYgKHRl eHQgPT09ICJQQVNTIikKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgZWxzZSBpZiAoL15G QUlMLy50ZXN0KHRleHQpKQorICAgICAgICAgICAgdGhpcy5mYWlsKHRleHQpOyAvLyBUaGlzIHdp bGwgdGhyb3cuCisgICAgfQorICAgIC8vIE5laXR3ZXIgUEFTUyBub3IgRkFJTCwgc28gd2FpdCBm b3IgbW9yZSBtZXNzYWdlcy4KKyAgICBmdW5jdGlvbiBvbkNvbnNvbGVNZXNzYWdlKGV2ZW50KQor ICAgIHsKKyAgICAgICAgdmFyIHRleHQgPSBldmVudC5kYXRhLnRleHQ7CisgICAgICAgIGlmICh0 ZXh0ID09PSAiUEFTUyIpCisgICAgICAgICAgICB0aGlzLnJlbGVhc2VDb250cm9sKCk7CisgICAg ICAgIGVsc2UgaWYgKC9eRkFJTC8udGVzdCh0ZXh0KSkKKyAgICAgICAgICAgIHRoaXMuZmFpbCh0 ZXh0KTsKKyAgICB9CisKKyAgICBXZWJJbnNwZWN0b3IuY29uc29sZS5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5Db25zb2xlTW9kZWwuRXZlbnRzLk1lc3NhZ2VBZGRlZCwgb25Db25zb2xl TWVzc2FnZSwgdGhpcyk7CisgICAgdGhpcy50YWtlQ29udHJvbCgpOworfTsKKworCiAvKioKICAq IFNlcmlhbGl6ZXMgb3B0aW9ucyBjb2xsZWN0aW9uIHRvIHN0cmluZy4KICAqIEBwYXJhbSB7SFRN TE9wdGlvbnNDb2xsZWN0aW9ufSBvcHRpb25zCg==