74189 2011-12-09 10:57:25 -0800 WebKit should ignore images with @alt matching only whitespace 2011-12-09 13:26:02 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 518345 0 cfleizach 2011-12-09 10:57:25 -0800 WebKit should ignore images with @alt matching only whitespace These are caused by <img alt=" "> (whitespace string); I think those should be treated the same way as alt="" (empty string). Ignore them completely. 518346 1 cfleizach 2011-12-09 10:57:53 -0800 rdar://10550385 518348 2 118595 cfleizach 2011-12-09 11:01:42 -0800 Created attachment 118595 patch 518362 3 118595 darin 2011-12-09 11:41:14 -0800 Comment on attachment 118595 patch View in context: https://bugs.webkit.org/attachment.cgi?id=118595&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1900 > + if (!alt.string().stripWhiteSpace().isEmpty()) A better way to write this is: if (!alt.string().containsOnlyWhitespace()) One subtle issue is that the containsOnlyWhitespace function uses the isASCIISpace definition of whitespace, not the HTML space definition, and there are some almost certainly irrelevant subtle differences between the two. 518450 4 cfleizach 2011-12-09 13:26:02 -0800 http://trac.webkit.org/changeset/102470 118595 2011-12-09 11:01:42 -0800 2011-12-09 11:41:14 -0800 patch patch.txt text/plain 4146 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjQ1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0IHNob3VsZCBp Z25vcmUgaW1hZ2VzIHdpdGggQGFsdCBtYXRjaGluZyBvbmx5IHdoaXRlc3BhY2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTg5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0 eS9pbWctYWx0LXRhZy1vbmx5LXdoaXRlc3BhY2UuaHRtbAorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQpOgorCiAyMDEx LTEyLTA4ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAK ICAgICAgICAgSW5zcGVjdG9yOiBEb24ndCB0cmFuc2xhdGUgdGhlIGNvbnRleHQgd2hlbiByZW5k ZXJpbmcgdGhlIGhpZ2hsaWdodHMgb24gYSB0aWxlZCBsYXllci4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAkocmV2aXNpb24gMTAyNDU4KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg5Nyw3 ICsxODk3LDcgQEAKICAgICAgICAgICAgIEVsZW1lbnQqIGVsdCA9IHN0YXRpY19jYXN0PEVsZW1l bnQqPihub2RlKTsKICAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYWx0ID0gZWx0LT5n ZXRBdHRyaWJ1dGUoYWx0QXR0cik7CiAgICAgICAgICAgICAvLyBkb24ndCBpZ25vcmUgYW4gaW1h Z2UgdGhhdCBoYXMgYW4gYWx0IHRhZwotICAgICAgICAgICAgaWYgKCFhbHQuaXNFbXB0eSgpKQor ICAgICAgICAgICAgaWYgKCFhbHQuc3RyaW5nKCkuc3RyaXBXaGl0ZVNwYWNlKCkuaXNFbXB0eSgp KQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIC8vIGluZm9ybWFs IHN0YW5kYXJkIGlzIHRvIGlnbm9yZSBpbWFnZXMgd2l0aCB6ZXJvLWxlbmd0aCBhbHQgc3RyaW5n cwogICAgICAgICAgICAgaWYgKCFhbHQuaXNOdWxsKCkpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDI0 NTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMS0xMi0wOSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgor CisgICAgICAgIFdlYktpdCBzaG91bGQgaWdub3JlIGltYWdlcyB3aXRoIEBhbHQgbWF0Y2hpbmcg b25seSB3aGl0ZXNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9pbWctYWx0LXRhZy1vbmx5LXdoaXRlc3BhY2UuaHRtbDog QWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvaW1nLWFsdC10YWct b25seS13aGl0ZXNwYWNlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEtMTItMDkgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVwZGF0ZSB0 ZXN0X2V4cGVjdGF0aW9ucy50eHQgdG8gbWF0Y2ggdGhlIGJvdHMuCkluZGV4OiBMYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L2ltZy1hbHQtdGFnLW9ubHktd2hpdGVzcGFjZS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvaW1nLWFsdC10YWctb25seS13aGl0ZXNw YWNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2ltZy1h bHQtdGFnLW9ubHktd2hpdGVzcGFjZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMzIEBA Cis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiB0YWJpbmRleD0i MCIgcm9sZT0iZ3JvdXAiIGlkPSJpbWFnZXMiPgorPGltZyBpZD0iZmlyc3RpbWFnZSIgYWx0PSIg IiBzcmM9InJlc291cmNlcy9jYWtlLnBuZyI+PGJyPgorPGltZyBhbHQ9IgkiIHNyYz0icmVzb3Vy Y2VzL2Nha2UucG5nIj48YnI+Cis8aW1nIGFsdD0iICAgSW1hZ2UgIiBzcmM9InJlc291cmNlcy9j YWtlLnBuZyI+PGJyPgorPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBp ZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0cyB0aGF0IGltYWdlcyB3aXRoIGFsdCB0YWdzIHRoYXQgb25seSBoYXZlIHdoaXRlIHNwYWNl IGFyZSBpZ25vcmVkLiIpOworCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxl cikgeworCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbWFnZXMiKS5mb2N1cygp OworICAgICAgICB2YXIgaW1hZ2VzR3JvdXAgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1 c2VkRWxlbWVudDsKKyAgICAgICAgc2hvdWxkQmUoImltYWdlc0dyb3VwLmNoaWxkcmVuQ291bnQi LCAiMSIpOworICAgICAgICBjb25zb2xlLmxvZygiSW1hZ2UgZGVzY3JpcHRpb246ICIgKyBpbWFn ZXNHcm91cC5jaGlsZEF0SW5kZXgoMCkuZGVzY3JpcHRpb24pOworICAgIH0KKworPC9zY3JpcHQ+ CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvaW1nLWFsdC10YWctb25seS13aGl0ZXNwYWNlLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9pbWct YWx0LXRhZy1vbmx5LXdoaXRlc3BhY2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvaW1nLWFsdC10YWctb25seS13aGl0 ZXNwYWNlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNCBAQAorQ09OU09M RSBNRVNTQUdFOiBsaW5lIDI2OiBJbWFnZSBkZXNjcmlwdGlvbjogQVhEZXNjcmlwdGlvbjogICAg SW1hZ2UgCisKKworCitUaGlzIHRlc3RzIHRoYXQgaW1hZ2VzIHdpdGggYWx0IHRhZ3MgdGhhdCBv bmx5IGhhdmUgd2hpdGUgc3BhY2UgYXJlIGlnbm9yZWQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGltYWdlc0dyb3VwLmNoaWxkcmVuQ291bnQgaXMgMQorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK