74177 2011-12-09 05:38:45 -0800 [qt][wk2] Postpone scroll effects when page transition is ongoing. 2011-12-12 09:41:01 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 michael.bruning michael.bruning kenneth laszlo.gombos webkit.review.bot zoltan oldest_to_newest 518222 0 michael.bruning 2011-12-09 05:38:45 -0800 Currently, scroll requests are applied immediately even if the view is transitioning to a new page. 518230 1 118566 michael.bruning 2011-12-09 06:12:06 -0800 Created attachment 118566 Patch. 519270 2 118566 kenneth 2011-12-12 09:26:39 -0800 Comment on attachment 118566 Patch. Great :-) looks like 100% like what I had in mind (or in local diff). We need to start to find ways to fix this soon, I already discussed that a bit with alex 519273 3 kenneth 2011-12-12 09:27:37 -0800 could you file a bug about this with regard to reload? ie, it should start the reload immediately but only change the contents when scrolling is done (and end up at the end scroll position) 519282 4 118566 webkit.review.bot 2011-12-12 09:40:57 -0800 Comment on attachment 118566 Patch. Clearing flags on attachment: 118566 Committed r102593: <http://trac.webkit.org/changeset/102593> 519283 5 webkit.review.bot 2011-12-12 09:41:01 -0800 All reviewed patches have been landed. Closing bug. 118566 2011-12-09 06:12:06 -0800 2011-12-12 09:40:57 -0800 Patch. 0001-qt-wk2-Postpone-scroll-effects-when-page-transition-.patch text/plain 3272 michael.bruning RnJvbSA4YWNmYzk3Y2YwZmU0MTgzOWRkOGIxNDc1OWZlZGQ0NDY3YWI4ZGViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJydW5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tp YS5jb20+CkRhdGU6IEZyaSwgOSBEZWMgMjAxMSAxNDo0MToxNyArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFtxdF1bd2syXSBQb3N0cG9uZSBzY3JvbGwgZWZmZWN0cyB3aGVuIHBhZ2UgdHJhbnNpdGlv biBpcyBvbmdvaW5nLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0 MTc3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClNvdXJjZS9XZWJLaXQyOgoqIFVJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CihRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6c2Ny b2xsUG9zaXRpb25SZXF1ZXN0ZWQpOgoqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19w X3AuaDoKKFFRdWlja1dlYlZpZXdQcml2YXRlOjpQb3N0VHJhbnNpdGlvblN0YXRlOjphcHBseSk6 Ci0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDEyICsrKysrKysrKysrKwogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVp Y2t3ZWJ2aWV3LmNwcCAgfCAgIDExICsrKysrKysrKy0tCiAuLi4vV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmggICB8ICAgIDMgKysrCiAzIGZpbGVzIGNoYW5nZWQs IDI0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDk3MTZiNWUu LjIyNmZhYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0xMi0wOSAgTWljaGFl bCBCcnVuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KKworICAgICAgICBbcXRdW3dr Ml0gUG9zdHBvbmUgc2Nyb2xsIGVmZmVjdHMgd2hlbiBwYWdlIHRyYW5zaXRpb24gaXMgb25nb2lu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTc3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1By aXZhdGU6OnNjcm9sbFBvc2l0aW9uUmVxdWVzdGVkKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6 UG9zdFRyYW5zaXRpb25TdGF0ZTo6YXBwbHkpOgorCiAyMDExLTEyLTA5ICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBjb21waWxh dGlvbiB3aXRoIG5ld2x5IHNlcGFyYXRlZCBRdCA1IFF0UXVpY2sgbW9kdWxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCAzMDg2 MDQyLi43Y2VlYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlldy5jcHAKQEAgLTE5Miw4ICsxOTIsMTUgQEAgdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6ZGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVzKGNvbnN0IFdlYkNvcmU6OlZpZXdw b3J0QXIKIAogdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6c2Nyb2xsUG9zaXRpb25SZXF1ZXN0 ZWQoY29uc3QgUVBvaW50JiBwb3MpCiB7Ci0gICAgaWYgKCF1c2VUcmFkaXRpb25hbERlc2t0b3BC ZWhhdmlvdXIpCi0gICAgICAgIGludGVyYWN0aW9uRW5naW5lLT5wYWdlUG9zaXRpb25SZXF1ZXN0 KHBvcyk7CisgICAgaWYgKHVzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW91cikKKyAgICAgICAg cmV0dXJuOworCisgICAgaWYgKGlzVHJhbnNpdGlvbmluZ1RvTmV3UGFnZSkgeworICAgICAgICBw b3N0VHJhbnNpdGlvblN0YXRlLT5wb3NpdGlvbiA9IHBvczsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKworICAgIGludGVyYWN0aW9uRW5naW5lLT5wYWdlUG9zaXRpb25SZXF1ZXN0KHBvcyk7CiB9 CiAKIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6OnVwZGF0ZVZpc2libGVDb250ZW50UmVjdCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZp ZXdfcF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cF9wLmgKaW5kZXggNjM0ZTgwMi4uYmYzZGE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaApAQCAtOTYsMTcgKzk2LDIwIEBA IHByaXZhdGU6CiAgICAgICAgIHsKICAgICAgICAgICAgIHAtPmludGVyYWN0aW9uRW5naW5lLT5y ZXNldCgpOwogICAgICAgICAgICAgcC0+aW50ZXJhY3Rpb25FbmdpbmUtPmFwcGx5Q29uc3RyYWlu dHMocC0+Y29tcHV0ZVZpZXdwb3J0Q29uc3RyYWludHMoKSk7CisgICAgICAgICAgICBwLT5pbnRl cmFjdGlvbkVuZ2luZS0+cGFnZVBvc2l0aW9uUmVxdWVzdChwb3NpdGlvbik7CiAKICAgICAgICAg ICAgIGlmIChjb250ZW50c1NpemUuaXNWYWxpZCgpKSB7CiAgICAgICAgICAgICAgICAgcC0+cGFn ZVZpZXctPnNldFdpZHRoKGNvbnRlbnRzU2l6ZS53aWR0aCgpKTsKICAgICAgICAgICAgICAgICBw LT5wYWdlVmlldy0+c2V0SGVpZ2h0KGNvbnRlbnRzU2l6ZS5oZWlnaHQoKSk7CiAgICAgICAgICAg ICB9CiAKKyAgICAgICAgICAgIHBvc2l0aW9uID0gUVBvaW50KCk7CiAgICAgICAgICAgICBjb250 ZW50c1NpemUgPSBRU2l6ZSgpOwogICAgICAgICB9CiAKICAgICAgICAgUVF1aWNrV2ViVmlld1By aXZhdGUqIHA7CiAgICAgICAgIFFTaXplIGNvbnRlbnRzU2l6ZTsKKyAgICAgICAgUVBvaW50IHBv c2l0aW9uOwogICAgIH07CiAKICAgICB2b2lkIHNldFZpZXdJbkF0dGFjaGVkUHJvcGVydGllcyhR T2JqZWN0Kik7Ci0tIAoxLjcuNC4xCgo=