74173 2011-12-09 02:13:34 -0800 [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method 2011-12-09 15:27:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73531 1 haraken haraken aroben ddkilzer rniwa webkit.review.bot oldest_to_newest 518191 0 haraken 2011-12-09 02:13:34 -0800 The objective is to make prepare-ChangeLog a loadable Perl module for unit testing. This requires to remove top-level code. We need some incremental refactoring for that. 518192 1 rniwa 2011-12-09 02:18:28 -0800 Maybe you should give it a more descriptive bug name instead of numbering them sequentially. 518195 2 118550 haraken 2011-12-09 02:23:54 -0800 Created attachment 118550 Patch 518581 3 118550 webkit.review.bot 2011-12-09 15:27:04 -0800 Comment on attachment 118550 Patch Clearing flags on attachment: 118550 Committed r102481: <http://trac.webkit.org/changeset/102481> 518582 4 webkit.review.bot 2011-12-09 15:27:10 -0800 All reviewed patches have been landed. Closing bug. 118550 2011-12-09 02:23:54 -0800 2011-12-09 15:27:04 -0800 Patch bug-74173-20111209192353.patch text/plain 4897 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjNiYTZkZTA5NjM2ZjQ5YjMwMGJmMjVhMDczNGFjMzlh OWQzYjc1Zi4uNDFiNTk5N2YyZDE3ZWM1YmQzNzc1N2VkYzdlOGYyNTJkY2Y3MDU1MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDExLTEyLTA5ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbUmVmYWN0b3JpbmddIEluIHByZXBhcmUtQ2hhbmdlTG9nLCBtb3ZlIHRvcC1sZXZl bCBjb2RlIHRvIGZldGNoIGEgYnVnIGRlc2NyaXB0aW9uIGZyb20gVVJMIGludG8gYSBtZXRob2QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTczCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9iamVj dGl2ZSBpcyB0byBtYWtlIHByZXBhcmUtQ2hhbmdlTG9nIGEgbG9hZGFibGUgUGVybCBtb2R1bGUg Zm9yIHVuaXQgdGVzdGluZy4KKyAgICAgICAgVGhpcyByZXF1aXJlcyB0byByZW1vdmUgdG9wLWxl dmVsIGNvZGUuIFRoaXMgcGF0Y2ggaXMgb25lIG9mIHRoZSBpbmNyZW1lbnRhbCByZWZhY3Rvcmlu Z3MKKyAgICAgICAgZm9yIHRoYXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdl TG9nOiBNb3ZlZCB0b3AtbGV2ZWwgY29kZSB0byBmZXRjaCBhIGJ1ZyBkZXNjcmlwdGlvbiBmcm9t IFVSTCBpbnRvIGZldGNoQnVnRGVzY3JpcHRpb25Gcm9tVVJMKCkuCisgICAgICAgIChmZXRjaEJ1 Z0Rlc2NyaXB0aW9uRnJvbVVSTCk6CisKIDIwMTEtMTItMDggIEFkYW0gS2xlaW4gIDxhZGFta0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBWOExhenlFdmVudEhh bmRsZXIgYnJlYWtzIG1pY3JvdGFzayBkZWxpdmVyeSBzZW1hbnRpY3MKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hh bmdlTG9nCmluZGV4IDJlMjdkYzM3YWE2ODY2YzdkMTc4MGJmNWI1ZmY3YTVkMTk5OGU0MzMuLjI4 OGVhYTA3ZGZlZjVlN2JhNGJkMGExYWJjNjZjZmVlMTY4NWNmYzkgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNo YW5nZUxvZwpAQCAtNjcsNiArNjcsNyBAQCB1c2UgVkNTVXRpbHM7CiBzdWIgY2hhbmdlTG9nRGF0 ZSgkKTsKIHN1YiBjaGFuZ2VMb2dFbWFpbEFkZHJlc3NGcm9tQXJncygkKTsKIHN1YiBjaGFuZ2VM b2dOYW1lRnJvbUFyZ3MoJCk7CitzdWIgZmV0Y2hCdWdEZXNjcmlwdGlvbkZyb21VUkwoJCk7CiBz dWIgZmlyc3REaXJlY3RvcnlPckN3ZCgpOwogc3ViIGRpZmZGcm9tVG9TdHJpbmcoKTsKIHN1YiBk aWZmQ29tbWFuZChAKTsKQEAgLTI1NiwzNyArMjU3LDE4IEBAICRlbWFpbEFkZHJlc3MgPSBjaGFu Z2VMb2dFbWFpbEFkZHJlc3NGcm9tQXJncygkZW1haWxBZGRyZXNzKTsKIAogcHJpbnQgU1RERVJS ICIgIENoYW5nZSBhdXRob3I6ICRuYW1lIDwkZW1haWxBZGRyZXNzPi5cbiI7CiAKKyMgUmVtb3Zl IHRyYWlsaW5nIHBhcmVudGhlc2l6ZWQgbm90ZXMgZnJvbSB1c2VyIG5hbWUgKGJpdCBvZiBoYWNr KS4KKyRuYW1lID1+IHMvXCguKj9cKVxzKiQvL2c7CisKIG15ICRidWdVUkw7CiBpZiAoJGJ1Z051 bWJlcikgewogICAgICRidWdVUkwgPSAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPSRidWdOdW1iZXIiOwogfQogCiBpZiAoJGJ1Z051bWJlciAmJiAhJGJ1Z0Rlc2NyaXB0 aW9uKSB7Ci0gICAgbXkgJGJ1Z1hNTFVSTCA9ICIkYnVnVVJMJmN0eXBlPXhtbCI7Ci0gICAgIyBQ ZXJsIGhhcyBubyBidWlsdCBpbiBYTUwgcHJvY2Vzc2luZywgc28gd2UnbGwgZmV0Y2ggYW5kIHBh cnNlIHdpdGggY3VybCBhbmQgZ3JlcAotICAgICMgUGFzcyAtLWluc2VjdXJlIGJlY2F1c2Ugc29t ZSBjeWd3aW4gaW5zdGFsbHMgaGF2ZSBubyBjZXJ0cyB3ZSBkb24ndAotICAgICMgY2FyZSBhYm91 dCB2YWxpZGF0aW5nIHRoYXQgYnVncy53ZWJraXQub3JnIGlzIHdobyBpdCBzYXlzIGl0IGlzIGhl cmUuCi0gICAgbXkgJGRlc2NyaXB0aW9uTGluZSA9IGBjdXJsIC0taW5zZWN1cmUgLS1zaWxlbnQg IiRidWdYTUxVUkwiIHwgZ3JlcCBzaG9ydF9kZXNjYDsKLSAgICBpZiAoJGRlc2NyaXB0aW9uTGlu ZSAhfiAvPHNob3J0X2Rlc2M+KC4qKTxcL3Nob3J0X2Rlc2M+LykgewotICAgICAgICAjIE1heWJl IHRoZSByZWFzb24gdGhlIGFib3ZlIGRpZCBub3Qgd29yayBpcyBiZWNhdXNlIHRoZSBjdXJsIHRo YXQgaXMgaW5zdGFsbGVkIGRvZXNuJ3QKLSAgICAgICAgIyBzdXBwb3J0IHNzbCBhdCBhbGwuCi0g ICAgICAgIGlmIChgY3VybCAtLXZlcnNpb24gfCBncmVwIF5Qcm90b2NvbHNgICF+IC9cYmh0dHBz XGIvKSB7Ci0gICAgICAgICAgICBwcmludCBTVERFUlIgIiAgQ291bGQgbm90IGdldCBkZXNjcmlw dGlvbiBmb3IgYnVnICRidWdOdW1iZXIuXG4iOwotICAgICAgICAgICAgcHJpbnQgU1RERVJSICIg IEl0IGxvb2tzIGxpa2UgeW91ciB2ZXJzaW9uIG9mIGN1cmwgZG9lcyBub3Qgc3VwcG9ydCBzc2wu XG4iOwotICAgICAgICAgICAgcHJpbnQgU1RERVJSICIgIElmIHlvdSBhcmUgdXNpbmcgbWFjcG9y dHMsIHRoaXMgY2FuIGJlIGZpeGVkIHdpdGggc3VkbyBwb3J0IGluc3RhbGwgY3VybCArc3NsLlxu IjsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHByaW50IFNUREVSUiAiICBCdWcgJGJ1 Z051bWJlciBoYXMgbm8gYnVnIGRlc2NyaXB0aW9uLiBNYXliZSB5b3Ugc2V0IHdyb25nIGJ1ZyBJ RD9cbiI7Ci0gICAgICAgICAgICBwcmludCBTVERFUlIgIiAgVGhlIGJ1ZyBVUkw6ICRidWdYTUxV UkxcbiI7Ci0gICAgICAgIH0KLSAgICAgICAgZXhpdCAxOwotICAgIH0KLSAgICAkYnVnRGVzY3Jp cHRpb24gPSBkZWNvZGVFbnRpdGllcygkMSk7Ci0gICAgcHJpbnQgU1RERVJSICIgIERlc2NyaXB0 aW9uIGZyb20gYnVnICRidWdOdW1iZXI6XG4gICAgXCIkYnVnRGVzY3JpcHRpb25cIi5cbiI7Cisg ICAgJGJ1Z0Rlc2NyaXB0aW9uID0gZmV0Y2hCdWdEZXNjcmlwdGlvbkZyb21VUkwoJGJ1Z1VSTCk7 CiB9CiAKLSMgUmVtb3ZlIHRyYWlsaW5nIHBhcmVudGhlc2l6ZWQgbm90ZXMgZnJvbSB1c2VyIG5h bWUgKGJpdCBvZiBoYWNrKS4KLSRuYW1lID1+IHMvXCguKj9cKVxzKiQvL2c7Ci0KICMgRmluZCB0 aGUgY2hhbmdlIGxvZ3MuCiBteSAlaGFzX2xvZzsKIG15ICVmaWxlczsKQEAgLTQ4OCw2ICs0NzAs MzMgQEAgc3ViIGNoYW5nZUxvZ0VtYWlsQWRkcmVzc0Zyb21BcmdzKCQpCiAgICAgcmV0dXJuICRl bWFpbEFkZHJlc3NGcm9tQXJncyB8fCBjaGFuZ2VMb2dFbWFpbEFkZHJlc3MoKTsKIH0KIAorc3Vi IGZldGNoQnVnRGVzY3JpcHRpb25Gcm9tVVJMKCQpCit7CisgICAgbXkgKCRidWdVUkwpID0gQF87 CisKKyAgICBteSAkYnVnWE1MVVJMID0gIiRidWdVUkwmY3R5cGU9eG1sIjsKKyAgICAjIFBlcmwg aGFzIG5vIGJ1aWx0IGluIFhNTCBwcm9jZXNzaW5nLCBzbyB3ZSdsbCBmZXRjaCBhbmQgcGFyc2Ug d2l0aCBjdXJsIGFuZCBncmVwCisgICAgIyBQYXNzIC0taW5zZWN1cmUgYmVjYXVzZSBzb21lIGN5 Z3dpbiBpbnN0YWxscyBoYXZlIG5vIGNlcnRzIHdlIGRvbid0CisgICAgIyBjYXJlIGFib3V0IHZh bGlkYXRpbmcgdGhhdCBidWdzLndlYmtpdC5vcmcgaXMgd2hvIGl0IHNheXMgaXQgaXMgaGVyZS4K KyAgICBteSAkZGVzY3JpcHRpb25MaW5lID0gYGN1cmwgLS1pbnNlY3VyZSAtLXNpbGVudCAiJGJ1 Z1hNTFVSTCIgfCBncmVwIHNob3J0X2Rlc2NgOworICAgIGlmICgkZGVzY3JpcHRpb25MaW5lICF+ IC88c2hvcnRfZGVzYz4oLiopPFwvc2hvcnRfZGVzYz4vKSB7CisgICAgICAgICMgTWF5YmUgdGhl IHJlYXNvbiB0aGUgYWJvdmUgZGlkIG5vdCB3b3JrIGlzIGJlY2F1c2UgdGhlIGN1cmwgdGhhdCBp cyBpbnN0YWxsZWQgZG9lc24ndAorICAgICAgICAjIHN1cHBvcnQgc3NsIGF0IGFsbC4KKyAgICAg ICAgaWYgKGBjdXJsIC0tdmVyc2lvbiB8IGdyZXAgXlByb3RvY29sc2AgIX4gL1xiaHR0cHNcYi8p IHsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiICBDb3VsZCBub3QgZ2V0IGRlc2NyaXB0aW9u IGZvciBidWcgJGJ1Z051bWJlci5cbiI7CisgICAgICAgICAgICBwcmludCBTVERFUlIgIiAgSXQg bG9va3MgbGlrZSB5b3VyIHZlcnNpb24gb2YgY3VybCBkb2VzIG5vdCBzdXBwb3J0IHNzbC5cbiI7 CisgICAgICAgICAgICBwcmludCBTVERFUlIgIiAgSWYgeW91IGFyZSB1c2luZyBtYWNwb3J0cywg dGhpcyBjYW4gYmUgZml4ZWQgd2l0aCBzdWRvIHBvcnQgaW5zdGFsbCBjdXJsICtzc2wuXG4iOwor ICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgcHJpbnQgU1RERVJSICIgIEJ1ZyAkYnVnTnVt YmVyIGhhcyBubyBidWcgZGVzY3JpcHRpb24uIE1heWJlIHlvdSBzZXQgd3JvbmcgYnVnIElEP1xu IjsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiICBUaGUgYnVnIFVSTDogJGJ1Z1hNTFVSTFxu IjsKKyAgICAgICAgfQorICAgICAgICBleGl0IDE7CisgICAgfQorICAgIG15ICRidWdEZXNjcmlw dGlvbiA9IGRlY29kZUVudGl0aWVzKCQxKTsKKyAgICBwcmludCBTVERFUlIgIiAgRGVzY3JpcHRp b24gZnJvbSBidWcgJGJ1Z051bWJlcjpcbiAgICBcIiRidWdEZXNjcmlwdGlvblwiLlxuIjsKKyAg ICByZXR1cm4gJGJ1Z0Rlc2NyaXB0aW9uOworfQorCiBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFu Z2VzKCQkKQogewogICAgIG15ICgkZmlsZV9oYW5kbGUsICRmaWxlX25hbWUpID0gQF87Cg==