74149 2011-12-08 17:47:07 -0800 WebScrollbarPainterDelegate should have a pointer to its Scrollbar 2011-12-08 17:54:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 517983 0 andersca 2011-12-08 17:47:07 -0800 WebScrollbarPainterDelegate should have a pointer to its Scrollbar 517986 1 118502 andersca 2011-12-08 17:47:41 -0800 Created attachment 118502 Patch 517987 2 118502 darin 2011-12-08 17:48:49 -0800 Comment on attachment 118502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118502&action=review > Source/WebCore/ChangeLog:3 > + WebScrollbarPainterDelegate should have a pointer to its Scrollbar Why? 517990 3 andersca 2011-12-08 17:52:33 -0800 (In reply to comment #2) > (From update of attachment 118502 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118502&action=review > > > Source/WebCore/ChangeLog:3 > > + WebScrollbarPainterDelegate should have a pointer to its Scrollbar > > Why? It's a step towards simplifying the scroll animator code and making it more robust. 517992 4 andersca 2011-12-08 17:54:14 -0800 Committed r102409: <http://trac.webkit.org/changeset/102409> 118502 2011-12-08 17:47:41 -0800 2011-12-08 17:48:49 -0800 Patch bug-74149-20111208174854.patch text/plain 5960 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI1MmE2MTU1NzJhMjA1 YmQ0NDA3N2IzOTMzYzQ0OThhYzgwYmM5My4uNGFlYjFjNzg1MzE0N2NjOTI1YTU5YzNhMmFiYTYw YWQwNTM5ZjFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDExLTEyLTA4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViU2Nyb2xsYmFy UGFpbnRlckRlbGVnYXRlIHNob3VsZCBoYXZlIGEgcG9pbnRlciB0byBpdHMgU2Nyb2xsYmFyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDE0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAgICAoLVtXZWJTY3JvbGxiYXJQYWludGVy RGVsZWdhdGUgaW5pdFdpdGhTY3JvbGxiYXI6V2ViQ29yZTo6XSk6CisgICAgICAgICgtW1dlYlNj cm9sbGJhclBhaW50ZXJEZWxlZ2F0ZSBzY3JvbGxBbmltYXRvcl0pOgorICAgICAgICAoLVtXZWJT Y3JvbGxiYXJQYWludGVyRGVsZWdhdGUgbGF5ZXJdKToKKyAgICAgICAgKC1bV2ViU2Nyb2xsYmFy UGFpbnRlckRlbGVnYXRlIG1vdXNlTG9jYXRpb25JblNjcm9sbGVyRm9yU2Nyb2xsZXJJbXA6XSk6 CisgICAgICAgICgtW1dlYlNjcm9sbGJhclBhaW50ZXJEZWxlZ2F0ZSBzY3JvbGxlckltcDphbmlt YXRlS25vYkFscGhhVG86ZHVyYXRpb246XSk6CisgICAgICAgICgtW1dlYlNjcm9sbGJhclBhaW50 ZXJEZWxlZ2F0ZSBzY3JvbGxlckltcDphbmltYXRlVHJhY2tBbHBoYVRvOmR1cmF0aW9uOl0pOgor ICAgICAgICAoLVtXZWJTY3JvbGxiYXJQYWludGVyRGVsZWdhdGUgc2Nyb2xsZXJJbXA6YW5pbWF0 ZVVJU3RhdGVUcmFuc2l0aW9uV2l0aER1cmF0aW9uOl0pOgorICAgICAgICAoLVtXZWJTY3JvbGxi YXJQYWludGVyRGVsZWdhdGUgc2Nyb2xsQW5pbWF0b3JEZXN0cm95ZWRdKToKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFjOjpkaWRBZGRWZXJ0aWNhbFNjcm9sbGJhcik6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvck1hYzo6ZGlkQWRkSG9yaXpvbnRhbFNjcm9sbGJh cik6CisKKzIwMTEtMTItMDggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K KwogICAgICAgICBBZGQgc2Nyb2xsQW5pbWF0b3IgZ2V0dGVyIG1ldGhvZCB0byBXZWJTY3JvbGxi YXJQYWludGVyRGVsZWdhdGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc0MTQ2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9TY3JvbGxBbmltYXRvck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3Jv bGxBbmltYXRvck1hYy5tbQppbmRleCAxYjA0YWVjZmI3NzVhMWU3Y2MzMjFhMTlhOTgxMGU4OTJm ODUyYmY3Li4yMzEyNDgzOGUyMWFkNzc4MDQwMTIzNzNlODE0OGM0YzA3NmYyMzcxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCkBAIC0z NTksNyArMzU5LDcgQEAgZW51bSBGZWF0dXJlVG9BbmltYXRlIHsKIAogQGludGVyZmFjZSBXZWJT Y3JvbGxiYXJQYWludGVyRGVsZWdhdGUgOiBOU09iamVjdDxOU0FuaW1hdGlvbkRlbGVnYXRlPgog ewotICAgIFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFjKiBfYW5pbWF0b3I7CisgICAgV2ViQ29y ZTo6U2Nyb2xsYmFyKiBfc2Nyb2xsYmFyOwogCiAgICAgUmV0YWluUHRyPFdlYlNjcm9sbGJhclBh cnRBbmltYXRpb24+IF92ZXJ0aWNhbEtub2JBbmltYXRpb247CiAgICAgUmV0YWluUHRyPFdlYlNj cm9sbGJhclBhcnRBbmltYXRpb24+IF9ob3Jpem9udGFsS25vYkFuaW1hdGlvbjsKQEAgLTM3MCwx OSArMzcwLDE5IEBAIGVudW0gRmVhdHVyZVRvQW5pbWF0ZSB7CiAgICAgUmV0YWluUHRyPFdlYlNj cm9sbGJhclBhcnRBbmltYXRpb24+IF92ZXJ0aWNhbFVJU3RhdGVUcmFuc2l0aW9uQW5pbWF0aW9u OwogICAgIFJldGFpblB0cjxXZWJTY3JvbGxiYXJQYXJ0QW5pbWF0aW9uPiBfaG9yaXpvbnRhbFVJ U3RhdGVUcmFuc2l0aW9uQW5pbWF0aW9uOwogfQotLSAoaWQpaW5pdFdpdGhTY3JvbGxBbmltYXRv cjooV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JNYWMqKXNjcm9sbEFuaW1hdG9yOworLSAoaWQpaW5p dFdpdGhTY3JvbGxiYXI6KFdlYkNvcmU6OlNjcm9sbGJhciopc2Nyb2xsYmFyOwogLSAodm9pZClj YW5jZWxBbmltYXRpb25zOwogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViU2Nyb2xsYmFyUGFp bnRlckRlbGVnYXRlCiAKLS0gKGlkKWluaXRXaXRoU2Nyb2xsQW5pbWF0b3I6KFdlYkNvcmU6OlNj cm9sbEFuaW1hdG9yTWFjKilzY3JvbGxBbmltYXRvcgorLSAoaWQpaW5pdFdpdGhTY3JvbGxiYXI6 KFdlYkNvcmU6OlNjcm9sbGJhciopc2Nyb2xsYmFyCiB7CiAgICAgc2VsZiA9IFtzdXBlciBpbml0 XTsKICAgICBpZiAoIXNlbGYpCiAgICAgICAgIHJldHVybiBuaWw7CiAgICAgCi0gICAgX2FuaW1h dG9yID0gc2Nyb2xsQW5pbWF0b3I7CisgICAgX3Njcm9sbGJhciA9IHNjcm9sbGJhcjsKICAgICBy ZXR1cm4gc2VsZjsKIH0KIApAQCAtNDAwLDcgKzQwMCw3IEBAIGVudW0gRmVhdHVyZVRvQW5pbWF0 ZSB7CiAKIC0gKFNjcm9sbEFuaW1hdG9yTWFjKilzY3JvbGxBbmltYXRvcgogewotICAgIHJldHVy biBfYW5pbWF0b3I7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PFNjcm9sbEFuaW1hdG9yTWFjKj4o X3Njcm9sbGJhci0+c2Nyb2xsYWJsZUFyZWEoKS0+c2Nyb2xsQW5pbWF0b3IoKSk7CiB9CiAKIC0g KE5TUmVjdCljb252ZXJ0UmVjdFRvQmFja2luZzooTlNSZWN0KWFSZWN0CkBAIC00MTUsMTEgKzQx NSwxMCBAQCBlbnVtIEZlYXR1cmVUb0FuaW1hdGUgewogCiAtIChDQUxheWVyICopbGF5ZXIKIHsK LSAgICBTY3JvbGxBbmltYXRvck1hYyogYW5pbWF0b3IgPSBbc2VsZiBzY3JvbGxBbmltYXRvcl07 Ci0gICAgaWYgKCFhbmltYXRvcikKKyAgICBpZiAoIV9zY3JvbGxiYXIpCiAgICAgICAgIHJldHVy biBuaWw7CiAKLSAgICBpZiAoIWFuaW1hdG9yLT5pc0RyYXdpbmdJbnRvTGF5ZXIoKSkKKyAgICBp ZiAoIVtzZWxmIHNjcm9sbEFuaW1hdG9yXS0+aXNEcmF3aW5nSW50b0xheWVyKCkpCiAgICAgICAg IHJldHVybiBuaWw7CiAKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYXR0ZW1wdCB0byByZXR1 cm4gYW4gYWN0dWFsIGxheWVyLgpAQCAtNDI5LDcgKzQyOCw3IEBAIGVudW0gRmVhdHVyZVRvQW5p bWF0ZSB7CiAKIC0gKE5TUG9pbnQpbW91c2VMb2NhdGlvbkluU2Nyb2xsZXJGb3JTY3JvbGxlcklt cDooaWQpc2Nyb2xsZXJJbXAKIHsKLSAgICBpZiAoIVtzZWxmIHNjcm9sbEFuaW1hdG9yXSkKKyAg ICBpZiAoIV9zY3JvbGxiYXIpCiAgICAgICAgIHJldHVybiBOU1plcm9Qb2ludDsKIAogICAgIFNj cm9sbGJhclBhaW50ZXIgc2Nyb2xsZXJQYWludGVyID0gKFNjcm9sbGJhclBhaW50ZXIpc2Nyb2xs ZXJJbXA7CkBAIC00OTEsNyArNDkwLDcgQEAgZW51bSBGZWF0dXJlVG9BbmltYXRlIHsKIAogLSAo dm9pZClzY3JvbGxlckltcDooaWQpc2Nyb2xsZXJJbXAgYW5pbWF0ZUtub2JBbHBoYVRvOihDR0Zs b2F0KW5ld0tub2JBbHBoYSBkdXJhdGlvbjooTlNUaW1lSW50ZXJ2YWwpZHVyYXRpb24KIHsKLSAg ICBpZiAoIVtzZWxmIHNjcm9sbEFuaW1hdG9yXSkKKyAgICBpZiAoIV9zY3JvbGxiYXIpCiAgICAg ICAgIHJldHVybjsKIAogICAgIFNjcm9sbGJhclBhaW50ZXIgc2Nyb2xsZXJQYWludGVyID0gKFNj cm9sbGJhclBhaW50ZXIpc2Nyb2xsZXJJbXA7CkBAIC01MDMsNyArNTAyLDcgQEAgZW51bSBGZWF0 dXJlVG9BbmltYXRlIHsKIAogLSAodm9pZClzY3JvbGxlckltcDooaWQpc2Nyb2xsZXJJbXAgYW5p bWF0ZVRyYWNrQWxwaGFUbzooQ0dGbG9hdCluZXdUcmFja0FscGhhIGR1cmF0aW9uOihOU1RpbWVJ bnRlcnZhbClkdXJhdGlvbgogewotICAgIGlmICghW3NlbGYgc2Nyb2xsQW5pbWF0b3JdKQorICAg IGlmICghX3Njcm9sbGJhcikKICAgICAgICAgcmV0dXJuOwogCiAgICAgU2Nyb2xsYmFyUGFpbnRl ciBzY3JvbGxlclBhaW50ZXIgPSAoU2Nyb2xsYmFyUGFpbnRlcilzY3JvbGxlckltcDsKQEAgLTUx NSw3ICs1MTQsNyBAQCBlbnVtIEZlYXR1cmVUb0FuaW1hdGUgewogCiAtICh2b2lkKXNjcm9sbGVy SW1wOihpZClzY3JvbGxlckltcCBhbmltYXRlVUlTdGF0ZVRyYW5zaXRpb25XaXRoRHVyYXRpb246 KE5TVGltZUludGVydmFsKWR1cmF0aW9uCiB7Ci0gICAgaWYgKCFbc2VsZiBzY3JvbGxBbmltYXRv cl0pCisgICAgaWYgKCFfc2Nyb2xsYmFyKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoIXN1 cHBvcnRzVUlTdGF0ZVRyYW5zaXRpb25Qcm9ncmVzcygpKQpAQCAtNTU2LDcgKzU1NSw3IEBAIGVu dW0gRmVhdHVyZVRvQW5pbWF0ZSB7CiAKIC0gKHZvaWQpc2Nyb2xsQW5pbWF0b3JEZXN0cm95ZWQK IHsKLSAgICBfYW5pbWF0b3IgPSAwOworICAgIF9zY3JvbGxiYXIgPSAwOwogICAgIEJFR0lOX0JM T0NLX09CSkNfRVhDRVBUSU9OUzsKICAgICBbX3ZlcnRpY2FsS25vYkFuaW1hdGlvbi5nZXQoKSBz Y3JvbGxBbmltYXRvckRlc3Ryb3llZF07CiAgICAgW19ob3Jpem9udGFsS25vYkFuaW1hdGlvbi5n ZXQoKSBzY3JvbGxBbmltYXRvckRlc3Ryb3llZF07CkBAIC04NjksNyArODY4LDcgQEAgdm9pZCBT Y3JvbGxBbmltYXRvck1hYzo6ZGlkQWRkVmVydGljYWxTY3JvbGxiYXIoU2Nyb2xsYmFyKiBzY3Jv bGxiYXIpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVCghbV92ZXJ0aWNhbFNjcm9sbGJh clBhaW50ZXJEZWxlZ2F0ZSk7Ci0gICAgbV92ZXJ0aWNhbFNjcm9sbGJhclBhaW50ZXJEZWxlZ2F0 ZS5hZG9wdE5TKFtbV2ViU2Nyb2xsYmFyUGFpbnRlckRlbGVnYXRlIGFsbG9jXSBpbml0V2l0aFNj cm9sbEFuaW1hdG9yOnRoaXNdKTsKKyAgICBtX3ZlcnRpY2FsU2Nyb2xsYmFyUGFpbnRlckRlbGVn YXRlLmFkb3B0TlMoW1tXZWJTY3JvbGxiYXJQYWludGVyRGVsZWdhdGUgYWxsb2NdIGluaXRXaXRo U2Nyb2xsYmFyOnNjcm9sbGJhcl0pOwogCiAgICAgW3BhaW50ZXIgc2V0RGVsZWdhdGU6bV92ZXJ0 aWNhbFNjcm9sbGJhclBhaW50ZXJEZWxlZ2F0ZS5nZXQoKV07CiAgICAgW21fc2Nyb2xsYmFyUGFp bnRlckNvbnRyb2xsZXIuZ2V0KCkgc2V0VmVydGljYWxTY3JvbGxlckltcDpwYWludGVyXTsKQEAg LTkwNyw3ICs5MDYsNyBAQCB2b2lkIFNjcm9sbEFuaW1hdG9yTWFjOjpkaWRBZGRIb3Jpem9udGFs U2Nyb2xsYmFyKFNjcm9sbGJhciogc2Nyb2xsYmFyKQogICAgICAgICByZXR1cm47CiAKICAgICBB U1NFUlQoIW1faG9yaXpvbnRhbFNjcm9sbGJhclBhaW50ZXJEZWxlZ2F0ZSk7Ci0gICAgbV9ob3Jp em9udGFsU2Nyb2xsYmFyUGFpbnRlckRlbGVnYXRlLmFkb3B0TlMoW1tXZWJTY3JvbGxiYXJQYWlu dGVyRGVsZWdhdGUgYWxsb2NdIGluaXRXaXRoU2Nyb2xsQW5pbWF0b3I6dGhpc10pOworICAgIG1f aG9yaXpvbnRhbFNjcm9sbGJhclBhaW50ZXJEZWxlZ2F0ZS5hZG9wdE5TKFtbV2ViU2Nyb2xsYmFy UGFpbnRlckRlbGVnYXRlIGFsbG9jXSBpbml0V2l0aFNjcm9sbGJhcjpzY3JvbGxiYXJdKTsKIAog ICAgIFtwYWludGVyIHNldERlbGVnYXRlOm1faG9yaXpvbnRhbFNjcm9sbGJhclBhaW50ZXJEZWxl Z2F0ZS5nZXQoKV07CiAgICAgW21fc2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIuZ2V0KCkgc2V0 SG9yaXpvbnRhbFNjcm9sbGVySW1wOnBhaW50ZXJdOwo=