74140 2011-12-08 17:02:53 -0800 [chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium 2011-12-15 19:44:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr webkit.review.bot oldest_to_newest 517931 0 enne 2011-12-08 17:02:53 -0800 [chromium] Clean up unnecessary leaf functions in GraphicsLayerChromium 517943 1 118496 enne 2011-12-08 17:08:07 -0800 Created attachment 118496 Patch 522324 2 enne 2011-12-15 16:39:49 -0800 jamesr: ping? Can I get a review on this followup to https://bugs.webkit.org/show_bug.cgi?id=73711? 522330 3 118496 jamesr 2011-12-15 16:44:47 -0800 Comment on attachment 118496 Patch Sorry, this slipped through my inbox. Looks great! 522458 4 118496 webkit.review.bot 2011-12-15 19:43:57 -0800 Comment on attachment 118496 Patch Clearing flags on attachment: 118496 Committed r103015: <http://trac.webkit.org/changeset/103015> 522459 5 webkit.review.bot 2011-12-15 19:44:00 -0800 All reviewed patches have been landed. Closing bug. 118496 2011-12-08 17:08:07 -0800 2011-12-15 19:43:56 -0800 Patch bug-74140-20111208170806.patch text/plain 4293 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQxYTExODY2YzgwYjRi NGY1MTdlYTJjNGEzMjA5NmJlYjA5M2I4MC4uODUwZGJhOTkzYTU4MTlmZDYzMmIxOTIwNmM0YThl ZjU0NzEzNjZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTA4ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBDbGVh biB1cCB1bm5lY2Vzc2FyeSBsZWFmIGZ1bmN0aW9ucyBpbiBHcmFwaGljc0xheWVyQ2hyb21pdW0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTQwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdGVkIGJ5 IGV4aXN0aW5nIGNvbXBvc2l0b3IgbGF5b3V0IHRlc3RzLgorCisgICAgICAgIFRoaXMgaXMgYSBm b2xsb3ctb24gY2xlYW51cCB0byByMTAyMTk2LCB3aGljaCBtYWRlIHNvbWUgb2YgdGhlc2UKKyAg ICAgICAgZnVuY3Rpb25zIGxlc3MgdXNlZnVsIHRoYW4gdGhleSBoYWQgYmVlbiBpbiB0aGUgcGFz dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJD aHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2hyb21pdW06OnNl dENvbnRlbnRzT3BhcXVlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDaHJvbWl1 bTo6c2V0QmFja2ZhY2VWaXNpYmlsaXR5KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5 ZXJDaHJvbWl1bTo6dXBkYXRlTGF5ZXJQcmVzZXJ2ZXMzRCk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmg6CisKIDIwMTEtMTItMDgg IFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXNl IFNraWEncyBpbXBsZW1lbnRhdGlvbiBvZiBHYXVzc2lhbiBibHVyIHdoZW4gYWNjZWxlcmF0ZWQg ZmlsdGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggMTNhMzlj ZGFmNjdiMDg4N2RiOWJiMzY4N2JlMWI0YTBhZGMyMDgyMC4uMjI5YmE5ZDgxYjhkMDY3OWIxZmRh NTZhZmUwNTIyZjFmOGRhMjBjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0u Y3BwCkBAIC0yNDIsNyArMjQyLDcgQEAgdm9pZCBHcmFwaGljc0xheWVyQ2hyb21pdW06OmNsZWFy QmFja2dyb3VuZENvbG9yKCkKIHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50 c09wYXF1ZShib29sIG9wYXF1ZSkKIHsKICAgICBHcmFwaGljc0xheWVyOjpzZXRDb250ZW50c09w YXF1ZShvcGFxdWUpOwotICAgIHVwZGF0ZUNvbnRlbnRzT3BhcXVlKCk7CisgICAgbV9sYXllci0+ c2V0T3BhcXVlKG1fY29udGVudHNPcGFxdWUpOwogfQogCiB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJv bWl1bTo6c2V0TWFza0xheWVyKEdyYXBoaWNzTGF5ZXIqIG1hc2tMYXllcikKQEAgLTI2MSw3ICsy NjEsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0TWFza0xheWVyKEdyYXBoaWNz TGF5ZXIqIG1hc2tMYXllcikKIHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRCYWNrZmFj ZVZpc2liaWxpdHkoYm9vbCB2aXNpYmxlKQogewogICAgIEdyYXBoaWNzTGF5ZXI6OnNldEJhY2tm YWNlVmlzaWJpbGl0eSh2aXNpYmxlKTsKLSAgICB1cGRhdGVCYWNrZmFjZVZpc2liaWxpdHkoKTsK KyAgICBtX2xheWVyLT5zZXREb3VibGVTaWRlZChtX2JhY2tmYWNlVmlzaWJpbGl0eSk7CiB9CiAK IHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRPcGFjaXR5KGZsb2F0IG9wYWNpdHkpCkBA IC01MTQsMTYgKzUxNCw2IEBAIHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjp1cGRhdGVNYXNr c1RvQm91bmRzKCkKICAgICB1cGRhdGVEZWJ1Z0luZGljYXRvcnMoKTsKIH0KIAotdm9pZCBHcmFw aGljc0xheWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzT3BhcXVlKCkKLXsKLSAgICBtX2xheWVy LT5zZXRPcGFxdWUobV9jb250ZW50c09wYXF1ZSk7Ci19Ci0KLXZvaWQgR3JhcGhpY3NMYXllckNo cm9taXVtOjp1cGRhdGVCYWNrZmFjZVZpc2liaWxpdHkoKQotewotICAgIG1fbGF5ZXItPnNldERv dWJsZVNpZGVkKG1fYmFja2ZhY2VWaXNpYmlsaXR5KTsKLX0KLQogdm9pZCBHcmFwaGljc0xheWVy Q2hyb21pdW06OnVwZGF0ZUxheWVyUHJlc2VydmVzM0QoKQogewogICAgIGlmIChtX3ByZXNlcnZl czNEICYmICFtX3RyYW5zZm9ybUxheWVyKSB7CkBAIC01NzQsNyArNTY0LDcgQEAgdm9pZCBHcmFw aGljc0xheWVyQ2hyb21pdW06OnVwZGF0ZUxheWVyUHJlc2VydmVzM0QoKQogICAgIH0KIAogICAg IG1fbGF5ZXItPnNldFByZXNlcnZlczNEKG1fcHJlc2VydmVzM0QpOwotICAgIHVwZGF0ZU9wYWNp dHlPbkxheWVyKCk7CisgICAgcHJpbWFyeUxheWVyKCktPnNldE9wYWNpdHkobV9vcGFjaXR5KTsK ICAgICB1cGRhdGVOYW1lcygpOwogfQogCkBAIC02NTgsMTIgKzY0OCw2IEBAIGZsb2F0IEdyYXBo aWNzTGF5ZXJDaHJvbWl1bTo6Y29udGVudHNTY2FsZSgpIGNvbnN0CiAgICAgcmV0dXJuIDE7CiB9 CiAKLS8vIFRoaXMgZnVuY3Rpb24gc2ltcGx5IG1pbWljcyB0aGUgb3BlcmF0aW9uIG9mIEdyYXBo aWNzTGF5ZXJDQQotdm9pZCBHcmFwaGljc0xheWVyQ2hyb21pdW06OnVwZGF0ZU9wYWNpdHlPbkxh eWVyKCkKLXsKLSAgICBwcmltYXJ5TGF5ZXIoKS0+c2V0T3BhY2l0eShtX29wYWNpdHkpOwotfQot CiB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6ZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFu Z2VkKCkKIHsKICAgICB1cGRhdGVDb250ZW50c1NjYWxlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0u aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5 ZXJDaHJvbWl1bS5oCmluZGV4IGRmMjY5OGFiZDkxZTM3NjU2YjEyNDhjN2I4YjQ4MmNjMTQ4Nzc0 ZmIuLjJmYzhlNTI0ODhhY2FjYmQzOWRmODA5ODQ2OGY3Yzk5M2ZjMjY0NTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJD aHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5oCkBAIC0xMDUsOCArMTA1LDYgQEAgcHVibGljOgogICAg IExheWVyQ2hyb21pdW0qIGNvbnRlbnRzTGF5ZXIoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRz TGF5ZXIuZ2V0KCk7IH0KIAogcHJpdmF0ZToKLSAgICB2b2lkIHVwZGF0ZU9wYWNpdHlPbkxheWVy KCk7Ci0KICAgICBMYXllckNocm9taXVtKiBwcmltYXJ5TGF5ZXIoKSBjb25zdCAgeyByZXR1cm4g bV90cmFuc2Zvcm1MYXllci5nZXQoKSA/IG1fdHJhbnNmb3JtTGF5ZXIuZ2V0KCkgOiBtX2xheWVy LmdldCgpOyB9CiAgICAgTGF5ZXJDaHJvbWl1bSogaG9zdExheWVyRm9yQ2hpbGRyZW4oKSBjb25z dDsKICAgICBMYXllckNocm9taXVtKiBsYXllckZvclBhcmVudCgpIGNvbnN0OwpAQCAtMTE5LDgg KzExNyw2IEBAIHByaXZhdGU6CiAgICAgdm9pZCB1cGRhdGVUcmFuc2Zvcm0oKTsKICAgICB2b2lk IHVwZGF0ZUNoaWxkcmVuVHJhbnNmb3JtKCk7CiAgICAgdm9pZCB1cGRhdGVNYXNrc1RvQm91bmRz KCk7Ci0gICAgdm9pZCB1cGRhdGVDb250ZW50c09wYXF1ZSgpOwotICAgIHZvaWQgdXBkYXRlQmFj a2ZhY2VWaXNpYmlsaXR5KCk7CiAgICAgdm9pZCB1cGRhdGVMYXllclByZXNlcnZlczNEKCk7CiAg ICAgdm9pZCB1cGRhdGVMYXllckRyYXdzQ29udGVudCgpOwogICAgIHZvaWQgdXBkYXRlTGF5ZXJC YWNrZ3JvdW5kQ29sb3IoKTsK