74126 2011-12-08 14:18:14 -0800 Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden 2011-12-08 16:15:31 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED HasReduction P1 Normal --- 1 rniwa rniwa darin enrica eric morrita ojan tkent tony oldest_to_newest 517785 0 rniwa 2011-12-08 14:18:14 -0800 Reproduction: <textarea id="test" style="display: none" cols="50" rows="10"></textarea> <script type="text/javascript"> var textarea = document.querySelector('textarea'); textarea.value = "\nwebkit"; textarea.style.display = ""; textarea.focus(); textarea.selectionStart = textarea.selectionEnd = 0; document.execCommand('insertHTML', false, 'hello\nworld\n'); alert(textarea.value); </script> Alert doesn't have any line breaks :( http://crbug.com/104620 517786 1 118468 rniwa 2011-12-08 14:18:59 -0800 Created attachment 118468 demo 517865 2 118481 rniwa 2011-12-08 15:47:17 -0800 Created attachment 118481 Fixes the bug 517878 3 rniwa 2011-12-08 16:11:07 -0800 Thanks for the review, Tony. Landing it now. 517883 4 rniwa 2011-12-08 16:15:31 -0800 Committed r102392: <http://trac.webkit.org/changeset/102392> 118468 2011-12-08 14:18:59 -0800 2011-12-08 14:18:59 -0800 demo hidden-textarea-pasted-linebreak-lost.html text/html 751 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPHRleHRhcmVhIGlkPSJ0ZXN0IiBzdHlsZT0i ZGlzcGxheTogbm9uZSIgY29scz0iNTAiIHJvd3M9IjEwIj48L3RleHRhcmVhPgo8ZGl2IGlkPSJs b2ciPjwvZGl2Pgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CgppZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQogICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OwoKdmFyIHRleHRhcmVhID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigndGV4dGFyZWEnKTsKdGV4 dGFyZWEudmFsdWUgPSAiXG53ZWJraXQiOwp0ZXh0YXJlYS5zdHlsZS5kaXNwbGF5ID0gIiI7Cgp0 ZXh0YXJlYS5mb2N1cygpOwp0ZXh0YXJlYS5zZWxlY3Rpb25TdGFydCA9IHRleHRhcmVhLnNlbGVj dGlvbkVuZCA9IDA7CmRvY3VtZW50LmV4ZWNDb21tYW5kKCdpbnNlcnRIVE1MJywgZmFsc2UsICdo ZWxsb1xud29ybGRcbicpOwoKdmFyIGV4cGVjdGVkID0gJ2hlbGxvXG53b3JsZFxud2Via2l0JzsK aWYgKHRleHRhcmVhLnZhbHVlID09IGV4cGVjdGVkKQogICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2xvZycpLmlubmVyVGV4dCA9ICdQQVNTJzsKZWxzZQogICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2xvZycpLmlubmVyVGV4dCA9ICdGQUlMRUQ6IGV4cGVjdGVkICInICsgZXhwZWN0ZWQg KyAnIiBidXQgZ290ICInICsgdGV4dGFyZWEudmFsdWUgKyAnIic7Cgo8L3NjcmlwdD4KPC9ib2R5 Pgo8L2h0bWw+Cg== 118481 2011-12-08 15:47:17 -0800 2011-12-08 16:08:41 -0800 Fixes the bug bug-74126-20111208154716.patch text/plain 4492 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTA4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIExpbmUgYnJlYWtzIGFyZSBsb3N0 IHdoZW4gcGFzdGVkIGludG8gdGV4dGFyZWEgdGV4dCBzdGFydGluZyB3aXRoIGEgYmxhbmsgbGlu ZSBzZXQgd2hpbGUgdGV4dGFyZWEgaXMgaGlkZGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSB0aGUgY29kZSB0aGF0 IGdlbmVyYXRlZCB0ZXh0IG91dCBvZiBwcmUtcmVuZGVyZWQgdGV4dCB3YXMgZ2VuZXJhdGluZyBk aXYncyBpbnNpZGUgdGhlIGZyYWdtZW50CisgICAgICAgIHBhc3RlZCBpbnRvIHRleHRhcmVhIGV2 ZW4gdGhvdWdoIHNlcmlhbGl6YXRpb24gYWxnb3JpdGhtIGluIHRleHRhcmVhIGRvZXNuJ3QgaGFu ZGxlIGJsb2NrIGVsZW1lbnRzLgorCisgICAgICAgIEZpeGVkIHRoZSBidWcgYnkgc3BlY2lhbC1j YXNpbmcgdGhpcyBpbiBjcmVhdGVGcmFnbWVudEZyb21UZXh0LiBJbiB0aGUgbG9uZyBydW4sIHdl IHNob3VsZCByZWFsbHkgZ2V0IHJpZCBvZiB0aGlzCisgICAgICAgIHdob2xlIHByZS1yZW5kZXJp bmcgdHJpY2suCisKKyAgICAgICAgKiBlZGl0aW5nL21hcmt1cC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpjcmVhdGVGcmFnbWVudEZyb21UZXh0KToKKwogMjAxMS0xMi0wOCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgYW5pbWF0aW9ucyBv ZiBDU1MgaW1hZ2VzIHVzaW5nIC13ZWJraXQtY3Jvc3MtZmFkZQpJbmRleDogU291cmNlL1dlYkNv cmUvZWRpdGluZy9tYXJrdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRp bmcvbWFya3VwLmNwcAkocmV2aXNpb24gMTAyMzU2KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYXJrdXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw3IEBACiAjaW5jbHVkZSAi SFRNTEJvZHlFbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTEVsZW1lbnQuaCIKICNpbmNsdWRlICJI VE1MTmFtZXMuaCIKKyNpbmNsdWRlICJIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5oIgogI2lu Y2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJNYXJrdXBBY2N1bXVsYXRvci5oIgogI2luY2x1ZGUg IlJhbmdlLmgiCkBAIC04ODAsNyArODgxLDggQEAgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50 PiBjcmVhdGVGcmFnbQogICAgICAgICAmJiAhYmxvY2stPmhhc1RhZ05hbWUoYm9keVRhZykKICAg ICAgICAgJiYgIWJsb2NrLT5oYXNUYWdOYW1lKGh0bWxUYWcpCiAgICAgICAgICYmIGJsb2NrICE9 IGVkaXRhYmxlUm9vdEZvclBvc2l0aW9uKGNvbnRleHQtPnN0YXJ0UG9zaXRpb24oKSk7Ci0gICAg CisgICAgYm9vbCB1c2VMaW5lQnJlYWsgPSBlbmNsb3NpbmdUZXh0Rm9ybUNvbnRyb2woY29udGV4 dC0+c3RhcnRQb3NpdGlvbigpKTsKKwogICAgIFZlY3RvcjxTdHJpbmc+IGxpc3Q7CiAgICAgc3Ry aW5nLnNwbGl0KCdcbicsIHRydWUsIGxpc3QpOyAvLyB0cnVlIGdldHMgdXMgZW1wdHkgc3RyaW5n cyBpbiB0aGUgbGlzdAogICAgIHNpemVfdCBudW1MaW5lcyA9IGxpc3Quc2l6ZSgpOwpAQCAtODkx LDcgKzg5MywxMCBAQCBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGNyZWF0ZUZyYWdtCiAg ICAgICAgIGlmIChzLmlzRW1wdHkoKSAmJiBpICsgMSA9PSBudW1MaW5lcykgewogICAgICAgICAg ICAgLy8gRm9yIGxhc3QgbGluZSwgdXNlIHRoZSAibWFnaWMgQlIiIHJhdGhlciB0aGFuIGEgUC4K ICAgICAgICAgICAgIGVsZW1lbnQgPSBjcmVhdGVCcmVha0VsZW1lbnQoZG9jdW1lbnQpOwotICAg ICAgICAgICAgZWxlbWVudC0+c2V0QXR0cmlidXRlKGNsYXNzQXR0ciwgQXBwbGVJbnRlcmNoYW5n ZU5ld2xpbmUpOyAgICAgICAgICAgIAorICAgICAgICAgICAgZWxlbWVudC0+c2V0QXR0cmlidXRl KGNsYXNzQXR0ciwgQXBwbGVJbnRlcmNoYW5nZU5ld2xpbmUpOworICAgICAgICB9IGVsc2UgaWYg KHVzZUxpbmVCcmVhaykgeworICAgICAgICAgICAgZWxlbWVudCA9IGNyZWF0ZUJyZWFrRWxlbWVu dChkb2N1bWVudCk7CisgICAgICAgICAgICBmaWxsQ29udGFpbmVyRnJvbVN0cmluZyhmcmFnbWVu dC5nZXQoKSwgcyk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBpZiAodXNlQ2xvbmVz T2ZFbmNsb3NpbmdCbG9jaykKICAgICAgICAgICAgICAgICBlbGVtZW50ID0gYmxvY2stPmNsb25l RWxlbWVudFdpdGhvdXRDaGlsZHJlbigpOwpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1 dC9wYXN0ZS1saW5lYnJlYWstaW50by1pbml0aWFsbHktaGlkZGVuLXRleHRhcmVhLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L3Bhc3RlLWxpbmVi cmVhay1pbnRvLWluaXRpYWxseS1oaWRkZW4tdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9wYXN0ZS1saW5lYnJlYWstaW50by1p bml0aWFsbHktaGlkZGVuLXRleHRhcmVhLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw0IEBACitUaGlzIHRlc3RzIHBhc3RpbmcgaW50byBhIHRleHRhcmVhIHRoYXQgc3RhcnRz IHdpdGggYSBsaW5lIGJyZWFrIHRoYXQgZGlkbid0IGluaXRpYWxseSBoYXZlIGEgcmVuZGVyZXIg KGRpc3BsYXk6IG5vbmUpLiBXZWJLaXQgc2hvdWxkIHN0aWxsIGJlIGFibGUgdG8gcGFzdGUgdGV4 dCB3aXRoIGxpbmUgYnJlYWtzLgorCisKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcv aW5wdXQvcGFzdGUtbGluZWJyZWFrLWludG8taW5pdGlhbGx5LWhpZGRlbi10ZXh0YXJlYS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvcGFzdGUtbGluZWJyZWFr LWludG8taW5pdGlhbGx5LWhpZGRlbi10ZXh0YXJlYS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9wYXN0ZS1saW5lYnJlYWstaW50by1pbml0aWFsbHktaGlk ZGVuLXRleHRhcmVhLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxwPlRoaXMgdGVzdHMgcGFzdGluZyBpbnRvIGEgdGV4 dGFyZWEgdGhhdCBzdGFydHMgd2l0aCBhIGxpbmUgYnJlYWsgdGhhdCBkaWRuJ3QgaW5pdGlhbGx5 IGhhdmUgYSByZW5kZXJlciAoZGlzcGxheTogbm9uZSkuCitXZWJLaXQgc2hvdWxkIHN0aWxsIGJl IGFibGUgdG8gcGFzdGUgdGV4dCB3aXRoIGxpbmUgYnJlYWtzLjwvcD4KKzx0ZXh0YXJlYSBpZD0i dGVzdCIgc3R5bGU9ImRpc3BsYXk6IG5vbmUiIGNvbHM9IjUwIiByb3dzPSIxMCI+PC90ZXh0YXJl YT4KKzxkaXYgaWQ9ImxvZyI+PC9kaXY+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+ CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuZHVtcEFzVGV4dCgpOworCit2YXIgdGV4dGFyZWEgPSBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCd0ZXh0YXJlYScpOwordGV4dGFyZWEudmFsdWUgPSAiXG53ZWJraXQiOwordGV4dGFyZWEu c3R5bGUuZGlzcGxheSA9ICIiOworCit0ZXh0YXJlYS5mb2N1cygpOwordGV4dGFyZWEuc2VsZWN0 aW9uU3RhcnQgPSB0ZXh0YXJlYS5zZWxlY3Rpb25FbmQgPSAwOworZG9jdW1lbnQuZXhlY0NvbW1h bmQoJ2luc2VydEhUTUwnLCBmYWxzZSwgJ2hlbGxvXG53b3JsZFxuJyk7CisKK3ZhciBleHBlY3Rl ZCA9ICdoZWxsb1xud29ybGRcbndlYmtpdCc7CitpZiAodGV4dGFyZWEudmFsdWUgPT0gZXhwZWN0 ZWQpCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xvZycpLmlubmVyVGV4dCA9ICdQQVNT JzsKK2Vsc2UKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbG9nJykuaW5uZXJUZXh0ID0g J0ZBSUxFRDogZXhwZWN0ZWQgIicgKyBleHBlY3RlZCArICciIGJ1dCBnb3QgIicgKyB0ZXh0YXJl YS52YWx1ZSArICciJzsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==