74118 2011-12-08 12:20:27 -0800 Chromium DEPS roll to pick up use_skia=1 for Mac, and accompanying layout_test update 2011-12-09 08:18:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 epoger abarth abarth epoger ojan tony webkit.review.bot oldest_to_newest 517675 0 epoger 2011-12-08 12:20:27 -0800 Chromium DEPS roll past Chromium's change to use skia by default on Mac (instead of CG). Also, layout_test changes needed to keep tests green in the face of the use_skia change. 517680 1 118448 epoger 2011-12-08 12:24:57 -0800 Created attachment 118448 Patch 517685 2 118448 epoger 2011-12-08 12:28:54 -0800 Comment on attachment 118448 Patch Adam- If you agree, my plan is to do the following tomorrow morning: 1. wait for a pretty green Chrome tree 2. land a Chromium change setting use_skia=1 3. modify the chromium_rev in this patch to the rev # landed in step 2 4. ask WebKit committer Cary Clark to land the patch for me Sound OK? 517689 3 118448 abarth 2011-12-08 12:33:02 -0800 Comment on attachment 118448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118448&action=review > Source/WebKit/chromium/DEPS:35 > - 'chromium_rev': '112974', > + 'chromium_rev': '112974', # EPOGER WILL UPDATE THIS BEFORE COMMITTING You can use the phrase "OOPS!", which will be blocked by a pre-commit hook. 517705 4 abarth 2011-12-08 12:53:28 -0800 > Sound OK? Sounds great. 517739 5 tony 2011-12-08 13:32:33 -0800 I'll be gardening. Let me know on IRC when you start this. 518277 6 epoger 2011-12-09 08:18:44 -0800 Committed r102454: <http://trac.webkit.org/changeset/102454> 118448 2011-12-08 12:24:57 -0800 2011-12-08 12:33:02 -0800 Patch bug-74118-20111208152455.patch text/plain 7529 epoger SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDIzNjIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEy IEBACisyMDExLTEyLTA4ICBFbGxpb3QgUG9nZXIgIDxlcG9nZXJAZ29vZ2xlLmNvbT4KKworICAg ICAgICBDaHJvbWl1bSBERVBTIHJvbGwgdG8gcGljayB1cCBuZXcgdXNlX3NraWE9MSBkZWZhdWx0 IG9uIENocm9taXVtLU1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzQxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIERFUFM6CisKIDIwMTEtMTItMDggIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gRXhjbHVkZSB0aGUgZm91ciBSZW5kZXJU YWJsZUNlbGxEZWF0aFRlc3QgZGVhdGggdGVzdHMgZm9yIEFuZHJvaWQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vREVQUwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L0RFUFMJKHJldmlzaW9uIDEwMjM0OCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwko d29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQAogCiB2YXJzID0gewogICAnY2hyb21pdW1f c3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMnLAotICAnY2hyb21p dW1fcmV2JzogJzExMjk3NCcsCisgICdjaHJvbWl1bV9yZXYnOiAnMTEyOTc0JywgIyBFUE9HRVIg V0lMTCBVUERBVEUgVEhJUyBCRUZPUkUgQ09NTUlUVElORwogICAnbmFjbF9zdm4nOiAnaHR0cDov L3NyYy5jaHJvbWl1bS5vcmcvbmF0aXZlX2NsaWVudC90cnVuaycsCiAgICduYWNsX3Jldic6ICc3 MTY5JywKIH0KSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFu Z2VMb2cJKHJldmlzaW9uIDEwMjM2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA4ICBFbGxpb3QgUG9nZXIgIDxlcG9nZXJAZ29v Z2xlLmNvbT4KKworICAgICAgICBsYXlvdXRfdGVzdCB1cGRhdGUgdG8gYWNjb21tb2RhdGUgbmV3 IHVzZV9za2lhPTEgZGVmYXVsdCBvbiBDaHJvbWl1bS1NYWMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2dwdS5weToKKyAgICAgICAgKGdldCk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHk6CisgICAgICAgIChD aHJvbWl1bU1hY1BvcnQuX19pbml0X18pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ2hyb21p dW1NYWNQb3J0VGVzdC50ZXN0X3ZlcnNpb25zKToKKyAgICAgICAgKENocm9taXVtTWFjUG9ydFRl c3QudGVzdF9ncmFwaGljc190eXBlKToKKwogMjAxMS0xMi0wOCAgQWRhbSBSb2JlbiAgPGFyb2Jl bkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBmaW5kaW5nIGNyYXNoIGxvZ3MgYnkgUElEIHdv cmsgb24gU25vdyBMZW9wYXJkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQkocmV2aXNpb24gMTAyMzQ4 KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9n cHUucHkJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgZGVmIGdldChob3N0LCBwbGF0 Zm9ybT1Ob25lLCBwb3J0X25hbWU9JwogICAgICAgICBlbGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgo J2xpbnV4Jyk6CiAgICAgICAgICAgICBwb3J0X25hbWUgPSAnY2hyb21pdW0tZ3B1LWxpbnV4Jwog ICAgICAgICBlbGlmIHBsYXRmb3JtID09ICdkYXJ3aW4nOgotICAgICAgICAgICAgcG9ydF9uYW1l ID0gJ2Nocm9taXVtLWdwdS1jZy1tYWMnCisgICAgICAgICAgICBwb3J0X25hbWUgPSAnY2hyb21p dW0tZ3B1LW1hYycKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJhaXNlIE5vdEltcGxlbWVu dGVkRXJyb3IoJ3Vuc3VwcG9ydGVkIHBsYXRmb3JtOiAlcycgJSBwbGF0Zm9ybSkKIApJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9j aHJvbWl1bV9tYWMucHkJKHJldmlzaW9uIDEwMjM0OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x MTIsNyArMTEyLDcgQEAgY2xhc3MgQ2hyb21pdW1NYWNQb3J0KGNocm9taXVtLkNocm9taXVtUAog ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25hbWU9Tm9uZSwgb3NfdmVyc2lvbl9z dHJpbmc9Tm9uZSwgKiprd2FyZ3MpOgogICAgICAgICAjIFdlJ3JlIGEgbGl0dGxlIGdlbmVyaWMg aGVyZSBiZWNhdXNlIHRoaXMgY29kZSBpcyByZXVzZWQgYnkgdGhlCiAgICAgICAgICMgJ2dvb2ds ZS1jaHJvbWUnIHBvcnQgYXMgd2VsbCBhcyB0aGUgJ21vY2stJyBhbmQgJ2RyeXJ1bi0nIHBvcnRz LgotICAgICAgICBwb3J0X25hbWUgPSBwb3J0X25hbWUgb3IgJ2Nocm9taXVtLWNnLW1hYycKKyAg ICAgICAgcG9ydF9uYW1lID0gcG9ydF9uYW1lIG9yICdjaHJvbWl1bS1tYWMnCiAgICAgICAgIGNo cm9taXVtLkNocm9taXVtUG9ydC5fX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25hbWU9cG9ydF9u YW1lLCAqKmt3YXJncykKICAgICAgICAgaWYgcG9ydF9uYW1lLmVuZHN3aXRoKCctbWFjJyk6CiAg ICAgICAgICAgICBzZWxmLl92ZXJzaW9uID0gbWFjLm9zX3ZlcnNpb24ob3NfdmVyc2lvbl9zdHJp bmcsIHNlbGYuU1VQUE9SVEVEX09TX1ZFUlNJT05TKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWNfdW5pdHRlc3QucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9t YWNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDEwMjM0OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC00NiwyNiArNDYsMjYgQEAgY2xhc3MgQ2hyb21pdW1NYWNQb3J0VGVzdChwb3J0X3Rl c3RjYXNlLgogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhleHBlY3RlZCwgcG9ydC5uYW1lKCkp CiAKICAgICBkZWYgdGVzdF92ZXJzaW9ucyhzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVl KHNlbGYubWFrZV9wb3J0KCkubmFtZSgpIGluICgnY2hyb21pdW0tY2ctbWFjLWxlb3BhcmQnLCAn Y2hyb21pdW0tY2ctbWFjLXNub3dsZW9wYXJkJywgJ2Nocm9taXVtLWNnLW1hYy1saW9uJywgJ2No cm9taXVtLWNnLW1hYy1mdXR1cmUnKSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHNlbGYubWFr ZV9wb3J0KCkubmFtZSgpIGluICgnY2hyb21pdW0tbWFjLWxlb3BhcmQnLCAnY2hyb21pdW0tbWFj LXNub3dsZW9wYXJkJywgJ2Nocm9taXVtLW1hYy1saW9uJywgJ2Nocm9taXVtLW1hYy1mdXR1cmUn KSkKIAotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC41LjMnLCAnY2hyb21pdW0t Y2ctbWFjLWxlb3BhcmQnKQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1jZy1t YWMnLCAnMTAuNS4zJywgJ2Nocm9taXVtLWNnLW1hYy1sZW9wYXJkJykKLSAgICAgICAgc2VsZi5h c3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjLWxlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVt LWNnLW1hYy1sZW9wYXJkJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ct bWFjLWxlb3BhcmQnLCAnMTAuNi4zJywgJ2Nocm9taXVtLWNnLW1hYy1sZW9wYXJkJykKLQotICAg ICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC42LjMnLCAnY2hyb21pdW0tY2ctbWFjLXNu b3dsZW9wYXJkJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjJywg JzEwLjYuMycsICdjaHJvbWl1bS1jZy1tYWMtc25vd2xlb3BhcmQnKQotICAgICAgICBzZWxmLmFz c2VydF9uYW1lKCdjaHJvbWl1bS1jZy1tYWMtc25vd2xlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9t aXVtLWNnLW1hYy1zbm93bGVvcGFyZCcpCi0gICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9t aXVtLWNnLW1hYy1zbm93bGVvcGFyZCcsICcxMC42LjMnLCAnY2hyb21pdW0tY2ctbWFjLXNub3ds ZW9wYXJkJykKLQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC43JywgJ2Nocm9t aXVtLWNnLW1hYy1saW9uJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZShOb25lLCAnMTAuNy4z JywgJ2Nocm9taXVtLWNnLW1hYy1saW9uJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZShOb25l LCAnMTAuOCcsICdjaHJvbWl1bS1jZy1tYWMtZnV0dXJlJykKLSAgICAgICAgc2VsZi5hc3NlcnRf bmFtZSgnY2hyb21pdW0tY2ctbWFjJywgJzEwLjcuMycsICdjaHJvbWl1bS1jZy1tYWMtbGlvbicp Ci0gICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUnLCAnMTAu NC4zJywgJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUnKQotICAgICAgICBzZWxmLmFzc2VydF9uYW1l KCdjaHJvbWl1bS1jZy1tYWMtZnV0dXJlJywgJzEwLjUuMycsICdjaHJvbWl1bS1jZy1tYWMtZnV0 dXJlJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjLWZ1dHVyZScs ICcxMC42LjMnLCAnY2hyb21pdW0tY2ctbWFjLWZ1dHVyZScpCi0gICAgICAgIHNlbGYuYXNzZXJ0 X25hbWUoJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUnLCAnMTAuNy4zJywgJ2Nocm9taXVtLWNnLW1h Yy1mdXR1cmUnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC41LjMnLCAnY2hy b21pdW0tbWFjLWxlb3BhcmQnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1t YWMnLCAnMTAuNS4zJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJkJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbmFtZSgnY2hyb21pdW0tbWFjLWxlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLW1hYy1s ZW9wYXJkJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjLWxlb3BhcmQn LCAnMTAuNi4zJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJkJykKKworICAgICAgICBzZWxmLmFzc2Vy dF9uYW1lKE5vbmUsICcxMC42LjMnLCAnY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjJywgJzEwLjYuMycsICdjaHJvbWl1bS1t YWMtc25vd2xlb3BhcmQnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1tYWMt c25vd2xlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLW1hYy1zbm93bGVvcGFyZCcpCisgICAg ICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLW1hYy1zbm93bGVvcGFyZCcsICcxMC42LjMn LCAnY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkJykKKworICAgICAgICBzZWxmLmFzc2VydF9uYW1l KE5vbmUsICcxMC43JywgJ2Nocm9taXVtLW1hYy1saW9uJykKKyAgICAgICAgc2VsZi5hc3NlcnRf bmFtZShOb25lLCAnMTAuNy4zJywgJ2Nocm9taXVtLW1hYy1saW9uJykKKyAgICAgICAgc2VsZi5h c3NlcnRfbmFtZShOb25lLCAnMTAuOCcsICdjaHJvbWl1bS1tYWMtZnV0dXJlJykKKyAgICAgICAg c2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjJywgJzEwLjcuMycsICdjaHJvbWl1bS1tYWMt bGlvbicpCisgICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLW1hYy1mdXR1cmUnLCAn MTAuNC4zJywgJ2Nocm9taXVtLW1hYy1mdXR1cmUnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1l KCdjaHJvbWl1bS1tYWMtZnV0dXJlJywgJzEwLjUuMycsICdjaHJvbWl1bS1tYWMtZnV0dXJlJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjLWZ1dHVyZScsICcxMC42LjMn LCAnY2hyb21pdW0tbWFjLWZ1dHVyZScpCisgICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9t aXVtLW1hYy1mdXR1cmUnLCAnMTAuNy4zJywgJ2Nocm9taXVtLW1hYy1mdXR1cmUnKQogCiAgICAg ICAgIHNlbGYuYXNzZXJ0UmFpc2VzKEFzc2VydGlvbkVycm9yLCBzZWxmLmFzc2VydF9uYW1lLCBO b25lLCAnMTAuNC4xJywgJ3Nob3VsZC1yYWlzZS1hc3NlcnRpb24tc28tdGhpcy12YWx1ZS1kb2Vz LW5vdC1tYXR0ZXInKQogCkBAIC04Miw4ICs4Miw4IEBAIGNsYXNzIENocm9taXVtTWFjUG9ydFRl c3QocG9ydF90ZXN0Y2FzZS4KICAgICBkZWYgdGVzdF9ncmFwaGljc190eXBlKHNlbGYpOgogICAg ICAgICBzZWxmLmFzc2VydEVxdWFscygnY3B1LWNnJywgc2VsZi5tYWtlX3BvcnQocG9ydF9uYW1l PSdjaHJvbWl1bS1jZy1tYWMnKS5ncmFwaGljc190eXBlKCkpCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWxzKCdjcHUnLCBzZWxmLm1ha2VfcG9ydChwb3J0X25hbWU9J2Nocm9taXVtLW1hYycpLmdy YXBoaWNzX3R5cGUoKSkKLSAgICAgICAgIyBGb3Igbm93LCBNYWMgZGVmYXVsdHMgdG8gY3B1LWNn IGdyYXBoaWNzIHR5cGUuCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCdjcHUtY2cnLCBzZWxm Lm1ha2VfcG9ydCgpLmdyYXBoaWNzX3R5cGUoKSkKKyAgICAgICAgIyBNYWMgZGVmYXVsdHMgdG8g Y3B1IGdyYXBoaWNzIHR5cGUuCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCdjcHUnLCBzZWxm Lm1ha2VfcG9ydCgpLmdyYXBoaWNzX3R5cGUoKSkKIAogCiBpZiBfX25hbWVfXyA9PSAnX19tYWlu X18nOgo=