74093 2011-12-08 08:25:35 -0800 platform/mac/accessibility/search-with-frames.html crashes 2011-12-08 14:12:10 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni cfleizach bdakin oldest_to_newest 517433 0 dmazzoni 2011-12-08 08:25:35 -0800 Crash log: Process: DumpRenderTree [51194] Path: /Volumes/Data/slave/snowleopard-intel-release-tests/build/WebKitBuild/Release/DumpRenderTree Identifier: DumpRenderTree Version: ??? (???) Code Type: X86-64 (Native) Parent Process: Python [51129] Date/Time: 2011-12-08 04:41:35.160 -0800 OS Version: Mac OS X 10.6.8 (10K549) Report Version: 6 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Application Specific Information: abort() called Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x00007fff835470b6 __kill + 10 1 libSystem.B.dylib 0x00007fff835e79f6 abort + 83 2 libSystem.B.dylib 0x00007fff835677d2 _Unwind_Resume + 66 3 DumpRenderTree 0x0000000100008ad9 AccessibilityUIElement::uiElementForSearchPredicate(AccessibilityUIElement*, bool, OpaqueJSString*, OpaqueJSString*) + 461 (AccessibilityUIElementMac.mm:972) 4 DumpRenderTree 0x000000010000380e uiElementForSearchPredicateCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) + 215 (AccessibilityUIElement.cpp:203) 5 com.apple.JavaScriptCore 0x00000001001e73bd JSC::JSCallbackFunction::call(JSC::ExecState*) + 349 (JSCallbackFunction.cpp:73) 6 com.apple.JavaScriptCore 0x00000001001d81c1 cti_op_call_NotJSFunction + 97 (JITStubs.cpp:2364) 7 ??? 0x00005acae7c0118f 0 + 99827518017935 8 com.apple.JavaScriptCore 0x00000001001a27af JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 911 (JSValueInlineMethods.h:363) 9 com.apple.JavaScriptCore 0x000000010014774a JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 42 (CallData.cpp:40) 10 com.apple.WebCore 0x0000000100d03731 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 961 (JSMainThreadExecState.h:52) 11 com.apple.WebCore 0x0000000100a4d1d5 WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul>&) + 149 (EventTarget.cpp:214) 12 com.apple.WebCore 0x0000000100a4d115 WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 69 (Event.h:133) 13 com.apple.WebCore 0x0000000100f4ec4a WebCore::Node::handleLocalEvents(WebCore::Event*) + 170 (Node.cpp:2813) 14 com.apple.WebCore 0x0000000100a3b478 WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 776 (PassRefPtr.h:76) 15 com.apple.WebCore 0x0000000100a3a345 WebCore::EventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 37 (EventDispatchMediator.cpp:51) 16 com.apple.WebCore 0x0000000100a3aa62 WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr<WebCore::EventDispatchMediator>) + 146 (EventDispatcher.cpp:55) 17 com.apple.WebCore 0x0000000100f4ed57 WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 55 (Node.cpp:2827) 18 com.apple.WebCore 0x0000000100a093c2 WebCore::DOMWindow::dispatchLoadEvent() + 658 (DOMWindow.cpp:1652) 19 com.apple.WebCore 0x00000001009489d6 WebCore::Document::implicitClose() + 326 (Document.cpp:3543) 20 com.apple.WebCore 0x0000000100a8351f WebCore::FrameLoader::checkCompleted() + 287 (FrameLoader.cpp:745) 21 com.apple.WebCore 0x0000000100a8263f WebCore::FrameLoader::finishedParsing() + 95 (FrameLoader.cpp:679) 22 com.apple.WebCore 0x00000001009508fa WebCore::Document::finishedParsing() + 330 (Frame.h:353) 23 com.apple.WebCore 0x0000000100afbfe2 WebCore::HTMLDocumentParser::prepareToStopParsing() + 162 (HTMLDocumentParser.cpp:381) 24 com.apple.WebCore 0x0000000100964b71 WebCore::DocumentWriter::endIfNotLoadingMainResource() + 81 (RefPtr.h:133) 25 com.apple.WebCore 0x0000000100a8a155 WebCore::FrameLoader::finishedLoading() + 69 (ResourceErrorBase.h:42) 26 com.apple.WebCore 0x0000000100f1a08b WebCore::MainResourceLoader::didFinishLoading(double) + 123 (MainResourceLoader.cpp:498) 27 com.apple.Foundation 0x00007fff870298f0 _NSURLConnectionDidFinishLoading + 113 517468 1 cfleizach 2011-12-08 09:22:34 -0800 strange this seems only to be with release. will fix this today 517488 2 cfleizach 2011-12-08 09:51:32 -0800 Dominic, can you reproduce this crash? if so, what command line are you running webkit-tests with 517513 3 dmazzoni 2011-12-08 10:14:40 -0800 (In reply to comment #2) > Dominic, can you reproduce this crash? if so, what command line are you running webkit-tests with Yes, I can reproduce it locally with Snow Leopard and XCode 3.2, both with DRT and WKTR. Tools/Scripts/run-webkit-tests platform/mac/accessibility/ Tools/Scripts/run-webkit-tests platform/mac/accessibility/ -2 The stack trace I got was basically the same as the one I found on the buildbot (see below). If you have a theory but can't repro locally, I can try to help test it. 0 libSystem.B.dylib 0x00007fff823310b6 __kill + 10 1 libSystem.B.dylib 0x00007fff823d19f6 abort + 83 2 libSystem.B.dylib 0x00007fff823517d2 _Unwind_Resume + 66 3 WebKitTestRunnerInjectedBundle 0x000000010566e89e WTR::AccessibilityUIElement::uiElementForSearchPredicate(WTR::AccessibilityUIElement*, bool, OpaqueJSString*, OpaqueJSString*) + 438 (AccessibilityUIElementMac.mm:907) 4 WebKitTestRunnerInjectedBundle 0x0000000105673f42 WTR::JSAccessibilityUIElement::uiElementForSearchPredicate(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) + 224 (JSAccessibilityUIElement.cpp:669) 5 com.apple.JavaScriptCore 0x000000010112b478 JSC::JSCallbackFunction::call(JSC::ExecState*) + 392 (JSCallbackFunction.cpp:73) 6 com.apple.JavaScriptCore 0x0000000101113f16 cti_op_call_NotJSFunction + 182 (JITStubs.cpp:2361) 7 ??? 0x0000426f59a0118f 0 + 73046012465551 8 com.apple.JavaScriptCore 0x00000001010d1d05 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 853 (JITCode.h:116) 9 ??? 0x000000000000000a 0 + 10 10 ??? 0x0000000119db2920 0 + 4728760608 11 com.apple.JavaScriptCore 0x000000010113da70 JSC::JSFunction::~JSFunction() + 0 (JSObject.h:73) 12 ??? 0x90c307894810c083 0 + 10431189448121172099 517520 4 cfleizach 2011-12-08 10:23:24 -0800 Not happening on Lion unfortunately. Also, it looks like an NSException is being thrown, however, it's unclear which one. If you break on +[NSException raise:format:] we could probably see what kind of exception is happening. Or alternatively, you could modify #define BEGIN_AX_OBJC_EXCEPTIONS @try { #define END_AX_OBJC_EXCEPTIONS } @catch(NSException *e) { if (![[e name] isEqualToString:NSAccessibilityException]) @throw; } to be #define BEGIN_AX_OBJC_EXCEPTIONS @try { #define END_AX_OBJC_EXCEPTIONS } @catch(NSException *e) { NSLog(@"%@", e); if (![[e name] isEqualToString:NSAccessibilityException]) @throw; } (add in the NSLog) so that we can see what the error is. then we'll know what to fix... (In reply to comment #3) > (In reply to comment #2) > > Dominic, can you reproduce this crash? if so, what command line are you running webkit-tests with > > Yes, I can reproduce it locally with Snow Leopard and XCode 3.2, both with DRT and WKTR. > > Tools/Scripts/run-webkit-tests platform/mac/accessibility/ > > Tools/Scripts/run-webkit-tests platform/mac/accessibility/ -2 > > The stack trace I got was basically the same as the one I found on the buildbot (see below). > > If you have a theory but can't repro locally, I can try to help test it. > > 0 libSystem.B.dylib 0x00007fff823310b6 __kill + 10 > 1 libSystem.B.dylib 0x00007fff823d19f6 abort + 83 > 2 libSystem.B.dylib 0x00007fff823517d2 _Unwind_Resume + 66 > 3 WebKitTestRunnerInjectedBundle 0x000000010566e89e WTR::AccessibilityUIElement::uiElementForSearchPredicate(WTR::AccessibilityUIElement*, bool, OpaqueJSString*, OpaqueJSString*) + 438 (AccessibilityUIElementMac.mm:907) > 4 WebKitTestRunnerInjectedBundle 0x0000000105673f42 WTR::JSAccessibilityUIElement::uiElementForSearchPredicate(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) + 224 (JSAccessibilityUIElement.cpp:669) > 5 com.apple.JavaScriptCore 0x000000010112b478 JSC::JSCallbackFunction::call(JSC::ExecState*) + 392 (JSCallbackFunction.cpp:73) > 6 com.apple.JavaScriptCore 0x0000000101113f16 cti_op_call_NotJSFunction + 182 (JITStubs.cpp:2361) > 7 ??? 0x0000426f59a0118f 0 + 73046012465551 > 8 com.apple.JavaScriptCore 0x00000001010d1d05 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 853 (JITCode.h:116) > 9 ??? 0x000000000000000a 0 + 10 > 10 ??? 0x0000000119db2920 0 + 4728760608 > 11 com.apple.JavaScriptCore 0x000000010113da70 JSC::JSFunction::~JSFunction() + 0 (JSObject.h:73) > 12 ??? 0x90c307894810c083 0 + 10431189448121172099 517564 5 dmazzoni 2011-12-08 10:56:33 -0800 (In reply to comment #4) > #define END_AX_OBJC_EXCEPTIONS } @catch(NSException *e) { NSLog(@"%@", e); if (![[e name] isEqualToString:NSAccessibilityException]) @throw; } Here's what I get: 2011-12-08 10:53:09.802 DumpRenderTree[24435:903] *** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value (key: AXStartElement) 517573 6 cfleizach 2011-12-08 11:02:12 -0800 (In reply to comment #5) > (In reply to comment #4) > > #define END_AX_OBJC_EXCEPTIONS } @catch(NSException *e) { NSLog(@"%@", e); if (![[e name] isEqualToString:NSAccessibilityException]) @throw; } > > Here's what I get: > > 2011-12-08 10:53:09.802 DumpRenderTree[24435:903] *** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value (key: AXStartElement) thanks, will have a patch in a few minutes ready 517601 7 118429 cfleizach 2011-12-08 11:22:03 -0800 Created attachment 118429 patch 517698 8 dmazzoni 2011-12-08 12:40:56 -0800 Fix looks good. Want to remove this test from platfom/mac/Skipped as part of this change too? 517779 9 cfleizach 2011-12-08 14:12:10 -0800 http://trac.webkit.org/changeset/102382 118429 2011-12-08 11:22:03 -0800 2011-12-08 13:10:45 -0800 patch patch.txt text/plain 3571 cfleizach SW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0FjY2Vzc2li aWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQkocmV2aXNp b24gMTAxNTczKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMv QWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtOTc3LDcgKzk3 Nyw3IEBACiAgICAgTlNNdXRhYmxlRGljdGlvbmFyeSogcGFyYW1ldGVyID0gW05TTXV0YWJsZURp Y3Rpb25hcnkgZGljdGlvbmFyeV07CiAgICAgW3BhcmFtZXRlciBzZXRPYmplY3Q6KGlzRGlyZWN0 aW9uTmV4dCkgPyBAIkFYRGlyZWN0aW9uTmV4dCIgOiBAIkFYRGlyZWN0aW9uUHJldmlvdXMiIGZv cktleTpAIkFYRGlyZWN0aW9uIl07CiAgICAgW3BhcmFtZXRlciBzZXRPYmplY3Q6W05TTnVtYmVy IG51bWJlcldpdGhJbnQ6MV0gZm9yS2V5OkAiQVhSZXN1bHRzTGltaXQiXTsKLSAgICBpZiAoc3Rh cnRFbGVtZW50KQorICAgIGlmIChzdGFydEVsZW1lbnQgJiYgc3RhcnRFbGVtZW50LT5wbGF0Zm9y bVVJRWxlbWVudCgpKQogICAgICAgICBbcGFyYW1ldGVyIHNldE9iamVjdDooaWQpc3RhcnRFbGVt ZW50LT5wbGF0Zm9ybVVJRWxlbWVudCgpIGZvcktleTpAIkFYU3RhcnRFbGVtZW50Il07CiAgICAg aWYgKHNlYXJjaEtleSkKICAgICAgICAgW3BhcmFtZXRlciBzZXRPYmplY3Q6W05TU3RyaW5nIHN0 cmluZ1dpdGhKU1N0cmluZ1JlZjpzZWFyY2hLZXldIGZvcktleTpAIkFYU2VhcmNoS2V5Il07Cklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNw cAkocmV2aXNpb24gMTAxNTcyKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5Miw3ICsxOTIsOSBAQAogICAgIEpT U3RyaW5nUmVmIHNlYXJjaEtleSA9IDA7CiAgICAgSlNTdHJpbmdSZWYgc2VhcmNoVGV4dCA9IDA7 CiAgICAgaWYgKGFyZ3VtZW50Q291bnQgPT0gNCkgewotICAgICAgICBzdGFydEVsZW1lbnQgPSB0 b0FYRWxlbWVudChKU1ZhbHVlVG9PYmplY3QoY29udGV4dCwgYXJndW1lbnRzWzBdLCBleGNlcHRp b24pKTsKKyAgICAgICAgSlNPYmplY3RSZWYgc3RhcnRFbGVtZW50T2JqZWN0ID0gSlNWYWx1ZVRv T2JqZWN0KGNvbnRleHQsIGFyZ3VtZW50c1swXSwgZXhjZXB0aW9uKTsKKyAgICAgICAgaWYgKHN0 YXJ0RWxlbWVudE9iamVjdCkKKyAgICAgICAgICAgIHN0YXJ0RWxlbWVudCA9IHRvQVhFbGVtZW50 KHN0YXJ0RWxlbWVudE9iamVjdCk7CiAgICAgICAgIGlzRGlyZWN0aW9uTmV4dCA9IEpTVmFsdWVU b0Jvb2xlYW4oY29udGV4dCwgYXJndW1lbnRzWzFdKTsKICAgICAgICAgaWYgKEpTVmFsdWVJc1N0 cmluZyhjb250ZXh0LCBhcmd1bWVudHNbMl0pKQogICAgICAgICAgICAgc2VhcmNoS2V5ID0gSlNW YWx1ZVRvU3RyaW5nQ29weShjb250ZXh0LCBhcmd1bWVudHNbMl0sIGV4Y2VwdGlvbik7CkluZGV4 OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxl bWVudE1hYy5tbQkocmV2aXNpb24gMTAxNTczKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTk2MCw3ICs5 NjAsNyBAQAogICAgIE5TTXV0YWJsZURpY3Rpb25hcnkqIHBhcmFtZXRlciA9IFtOU011dGFibGVE aWN0aW9uYXJ5IGRpY3Rpb25hcnldOwogICAgIFtwYXJhbWV0ZXIgc2V0T2JqZWN0Oihpc0RpcmVj dGlvbk5leHQpID8gQCJBWERpcmVjdGlvbk5leHQiIDogQCJBWERpcmVjdGlvblByZXZpb3VzIiBm b3JLZXk6QCJBWERpcmVjdGlvbiJdOwogICAgIFtwYXJhbWV0ZXIgc2V0T2JqZWN0OltOU051bWJl ciBudW1iZXJXaXRoSW50OjFdIGZvcktleTpAIkFYUmVzdWx0c0xpbWl0Il07Ci0gICAgaWYgKHN0 YXJ0RWxlbWVudCkKKyAgICBpZiAoc3RhcnRFbGVtZW50ICYmIHN0YXJ0RWxlbWVudC0+cGxhdGZv cm1VSUVsZW1lbnQoKSkKICAgICAgICAgW3BhcmFtZXRlciBzZXRPYmplY3Q6KGlkKXN0YXJ0RWxl bWVudC0+cGxhdGZvcm1VSUVsZW1lbnQoKSBmb3JLZXk6QCJBWFN0YXJ0RWxlbWVudCJdOwogICAg IGlmIChzZWFyY2hLZXkpCiAgICAgICAgIFtwYXJhbWV0ZXIgc2V0T2JqZWN0OltOU1N0cmluZyBz dHJpbmdXaXRoSlNTdHJpbmdSZWY6c2VhcmNoS2V5XSBmb3JLZXk6QCJBWFNlYXJjaEtleSJdOwpJ bmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2 aXNpb24gMTAyMzU1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMTItMDggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KKworICAgICAgICBBWDogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXdpdGgt ZnJhbWVzLmh0bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzQwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUYWtlIGNhcmUgb2YgdGhlIGNhc2Ugd2hlbiBhbiBpbmNvbWluZyBlbGVtZW50 IGlzIG51bGwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50LmNwcDoKKyAgICAgICAgKHVpRWxlbWVudEZvclNlYXJjaFByZWRpY2F0ZUNhbGxiYWNrKToK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5t bToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnVpRWxlbWVudEZvclNlYXJjaFBy ZWRpY2F0ZSk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMv QWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbToKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0 eVVJRWxlbWVudDo6dWlFbGVtZW50Rm9yU2VhcmNoUHJlZGljYXRlKToKKwogMjAxMS0xMi0wOCAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBmaW5kaW5nIGNy YXNoIGxvZ3MgYnkgUElEIHdvcmsgb24gU25vdyBMZW9wYXJkCg==