74091 2011-12-08 07:49:18 -0800 [chromium] Fix V8 bindings so Chrome will compile with ENABLE(CSS_FILTERS) 2011-12-08 16:22:29 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco abarth dglazkov japhet kbr webkit.review.bot oldest_to_newest 517416 0 senorblanco 2011-12-08 07:49:18 -0800 [chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS)[chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS) 517420 1 118392 senorblanco 2011-12-08 07:54:12 -0800 Created attachment 118392 Patch 517594 2 118392 kbr 2011-12-08 11:16:11 -0800 Comment on attachment 118392 Patch Looks fine. r=me 517606 3 senorblanco 2011-12-08 11:27:00 -0800 Committed r102356: <http://trac.webkit.org/changeset/102356> 517654 4 118392 abarth 2011-12-08 12:10:00 -0800 Comment on attachment 118392 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review > Source/WebCore/ChangeLog:10 > + * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added. You don't need to add this file to the gypi ? 517659 5 senorblanco 2011-12-08 12:11:43 -0800 (In reply to comment #4) > (From update of attachment 118392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review > > > Source/WebCore/ChangeLog:10 > > + * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added. > > You don't need to add this file to the gypi ? Whoops, must've reverted that change by mistake. Thanks. 517696 6 senorblanco 2011-12-08 12:38:53 -0800 Reopening to add to .gypi. 517712 7 118456 senorblanco 2011-12-08 13:01:36 -0800 Created attachment 118456 Patch 517890 8 118456 webkit.review.bot 2011-12-08 16:22:25 -0800 Comment on attachment 118456 Patch Clearing flags on attachment: 118456 Committed r102394: <http://trac.webkit.org/changeset/102394> 517891 9 webkit.review.bot 2011-12-08 16:22:29 -0800 All reviewed patches have been landed. Closing bug. 118392 2011-12-08 07:54:12 -0800 2011-12-08 13:01:31 -0800 Patch bug-74091-20111208105410.patch text/plain 3168 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjMzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA4ICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBtaXNzaW5n IFY4IGJpbmRpbmdzIHRvIGdldCBDU1NfRklMVEVSUyB0byBjb21waWxlIGluIENocm9taXVtLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQwOTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaWxsIGJlIGNv dmVyZWQgYnkgdGVzdHMgaW4gY3NzMy9maWx0ZXJzICh3aGVuIGVuYWJsZWQpLgorCisgICAgICAg ICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViS2l0Q1NTRmlsdGVyVmFsdWVDdXN0b20uY3BwOiBB ZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlY4V2ViS2l0Q1NTRmlsdGVyVmFsdWU6OmluZGV4ZWRQ cm9wZXJ0eUdldHRlcik6CisKIDIwMTEtMTItMDggIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBh ZG9iZS5jb20+CiAKICAgICAgICAgW0NTU1JlZ2lvbnNdW0NTU09NXSBJbXBsZW1lbnQgTmFtZWRG bG93IGludGVyZmFjZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 V2ViS2l0Q1NTRmlsdGVyVmFsdWVDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYktpdENTU0ZpbHRlclZhbHVlQ3VzdG9tLmNwcAko cmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYktp dENTU0ZpbHRlclZhbHVlQ3VzdG9tLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NSBAQAor LyoKKyAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gIFJl ZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJp Z2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv d2luZyBkaXNjbGFpbWVyLgorICogMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBt dXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICog ICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRo ZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBM RSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNT IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRI RSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBG T1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT SEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyAq IERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBS T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7CisgKiBMT1NTIE9GIFVT RSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQgT04KKyAqIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRS QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUwor ICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorCisjaWYgRU5BQkxFKENTU19GSUxU RVJTKQorCisjaW5jbHVkZSAiVjhXZWJLaXRDU1NGaWx0ZXJWYWx1ZS5oIgorCisjaW5jbHVkZSAi VjhCaW5kaW5nLmgiCisjaW5jbHVkZSAiV2ViS2l0Q1NTRmlsdGVyVmFsdWUuaCIKKworbmFtZXNw YWNlIFdlYkNvcmUgeworCit2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhXZWJLaXRDU1NGaWx0ZXJW YWx1ZTo6aW5kZXhlZFByb3BlcnR5R2V0dGVyKHVpbnQzMl90IGluZGV4LCBjb25zdCB2ODo6QWNj ZXNzb3JJbmZvJiBpbmZvKQoreworICAgIElOQ19TVEFUUygiRE9NLldlYktpdENTU0ZpbHRlclZh bHVlLkluZGV4ZWRQcm9wZXJ0eUdldHRlciIpOworICAgIFdlYktpdENTU0ZpbHRlclZhbHVlKiBs aXN0ID0gVjhXZWJLaXRDU1NGaWx0ZXJWYWx1ZTo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7Cisg ICAgcmV0dXJuIHRvVjgobGlzdC0+aXRlbShpbmRleCkpOworfQorCit9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCisKKyNlbmRpZgoKUHJvcGVydHkgY2hhbmdlcyBvbjogU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4V2ViS2l0Q1NTRmlsdGVyVmFsdWVDdXN0b20uY3BwCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK 118456 2011-12-08 13:01:36 -0800 2011-12-08 16:22:25 -0800 Patch bug-74091-20111208160135.patch text/plain 1286 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEyLTA4ICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g QWRkIENTU19GSUxURVJTIGN1c3RvbSBiaW5kaW5nIGZpbGUgdG8gV2ViQ29yZS5neXBpLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQwOTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBpdCBidWlsZHMs IHlvdSdyZSBoYXBweS4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwaToKKwogMjAxMS0xMi0wOCAg QW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVuZGVyT2JqZWN0 OiBSZW5hbWUgc3R5bGVTbG93Q2FzZSgpIHRvIHN0eWxlSW5SZWdpb24oKS4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cGkJKHJldmlzaW9uIDEwMjM2MSkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lw aQkod29ya2luZyBjb3B5KQpAQCAtMjI2NCw2ICsyMjY0LDcgQEAKICAgICAgICAgICAgICdiaW5k aW5ncy92OC9jdXN0b20vVjhVaW50OEFycmF5Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcCcsCiAgICAg ICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViS2l0QW5pbWF0aW9uQ3VzdG9tLmNwcCcs CisgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViS2l0Q1NTRmlsdGVyVmFsdWVD dXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhXZWJLaXRNdXRh dGlvbk9ic2VydmVyQ3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9t L1Y4V2ViS2l0UG9pbnRDb25zdHJ1Y3Rvci5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOFdlYlNvY2tldEN1c3RvbS5jcHAnLAo=