74066 2011-12-08 01:50:06 -0800 [GTK] [WebSocket] Provide more specific error description for SocketStreamError 2011-12-08 07:45:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 toyoshim toyoshim svillar tkent webkit.review.bot yutak oldest_to_newest 517253 0 toyoshim 2011-12-08 01:50:06 -0800 Current GTK port provide only error code to show SocketStreamError in console. This patch add short readable description. Before: CONSOLE MESSAGE: line 0: WebSocket network error: error code 0 After: CONSOLE MESSAGE: line 0: WebSocket network error: Error sending data: Broken pipe 517255 1 118347 toyoshim 2011-12-08 01:53:14 -0800 Created attachment 118347 Patch 517412 2 118347 webkit.review.bot 2011-12-08 07:45:54 -0800 Comment on attachment 118347 Patch Clearing flags on attachment: 118347 Committed r102339: <http://trac.webkit.org/changeset/102339> 517413 3 webkit.review.bot 2011-12-08 07:45:58 -0800 All reviewed patches have been landed. Closing bug. 118347 2011-12-08 01:53:14 -0800 2011-12-08 07:45:54 -0800 Patch bug-74066-20111208185315.patch text/plain 5059 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQwZGE0ZGQ0ZTM2MGJj M2YyZGE2Nzc3NmZjZGM5MzMwMDY1NTRjNS4uNzU3MmUwMzI1YTE3ZmJjNTgwMWM1NzkyZjZiNWNm ZjFmMDI5OGYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTEyLTA4ICBUYWth c2hpIFRveW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9yZz4KKworICAgICAgICBQcm92aWRl IG1vcmUgc3BlY2lmaWMgZXJyb3IgZGVzY3JpcHRpb24gZm9yIFNvY2tldFN0cmVhbUVycm9yLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQwNjYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgYmVjYXVzZSB0aGlzIGNoYW5nZSBqdXN0IGltcHJvdmUgZXJyb3IgbWVzc2FnZXMgZm9yIHVu ZXhwZWN0ZWQgZmFpbHVyZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29j a2V0U3RyZWFtRXJyb3IuaDogQWRkIGFuIGFyZ3VtZW50IGZvciBwYXNzaW5nIGVycm9yIGRlc2Ny aXB0aW9uLgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtRXJyb3I6OlNvY2tldFN0cmVh bUVycm9yKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtSGFu ZGxlU291cC5jcHA6IEFkZCBlcnJvciBkZXNjcmlwdGlvbiBmb3IgU29ja2V0U3RyZWFtRXJyb3Iu CisgICAgICAgIChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OmNvbm5lY3RlZCk6CisgICAg ICAgIChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OnJlYWRCeXRlcyk6CisgICAgICAgIChX ZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OnBsYXRmb3JtU2VuZCk6CisgICAgICAgIChXZWJD b3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OnBsYXRmb3JtQ2xvc2UpOgorCiAyMDExLTEyLTA2ICBE YXZpZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt XSBJbXBsZW1lbnQgdGlsZS1zaXplZCBwYWludGluZyB1c2luZyBTa1BpY3R1cmUuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtRXJy b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1F cnJvci5oCmluZGV4IGY5NjQxYWQzMzBkYzQzMzNjZTM3NmJjNjM0NGU4M2I2ZGZlYmE0MWYuLmFh NGE3ODllMGNiYjE5MjAwY2JjM2FhNzE4NDIzZDM3NzJhYjg5YmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1FcnJvci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1FcnJvci5o CkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiAg QWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOSwgMjAxMSBHb29nbGUg SW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cyBhcmUKQEAgLTM4LDggKzM4LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNzIFNv Y2tldFN0cmVhbUVycm9yIDogcHVibGljIFNvY2tldFN0cmVhbUVycm9yQmFzZSB7CiAgICAgcHVi bGljOgogICAgICAgICBTb2NrZXRTdHJlYW1FcnJvcigpIHsgfQotICAgICAgICBleHBsaWNpdCBT b2NrZXRTdHJlYW1FcnJvcihpbnQgZXJyb3JDb2RlKQotICAgICAgICAgICAgOiBTb2NrZXRTdHJl YW1FcnJvckJhc2UoZXJyb3JDb2RlKQorICAgICAgICBleHBsaWNpdCBTb2NrZXRTdHJlYW1FcnJv cihpbnQgZXJyb3JDb2RlLCBjb25zdCBnY2hhciogZGVzY3JpcHRpb24pCisgICAgICAgICAgICA6 IFNvY2tldFN0cmVhbUVycm9yQmFzZShlcnJvckNvZGUsIFN0cmluZygpLCBTdHJpbmcoZGVzY3Jp cHRpb24pKQogICAgICAgICB7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVhbUhhbmRsZVNvdXAuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVhbUhhbmRsZVNvdXAu Y3BwCmluZGV4IDUzOGYzYWNhNDA0NTYwNmE5MDY4ZmFmMzMzZDMxOTZhZDgwNDVjMjkuLjI5MjQ3 YzNmOTI3NDQxOGZhODNhODU2MmJlYTJlYmI1YzA0NDNmMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGVTb3VwLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtSGFu ZGxlU291cC5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5IEdv b2dsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA5LCAy MDExIEdvb2dsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAog ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zIGFyZQpAQCAtMTAyLDcgKzEwMiw3IEBAIFNvY2tldFN0cmVhbUhhbmRsZTo6 flNvY2tldFN0cmVhbUhhbmRsZSgpCiB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6Y29ubmVjdGVk KEdTb2NrZXRDb25uZWN0aW9uKiBzb2NrZXRDb25uZWN0aW9uLCBHRXJyb3IqIGVycm9yKQogewog ICAgIGlmIChlcnJvcikgewotICAgICAgICBtX2NsaWVudC0+ZGlkRmFpbFNvY2tldFN0cmVhbSh0 aGlzLCBTb2NrZXRTdHJlYW1FcnJvcihlcnJvci0+Y29kZSkpOworICAgICAgICBtX2NsaWVudC0+ ZGlkRmFpbFNvY2tldFN0cmVhbSh0aGlzLCBTb2NrZXRTdHJlYW1FcnJvcihlcnJvci0+Y29kZSwg ZXJyb3ItPm1lc3NhZ2UpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMTI1LDcgKzEy NSw3IEBAIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjpjb25uZWN0ZWQoR1NvY2tldENvbm5lY3Rp b24qIHNvY2tldENvbm5lY3Rpb24sIEdFcnJvcioKIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjpy ZWFkQnl0ZXMoc2lnbmVkIGxvbmcgYnl0ZXNSZWFkLCBHRXJyb3IqIGVycm9yKQogewogICAgIGlm IChlcnJvcikgewotICAgICAgICBtX2NsaWVudC0+ZGlkRmFpbFNvY2tldFN0cmVhbSh0aGlzLCBT b2NrZXRTdHJlYW1FcnJvcihlcnJvci0+Y29kZSkpOworICAgICAgICBtX2NsaWVudC0+ZGlkRmFp bFNvY2tldFN0cmVhbSh0aGlzLCBTb2NrZXRTdHJlYW1FcnJvcihlcnJvci0+Y29kZSwgZXJyb3It Pm1lc3NhZ2UpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMTU1LDE1ICsxNTUsMTMg QEAgdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGU6OndyaXRlUmVhZHkoKQogCiBpbnQgU29ja2V0U3Ry ZWFtSGFuZGxlOjpwbGF0Zm9ybVNlbmQoY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKIHsK LSAgICBpZiAoIWdfcG9sbGFibGVfb3V0cHV0X3N0cmVhbV9pc193cml0YWJsZShtX291dHB1dFN0 cmVhbS5nZXQoKSkpIHsKLSAgICAgICAgYmVnaW5XYWl0aW5nRm9yU29ja2V0V3JpdGFiaWxpdHko KTsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQotCiAgICAgR093blB0cjxHRXJyb3I+IGVycm9y OwogICAgIGdzc2l6ZSB3cml0dGVuID0gZ19wb2xsYWJsZV9vdXRwdXRfc3RyZWFtX3dyaXRlX25v bmJsb2NraW5nKG1fb3V0cHV0U3RyZWFtLmdldCgpLCBkYXRhLCBsZW5ndGgsIDAsICZlcnJvci5v dXRQdHIoKSk7Ci0gICAgaWYgKGVycm9yICYmICFnX2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCks IEdfSU9fRVJST1IsIEdfSU9fRVJST1JfV09VTERfQkxPQ0spKSB7Ci0gICAgICAgIG1fY2xpZW50 LT5kaWRGYWlsU29ja2V0U3RyZWFtKHRoaXMsIFNvY2tldFN0cmVhbUVycm9yKGVycm9yLT5jb2Rl KSk7IC8vIEZJWE1FOiBQcm92aWRlIGEgc2Vuc2libGUgZXJyb3IuCisgICAgaWYgKGVycm9yKSB7 CisgICAgICAgIGlmIChnX2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIEdfSU9fRVJST1IsIEdf SU9fRVJST1JfV09VTERfQkxPQ0spKQorICAgICAgICAgICAgYmVnaW5XYWl0aW5nRm9yU29ja2V0 V3JpdGFiaWxpdHkoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbV9jbGllbnQtPmRpZEZh aWxTb2NrZXRTdHJlYW0odGhpcywgU29ja2V0U3RyZWFtRXJyb3IoZXJyb3ItPmNvZGUsIGVycm9y LT5tZXNzYWdlKSk7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIApAQCAtMTg1LDcgKzE4Myw3 IEBAIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjpwbGF0Zm9ybUNsb3NlKCkKICAgICAgICAgR093 blB0cjxHRXJyb3I+IGVycm9yOwogICAgICAgICBnX2lvX3N0cmVhbV9jbG9zZShHX0lPX1NUUkVB TShtX3NvY2tldENvbm5lY3Rpb24uZ2V0KCkpLCAwLCAmZXJyb3Iub3V0UHRyKCkpOwogICAgICAg ICBpZiAoZXJyb3IpCi0gICAgICAgICAgICBtX2NsaWVudC0+ZGlkRmFpbFNvY2tldFN0cmVhbSh0 aGlzLCBTb2NrZXRTdHJlYW1FcnJvcihlcnJvci0+Y29kZSkpOyAvLyBGSVhNRTogUHJvdmlkZSBh IHNlbnNpYmxlIGVycm9yLgorICAgICAgICAgICAgbV9jbGllbnQtPmRpZEZhaWxTb2NrZXRTdHJl YW0odGhpcywgU29ja2V0U3RyZWFtRXJyb3IoZXJyb3ItPmNvZGUsIGVycm9yLT5tZXNzYWdlKSk7 CiAgICAgICAgIG1fc29ja2V0Q29ubmVjdGlvbiA9IDA7CiAgICAgfQogCg==