74064 2011-12-08 01:22:19 -0800 [GTK] Change default WebSocket protocol to the latest one 2011-12-20 05:17:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 yutak yutak gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 517249 0 yutak 2011-12-08 01:22:19 -0800 [This is the GTK version of Qt's bug 73630 and I'm lazy enough to copy and paste the bug description] Currently, WebKitGtk only supports the old WebSocket protocol (hixie-76). The old protocol is known to have a security defect, and should be phased out into the new protocol. The new protocol (hybi-17, which is going to be published as RFC6455 soon) is already implemented in WebCore and we can switch to the new protocol using WebCore::Settings. LayoutTests for hybi-17 are running fine on GTK bots, and there is no substantial problem observed. Hence, to migrate to the new version, we essentially just need to switch the default value of a Settings flag. Folks, are you happy with this change? Should I bring up this topic on webkit-gtk list? (Note: the old protocol and the new one are incompatible; if there's any existing service depending on the old protocol, it will break.) 518552 1 mrobinson 2011-12-09 14:54:38 -0800 Hrm. Unfortunately, this would be an API break. :( In this case it might be useful to make an exception though. 518557 2 mrobinson 2011-12-09 14:58:48 -0800 CCing some other people, because this situation might be one in which breaking the API is a reasonable consideration. The old default is both insecure and incompatible. 518796 3 xan.lopez 2011-12-10 08:06:50 -0800 I think the right thing to do here is switch and add a comment in NEWS/release notes. The sooner the better. 519092 4 gustavo 2011-12-12 03:08:58 -0800 Agreed! 523847 5 119850 yutak 2011-12-19 05:19:23 -0800 Created attachment 119850 Patch 524484 6 yutak 2011-12-20 01:44:39 -0800 Thanks, I'm going to put the patch into CQ. 524544 7 119850 webkit.review.bot 2011-12-20 05:17:35 -0800 Comment on attachment 119850 Patch Clearing flags on attachment: 119850 Committed r103321: <http://trac.webkit.org/changeset/103321> 524545 8 webkit.review.bot 2011-12-20 05:17:39 -0800 All reviewed patches have been landed. Closing bug. 119850 2011-12-19 05:19:23 -0800 2011-12-20 05:17:35 -0800 Patch bug-74064-20111219221921.patch text/plain 1440 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZTE3NjAyNmM4 NWY4OGMxZDJiNzU0M2RlNmY1MTNjYzU3NTUwMmIyYS4uZTUyNDlmOTI0Nzg0OGI3YWQ2MmMyYzUz ZTcwMWI1OWEwZjBjMDZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEx LTEyLTE5ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtH VEtdIENoYW5nZSBkZWZhdWx0IFdlYlNvY2tldCBwcm90b2NvbCB0byB0aGUgbGF0ZXN0IG9uZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQwNjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld191cGRhdGVfc2V0dGlu Z3MpOgorICAgICAgICBVc2UgaHliaSBXZWJTb2NrZXQgcHJvdG9jb2wgYnkgZGVmYXVsdC4KKwog MjAxMS0xMi0xNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW5hbWUgcmVnaXN0ZXJDb21tYW5kRm9yKFVuZG98UmVkbykgdG8gcmVnaXN0ZXIoVW5kb3xSZWRv KVN0ZXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCA1 ZTNmMGJlMjQ1MmViMTM4Y2ZmZWM2NmNkOTVjYmNlOGNiZTZhYjNhLi44OTVkZTkyODViZjBmMDJk NmY2NDZkYTYwZmU5NTQxZDFlNGFiMGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwCkBAIC0zMTIyLDYgKzMxMjIsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIGNv cmVTZXR0aW5ncy0+c2V0V2ViQXVkaW9FbmFibGVkKHNldHRpbmdzUHJpdmF0ZS0+ZW5hYmxlV2Vi QXVkaW8pOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoV0VCX1NPQ0tFVFMpCisgICAgY29yZVNldHRp bmdzLT5zZXRVc2VIaXhpZTc2V2ViU29ja2V0UHJvdG9jb2woZmFsc2UpOworI2VuZGlmCisKICAg ICBpZiAoUGFnZSogcGFnZSA9IGNvcmUod2ViVmlldykpCiAgICAgICAgIHBhZ2UtPnNldFRhYktl eUN5Y2xlc1Rocm91Z2hFbGVtZW50cyhzZXR0aW5nc1ByaXZhdGUtPnRhYktleUN5Y2xlc1Rocm91 Z2hFbGVtZW50cyk7CiAK