74058 2011-12-07 23:11:06 -0800 [Qt] [WK2] Directly composited images don't render 2011-12-08 08:17:15 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned hausmann noam webkit.review.bot oldest_to_newest 517206 0 ostap73 2011-12-07 23:11:06 -0800 Load LayoutTests/compositing/direct-image-compositing.html in MiniBrowser. All images that should be directly composited are not visible. 517212 1 ostap73 2011-12-07 23:25:01 -0800 Images do not attach to WebGraphicsLayer because graphics layer not yet attached to parent and layerTreeTileClient is 0. 517213 2 118337 ostap73 2011-12-07 23:26:37 -0800 Created attachment 118337 Patch 517241 3 hausmann 2011-12-08 00:43:42 -0800 Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid putting the extra logic into syncCompositingStateForThisLayerOnly? 517406 4 noam 2011-12-08 07:34:19 -0800 (In reply to comment #3) > Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid putting the extra logic into syncCompositingStateForThisLayerOnly? syncCompositingStateForThisLayerOnly is where the per-layer synchronization should occur; I'm good with adding that logic there. 517426 5 118337 webkit.review.bot 2011-12-08 08:17:10 -0800 Comment on attachment 118337 Patch Clearing flags on attachment: 118337 Committed r102342: <http://trac.webkit.org/changeset/102342> 517427 6 webkit.review.bot 2011-12-08 08:17:15 -0800 All reviewed patches have been landed. Closing bug. 118337 2011-12-07 23:26:37 -0800 2011-12-08 08:17:09 -0800 Patch direct_composited_fix_02.diff text/plain 3383 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNGVhMmQ2Li5hM2YyOWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTItMDcgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBEaXJlY3RseSBjb21wb3NpdGVk IGltYWdlcyBkb2Vzbid0IHJlbmRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzQwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBdHRhY2ggaW1hZ2UgdG8gV2ViR3JhcGhpY3NMYXllciBldmVuIGlmIGxh eWVyVHJlZVRpbGVDbGllbnQgaXMgbm90IHNldAorICAgICAgICBhbmQgY3JlYXRlL2Fzc2lnbiBy ZW1vdGUgaW1hZ2UgdGlsZXMgbGF0ZXIgZHVyaW5nIHN5bmMuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkdyYXBoaWNzTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V2ViR3JhcGhpY3NMYXllcjo6c2V0Q29udGVudHNOZWVkc0Rpc3BsYXkpOgorICAgICAgICAo V2ViQ29yZTo6V2ViR3JhcGhpY3NMYXllcjo6c2V0Q29udGVudHNUb0ltYWdlKToKKyAgICAgICAg KFdlYkNvcmU6OldlYkdyYXBoaWNzTGF5ZXI6OnN5bmNDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0xh eWVyT25seSk6CisKIDIwMTEtMTItMDUgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5p bmdAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUmVuYW1lIFFRdWlja1dlYlZpZXc6OmNhblN0 b3AgcHJvcGVydHkgdG8ganVzdCBsb2FkaW5nIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJHcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViR3JhcGhpY3NMYXllci5jcHAKaW5k ZXggNjE2MzQ2NS4uNThiZDEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9XZWJHcmFwaGljc0xheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkdyYXBoaWNzTGF5ZXIuY3BwCkBAIC0zMTcs OCArMzE3LDkgQEAgdm9pZCBXZWJHcmFwaGljc0xheWVyOjpyZW1vdmVBbmltYXRpb24oY29uc3Qg U3RyaW5nJiBhbmltYXRpb25OYW1lKQogCiB2b2lkIFdlYkdyYXBoaWNzTGF5ZXI6OnNldENvbnRl bnRzTmVlZHNEaXNwbGF5KCkKIHsKKyAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gbV9pbWFnZTsK ICAgICBzZXRDb250ZW50c1RvSW1hZ2UoMCk7Ci0gICAgc2V0Q29udGVudHNUb0ltYWdlKG1faW1h Z2UuZ2V0KCkpOworICAgIHNldENvbnRlbnRzVG9JbWFnZShpbWFnZS5nZXQoKSk7CiB9CiAKIHZv aWQgV2ViR3JhcGhpY3NMYXllcjo6c2V0Q29udGVudHNUb0ltYWdlKEltYWdlKiBpbWFnZSkKQEAg LTMyNiwxNSArMzI3LDIwIEBAIHZvaWQgV2ViR3JhcGhpY3NMYXllcjo6c2V0Q29udGVudHNUb0lt YWdlKEltYWdlKiBpbWFnZSkKICAgICBpZiAoaW1hZ2UgPT0gbV9pbWFnZSkKICAgICAgICAgcmV0 dXJuOwogICAgIFdlYkxheWVyVHJlZVRpbGVDbGllbnQqIGNsaWVudCA9IGxheWVyVHJlZVRpbGVD bGllbnQoKTsKLSAgICBpZiAoIWNsaWVudCkKLSAgICAgICAgcmV0dXJuOworICAgIGludDY0X3Qg bmV3SUQgPSAwOworICAgIGlmIChjbGllbnQpIHsKKyAgICAgICAgLy8gV2UgYWRvcHQgZmlyc3Qs IGluIGNhc2UgdGhpcyBpcyB0aGUgc2FtZSBmcmFtZSAtIHRoYXQgd2F5IHdlIGF2b2lkIGRlc3Ry b3lpbmcgYW5kIHJlY3JlYXRpbmcgdGhlIGltYWdlLgorICAgICAgICBuZXdJRCA9IGNsaWVudC0+ YWRvcHRJbWFnZUJhY2tpbmdTdG9yZShpbWFnZSk7CisgICAgICAgIGNsaWVudC0+cmVsZWFzZUlt YWdlQmFja2luZ1N0b3JlKG1fbGF5ZXJJbmZvLmltYWdlQmFja2luZ1N0b3JlSUQpOworICAgICAg ICBub3RpZnlDaGFuZ2UoKTsKKyAgICAgICAgaWYgKG1fbGF5ZXJJbmZvLmltYWdlQmFja2luZ1N0 b3JlSUQgJiYgbmV3SUQgPT0gbV9sYXllckluZm8uaW1hZ2VCYWNraW5nU3RvcmVJRCkKKyAgICAg ICAgICAgIHJldHVybjsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBJZiBjbGllbnQgbm90IHNl dCB5ZXQgdGhlcmUgc2hvdWxkIGJlIG5vIGJhY2tpbmcgc3RvcmUgSUQuCisgICAgICAgIEFTU0VS VCghbV9sYXllckluZm8uaW1hZ2VCYWNraW5nU3RvcmVJRCk7CisgICAgICAgIG5vdGlmeUNoYW5n ZSgpOworICAgIH0KIAotICAgIC8vIFdlIGFkb3B0IGZpcnN0LCBpbiBjYXNlIHRoaXMgaXMgdGhl IHNhbWUgZnJhbWUgLSB0aGF0IHdheSB3ZSBhdm9pZCBkZXN0cm95aW5nIGFuZCByZWNyZWF0aW5n IHRoZSBpbWFnZS4KLSAgICBpbnQ2NF90IG5ld0lEID0gY2xpZW50LT5hZG9wdEltYWdlQmFja2lu Z1N0b3JlKGltYWdlKTsKLSAgICBjbGllbnQtPnJlbGVhc2VJbWFnZUJhY2tpbmdTdG9yZShtX2xh eWVySW5mby5pbWFnZUJhY2tpbmdTdG9yZUlEKTsKLSAgICBub3RpZnlDaGFuZ2UoKTsKLSAgICBp ZiAobmV3SUQgPT0gbV9sYXllckluZm8uaW1hZ2VCYWNraW5nU3RvcmVJRCkKLSAgICAgICAgcmV0 dXJuOwogICAgIG1fbGF5ZXJJbmZvLmltYWdlQmFja2luZ1N0b3JlSUQgPSBuZXdJRDsKICAgICBt X2ltYWdlID0gaW1hZ2U7CiAgICAgbV9sYXllckluZm8uaW1hZ2VJc1VwZGF0ZWQgPSB0cnVlOwpA QCAtNDIxLDYgKzQyNyw5IEBAIHZvaWQgV2ViR3JhcGhpY3NMYXllcjo6c3luY0NvbXBvc2l0aW5n U3RhdGVGb3JUaGlzTGF5ZXJPbmx5KCkKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNoaWxk cmVuKCkuc2l6ZSgpOyArK2kpCiAgICAgICAgIG1fbGF5ZXJJbmZvLmNoaWxkcmVuLmFwcGVuZCh0 b1dlYkxheWVySUQoY2hpbGRyZW4oKVtpXSkpOwogCisgICAgaWYgKG1fbGF5ZXJJbmZvLmltYWdl SXNVcGRhdGVkICYmIG1faW1hZ2UgJiYgIW1fbGF5ZXJJbmZvLmltYWdlQmFja2luZ1N0b3JlSUQp CisgICAgICAgIG1fbGF5ZXJJbmZvLmltYWdlQmFja2luZ1N0b3JlSUQgPSBsYXllclRyZWVUaWxl Q2xpZW50KCktPmFkb3B0SW1hZ2VCYWNraW5nU3RvcmUobV9pbWFnZS5nZXQoKSk7CisKICAgICBt X2xheWVyVHJlZVRpbGVDbGllbnQtPmRpZFN5bmNDb21wb3NpdGluZ1N0YXRlRm9yTGF5ZXIobV9s YXllckluZm8pOwogICAgIG1fbW9kaWZpZWQgPSBmYWxzZTsKICAgICBtX2xheWVySW5mby5pbWFn ZUlzVXBkYXRlZCA9IGZhbHNlOwo=