74039 2011-12-07 16:47:19 -0800 chromium win test bots can get stuck 2012-05-08 14:32:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth dpranke eric maruel simonjam tony oldest_to_newest 516995 0 dpranke 2011-12-07 16:47:19 -0800 It appears there are cases where the Chromium win test bots can get stuck or wedged still (see, e.g.: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/9519/steps/webkit_tests/logs/stdio). This can be very disruptive to gardeners and others watching the bots. What seems to be happening is that DRT crashes, but instead of exiting, a dialog gets displayed on the bot. Because the chromium port-specific implementation on the Port class relies on DRT to enforce the timeout and exit, the worker thread in NRWT hangs indefinitely instead of timing out. We should fix this :) At one point we also had code to detect when these threads were wedged, but that was removed (in r90207). We should consider restoring that code, perhaps just temporarily, if fixing this properly turns out to be hard. 516997 1 tony 2011-12-07 16:51:43 -0800 What is in the dialog? Where did it come from? 517003 2 dpranke 2011-12-07 17:01:33 -0800 The dialog said something like "DumpRenderTree.exe has stopped working". I'm not sure what the source of the dialog was (it wasn't the regular windows debugger dialog). 517076 3 tony 2011-12-07 18:26:02 -0800 I thought we disabled the visual studio debugger dialog on our windows bots. 517080 4 tony 2011-12-07 18:27:08 -0800 Looks like bev fixed it on that bot: http://code.google.com/p/chromium/issues/detail?id=106799 517098 5 dpranke 2011-12-07 18:53:28 -0800 yeah, it's still broken on that bot. Regardless of the state of the chromium bots, we still need to fix these tests so that the chromium run_test() call implements the timeout properly. 618810 6 dpranke 2012-05-08 14:32:23 -0700 this was fixed with the change to using "DRT mode" in NRWT/test-shell in r115903.