74031 2011-12-07 15:59:34 -0800 fix build-webkit --chromium after breakage in r102201 2011-12-08 06:51:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke haraken webkit.review.bot oldest_to_newest 516958 0 dpranke 2011-12-07 15:59:34 -0800 fix build-webkit --chromium after breakage in r102201 516961 1 118285 dpranke 2011-12-07 16:01:55 -0800 Created attachment 118285 Patch 516964 2 118285 tony 2011-12-07 16:02:49 -0800 Comment on attachment 118285 Patch It would be nice to add a reason for the breakage here and what the fix is. 516966 3 dpranke 2011-12-07 16:04:50 -0800 done. 516970 4 dpranke 2011-12-07 16:12:57 -0800 Committed r102280: <http://trac.webkit.org/changeset/102280> 517313 5 haraken 2011-12-08 05:05:12 -0800 Reverted r102280 for reason: Chromium/Windows build is broken Committed r102332: <http://trac.webkit.org/changeset/102332> 517337 6 haraken 2011-12-08 05:40:34 -0800 (In reply to comment #5) > Reverted r102280 for reason: > > Chromium/Windows build is broken > > Committed r102332: <http://trac.webkit.org/changeset/102332> I am sorry. I first thought that this patch caused Chromium/Windows build failure, but actually it was innocent. I cq+ed again. 517379 7 118285 webkit.review.bot 2011-12-08 06:51:11 -0800 Comment on attachment 118285 Patch Clearing flags on attachment: 118285 Committed r102335: <http://trac.webkit.org/changeset/102335> 517380 8 webkit.review.bot 2011-12-08 06:51:16 -0800 All reviewed patches have been landed. Closing bug. 118285 2011-12-07 16:01:55 -0800 2011-12-08 06:51:11 -0800 Patch bug-74031-20111207160153.patch text/plain 1824 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMjA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE0MGEyN2JkZmQ5YmIyOTEwZWMzNTgxZGQ5M2JkZDRm MDllMmEyYy4uMzI1OGRhY2ZmNmMyZWRiNzY5OTQ1MWRjZjkwYzIxMzdmZjllMjE0YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTEyLTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIGZpeCBidWlsZC13ZWJraXQgLS1jaHJvbWl1bSBhZnRlciBicmVha2FnZSBpbiByMTAy MjAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDAz MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDaHJvbWl1bSk6CisKIDIwMTEtMTIt MDYgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgYmluYXJp ZXMgaW4gd2Via2l0Lmd5cCBzaG91bGQgYmUgc3BsaXQgaW50byBhIG5ldyBmaWxlIHRvIGJyZWFr IGNpcmN1bGFyIGRlcGVuZGVuY2llcyBvbiB3ZWJraXRfc3VwcG9ydApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmlu ZGV4IDhjZWQ0ZjNjOTNmYjE5ZjdkODk5ZGYzZGViZjhiMzYyZTc2YzhjNmQuLmNhNDQ2NmQyYTA5 ZWZmNDkxODIzNGI2OWQ3MWRjN2UxNTA1Mzg1ZTMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIwODEs MTAgKzIwODEsMTAgQEAgc3ViIGJ1aWxkQ2hyb21pdW0oJEApCiAgICAgbXkgJHJlc3VsdCA9IDE7 CiAgICAgaWYgKGlzRGFyd2luKCkgJiYgIWlzQ2hyb21pdW1BbmRyb2lkKCkgJiYgIWlzQ2hyb21p dW1NYWNNYWtlKCkpIHsKICAgICAgICAgIyBNYWMgYnVpbGQgLSBidWlsZHMgdGhlIHJvb3QgeGNv ZGUgcHJvamVjdC4KLSAgICAgICAgJHJlc3VsdCA9IGJ1aWxkWENvZGVQcm9qZWN0KCJTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL1dlYktpdCIsICRjbGVhbiwgIi1jb25maWd1cmF0aW9uIiwgY29uZmln dXJhdGlvbigpLCBAb3B0aW9ucyk7CisgICAgICAgICRyZXN1bHQgPSBidWlsZFhDb2RlUHJvamVj dCgiU291cmNlL1dlYktpdC9jaHJvbWl1bS9BbGwiLCAkY2xlYW4sICItY29uZmlndXJhdGlvbiIs IGNvbmZpZ3VyYXRpb24oKSwgQG9wdGlvbnMpOwogICAgIH0gZWxzaWYgKGlzQ3lnd2luKCkgfHwg aXNXaW5kb3dzKCkpIHsKICAgICAgICAgIyBXaW5kb3dzIGJ1aWxkIC0gYnVpbGRzIHRoZSByb290 IHZpc3VhbCBzdHVkaW8gc29sdXRpb24uCi0gICAgICAgICRyZXN1bHQgPSBidWlsZENocm9taXVt VmlzdWFsU3R1ZGlvUHJvamVjdCgiU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuc2xuIiwg JGNsZWFuKTsKKyAgICAgICAgJHJlc3VsdCA9IGJ1aWxkQ2hyb21pdW1WaXN1YWxTdHVkaW9Qcm9q ZWN0KCJTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0FsbC5zbG4iLCAkY2xlYW4pOwogICAgIH0gZWxz aWYgKGlzTGludXgoKSB8fCBpc0Nocm9taXVtQW5kcm9pZCgpIHx8IGlzQ2hyb21pdW1NYWNNYWtl KSB7CiAgICAgICAgICMgTGludXggYnVpbGQgLSBidWlsZCB1c2luZyBtYWtlLgogICAgICAgICAk cmVzdWx0ID0gYnVpbGRDaHJvbWl1bU1ha2VmaWxlKCJhbGwiLCAkY2xlYW4sIEBvcHRpb25zKTsK