74011 2011-12-07 10:51:55 -0800 ShareableBitmapGtk.cpp has no reason to exist 2011-12-07 10:59:00 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs mrobinson oldest_to_newest 516745 0 kbalazs 2011-12-07 10:51:55 -0800 It has been added as a stub but later ShareableBitmapCairo.cpp has been introduced with the real implementation for Gtk. Let's remove this file. 516747 1 118232 kbalazs 2011-12-07 10:54:47 -0800 Created attachment 118232 Patch 516750 2 118232 kbalazs 2011-12-07 10:58:54 -0800 Comment on attachment 118232 Patch Clearing flags on attachment: 118232 Committed r102251: <http://trac.webkit.org/changeset/102251> 516752 3 kbalazs 2011-12-07 10:59:00 -0800 All reviewed patches have been landed. Closing bug. 118232 2011-12-07 10:54:47 -0800 2011-12-07 10:58:54 -0800 Patch bug-74011-20111207195444.patch text/plain 3276 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWZlOTI3NmQwYjk0MmQy NTEwNTBjYTBmYTkxN2RhZGUzZGVhNmU5OS4uYjVlNzJiMjkyMTM2ZmYyYjNiZTgxNTY0MGUyODUy Y2YzOGRhYjk4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA3ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBTaGFyZWFibGVCaXRt YXBHdGsuY3BwIGhhcyBubyByZWFzb24gdG8gZXhpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0MDExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoaXMgZmlsZSBzaW5jZSB0aGUgcmVhbCBp bXBsZW1lbnRhdGlvbiBpcworICAgICAgICBleGlzdHMgaW4gU2hhcmVhYmxlQml0bWFwQ2Fpcm8u Y3BwLgorCisgICAgICAgICogU2hhcmVkL2d0ay9TaGFyZWFibGVCaXRtYXBHdGsuY3BwOiBSZW1v dmVkLgorCiAyMDExLTEyLTA3ICBNYXJ5IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+ CiAKICAgICAgICAgQ2hhbmdlIGZ1bmN0aW9uIG5hbWUgSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVs c0lmTmVjZXNzYXJ5IHRvIGZvbGxvdyBjb2Rpbmcgc3R5bGUgZ3VpZGVsaW5lCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1NoYXJlYWJsZUJpdG1hcEd0ay5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1NoYXJlYWJsZUJpdG1hcEd0ay5jcHAKZGVsZXRlZCBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IGFhNzk1ZjE5MmVlNzMyY2ZlYzI5MDMwODllZTY4ODYxZTdmN2Qy MmYuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvU291cmNl L1dlYktpdDIvU2hhcmVkL2d0ay9TaGFyZWFibGVCaXRtYXBHdGsuY3BwCisrKyAvZGV2L251bGwK QEAgLTEsNTQgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMCBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCi0gKiBQb3J0aW9ucyBDb3B5cmlnaHQgKGMpIDIwMTAgTW90b3Jv bGEgTW9iaWxpdHksIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKgotICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKLSAqIGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291 cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0 aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotICog Mi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92 ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24gYW5kL29y IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0gKgotICog VEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVU T1JTIGBgQVMgSVMnJwotICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywg SU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBUSEUgSU1QTElFRCBXQVJSQU5USUVT IE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCi0gKiBQVVJQ T1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBD T05UUklCVVRPUlMKLSAqIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lE RU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKLSAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAo SU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GCi0gKiBTVUJTVElU VVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1Ig QlVTSU5FU1MKLSAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVP UlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCi0gKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElU WSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKQotICogQVJJU0lO RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURW SVNFRCBPRgotICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpbmNs dWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJTaGFyZWFibGVCaXRtYXAuaCIKLQotI2luY2x1ZGUg PFdlYkNvcmUvR3JhcGhpY3NDb250ZXh0Lmg+Ci0jaW5jbHVkZSA8V2ViQ29yZS9Ob3RJbXBsZW1l bnRlZC5oPgotCi11c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKLQotbmFtZXNwYWNlIFdlYktpdCB7 Ci0KLVBhc3NPd25QdHI8R3JhcGhpY3NDb250ZXh0PiBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZUdy YXBoaWNzQ29udGV4dCgpCi17Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gMDsK LX0KLQotdm9pZCBTaGFyZWFibGVCaXRtYXA6OnBhaW50KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dCYsIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBkc3RQb2ludCwgY29uc3QgV2ViQ29yZTo6SW50 UmVjdCYgc3JjUmVjdCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi12b2lkIFNoYXJl YWJsZUJpdG1hcDo6cGFpbnQoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0JiwgZmxvYXQgc2NhbGVG YWN0b3IsIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBkc3RQb2ludCwgY29uc3QgV2ViQ29yZTo6 SW50UmVjdCYgc3JjUmVjdCkKLXsKLSAgICAvLyBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NDY2ND4uCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKLX0KLSAgICAg ICAgCi19IC8vIG5hbWVzcGFjZSBXZWJLaXQK