74006 2011-12-07 09:45:38 -0800 ASSERT_UNREACHED() should be ASSERT_NOT_REACHED() on assertion-guidelines.html 2011-12-07 10:24:26 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates webkit.review.bot oldest_to_newest 516682 0 dbates 2011-12-07 09:45:38 -0800 As far as I can tell from looking through history and searching my source tree we've never had a macro called ASSERT_UNREACHED(). Instead, we have ASSERT_NOT_REACHED(). We should update assertion-guidelines.html to reflect this. 516686 1 118223 dbates 2011-12-07 09:53:23 -0800 Created attachment 118223 Patch 516716 2 118223 webkit.review.bot 2011-12-07 10:24:22 -0800 Comment on attachment 118223 Patch Clearing flags on attachment: 118223 Committed r102248: <http://trac.webkit.org/changeset/102248> 516717 3 webkit.review.bot 2011-12-07 10:24:26 -0800 All reviewed patches have been landed. Closing bug. 118223 2011-12-07 09:53:23 -0800 2011-12-07 10:24:22 -0800 Patch bug-74006-20111207125320.patch text/plain 1660 dbates SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDIyNDMpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEx LTEyLTA3ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KKworICAgICAgICBBU1NF UlRfVU5SRUFDSEVEKCkgc2hvdWxkIGJlIEFTU0VSVF9OT1RfUkVBQ0hFRCgpIG9uIGFzc2VydGlv bi1ndWlkZWxpbmVzLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc0MDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXMgZmFyIEkgY2FuIHRlbGwsIHdlJ3ZlIG5ldmVyIGhhZCBhbiBBU1NFUlRfVU5S RUFDSEVEKCkuIFdlIGRvIGhhdmUgYW4KKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCkuCisK KyAgICAgICAgKiBjb2RpbmcvYXNzZXJ0aW9uLWd1aWRlbGluZXMuaHRtbDoKKwogMjAxMS0xMS0z MCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBjb21taXQtcmV2 aWV3LXBvbGljeS5odG1sIHNob3VsZCBtYWtlIGNsZWFyIGNvbW1pdHRlcnMgc2hvdWxkbid0IGxh bmQgcGF0Y2hlcyB3aXRob3V0IGF1dGhvcnMnIGNvbnNlbnQKSW5kZXg6IFdlYnNpdGVzL3dlYmtp dC5vcmcvY29kaW5nL2Fzc2VydGlvbi1ndWlkZWxpbmVzLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi c2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvYXNzZXJ0aW9uLWd1aWRlbGluZXMuaHRtbAkocmV2aXNp b24gMTAxNzQwKQorKysgV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvYXNzZXJ0aW9uLWd1aWRl bGluZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzcsMTMgKzM3LDEzIEBACiA8dWw+CiAgIDxs aT5BU1NFUlQoZXhwcmVzc2lvbikgLSBmb3IgdXNlIGR1cmluZyBkZXZlbG9wbWVudCB0byBlbnN1 cmUgdGhhdCB1bmV4cGVjdGVkIGNvbmRpdGlvbnMgZG8gbm90IG9jY3VyLiBJZiB0aGUgZXhwcmVz c2lvbiBldmFsdWF0ZXMgdG8gZmFsc2UgdGhlbiBhYm9ydCBleGVjdXRpb24gYW5kIGJyZWFrIGlu dG8gdGhlIGRlYnVnZ2VyLgogICA8L2xpPgotICA8bGk+QVNTRVJUX1VOUkVBQ0hFRCgpIC0gZm9y IHVzZSB3aGVuIGEgY2VydGFpbiBicmFuY2ggb2YgY29kZSBzaG91bGQgbmV2ZXIgYmUgZXhlY3V0 ZWQuCisgIDxsaT5BU1NFUlRfTk9UX1JFQUNIRUQoKSAtIGZvciB1c2Ugd2hlbiBhIGNlcnRhaW4g YnJhbmNoIG9mIGNvZGUgc2hvdWxkIG5ldmVyIGJlIGV4ZWN1dGVkLgogICAgIDxwcmUgY2xhc3M9 ImNvZGUiPgogaWYgKGNvbmRpdGlvbikgewogICAuLi4KIH0gZWxzZSB7CiAgICAgPHNwYW4gY2xh c3M9ImNvbW1lbnQiPi8vIFRoaXMgc2hvdWxkIG5ldmVyIGhhcHBlbi48L3NwYW4+Ci0gICAgQVNT RVJUX1VOUkVBQ0hFRCgpOworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogPC9wcmU+CiAg IDwvbGk+Cg==