73992 2011-12-07 02:47:11 -0800 [filter-build-webkit] should not emit reset color when --no-color is given 2011-12-21 20:08:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita dbates eric oldest_to_newest 516565 0 morrita 2011-12-07 02:47:11 -0800 filter-build-webkit writes reset color control code even when it --no-color is given. I hope not to emit this because my Emacs cannot handle it well... 516569 1 118195 morrita 2011-12-07 02:53:10 -0800 Created attachment 118195 Patch 516570 2 morrita 2011-12-07 02:55:57 -0800 Hi guys, could you take a look at this small change? 516612 3 118195 dbates 2011-12-07 06:32:56 -0800 Comment on attachment 118195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review OK > Tools/ChangeLog:7 > + You should briefly explain the purpose of this fix and how youR environment is affected without this fix. 517042 4 morrita 2011-12-07 17:57:20 -0800 (In reply to comment #3) > (From update of attachment 118195 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review > > OK > > > Tools/ChangeLog:7 > > + > > You should briefly explain the purpose of this fix and how youR environment is affected without this fix. Thanks! I'll add an explanation before landing. 525944 5 118195 morrita 2011-12-21 20:07:59 -0800 Comment on attachment 118195 Patch Landed by hand. closing and clearing flags. http://trac.webkit.org/changeset/102296 118195 2011-12-07 02:53:10 -0800 2011-12-21 20:07:59 -0800 Patch bug-73992-20111207195309.patch text/plain 1704 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMjI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE0MGEyN2JkZmQ5YmIyOTEwZWMzNTgxZGQ5M2JkZDRm MDllMmEyYy4uMTQxNDdhN2U5YjMyNjkxNzU1MjY1NGJjZjQ5NzYwMjA3ODc1ZDUyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTEyLTA3ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisg ICAgICAgIFtmaWx0ZXItYnVpbGQtd2Via2l0XSBzaG91bGQgbm90IGVtaXQgcmVzZXQgY29sb3Ig d2hlbiAtLW5vLWNvbG9yIGlzIGdpdmVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03Mzk5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0OgorICAgICAgICAo cHJpbnRMaW5lKToKKwogMjAxMS0xMi0wNiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBiaW5hcmllcyBpbiB3ZWJraXQuZ3lwIHNob3VsZCBiZSBzcGxpdCBp bnRvIGEgbmV3IGZpbGUgdG8gYnJlYWsgY2lyY3VsYXIgZGVwZW5kZW5jaWVzIG9uIHdlYmtpdF9z dXBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQgYi9U b29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKaW5kZXggYWE0Y2U3MDRkODA2MjM5Y2E3 MTNmODUzZjgwOTA2NWU5NWQxYjA1OS4uZTM0YjFkNzZhOGRmYzU2YTMzZDA4YzJhODgzYjI5ZDJm MzFlYzljNSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0Cisr KyBiL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdApAQCAtMTc4LDEzICsxNzgsMTUg QEAgc3ViIHByaW50TGluZSgkJCkKICAgICAgICAgZWxzaWYgKCRzdHlsZSA9PSBTVFlMRV9BTEVS VCkgICB7IHByaW50IE9VVFBVVF9IQU5ETEUgIjxwIGNsYXNzPVwiYWxlcnRcIj4kbGluZTwvcD4i OyB9CiAgICAgICAgIGVsc2UgICAgICAgICAgICAgICAgICAgICAgICAgICAgeyBwcmludCBPVVRQ VVRfSEFORExFICI8cD4kbGluZTwvcD4iOyB9CiAgICAgfSBlbHNlIHsKLSAgICAgICAgbXkgJGNv bG9ycyA9ICJyZXNldCI7CiAgICAgICAgIGlmICgkdXNlQ29sb3IpIHsKKyAgICAgICAgICAgIG15 ICRjb2xvcnMgPSAicmVzZXQiOwogICAgICAgICAgICAgaWYgKCRzdHlsZSA9PSBTVFlMRV9IRUFE RVIpICB7ICRjb2xvcnMgPSAiYmx1ZSI7IH0KICAgICAgICAgICAgIGlmICgkc3R5bGUgPT0gU1RZ TEVfU1VDQ0VTUykgeyAkY29sb3JzID0gImdyZWVuIjsgfQogICAgICAgICAgICAgaWYgKCRzdHls ZSA9PSBTVFlMRV9BTEVSVCkgICB7ICRjb2xvcnMgPSAicmVkIjsgfQorICAgICAgICAgICAgcHJp bnQgT1VUUFVUX0hBTkRMRSBwb3NzaWJseUNvbG9yZWQoJGNvbG9ycywgJGxpbmUpOworICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgcHJpbnQgT1VUUFVUX0hBTkRMRSAkbGluZTsKICAgICAg ICAgfQotICAgICAgICBwcmludCBPVVRQVVRfSEFORExFIHBvc3NpYmx5Q29sb3JlZCgkY29sb3Jz LCAkbGluZSk7CiAgICAgfQogICAgIHByaW50IE9VVFBVVF9IQU5ETEUgIlxuIjsKIH0K