<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>73983</bug_id>
          
          <creation_ts>2011-12-06 23:25:55 -0800</creation_ts>
          <short_desc>REGRESSION(r102017): StringBuilder tests are failing</short_desc>
          <delta_ts>2011-12-07 10:19:47 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>73995</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>levin</cc>
    
    <cc>msaboff</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>516509</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-12-06 23:25:55 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/102017/trunk/Source/JavaScriptCore/wtf/text/StringBuilder.cpp

It appears that we should be copying length + 1 to include the null character at the end. Unfortunately, I can&apos;t reproduce this error locally on my Mac.

http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/26827/steps/run-api-tests/logs/stdio

[ RUN      ] StringBuilderTest.Append
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:53: Failure
Value of: String(builder.characters(), builder.length())
  Actual: 0123456789abcd7
Expected: String(expected)
Which is: 0123456789abcdefg
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:53: Failure
Value of: String(builder.characters(), builder.length())
  Actual: 0123456789abcd7
Expected: String(expected)
Which is: 0123456789abcdefg
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:53: Failure
Value of: String(builder.characters(), builder.length())
  Actual: 0123456789abcd7
Expected: String(expected)
Which is: 0123456789abcdefg#
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:53: Failure
Value of: String(builder.characters(), builder.length())
  Actual: 0123456789abcd7
Expected: String(expected)
Which is: 0123456789abcdefg#
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:53: Failure
Value of: String(builder.characters(), builder.length())
  Actual: 0123456789abcdefg#0123456789abcd7
Expected: String(expected)
Which is: 0123456789abcdefg#0123456789abcdefg#XYZ
[  FAILED  ] StringBuilderTest.Append (1 ms)
[----------] 1 test from StringBuilderTest (1 ms total)

[ RUN      ] StringBuilderTest.ToStringPreserveCapacity
Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:153: Failure
Value of: string1
  Actual: 0123456789abcdefghijklmnopqrstuvwxyz
Expected: String(&quot;0123456789abcdefghijklmnopqrstuvwxyzABCDEF&quot;)
Which is: 0123456789abcdefghijklmnopqrstuvwxyzABCDEF
[  FAILED  ] StringBuilderTest.ToStringPreserveCapacity (0 ms)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>516710</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2011-12-07 10:19:47 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 73995 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>