7397 2006-02-20 17:54:39 -0800 TCPageMap.h would not compile for me because string.h was missing 2006-02-21 09:01:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ PC Linux RESOLVED FIXED P2 Normal --- 0 mike.emmel webkit-unassigned oldest_to_newest 33549 0 mike.emmel 2006-02-20 17:54:39 -0800 TCPageMap.h would not compile for me because string.h was missing thus not picking up memset Index: JavaScriptCore/kxmlcore/TCPageMap.h =================================================================== --- JavaScriptCore/kxmlcore/TCPageMap.h (revision 12896) +++ JavaScriptCore/kxmlcore/TCPageMap.h (working copy) @@ -53,6 +53,7 @@ #else #include <sys/types.h> #endif +#include <string.h> #include "kxmlcore/Assertions.h" 33560 1 joost 2006-02-20 22:30:33 -0800 Hi Reporter, i've seen this thread on the mailinglist, but the proper procedure here would be to tell in the summary of the bugreport what is failing for you, and then add the patch to this as an attachment, setting a "review ?" flag on it. I'll do this for you for now :) 33561 2 6636 joost 2006-02-20 22:32:19 -0800 Created attachment 6636 patch As said above. 33570 3 6636 darin 2006-02-20 23:07:08 -0800 Comment on attachment 6636 patch Looks fine, r=me. 6636 2006-02-20 22:32:19 -0800 2006-02-20 23:07:08 -0800 patch include_string.h.patch text/plain 336 joost SW5kZXg6IEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL1RDUGFnZU1hcC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL1RDUGFnZU1hcC5oIChyZXZpc2lvbiAxMjg5NikKKysr IEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL1RDUGFnZU1hcC5oICh3b3JraW5nIGNvcHkpCkBAIC01 Myw2ICs1Myw3IEBACiAjZWxzZQogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgogI2VuZGlmCgorI2lu Y2x1ZGUgPHN0cmluZy5oPgoKICNpbmNsdWRlICJreG1sY29yZS9Bc3NlcnRpb25zLmgi