73958 2011-12-06 15:52:47 -0800 [chromium] Clearing root surface should happen after damage tracking 2011-12-07 18:02:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh backer cc-bugs enne jamesr webkit.review.bot oldest_to_newest 516319 0 shawnsingh 2011-12-06 15:52:47 -0800 There was a minor bug in the scissoring optimization that the root surface clear was happening before the scissor was actually computed. I went ahead cleaned up that code at the same time. No obvious regressions on layout tests on OSX, works fine with manual testing. Jonathan, can you please verify that this patch fixes the partial swap problem on your side before we flag it for official review? (Don't forget to manually remove the usingPartialSwap=false, otherwise it will seem to work without actually doing partial swap) Thanks in advance! 516324 1 118128 shawnsingh 2011-12-06 15:57:50 -0800 Created attachment 118128 Patch 516636 2 backer 2011-12-07 07:37:54 -0800 Fixes the problems that I was having with OSX 10.6 517025 3 118128 jamesr 2011-12-07 17:43:52 -0800 Comment on attachment 118128 Patch OK 517048 4 118128 webkit.review.bot 2011-12-07 18:02:31 -0800 Comment on attachment 118128 Patch Clearing flags on attachment: 118128 Committed r102294: <http://trac.webkit.org/changeset/102294> 517049 5 webkit.review.bot 2011-12-07 18:02:37 -0800 All reviewed patches have been landed. Closing bug. 118128 2011-12-06 15:57:50 -0800 2011-12-07 18:02:31 -0800 Patch bug-73958-20111206155749.patch text/plain 5157 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWE2ZDMyODcxYzJjZTVi NmMzYTJkNjM3NjQ1YWJjZDJlMDNmMzAxZi4uNTQxZjAyNzA3ZTc0YTU5OTI4N2UxODQ3ODc3MGJk M2FjOWZjMTA3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA2ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Q2xlYXJpbmcgcm9vdCBzdXJmYWNlIHNob3VsZCBoYXBwZW4gYWZ0ZXIgZGFtYWdlIHRyYWNraW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mzk1OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyBz ZW1hbnRpY3MsIGNvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0IHRlc3RzLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6Y2xlYXJTdXJmYWNlRm9yRGVi dWcpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJz T250b1JlbmRlclN1cmZhY2VzKToKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJv bWl1bTo6ZHJhd0xheWVyc0ludGVybmFsKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uaDoKKwogMjAxMS0xMi0wNiAgSmFycmVkIE5p Y2hvbGxzICA8amFycmVkQHNlbmNoYS5jb20+CiAKICAgICAgICAgZ2V0Q29tcHV0ZWRTdHlsZSBy ZXR1cm5zIHdyb25nIHZhbHVlIGZvciBtYXJnaW4tKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJD aHJvbWl1bS5jcHAKaW5kZXggZjczZDc3YzdjOWU0YzA3Njc5OTg5OTgxYjhmNmM5MTI0MWJlYmNk MS4uYjdhNmQzMDYwYzYxNTZiYTljODUzZTZmMDJjZjkzNTMxZjM1OGVjZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNo cm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC0zNjUsNiArMzY1LDI4IEBAIHZvaWQgTGF5 ZXJSZW5kZXJlckNocm9taXVtOjp0cmFja0RhbWFnZUZvckFsbFN1cmZhY2VzKENDTGF5ZXJJbXBs KiByb290RHJhd0xheWVyCiAgICAgfQogfQogCit2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6 Y2xlYXJTdXJmYWNlRm9yRGVidWcoQ0NMYXllckltcGwqIHJlbmRlclN1cmZhY2VMYXllciwgQ0NM YXllckltcGwqIHJvb3REcmF3TGF5ZXIsIGNvbnN0IEZsb2F0UmVjdCYgc3VyZmFjZURhbWFnZVJl Y3QpCit7CisgICAgLy8gTm9uLXJvb3QgbGF5ZXJzIHNob3VsZCBjbGVhciB0aGVpciBlbnRpcmUg Y29udGVudHMgdG8gdHJhbnNwYXJlbnQuIFRoZSByb290IGxheWVyCisgICAgLy8gaXMgY2xlYXJl ZCB0byBibHVlIHRvIGVhc2lseSBzZWUgcmVnaW9ucyB0aGF0IHdlcmUgbm90IGRyYXduIG9uIHRo ZSBzY3JlZW4uIElmIHdlCisgICAgLy8gYXJlIHVzaW5nIHBhcnRpYWwgc3dhcCAvIHNjaXNzb3Ig b3B0aW1pemF0aW9uLCB0aGVuIHRoZSBzdXJmYWNlIHNob3VsZCBvbmx5CisgICAgLy8gY2xlYXIg dGhlIGRhbWFnZWQgcmVnaW9uLCBzbyB0aGF0IHdlIGRvbid0IGFjY2lkZW50YWxseSBjbGVhciB1 bi1jaGFuZ2VkIHBvcnRpb25zCisgICAgLy8gb2YgdGhlIHNjcmVlbi4KKworICAgIGlmIChyZW5k ZXJTdXJmYWNlTGF5ZXIgIT0gcm9vdERyYXdMYXllcikKKyAgICAgICAgR0xDKG1fY29udGV4dC5n ZXQoKSwgbV9jb250ZXh0LT5jbGVhckNvbG9yKDAsIDAsIDAsIDApKTsKKyAgICBlbHNlCisgICAg ICAgIEdMQyhtX2NvbnRleHQuZ2V0KCksIG1fY29udGV4dC0+Y2xlYXJDb2xvcigwLCAwLCAxLCAx KSk7CisKKyAgICBpZiAobV9jYXBhYmlsaXRpZXMudXNpbmdQYXJ0aWFsU3dhcCkKKyAgICAgICAg c2V0U2Npc3NvclRvUmVjdChlbmNsb3NpbmdJbnRSZWN0KHN1cmZhY2VEYW1hZ2VSZWN0KSk7Cisg ICAgZWxzZQorICAgICAgICBHTEMobV9jb250ZXh0LmdldCgpLCBtX2NvbnRleHQtPmRpc2FibGUo R3JhcGhpY3NDb250ZXh0M0Q6OlNDSVNTT1JfVEVTVCkpOworCisgICAgbV9jb250ZXh0LT5jbGVh cihHcmFwaGljc0NvbnRleHQzRDo6Q09MT1JfQlVGRkVSX0JJVCk7CisgICAgR0xDKG1fY29udGV4 dC5nZXQoKSwgbV9jb250ZXh0LT5lbmFibGUoR3JhcGhpY3NDb250ZXh0M0Q6OlNDSVNTT1JfVEVT VCkpOworfQorCiB2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVyc09udG9SZW5k ZXJTdXJmYWNlcyhDQ0xheWVySW1wbCogcm9vdERyYXdMYXllciwgY29uc3QgQ0NMYXllckxpc3Qm IHJlbmRlclN1cmZhY2VMYXllckxpc3QpCiB7CiAgICAgVFJBQ0VfRVZFTlQoIkxheWVyUmVuZGVy ZXJDaHJvbWl1bTo6ZHJhd0xheWVyc09udG9SZW5kZXJTdXJmYWNlcyIsIHRoaXMsIDApOwpAQCAt Mzk5LDEyICs0MjEsOCBAQCB2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVyc09u dG9SZW5kZXJTdXJmYWNlcyhDQ0xheWVySW1wbCogcm9vdERyYXdMYQogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgaWYgKHJlbmRlclN1cmZhY2VMYXllciAh PSByb290RHJhd0xheWVyKSB7Ci0gICAgICAgICAgICAgICAgaWYgKG1fY2FwYWJpbGl0aWVzLnVz aW5nUGFydGlhbFN3YXApCi0gICAgICAgICAgICAgICAgICAgIHNldFNjaXNzb3JUb1JlY3QoZW5j bG9zaW5nSW50UmVjdChzdXJmYWNlRGFtYWdlUmVjdCkpOwotICAgICAgICAgICAgICAgIEdMQyht X2NvbnRleHQuZ2V0KCksIG1fY29udGV4dC0+Y2xlYXJDb2xvcigwLCAwLCAwLCAwKSk7Ci0gICAg ICAgICAgICAgICAgR0xDKG1fY29udGV4dC5nZXQoKSwgbV9jb250ZXh0LT5jbGVhcihHcmFwaGlj c0NvbnRleHQzRDo6Q09MT1JfQlVGRkVSX0JJVCkpOwotICAgICAgICAgICAgfQorICAgICAgICAg ICAgLy8gRklYTUU6IGV2ZW50dWFsbHkgd2Ugc2hvdWxkIHBsYWNlIHRoaXMgdW5kZXIgYSBkZWJ1 ZyBmbGFnLgorICAgICAgICAgICAgY2xlYXJTdXJmYWNlRm9yRGVidWcocmVuZGVyU3VyZmFjZUxh eWVyLCByb290RHJhd0xheWVyLCBzdXJmYWNlRGFtYWdlUmVjdCk7CiAKICAgICAgICAgICAgIGNv bnN0IENDTGF5ZXJMaXN0JiBsYXllckxpc3QgPSByZW5kZXJTdXJmYWNlLT5sYXllckxpc3QoKTsK ICAgICAgICAgICAgIGZvciAodW5zaWduZWQgbGF5ZXJJbmRleCA9IDA7IGxheWVySW5kZXggPCBs YXllckxpc3Quc2l6ZSgpOyArK2xheWVySW5kZXgpCkBAIC00NjEsMTYgKzQ3OSw3IEBAIHZvaWQg TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzSW50ZXJuYWwoKQogCiAgICAgR0xDKG1f Y29udGV4dC5nZXQoKSwgbV9jb250ZXh0LT5kaXNhYmxlKEdyYXBoaWNzQ29udGV4dDNEOjpERVBU SF9URVNUKSk7CiAgICAgR0xDKG1fY29udGV4dC5nZXQoKSwgbV9jb250ZXh0LT5kaXNhYmxlKEdy YXBoaWNzQ29udGV4dDNEOjpDVUxMX0ZBQ0UpKTsKLQotICAgIHVzZVJlbmRlclN1cmZhY2UobV9k ZWZhdWx0UmVuZGVyU3VyZmFjZSk7Ci0KLSAgICAvLyBDbGVhciB0byBibHVlIHRvIG1ha2UgaXQg ZWFzaWVyIHRvIHNwb3QgdW5yZW5kZXJlZCByZWdpb25zLgotICAgIGlmIChtX2NhcGFiaWxpdGll cy51c2luZ1BhcnRpYWxTd2FwKQotICAgICAgICBzZXRTY2lzc29yVG9SZWN0KGVuY2xvc2luZ0lu dFJlY3QobV9yb290RGFtYWdlUmVjdCkpOwotICAgIG1fY29udGV4dC0+Y2xlYXJDb2xvcigwLCAw LCAxLCAxKTsKLSAgICBtX2NvbnRleHQtPmNvbG9yTWFzayh0cnVlLCB0cnVlLCB0cnVlLCB0cnVl KTsKLSAgICBtX2NvbnRleHQtPmNsZWFyKEdyYXBoaWNzQ29udGV4dDNEOjpDT0xPUl9CVUZGRVJf QklUKTsKLQorICAgIEdMQyhtX2NvbnRleHQuZ2V0KCksIG1fY29udGV4dC0+Y29sb3JNYXNrKHRy dWUsIHRydWUsIHRydWUsIHRydWUpKTsKICAgICBHTEMobV9jb250ZXh0LmdldCgpLCBtX2NvbnRl eHQtPmVuYWJsZShHcmFwaGljc0NvbnRleHQzRDo6QkxFTkQpKTsKICAgICBHTEMobV9jb250ZXh0 LmdldCgpLCBtX2NvbnRleHQtPmJsZW5kRnVuYyhHcmFwaGljc0NvbnRleHQzRDo6T05FLCBHcmFw aGljc0NvbnRleHQzRDo6T05FX01JTlVTX1NSQ19BTFBIQSkpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21p dW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVu ZGVyZXJDaHJvbWl1bS5oCmluZGV4IDVjODA2ZDMzYTcwZjBiNWYwZmE3ZWE5MjVjZTU3NjEyMGFh ZmEyNzkuLmZjMmE3YWIxOTY5NmU0MjE3N2U5MmE1MmFhNzRhYTkyYjUyODdmZDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5oCkBAIC0xNzksNiArMTc5LDcgQEAgcHJpdmF0ZToK ICAgICB2b2lkIHJlbGVhc2VSZW5kZXJTdXJmYWNlVGV4dHVyZXMoKTsKIAogICAgIGJvb2wgdXNl UmVuZGVyU3VyZmFjZShDQ1JlbmRlclN1cmZhY2UqKTsKKyAgICB2b2lkIGNsZWFyU3VyZmFjZUZv ckRlYnVnKENDTGF5ZXJJbXBsKiByZW5kZXJTdXJmYWNlTGF5ZXIsIENDTGF5ZXJJbXBsKiByb290 RHJhd0xheWVyLCBjb25zdCBGbG9hdFJlY3QmIHN1cmZhY2VEYW1hZ2VSZWN0KTsKIAogICAgIGJv b2wgbWFrZUNvbnRleHRDdXJyZW50KCk7CiAK