73948 2011-12-06 13:54:25 -0800 [chromium] Scale audio, video tags in MediaDocument to fit in window. 2011-12-28 14:33:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 dalecurtis webkit-unassigned eric.carlson eric jer.noble macpherson rniwa scherkus webkit.review.bot oldest_to_newest 516217 0 dalecurtis 2011-12-06 13:54:25 -0800 [chromium] Scale audio, video tags in MediaDocument to fit in window. 516228 1 118108 dalecurtis 2011-12-06 14:01:37 -0800 Created attachment 118108 Patch 516230 2 dalecurtis 2011-12-06 14:02:53 -0800 Currently audio, video elements in MediaDocument don't scale to fit undersized containers. A painful situation for users wanting to watch high resolution videos without scroll bars. The attached patch fixes this issue by attaching CSS max-height: 100%, max-width: 100% settings to the audio and video tags for Chromium controls. A new layout test is included to verify this behavior. Chromium Issue: http://crbug.com/26848 Chromium CL: http://codereview.chromium.org/8728018/ 516233 3 dalecurtis 2011-12-06 14:04:50 -0800 Since the test is Chromium specific, scherkus suggested I might need to add some lines to the various "Skipped" files for each platform. Is this done automatically? If not, which files should I modify? 517556 4 scherkus 2011-12-08 10:52:48 -0800 this looks good to me -- I'm not sure what to do about the Skipped tests for other platforms perhaps a WebKit reviewer can chime in? 525442 5 118108 eric 2011-12-21 12:09:56 -0800 Comment on attachment 118108 Patch Seems reasonable to me. 525443 6 eric 2011-12-21 12:10:25 -0800 CCing the Apple FullScreen and Media folks just in case they're curious to see this patch go by. 525452 7 118108 eric.carlson 2011-12-21 12:16:01 -0800 Comment on attachment 118108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118108&action=review > LayoutTests/ChangeLog:12 > + * media/video-scales-in-media-document-expected.txt: Added. > + * media/video-scales-in-media-document.html: Added. This new test will fail on all ports that don't include mediaControlsChromium.css. You need to skip the test on every other port. 525467 8 dalecurtis 2011-12-21 12:27:20 -0800 Thanks for the review! @Eric Carlson: Which Skipped files do I need to modify? All of them? Something else? $ WebKit/LayoutTests/platform $ find -name Skipped ./mac/Skipped ./qt-5.0/Skipped ./qt/Skipped ./qt-4.8/Skipped ./gtk-wk2/Skipped ./win-xp/Skipped ./efl/Skipped ./qt-mac/Skipped ./qt-win/Skipped ./qt-linux/Skipped ./mac-leopard/Skipped ./win-wk2/Skipped ./mac-snowleopard/Skipped ./wk2/Skipped ./mac-lion/Skipped ./qt-arm/Skipped ./qt-wk2/Skipped ./wincairo/Skipped ./win/Skipped ./mac-wk2/Skipped ./gtk/Skipped ./qt-wk1/Skipped 525472 9 eric.carlson 2011-12-21 12:33:44 -0800 (In reply to comment #8) > @Eric Carlson: Which Skipped files do I need to modify? All of them? Something else? > Only the the top-level file for ports that don't already skip all media test. I think this means: ./mac/Skipped ./efl/Skipped ./win/Skipped ./gtk/Skipped 525957 10 118108 webkit.review.bot 2011-12-21 20:41:50 -0800 Comment on attachment 118108 Patch Clearing flags on attachment: 118108 Committed r103489: <http://trac.webkit.org/changeset/103489> 525958 11 webkit.review.bot 2011-12-21 20:41:54 -0800 All reviewed patches have been landed. Closing bug. 526943 12 rniwa 2011-12-23 20:11:14 -0800 The test added by this patch is failing on Mac: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r103641%20(35833)/media/video-scales-in-media-document-pretty-diff.html Is this test specific to Chromium? If so, why wasn't it added to LayoutTests/platform/chromium ? 527009 13 dalecurtis 2011-12-24 11:56:13 -0800 @Ryosuke, the test is Chromium specific, I've put up a patch with the appropriate Skipped files here, but no one has approved it yet: https://bugs.webkit.org/show_bug.cgi?id=75079 I'm new at this, so apologies if it's preferred to craft the platform expected files into no-ops for the platforms which can't run the test. 527012 14 rniwa 2011-12-24 12:21:08 -0800 (In reply to comment #13) > @Ryosuke, the test is Chromium specific, I've put up a patch with the appropriate Skipped files here, but no one has approved it yet: > > https://bugs.webkit.org/show_bug.cgi?id=75079 > > I'm new at this, so apologies if it's preferred to craft the platform expected files into no-ops for the platforms which can't run the test. Can we move this test to LayoutTests/platform/chromium/media? It doesn't make much sense to put ths in LayoutTests/media if other ports shouldn't be passing this test. 527772 15 dalecurtis 2011-12-28 14:33:02 -0800 Done. The patch in https://bugs.webkit.org/show_bug.cgi?id=75079 now moves the test into platform/chromium/media. 118108 2011-12-06 14:01:37 -0800 2011-12-21 20:41:50 -0800 Patch bug-73948-20111206140136.patch text/plain 4255 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWE2ZDMyODcxYzJjZTVi NmMzYTJkNjM3NjQ1YWJjZDJlMDNmMzAxZi4uY2UyYzA1ZWU4MDI4MDEyOWI2YWVjMDI5YjJhMTc5 ZTcwZGI0NjhiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA2ICBEYWxl IEN1cnRpcyAgPGRhbGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g U2NhbGUgYXVkaW8sIHZpZGVvIHRhZ3MgaW4gTWVkaWFEb2N1bWVudCB0byBmaXQgaW4gd2luZG93 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5NDgK KworICAgICAgICBBZGQgQ1NTIG1heC1oZWlnaHQ6IDEwMCUsIG1heC13aWR0aDogMTAwJSBzZXR0 aW5ncyB0byB0aGUgYXVkaW8gYW5kCisgICAgICAgIHZpZGVvIHRhZ3Mgd2hlbiBpbiBNZWRpYURv Y3VtZW50cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0OiBtZWRpYS92aWRlby1zY2FsZXMtaW4tbWVkaWEtZG9jdW1lbnQuaHRtbAorCisgICAg ICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3M6CisgICAgICAgIChhdWRpbzotd2Vi a2l0LWZ1bGwtcGFnZS1tZWRpYSwgdmlkZW86LXdlYmtpdC1mdWxsLXBhZ2UtbWVkaWEpOgorCiAy MDExLTEyLTA2ICBKYXJyZWQgTmljaG9sbHMgIDxqYXJyZWRAc2VuY2hhLmNvbT4KIAogICAgICAg ICBnZXRDb21wdXRlZFN0eWxlIHJldHVybnMgd3JvbmcgdmFsdWUgZm9yIG1hcmdpbi0qCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0Nocm9taXVtLmNzcyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3NzCmluZGV4IDFhZWE4N2U4 MGE5ZmJjYmRiMWYyNmJhZDc2NTFjZGE4YTI1MWVhZGMuLmMwYzMzYzM2OWVjODdmODZiMDIxM2Vi YWE1ZmZlNjI0ZDI5Zjg1ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNv bnRyb2xzQ2hyb21pdW0uY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xz Q2hyb21pdW0uY3NzCkBAIC0zMCw2ICszMCwxMSBAQCBhdWRpbyB7CiAgICAgaGVpZ2h0OiAzMnB4 OwogfQogCithdWRpbzotd2Via2l0LWZ1bGwtcGFnZS1tZWRpYSwgdmlkZW86LXdlYmtpdC1mdWxs LXBhZ2UtbWVkaWEgeworICAgIG1heC1oZWlnaHQ6IDEwMCU7CisgICAgbWF4LXdpZHRoOiAxMDAl OworfQorCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCwgdmlkZW86Oi13ZWJr aXQtbWVkaWEtY29udHJvbHMtcGFuZWwgewogICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IG5vbmU7 CiAgICAgcG9zaXRpb246IGFic29sdXRlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY4NDgxMjg0NDIxMDUzNWZiYzY4NDky N2M3NTVhMTYwZjFkY2VhZjcuLjIzZjAwOTAzMjZhZGVkZWIxNmYyZjA2NjE2OGJiNGUyZTYyMGM3 MmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0xMi0wNiAgRGFsZSBDdXJ0aXMgIDxkYWxl Y3VydGlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFNjYWxlIGF1ZGlvLCB2 aWRlbyB0YWdzIGluIE1lZGlhRG9jdW1lbnQgdG8gZml0IGluIHdpbmRvdy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTQ4CisKKyAgICAgICAgQWRk ZWQgbmV3IGxheW91dCB0ZXN0IHRvIHZlcmlmeSBhdWRpbywgdmlkZW8gdGFncyBzY2FsZSB0byBm aXQKKyAgICAgICAgdW5kZXJzaXplZCBjb250YWluZXJzLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdmlkZW8tc2NhbGVzLWluLW1lZGlh LWRvY3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvdmlkZW8tc2Nh bGVzLWluLW1lZGlhLWRvY3VtZW50Lmh0bWw6IEFkZGVkLgorCiAyMDExLTEyLTA2ICBWc2V2b2xv ZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY2hy b21pdW0gdGVzdHMgcmViYXNlbGluZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3Zp ZGVvLXNjYWxlcy1pbi1tZWRpYS1kb2N1bWVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1zY2FsZXMtaW4tbWVkaWEtZG9jdW1lbnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmRmMGVkYjEyYjg0M2Y2MDU1NTUzNDdiZDA2NjBkYTNlN2FmN2NmNzcKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zY2FsZXMtaW4tbWVkaWEtZG9jdW1lbnQt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorVGVzdCB0aGF0IHZpZGVvIG1lZGlhIGRvY3Vt ZW50cyBzY2FsZSB0byBmaXQgdW5kZXJzaXplZCBjb250YWluZXJzLgorCisKK0VYUEVDVEVEICgy MDAgPT0gJzIwMCcpIE9LCitFWFBFQ1RFRCAoMTYzID09ICcxNjMnKSBPSworRU5EIE9GIFRFU1QK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc2NhbGVzLWluLW1lZGlhLWRv Y3VtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zY2FsZXMtaW4tbWVkaWEtZG9j dW1lbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNTliYTI0MTU5ZjU2MGFiYzQ1MTRiYmJjNzIyYmYzNzI0 MGMxN2Y4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc2NhbGVz LWluLW1lZGlhLWRvY3VtZW50Lmh0bWwKQEAgLTAsMCArMSwzMiBAQAorPGh0bWw+CisgICAgPGhl YWQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSJtZWRpYS1maWxlLmpzIj48L3NjcmlwdD4KKyAgICAg ICAgPHNjcmlwdCBzcmM9InZpZGVvLXRlc3QuanMiPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0 PgorICAgICAgICAgICAgZnVuY3Rpb24gY2FuUGxheVRocm91Z2goZXZlbnQpIHsKKyAgICAgICAg ICAgICAgICB2YXIgdmlkZW8gPSBldmVudC50YXJnZXQ7CisgICAgICAgICAgICAgICAgdGVzdEV4 cGVjdGVkKHZpZGVvLm9mZnNldFdpZHRoLCAyMDApOworICAgICAgICAgICAgICAgIHRlc3RFeHBl Y3RlZCh2aWRlby5vZmZzZXRIZWlnaHQsIDE2Myk7CisgICAgICAgICAgICAgICAgZW5kVGVzdCgp OworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBpZnJhbWVMb2FkKCkgewor ICAgICAgICAgICAgICAgIHZhciBpZnJhbWUgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJpZnJh bWUiKTsKKyAgICAgICAgICAgICAgICB2YXIgdmlkZW8gPSBpZnJhbWUuY29udGVudERvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoInZpZGVvIik7CisgICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRM aXN0ZW5lcigiY2FucGxheXRocm91Z2giLCBjYW5QbGF5VGhyb3VnaCk7CisgICAgICAgICAgICAg ICAgdmlkZW8ubG9hZCgpCisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIGxv YWQoKSB7CisgICAgICAgICAgICAgICAgdmFyIGlmcmFtZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoImlmcmFtZSIpOworICAgICAgICAgICAgICAgIGlmcmFtZS5vbmxvYWQgPSBpZnJhbWVMb2Fk OworICAgICAgICAgICAgICAgIGlmcmFtZS5zcmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJj b250ZW50L2NvdW50aW5nIik7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAg IDwvaGVhZD4KKworICAgIDxib2R5IG9ubG9hZD0ibG9hZCgpIj4KKyAgICAgICAgPHA+VGVzdCB0 aGF0IHZpZGVvIG1lZGlhIGRvY3VtZW50cyBzY2FsZSB0byBmaXQgdW5kZXJzaXplZCBjb250YWlu ZXJzLjwvcD4KKyAgICAgICAgPGlmcmFtZSBzdHlsZT0id2lkdGg6IDIwMHB4OyBoZWlnaHQ6IDIw MHB4OyI+PC9pZnJhbWU+CisgICA8L2JvZHk+Cis8L2h0bWw+Cg==