73947 2011-12-06 13:34:52 -0800 GC zapping logic could benefit from some more assertions 2011-12-06 14:13:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 516199 0 fpizlo 2011-12-06 13:34:52 -0800 Patch forthcoming 516201 1 118103 fpizlo 2011-12-06 13:37:01 -0800 Created attachment 118103 the patch 516210 2 118103 barraclough 2011-12-06 13:45:36 -0800 Comment on attachment 118103 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=118103&action=review > Source/JavaScriptCore/heap/MarkedBlock.h:293 > + } This could be: ASSERT(!isZapped(cell) || !m_marks.get(atomNumber(cell))); return !isZapped(cell); 516214 3 webkit.review.bot 2011-12-06 13:51:39 -0800 Attachment 118103 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/heap/MarkedBlock.h:285: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 516240 4 fpizlo 2011-12-06 14:13:11 -0800 Landed in http://trac.webkit.org/changeset/102179 516241 5 118103 fpizlo 2011-12-06 14:13:23 -0800 Comment on attachment 118103 the patch Clearing flags. 118103 2011-12-06 13:37:01 -0800 2011-12-06 14:13:23 -0800 the patch gcassert_patch_1.diff text/plain 2355 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAyMTczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDExLTEyLTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg R0MgemFwcGluZyBsb2dpYyBjb3VsZCBiZW5lZml0IGZyb20gc29tZSBtb3JlIGFzc2VydGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTQ3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICAt IElmIHlvdSdyZSBpbiBhIHphcHBlZCBibG9jayBhbmQgeW91J3JlIHphcHBlZCwgdGhlbiB5b3Vy IG1hcmsgYml0IHNob3VsZAorICAgICAgICAgIG5ldmVyIGJlIHNldC4KKyAgICAgICAgICAKKyAg ICAgICAgLSBJZiB5b3UncmUgYmVpbmcgbWFya2VkLCB0aGVuIHlvdSBzaG91bGQgbmV2ZXIgYmUg emFwcGVkLgorCisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5oOgorICAgICAgICAoSlNDOjpN YXJrZWRCbG9jazo6aXNMaXZlKToKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5oOgorICAg ICAgICAoSlNDOjpNYXJrU3RhY2s6OmludGVybmFsQXBwZW5kKToKKwogMjAxMS0xMi0wNiAgT2xp dmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IGFsbG9jYXRlIHJl Z2lzdGVyIGluIHR5cGVkYXJyYXkgY29udHJvbCBmbG93CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgJKHJldmlzaW9uIDEwMjAzOSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4Miw3ICsy ODIsMTUgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGNhc2UgQWxsb2NhdGVkOgogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIGNhc2UgWmFwcGVkOgotICAgICAgICAgICAgcmV0 dXJuICFpc1phcHBlZChjZWxsKTsKKyAgICAgICAgICAgIGlmIChpc1phcHBlZChjZWxsKSkgewor ICAgICAgICAgICAgICAgIC8vIE9iamVjdCBkZWFkIGluIHByZXZpb3VzIGNvbGxlY3Rpb24sIG5v dCBhbGxvY2F0ZWQgc2luY2UgcHJldmlvdXMgY29sbGVjdGlvbjogbWFyayBiaXQgc2hvdWxkIG5v dCBiZSBzZXQuCisgICAgICAgICAgICAgICAgQVNTRVJUKCFtX21hcmtzLmdldChhdG9tTnVtYmVy KGNlbGwpKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgfSBl bHNlIHsKKyAgICAgICAgICAgICAgICAvLyBOZXdseSBhbGxvY2F0ZWQgb2JqZWN0czogbWFyayBi aXQgbm90IHNldC4KKyAgICAgICAgICAgICAgICAvLyBPYmplY3RzIHRoYXQgc3Vydml2ZWQgcHJp b3IgY29sbGVjdGlvbjogbWFyayBiaXQgc2V0LgorICAgICAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICAgICAgfQogICAgICAgICBjYXNlIE1hcmtlZDoKICAgICAgICAgICAgIHJldHVy biBtX21hcmtzLmdldChhdG9tTnVtYmVyKGNlbGwpKTsKIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgJKHJldmlzaW9uIDEwMjAzOSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNTYs NiArMzU2LDEwIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBtX3Zpc2l0Q291bnQrKzsKICAg ICAgICAgaWYgKEhlYXA6OnRlc3RBbmRTZXRNYXJrZWQoY2VsbCkgfHwgIWNlbGwtPnN0cnVjdHVy ZSgpKQogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAKKyAgICAgICAgLy8gU2hvdWxkIG5l dmVyIGF0dGVtcHQgdG8gbWFyayBzb21ldGhpbmcgdGhhdCBpcyB6YXBwZWQuCisgICAgICAgIEFT U0VSVCghY2VsbC0+aXNaYXBwZWQoKSk7CisgICAgICAgIAogICAgICAgICBtX3N0YWNrLmFwcGVu ZChjZWxsKTsKICAgICB9CiAK