73945 2011-12-06 13:17:27 -0800 JSCustomVoidCallback should also be derived from ActiveDOMCallback 2012-01-05 11:08:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 49401 1 yong.li.webkit webkit-unassigned staikos webkit.review.bot oldest_to_newest 516188 0 yong.li.webkit 2011-12-06 13:17:27 -0800 Bug 40112 and r64537 introduced ActiveDOMCallback which can be suspended & resumed when needed. However it doesn't cover JSCustomVoidCallback which is used by database transaction as success callback. This results in: 1) the callback can be executed when page loading is deferred (for example, when a JS dialog shows up). I've verified this with Google Chrome. 2) the original issue of Bug 40112 could still exist for success callbacks with real(non-null) transactions. I haven't verified that though. My patch for https://bugs.webkit.org/show_bug.cgi?id=49401 was rolled out otherwise 1) wouldn't be an issue. 516202 1 yong.li.webkit 2011-12-06 13:37:11 -0800 Change the tile 516212 2 yong.li.webkit 2011-12-06 13:46:18 -0800 (In reply to comment #0) > Bug 40112 and r64537 introduced ActiveDOMCallback which can be suspended & resumed when needed. > > However it doesn't cover JSCustomVoidCallback which is used by database transaction as success callback. > > This results in: > > 1) the callback can be executed when page loading is deferred (for example, when a JS dialog shows up). I've verified this with Google Chrome. > 2) the original issue of Bug 40112 could still exist for success callbacks with real(non-null) transactions. I haven't verified that though. > > My patch for https://bugs.webkit.org/show_bug.cgi?id=49401 was rolled out otherwise 1) wouldn't be an issue. Ignore 2). seems it shouldn't be a problem 516247 3 118110 yong.li.webkit 2011-12-06 14:20:29 -0800 Created attachment 118110 proposed patch With the patch, the callback event will be discarded when a JS dialog is running. That issue is covered by Bug 49401. 516252 4 webkit.review.bot 2011-12-06 14:24:20 -0800 Attachment 118110 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ManualTests/database-success-callback.html..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/bindings/js/JSCustomVoidCallback.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 516256 5 118110 webkit-ews 2011-12-06 14:31:18 -0800 Comment on attachment 118110 proposed patch Attachment 118110 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10744075 516264 6 118115 yong.li.webkit 2011-12-06 14:38:47 -0800 Created attachment 118115 fix the style 516267 7 webkit.review.bot 2011-12-06 14:41:14 -0800 Attachment 118115 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ManualTests/database-success-callback.html..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 516280 8 118118 yong.li.webkit 2011-12-06 15:01:48 -0800 Created attachment 118118 should be done in this way 516281 9 webkit.review.bot 2011-12-06 15:04:16 -0800 Attachment 118118 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ManualTests/database-success-callback.html..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 516639 10 118210 yong.li.webkit 2011-12-07 07:45:03 -0800 Created attachment 118210 Ready for review 530447 11 yong.li.webkit 2012-01-05 11:08:27 -0800 (In reply to comment #0) > My patch for https://bugs.webkit.org/show_bug.cgi?id=49401 was rolled out otherwise 1) wouldn't be an issue. The patch for https://bugs.webkit.org/show_bug.cgi?id=49401 is landed again, so we no longer need to make JSCustomVoidCallback a ActiveDOMCallback. 118110 2011-12-06 14:20:29 -0800 2011-12-06 14:38:55 -0800 proposed patch 73945.patch text/plain 3377 yong.li.webkit ZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbCBi L01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi40YWUwZTViCi0tLSAvZGV2L251bGwKKysrIGIvTWFudWFs VGVzdHMvZGF0YWJhc2Utc3VjY2Vzcy1jYWxsYmFjay5odG1sCkBAIC0wLDAgKzEsMjQgQEAKKzxi b2R5PgorPHAgaWQ9InJlc3VsdCI+Q2FsbGJhY2sgaGFzbid0IGJlZW4gY2FsbGVkPC9wPgorPHNj cmlwdD4KK3ZhciBzaG93aW5nQWxlcnQ7CisKK2Z1bmN0aW9uIHRyYW5zYWN0aW9uU3VjY2Vzc0Nh bGxiYWNrKCkKK3sKKyAgICBpZiAoc2hvd2luZ0FsZXJ0KQorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkNhbGxiYWNrIHdhcyBjYWxsZWQgd2hp bGUgSlMgZGlhbG9nIHdhcyBvcGVuZWQuIFRlc3QgZmFpbGVkIjsKKyAgICBlbHNlCisgICAgICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAiVGVzdCBwYXNz ZWQiOworfQorCit2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIkRhdGFiYXNlQ2FsbGJhY2tUZXN0Iiwg IjEuMCIsICIiLCAxKTsKK2RiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7IHR4LmV4ZWN1dGVT cWwoIkNSRUFURSBUQUJMRSBJRiBOT1QgRVhJU1RTIENhbGxiYWNrRGVmZXJyZWRUZXN0IChyYW5k b21EYXRhKSIsIFtdKTsgfSwgbnVsbCwgdHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2spOworCitz aG93aW5nQWxlcnQgPSB0cnVlOworCithbGVydCgiV2FpdCBhIGZldyBzZWNvbmRzIGFuZCBjbG9z ZSBtZSIpOworCitzaG93aW5nQWxlcnQgPSBmYWxzZTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjEyYjMyNC4uZGZjMWZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTEyLTA2ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIExldCBKU0N1 c3RvbVZvaWRDYWxsYmFjayBkZXJpdmUgZnJvbSBBY3RpdmVET01DYWxsYmFjaywgYmVjYXVzZQor ICAgICAgICBpdCBiZWxvbmdzIHRvIHRoZSBkb2N1bWVudC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBNYW51YWxUZXN0cy9kYXRhYmFzZS1z dWNjZXNzLWNhbGxiYWNrLmh0bWwuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZv aWRDYWxsYmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0N1c3RvbVZvaWRDYWxsYmFjazo6 SlNDdXN0b21Wb2lkQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6SlNDdXN0b21Wb2lkQ2Fs bGJhY2s6OmhhbmRsZUV2ZW50KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRD YWxsYmFjay5oOgorCiAyMDExLTEyLTAyICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzY4MwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCmlu ZGV4IGY4MzBmNWMuLmZlY2JmMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5jcHAKQEAgLTQxLDcgKzQxLDggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEpTQzsKICAgICAKIEpTQ3VzdG9tVm9pZENhbGxi YWNrOjpKU0N1c3RvbVZvaWRDYWxsYmFjayhKU09iamVjdCogY2FsbGJhY2ssIEpTRE9NR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QpCi0gICAgOiBtX2RhdGEobmV3IEpTQ2FsbGJhY2tEYXRhKGNh bGxiYWNrLCBnbG9iYWxPYmplY3QpKQorICAgIDogQWN0aXZlRE9NQ2FsbGJhY2soZ2xvYmFsT2Jq ZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCisgICAgLCBtX2RhdGEobmV3IEpTQ2FsbGJh Y2tEYXRhKGNhbGxiYWNrLCBnbG9iYWxPYmplY3QpKQogICAgICwgbV9zY3JpcHRFeGVjdXRpb25D b250ZXh0KGdsb2JhbE9iamVjdC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQogewogfQpAQCAt NTksNyArNjAsOCBAQCBKU0N1c3RvbVZvaWRDYWxsYmFjazo6fkpTQ3VzdG9tVm9pZENhbGxiYWNr KCkKICAgICAKIHZvaWQgSlNDdXN0b21Wb2lkQ2FsbGJhY2s6OmhhbmRsZUV2ZW50KCkKIHsKLSAg ICBBU1NFUlQobV9kYXRhKTsKKyAgICBpZiAoIW1fZGF0YSB8fCAhbV9kYXRhLT5nbG9iYWxPYmpl Y3QoKSB8fCAhY2FuSW52b2tlQ2FsbGJhY2soKSkKKyAgICAgICAgcmV0dXJuIHRydWU7IAogCiAg ICAgUmVmUHRyPEpTQ3VzdG9tVm9pZENhbGxiYWNrPiBwcm90ZWN0KHRoaXMpOwogICAgICAgICAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxi YWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5o CmluZGV4IGYzNDJiOGIuLjE5MGU3MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suaApAQCAtMzAsNyArMzAsNyBAQAogI2RlZmluZSBK U0N1c3RvbVZvaWRDYWxsYmFja19oCiAKICNpbmNsdWRlICJKU0RPTUdsb2JhbE9iamVjdC5oIgot I2luY2x1ZGUgIlZvaWRDYWxsYmFjay5oIgorI2luY2x1ZGUgIkFjdGl2ZURPTUNhbGxiYWNrLmgi CiAjaW5jbHVkZSA8aGVhcC9TdHJvbmcuaD4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogCkBA IC0zOCw3ICszOCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgSlNDYWxsYmFja0Rh dGE7CiAKLWNsYXNzIEpTQ3VzdG9tVm9pZENhbGxiYWNrIDogcHVibGljIFZvaWRDYWxsYmFjayB7 CitjbGFzcyBKU0N1c3RvbVZvaWRDYWxsYmFjayA6IHB1YmxpYyBBY3RpdmVET01DYWxsYmFjayB7 CiBwdWJsaWM6IAogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEpTQ3VzdG9tVm9pZENhbGxiYWNrPiBj cmVhdGUoSlNDOjpKU09iamVjdCogY2FsbGJhY2ssIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxP YmplY3QpCiAgICAgewo= 118115 2011-12-06 14:38:47 -0800 2011-12-06 14:40:22 -0800 fix the style 73945.patch text/plain 3409 yong.li.webkit ZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbCBi L01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi40YWUwZTViCi0tLSAvZGV2L251bGwKKysrIGIvTWFudWFs VGVzdHMvZGF0YWJhc2Utc3VjY2Vzcy1jYWxsYmFjay5odG1sCkBAIC0wLDAgKzEsMjQgQEAKKzxi b2R5PgorPHAgaWQ9InJlc3VsdCI+Q2FsbGJhY2sgaGFzbid0IGJlZW4gY2FsbGVkPC9wPgorPHNj cmlwdD4KK3ZhciBzaG93aW5nQWxlcnQ7CisKK2Z1bmN0aW9uIHRyYW5zYWN0aW9uU3VjY2Vzc0Nh bGxiYWNrKCkKK3sKKyAgICBpZiAoc2hvd2luZ0FsZXJ0KQorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkNhbGxiYWNrIHdhcyBjYWxsZWQgd2hp bGUgSlMgZGlhbG9nIHdhcyBvcGVuZWQuIFRlc3QgZmFpbGVkIjsKKyAgICBlbHNlCisgICAgICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAiVGVzdCBwYXNz ZWQiOworfQorCit2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIkRhdGFiYXNlQ2FsbGJhY2tUZXN0Iiwg IjEuMCIsICIiLCAxKTsKK2RiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7IHR4LmV4ZWN1dGVT cWwoIkNSRUFURSBUQUJMRSBJRiBOT1QgRVhJU1RTIENhbGxiYWNrRGVmZXJyZWRUZXN0IChyYW5k b21EYXRhKSIsIFtdKTsgfSwgbnVsbCwgdHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2spOworCitz aG93aW5nQWxlcnQgPSB0cnVlOworCithbGVydCgiV2FpdCBhIGZldyBzZWNvbmRzIGFuZCBjbG9z ZSBtZSIpOworCitzaG93aW5nQWxlcnQgPSBmYWxzZTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjEyYjMyNC4uZGZjMWZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTEyLTA2ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIExldCBKU0N1 c3RvbVZvaWRDYWxsYmFjayBkZXJpdmUgZnJvbSBBY3RpdmVET01DYWxsYmFjaywgYmVjYXVzZQor ICAgICAgICBpdCBiZWxvbmdzIHRvIHRoZSBkb2N1bWVudC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBNYW51YWxUZXN0cy9kYXRhYmFzZS1z dWNjZXNzLWNhbGxiYWNrLmh0bWwuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZv aWRDYWxsYmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0N1c3RvbVZvaWRDYWxsYmFjazo6 SlNDdXN0b21Wb2lkQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6SlNDdXN0b21Wb2lkQ2Fs bGJhY2s6OmhhbmRsZUV2ZW50KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRD YWxsYmFjay5oOgorCiAyMDExLTEyLTAyICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzY4MwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCmlu ZGV4IGY4MzBmNWMuLmZlY2JmMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5jcHAKQEAgLTQxLDcgKzQxLDggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEpTQzsKICAgICAKIEpTQ3VzdG9tVm9pZENhbGxi YWNrOjpKU0N1c3RvbVZvaWRDYWxsYmFjayhKU09iamVjdCogY2FsbGJhY2ssIEpTRE9NR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QpCi0gICAgOiBtX2RhdGEobmV3IEpTQ2FsbGJhY2tEYXRhKGNh bGxiYWNrLCBnbG9iYWxPYmplY3QpKQorICAgIDogQWN0aXZlRE9NQ2FsbGJhY2soZ2xvYmFsT2Jq ZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCisgICAgLCBtX2RhdGEobmV3IEpTQ2FsbGJh Y2tEYXRhKGNhbGxiYWNrLCBnbG9iYWxPYmplY3QpKQogICAgICwgbV9zY3JpcHRFeGVjdXRpb25D b250ZXh0KGdsb2JhbE9iamVjdC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQogewogfQpAQCAt NTksNyArNjAsOCBAQCBKU0N1c3RvbVZvaWRDYWxsYmFjazo6fkpTQ3VzdG9tVm9pZENhbGxiYWNr KCkKICAgICAKIHZvaWQgSlNDdXN0b21Wb2lkQ2FsbGJhY2s6OmhhbmRsZUV2ZW50KCkKIHsKLSAg ICBBU1NFUlQobV9kYXRhKTsKKyAgICBpZiAoIW1fZGF0YSB8fCAhbV9kYXRhLT5nbG9iYWxPYmpl Y3QoKSB8fCAhY2FuSW52b2tlQ2FsbGJhY2soKSkKKyAgICAgICAgcmV0dXJuIHRydWU7IAogCiAg ICAgUmVmUHRyPEpTQ3VzdG9tVm9pZENhbGxiYWNrPiBwcm90ZWN0KHRoaXMpOwogICAgICAgICAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxi YWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5o CmluZGV4IGYzNDJiOGIuLjdhYzU1ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suaApAQCAtMjksOCArMjksOCBAQAogI2lmbmRlZiBK U0N1c3RvbVZvaWRDYWxsYmFja19oCiAjZGVmaW5lIEpTQ3VzdG9tVm9pZENhbGxiYWNrX2gKIAor I2luY2x1ZGUgIkFjdGl2ZURPTUNhbGxiYWNrLmgiCiAjaW5jbHVkZSAiSlNET01HbG9iYWxPYmpl Y3QuaCIKLSNpbmNsdWRlICJWb2lkQ2FsbGJhY2suaCIKICNpbmNsdWRlIDxoZWFwL1N0cm9uZy5o PgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAKQEAgLTM4LDcgKzM4LDcgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogCiBjbGFzcyBKU0NhbGxiYWNrRGF0YTsKIAotY2xhc3MgSlNDdXN0b21Wb2lk Q2FsbGJhY2sgOiBwdWJsaWMgVm9pZENhbGxiYWNrIHsKK2NsYXNzIEpTQ3VzdG9tVm9pZENhbGxi YWNrIDogcHVibGljIEFjdGl2ZURPTUNhbGxiYWNrIHsKIHB1YmxpYzogCiAgICAgc3RhdGljIFBh c3NSZWZQdHI8SlNDdXN0b21Wb2lkQ2FsbGJhY2s+IGNyZWF0ZShKU0M6OkpTT2JqZWN0KiBjYWxs YmFjaywgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICB7Cg== 118118 2011-12-06 15:01:48 -0800 2011-12-07 07:45:03 -0800 should be done in this way 73945.patch text/plain 3396 yong.li.webkit ZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbCBi L01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi40YWUwZTViCi0tLSAvZGV2L251bGwKKysrIGIvTWFudWFs VGVzdHMvZGF0YWJhc2Utc3VjY2Vzcy1jYWxsYmFjay5odG1sCkBAIC0wLDAgKzEsMjQgQEAKKzxi b2R5PgorPHAgaWQ9InJlc3VsdCI+Q2FsbGJhY2sgaGFzbid0IGJlZW4gY2FsbGVkPC9wPgorPHNj cmlwdD4KK3ZhciBzaG93aW5nQWxlcnQ7CisKK2Z1bmN0aW9uIHRyYW5zYWN0aW9uU3VjY2Vzc0Nh bGxiYWNrKCkKK3sKKyAgICBpZiAoc2hvd2luZ0FsZXJ0KQorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkNhbGxiYWNrIHdhcyBjYWxsZWQgd2hp bGUgSlMgZGlhbG9nIHdhcyBvcGVuZWQuIFRlc3QgZmFpbGVkIjsKKyAgICBlbHNlCisgICAgICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAiVGVzdCBwYXNz ZWQiOworfQorCit2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIkRhdGFiYXNlQ2FsbGJhY2tUZXN0Iiwg IjEuMCIsICIiLCAxKTsKK2RiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7IHR4LmV4ZWN1dGVT cWwoIkNSRUFURSBUQUJMRSBJRiBOT1QgRVhJU1RTIENhbGxiYWNrRGVmZXJyZWRUZXN0IChyYW5k b21EYXRhKSIsIFtdKTsgfSwgbnVsbCwgdHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2spOworCitz aG93aW5nQWxlcnQgPSB0cnVlOworCithbGVydCgiV2FpdCBhIGZldyBzZWNvbmRzIGFuZCBjbG9z ZSBtZSIpOworCitzaG93aW5nQWxlcnQgPSBmYWxzZTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjEyYjMyNC4uZGZjMWZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTEyLTA2ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIExldCBKU0N1 c3RvbVZvaWRDYWxsYmFjayBkZXJpdmUgZnJvbSBBY3RpdmVET01DYWxsYmFjaywgYmVjYXVzZQor ICAgICAgICBpdCBiZWxvbmdzIHRvIHRoZSBkb2N1bWVudC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBNYW51YWxUZXN0cy9kYXRhYmFzZS1z dWNjZXNzLWNhbGxiYWNrLmh0bWwuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZv aWRDYWxsYmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0N1c3RvbVZvaWRDYWxsYmFjazo6 SlNDdXN0b21Wb2lkQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6SlNDdXN0b21Wb2lkQ2Fs bGJhY2s6OmhhbmRsZUV2ZW50KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRD YWxsYmFjay5oOgorCiAyMDExLTEyLTAyICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzY4MwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCmlu ZGV4IGY4MzBmNWMuLjM5YTdlMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5jcHAKQEAgLTQxLDcgKzQxLDggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEpTQzsKICAgICAKIEpTQ3VzdG9tVm9pZENhbGxi YWNrOjpKU0N1c3RvbVZvaWRDYWxsYmFjayhKU09iamVjdCogY2FsbGJhY2ssIEpTRE9NR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QpCi0gICAgOiBtX2RhdGEobmV3IEpTQ2FsbGJhY2tEYXRhKGNh bGxiYWNrLCBnbG9iYWxPYmplY3QpKQorICAgIDogQWN0aXZlRE9NQ2FsbGJhY2soZ2xvYmFsT2Jq ZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCisgICAgLCBtX2RhdGEobmV3IEpTQ2FsbGJh Y2tEYXRhKGNhbGxiYWNrLCBnbG9iYWxPYmplY3QpKQogICAgICwgbV9zY3JpcHRFeGVjdXRpb25D b250ZXh0KGdsb2JhbE9iamVjdC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQogewogfQpAQCAt NTksNyArNjAsOCBAQCBKU0N1c3RvbVZvaWRDYWxsYmFjazo6fkpTQ3VzdG9tVm9pZENhbGxiYWNr KCkKICAgICAKIHZvaWQgSlNDdXN0b21Wb2lkQ2FsbGJhY2s6OmhhbmRsZUV2ZW50KCkKIHsKLSAg ICBBU1NFUlQobV9kYXRhKTsKKyAgICBpZiAoIW1fZGF0YSB8fCAhbV9kYXRhLT5nbG9iYWxPYmpl Y3QoKSB8fCAhY2FuSW52b2tlQ2FsbGJhY2soKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgUmVm UHRyPEpTQ3VzdG9tVm9pZENhbGxiYWNrPiBwcm90ZWN0KHRoaXMpOwogICAgICAgICAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5oCmluZGV4 IGYzNDJiOGIuLmJmOTE2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTQ3VzdG9tVm9pZENhbGxiYWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv SlNDdXN0b21Wb2lkQ2FsbGJhY2suaApAQCAtMjksNiArMjksNyBAQAogI2lmbmRlZiBKU0N1c3Rv bVZvaWRDYWxsYmFja19oCiAjZGVmaW5lIEpTQ3VzdG9tVm9pZENhbGxiYWNrX2gKIAorI2luY2x1 ZGUgIkFjdGl2ZURPTUNhbGxiYWNrLmgiCiAjaW5jbHVkZSAiSlNET01HbG9iYWxPYmplY3QuaCIK ICNpbmNsdWRlICJWb2lkQ2FsbGJhY2suaCIKICNpbmNsdWRlIDxoZWFwL1N0cm9uZy5oPgpAQCAt MzgsNyArMzksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEpTQ2FsbGJhY2tEYXRh OwogCi1jbGFzcyBKU0N1c3RvbVZvaWRDYWxsYmFjayA6IHB1YmxpYyBWb2lkQ2FsbGJhY2sgewor Y2xhc3MgSlNDdXN0b21Wb2lkQ2FsbGJhY2sgOiBwdWJsaWMgVm9pZENhbGxiYWNrLCBwdWJsaWMg QWN0aXZlRE9NQ2FsbGJhY2sgewogcHVibGljOiAKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxKU0N1 c3RvbVZvaWRDYWxsYmFjaz4gY3JlYXRlKEpTQzo6SlNPYmplY3QqIGNhbGxiYWNrLCBKU0RPTUds b2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQogICAgIHsK 118210 2011-12-07 07:45:03 -0800 2012-01-05 11:06:14 -0800 Ready for review 73945.patch text/plain 3451 yong.li.webkit ZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbCBi L01hbnVhbFRlc3RzL2RhdGFiYXNlLXN1Y2Nlc3MtY2FsbGJhY2suaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi40YWUwZTViCi0tLSAvZGV2L251bGwKKysrIGIvTWFudWFs VGVzdHMvZGF0YWJhc2Utc3VjY2Vzcy1jYWxsYmFjay5odG1sCkBAIC0wLDAgKzEsMjQgQEAKKzxi b2R5PgorPHAgaWQ9InJlc3VsdCI+Q2FsbGJhY2sgaGFzbid0IGJlZW4gY2FsbGVkPC9wPgorPHNj cmlwdD4KK3ZhciBzaG93aW5nQWxlcnQ7CisKK2Z1bmN0aW9uIHRyYW5zYWN0aW9uU3VjY2Vzc0Nh bGxiYWNrKCkKK3sKKyAgICBpZiAoc2hvd2luZ0FsZXJ0KQorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIkNhbGxiYWNrIHdhcyBjYWxsZWQgd2hp bGUgSlMgZGlhbG9nIHdhcyBvcGVuZWQuIFRlc3QgZmFpbGVkIjsKKyAgICBlbHNlCisgICAgICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSAiVGVzdCBwYXNz ZWQiOworfQorCit2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIkRhdGFiYXNlQ2FsbGJhY2tUZXN0Iiwg IjEuMCIsICIiLCAxKTsKK2RiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7IHR4LmV4ZWN1dGVT cWwoIkNSRUFURSBUQUJMRSBJRiBOT1QgRVhJU1RTIENhbGxiYWNrRGVmZXJyZWRUZXN0IChyYW5k b21EYXRhKSIsIFtdKTsgfSwgbnVsbCwgdHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2spOworCitz aG93aW5nQWxlcnQgPSB0cnVlOworCithbGVydCgiV2FpdCBhIGZldyBzZWNvbmRzIGFuZCBjbG9z ZSBtZSIpOworCitzaG93aW5nQWxlcnQgPSBmYWxzZTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjEyYjMyNC4uZTRkOGM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDExLTEyLTA2ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mzk0NQorICAgICAgICBMZXQgSlNDdXN0 b21Wb2lkQ2FsbGJhY2sgZGVyaXZlIGZyb20gQWN0aXZlRE9NQ2FsbGJhY2ssIGJlY2F1c2UKKyAg ICAgICAgaXQgYmVsb25ncyB0byB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogTWFudWFsVGVzdHMvZGF0YWJhc2Utc3Vj Y2Vzcy1jYWxsYmFjay5odG1sLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNDdXN0b21Wb2lk Q2FsbGJhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNDdXN0b21Wb2lkQ2FsbGJhY2s6OkpT Q3VzdG9tVm9pZENhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3VzdG9tVm9pZENhbGxi YWNrOjpoYW5kbGVFdmVudCk6CisgICAgICAgICogYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2Fs bGJhY2suaDoKKwogMjAxMS0xMi0wMiAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2ODMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tVm9pZENhbGxiYWNrLmNwcAppbmRl eCBmODMwZjVjLi4zOWE3ZTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0N1c3RvbVZvaWRDYWxsYmFjay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCkBAIC00MSw3ICs0MSw4IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFjZSBKU0M7CiAgICAgCiBKU0N1c3RvbVZvaWRDYWxsYmFj azo6SlNDdXN0b21Wb2lkQ2FsbGJhY2soSlNPYmplY3QqIGNhbGxiYWNrLCBKU0RPTUdsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0KQotICAgIDogbV9kYXRhKG5ldyBKU0NhbGxiYWNrRGF0YShjYWxs YmFjaywgZ2xvYmFsT2JqZWN0KSkKKyAgICA6IEFjdGl2ZURPTUNhbGxiYWNrKGdsb2JhbE9iamVj dC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKQorICAgICwgbV9kYXRhKG5ldyBKU0NhbGxiYWNr RGF0YShjYWxsYmFjaywgZ2xvYmFsT2JqZWN0KSkKICAgICAsIG1fc2NyaXB0RXhlY3V0aW9uQ29u dGV4dChnbG9iYWxPYmplY3QtPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKIHsKIH0KQEAgLTU5 LDcgKzYwLDggQEAgSlNDdXN0b21Wb2lkQ2FsbGJhY2s6On5KU0N1c3RvbVZvaWRDYWxsYmFjaygp CiAgICAgCiB2b2lkIEpTQ3VzdG9tVm9pZENhbGxiYWNrOjpoYW5kbGVFdmVudCgpCiB7Ci0gICAg QVNTRVJUKG1fZGF0YSk7CisgICAgaWYgKCFtX2RhdGEgfHwgIW1fZGF0YS0+Z2xvYmFsT2JqZWN0 KCkgfHwgIWNhbkludm9rZUNhbGxiYWNrKCkpCisgICAgICAgIHJldHVybjsKIAogICAgIFJlZlB0 cjxKU0N1c3RvbVZvaWRDYWxsYmFjaz4gcHJvdGVjdCh0aGlzKTsKICAgICAgICAgCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0N1c3RvbVZvaWRDYWxsYmFjay5oIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suaAppbmRleCBm MzQyYjhiLi5iZjkxNjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0N1c3RvbVZvaWRDYWxsYmFjay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT Q3VzdG9tVm9pZENhbGxiYWNrLmgKQEAgLTI5LDYgKzI5LDcgQEAKICNpZm5kZWYgSlNDdXN0b21W b2lkQ2FsbGJhY2tfaAogI2RlZmluZSBKU0N1c3RvbVZvaWRDYWxsYmFja19oCiAKKyNpbmNsdWRl ICJBY3RpdmVET01DYWxsYmFjay5oIgogI2luY2x1ZGUgIkpTRE9NR2xvYmFsT2JqZWN0LmgiCiAj aW5jbHVkZSAiVm9pZENhbGxiYWNrLmgiCiAjaW5jbHVkZSA8aGVhcC9TdHJvbmcuaD4KQEAgLTM4 LDcgKzM5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBKU0NhbGxiYWNrRGF0YTsK IAotY2xhc3MgSlNDdXN0b21Wb2lkQ2FsbGJhY2sgOiBwdWJsaWMgVm9pZENhbGxiYWNrIHsKK2Ns YXNzIEpTQ3VzdG9tVm9pZENhbGxiYWNrIDogcHVibGljIFZvaWRDYWxsYmFjaywgcHVibGljIEFj dGl2ZURPTUNhbGxiYWNrIHsKIHB1YmxpYzogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8SlNDdXN0 b21Wb2lkQ2FsbGJhY2s+IGNyZWF0ZShKU0M6OkpTT2JqZWN0KiBjYWxsYmFjaywgSlNET01HbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICB7Cg==