73939 2011-12-06 11:47:14 -0800 [chromium] Don't crash if tile upload happens without painting first 2011-12-06 14:26:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr reveman vangelis webkit.review.bot oldest_to_newest 516104 0 enne 2011-12-06 11:47:14 -0800 [chromium] Don't crash if tile upload happens without painting first 516113 1 118084 enne 2011-12-06 11:51:01 -0800 Created attachment 118084 Patch 516122 2 enne 2011-12-06 11:56:14 -0800 See: http://code.google.com/p/chromium/issues/detail?id=105569 I think this crash is caused by a paint/upload mismatch. A layer isn't painted but is uploaded from, so its tiler isn't created. I'm not totally sure where this is happening, but that seems like a likely culprit. The proper fix is the ForEachCompositorResource functor iteration from https://bugs.webkit.org/show_bug.cgi?id=72752, but I want something small that can be backported to m17. 516136 3 reveman 2011-12-06 12:09:01 -0800 Looks good to me. Any idea how we end up calling updateCompositorResources() without prepareToUpdate first? 516137 4 enne 2011-12-06 12:16:32 -0800 (In reply to comment #3) > Looks good to me. Any idea how we end up calling updateCompositorResources() without prepareToUpdate first? I'm not totally sure, but there's two totally different code paths, so it seemed really plausible. Actually, ImageLayerChromium::paintContentsIfDirty has an early out before prepareToUpdate if the visible rect is empty. That would do it. 516151 5 118090 enne 2011-12-06 12:27:44 -0800 Created attachment 118090 Fix ImageLayerChromium to not do this 516154 6 118090 jamesr 2011-12-06 12:31:08 -0800 Comment on attachment 118090 Fix ImageLayerChromium to not do this This looks safe 516253 7 118090 webkit.review.bot 2011-12-06 14:26:44 -0800 Comment on attachment 118090 Fix ImageLayerChromium to not do this Clearing flags on attachment: 118090 Committed r102180: <http://trac.webkit.org/changeset/102180> 516254 8 webkit.review.bot 2011-12-06 14:26:49 -0800 All reviewed patches have been landed. Closing bug. 118084 2011-12-06 11:51:01 -0800 2011-12-06 12:27:41 -0800 Patch bug-73939-20111206115100.patch text/plain 1961 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThjMjI5ZDE0Njc4NWJm YmY0OTI2N2JiZmI3YjhiYjU4M2ZhN2FiZS4uN2EyZTBlZDY4ZTQwYWE0N2RhZTk2NzI3MjYwN2Ux MmFmZGRjYzkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTA2ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24n dCBjcmFzaCBpZiB0aWxlIHVwbG9hZCBoYXBwZW5zIHdpdGhvdXQgcGFpbnRpbmcgZmlyc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWx0aG91Z2ggdGhp cyBzaG91bGRuJ3QgaGFwcGVuLCB3ZSBzaG91bGQgYmUgcm9idXN0IHRvIGl0IGluIHRoZQorICAg ICAgICBjaGFuY2UgdGhhdCBvdGhlciBjb2RlIGNhdXNlcyBpdCB0by4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpUaWxlZExheWVyQ2hyb21pdW06OnVwZGF0ZUNvbXBvc2l0b3JSZXNvdXJjZXMp OgorCiAyMDExLTEyLTA0ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAg ICAgICBDU1NWYWx1ZVBvb2w6IElubGluZSB0cml2aWFsIGdldHRlcnMuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21p dW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRM YXllckNocm9taXVtLmNwcAppbmRleCA5NjhkOWUzZTRhY2U2NTAxMGM4M2RkYzlkODg0Y2NiYTkx YjAyNWUxLi41YzU1ZjU5YmYzZTczNzJmZTllYzUxMmVmNjM2MTEwMWFjNWEwNWU1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVy Q2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTE3NCw4ICsxNzQsMTIgQEAgdm9pZCBUaWxl ZExheWVyQ2hyb21pdW06OmNyZWF0ZVRpbGVyKENDTGF5ZXJUaWxpbmdEYXRhOjpCb3JkZXJUZXhl bE9wdGlvbiBib3JkZXIKIAogdm9pZCBUaWxlZExheWVyQ2hyb21pdW06OnVwZGF0ZUNvbXBvc2l0 b3JSZXNvdXJjZXMoR3JhcGhpY3NDb250ZXh0M0QqLCBDQ1RleHR1cmVVcGRhdGVyJiB1cGRhdGVy KQogeworICAgIC8vIElmIHRoaXMgYXNzZXJ0IGlzIGhpdCwgaXQgbWVhbnMgdGhhdCBwYWludENv bnRlbnRzSWZEaXJ0eSBoYXNuJ3QgYmVlbgorICAgIC8vIGNhbGxlZCBvbiB0aGlzIGxheWVyLiBB bnkgbGF5ZXIgdGhhdCBpcyB1cGRhdGVkIHNob3VsZCBiZSBwYWludGVkIGZpcnN0LgorICAgIEFT U0VSVChtX3RpbGVyKTsKKwogICAgIC8vIFBhaW50aW5nIGNvdWxkIGNhdXNlIGNvbXBvc2l0aW5n IHRvIGdldCB0dXJuZWQgb2ZmLCB3aGljaCBtYXkgY2F1c2UgdGhlIHRpbGVyIHRvIGJlY29tZSBp bnZhbGlkYXRlZCBtaWQtdXBkYXRlLgotICAgIGlmIChtX3NraXBzRHJhdyB8fCBtX3JlcXVlc3Rl ZFVwZGF0ZVJlY3QuaXNFbXB0eSgpIHx8ICFtX3RpbGVyLT5udW1UaWxlcygpKQorICAgIGlmICht X3NraXBzRHJhdyB8fCBtX3JlcXVlc3RlZFVwZGF0ZVJlY3QuaXNFbXB0eSgpIHx8ICFtX3RpbGVy IHx8ICFtX3RpbGVyLT5udW1UaWxlcygpKQogICAgICAgICByZXR1cm47CiAKICAgICBpbnQgbGVm dCwgdG9wLCByaWdodCwgYm90dG9tOwo= 118090 2011-12-06 12:27:44 -0800 2011-12-06 14:26:44 -0800 Fix ImageLayerChromium to not do this bug-73939-20111206122743.patch text/plain 2756 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThjMjI5ZDE0Njc4NWJm YmY0OTI2N2JiZmI3YjhiYjU4M2ZhN2FiZS4uOWYzOGYyZmU2NmM5NDI5OGYwOTZkMmU4Y2ZkYmMw YzIxZWExZjNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTA2ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24n dCBjcmFzaCBpZiB0aWxlIHVwbG9hZCBoYXBwZW5zIHdpdGhvdXQgcGFpbnRpbmcgZmlyc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGF0IGxl YXN0IG9uZSBwbGFjZSAoaW4gSW1hZ2VMYXllckNocm9taXVtKSB3aGVyZSB0aGlzIGNvdWxkCisg ICAgICAgIGhhcHBlbi4KKworICAgICAgICBBbHRob3VnaCB0aGlzIHNob3VsZG4ndCBoYXBwZW4s IHdlIHNob3VsZCBiZSByb2J1c3QgdG8gaXQgaW4gdGhlCisgICAgICAgIGNoYW5jZSB0aGF0IG90 aGVyIGNvZGUgY2F1c2VzIGl0IHRvLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlTGF5 ZXJDaHJvbWl1bTo6cGFpbnRDb250ZW50c0lmRGlydHkpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpUaWxlZExheWVyQ2hyb21pdW06OnVwZGF0ZUNvbXBvc2l0b3JSZXNvdXJjZXMpOgorCiAyMDEx LTEyLTA0ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBDU1NW YWx1ZVBvb2w6IElubGluZSB0cml2aWFsIGdldHRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9t aXVtLmNwcAppbmRleCA3MGFmZGQwODJjNDNmYzAyODljYTkwMjliOTY0YTRkNDRlMzQ0ZTczLi5h MWFjNDdmNDFiMGNlZDgxOWU2MWY3MGVkNGUwN2Y3Yzk4ZjQ2OTk2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdl TGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTE3OSw5ICsxNzksNiBAQCB2b2lkIEltYWdlTGF5ZXJDaHJv bWl1bTo6cGFpbnRDb250ZW50c0lmRGlydHkoKQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYg KHZpc2libGVMYXllclJlY3QoKS5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybjsKLQogICAgIHBy ZXBhcmVUb1VwZGF0ZSh2aXNpYmxlTGF5ZXJSZWN0KCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXll ckNocm9taXVtLmNwcAppbmRleCA5NjhkOWUzZTRhY2U2NTAxMGM4M2RkYzlkODg0Y2NiYTkxYjAy NWUxLi41YzU1ZjU5YmYzZTczNzJmZTllYzUxMmVmNjM2MTEwMWFjNWEwNWU1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hy b21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTE3NCw4ICsxNzQsMTIgQEAgdm9pZCBUaWxlZExh eWVyQ2hyb21pdW06OmNyZWF0ZVRpbGVyKENDTGF5ZXJUaWxpbmdEYXRhOjpCb3JkZXJUZXhlbE9w dGlvbiBib3JkZXIKIAogdm9pZCBUaWxlZExheWVyQ2hyb21pdW06OnVwZGF0ZUNvbXBvc2l0b3JS ZXNvdXJjZXMoR3JhcGhpY3NDb250ZXh0M0QqLCBDQ1RleHR1cmVVcGRhdGVyJiB1cGRhdGVyKQog eworICAgIC8vIElmIHRoaXMgYXNzZXJ0IGlzIGhpdCwgaXQgbWVhbnMgdGhhdCBwYWludENvbnRl bnRzSWZEaXJ0eSBoYXNuJ3QgYmVlbgorICAgIC8vIGNhbGxlZCBvbiB0aGlzIGxheWVyLiBBbnkg bGF5ZXIgdGhhdCBpcyB1cGRhdGVkIHNob3VsZCBiZSBwYWludGVkIGZpcnN0LgorICAgIEFTU0VS VChtX3RpbGVyKTsKKwogICAgIC8vIFBhaW50aW5nIGNvdWxkIGNhdXNlIGNvbXBvc2l0aW5nIHRv IGdldCB0dXJuZWQgb2ZmLCB3aGljaCBtYXkgY2F1c2UgdGhlIHRpbGVyIHRvIGJlY29tZSBpbnZh bGlkYXRlZCBtaWQtdXBkYXRlLgotICAgIGlmIChtX3NraXBzRHJhdyB8fCBtX3JlcXVlc3RlZFVw ZGF0ZVJlY3QuaXNFbXB0eSgpIHx8ICFtX3RpbGVyLT5udW1UaWxlcygpKQorICAgIGlmIChtX3Nr aXBzRHJhdyB8fCBtX3JlcXVlc3RlZFVwZGF0ZVJlY3QuaXNFbXB0eSgpIHx8ICFtX3RpbGVyIHx8 ICFtX3RpbGVyLT5udW1UaWxlcygpKQogICAgICAgICByZXR1cm47CiAKICAgICBpbnQgbGVmdCwg dG9wLCByaWdodCwgYm90dG9tOwo=