73924 2011-12-06 08:15:49 -0800 [EFL] Do not lose message flags when soup resources are converted. 2011-12-06 11:30:44 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gustavo gyuyoung.kim leandro lucas.de.marchi mrobinson rakuco webkit.review.bot oldest_to_newest 515924 0 118053 rakuco 2011-12-06 08:15:49 -0800 Created attachment 118053 Patch Apply the same change added to the GTK+ port in r55086 to prevent soup message flags from being lost by updating the request flags when a response is received. 515928 1 webkit.review.bot 2011-12-06 08:19:04 -0800 Attachment 118053 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 515929 2 118055 rakuco 2011-12-06 08:19:20 -0800 Created attachment 118055 Add bug number to ChangeLog 516061 3 118055 gustavo 2011-12-06 11:22:46 -0800 Comment on attachment 118055 Add bug number to ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=118055&action=review > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:239 > +void FrameLoaderClientEfl::dispatchDidReceiveResponse(DocumentLoader* loader, unsigned long, const ResourceResponse& response) > { > +#if USE(SOUP) > + // Update our knowledge of request soup flags - some are only set > + // after the request is done. > + loader->request().setSoupMessageFlags(response.soupMessageFlags()); > +#endif If you want your build to be really tidy in the non-soup case you should probably have UNUSED_PARAM(loader); in an #else block here, looks good otherwise. 516076 4 118077 rakuco 2011-12-06 11:29:03 -0800 Created attachment 118077 Patch for landing 516081 5 rakuco 2011-12-06 11:30:44 -0800 Committed r102159: <http://trac.webkit.org/changeset/102159> 118053 2011-12-06 08:15:49 -0800 2011-12-06 08:19:14 -0800 Patch 20111206141623.patch text/plain 1841 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNWQ4OWQxMjVl M2YyMTgzZWYyYzdjZDg2MTU5MmM5NDU1OTZhYTMyNy4uYjNmMWE1OTkxMWIzZjA5Yjk3YzJjNjA3 YTJmMDU0MWM1OWFjNDQ1NiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEx LTEyLTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIERvIG5vdCBsb3NlIG1lc3NhZ2UgZmxhZ3Mgd2hlbiBjb252ZXJ0aW5nIHRv L2Zyb20gU291cCBSZXF1ZXN0cy9SZXNwb25zZXMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBcHBseSB0aGUgc2FtZSBjaGFuZ2UgYWRkZWQgdG8gdGhl IEdUSysgcG9ydCBpbiByNTUwODYgdG8gcHJldmVudAorICAgICAgICBzb3VwIG1lc3NhZ2UgZmxh Z3MgZnJvbSBiZWluZyBsb3N0IGJ5IHVwZGF0aW5nIHRoZSByZXF1ZXN0IGZsYWdzIHdoZW4KKyAg ICAgICAgYSByZXNwb25zZSBpcyByZWNlaXZlZC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy Q2xpZW50RWZsOjpkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZSk6CisKIDIwMTEtMTItMDQgIEth bmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEZpeCBi cm9rZW4gVVRGLTggY2hhcmFjdGVycyBpc3N1ZSBvbiBlZGl0b3IgY29tbWFuZC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 RWZsLmNwcAppbmRleCA0ZGUxY2VjZWYwOWU2MDRlOTRjMzA2YzY0OTM5ZWY1NGNiN2QzYWY5Li4x NTQ2NTIwMzkzY2I5ZGI2ZWRkYjgzZTJhNTg4MjUzNTU1NjBiODc3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwu Y3BwCkBAIC0yMzAsOCArMjMwLDE0IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRFZmw6OmZyYW1l TG9hZGVyRGVzdHJveWVkKCkKICAgICBkZWxldGUgdGhpczsKIH0KIAotdm9pZCBGcmFtZUxvYWRl ckNsaWVudEVmbDo6ZGlzcGF0Y2hEaWRSZWNlaXZlUmVzcG9uc2UoRG9jdW1lbnRMb2FkZXIqLCB1 bnNpZ25lZCBsb25nLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKK3ZvaWQgRnJh bWVMb2FkZXJDbGllbnRFZmw6OmRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKERvY3VtZW50TG9h ZGVyKiBsb2FkZXIsIHVuc2lnbmVkIGxvbmcsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3Bv bnNlKQogeworI2lmIFVTRShTT1VQKQorICAgIC8vIFVwZGF0ZSBvdXIga25vd2xlZGdlIG9mIHJl cXVlc3Qgc291cCBmbGFncyAtIHNvbWUgYXJlIG9ubHkgc2V0CisgICAgLy8gYWZ0ZXIgdGhlIHJl cXVlc3QgaXMgZG9uZS4KKyAgICBsb2FkZXItPnJlcXVlc3QoKS5zZXRTb3VwTWVzc2FnZUZsYWdz KHJlc3BvbnNlLnNvdXBNZXNzYWdlRmxhZ3MoKSk7CisjZW5kaWYKKwogICAgIG1fcmVzcG9uc2Ug PSByZXNwb25zZTsKIH0KIAo= 118055 2011-12-06 08:19:20 -0800 2011-12-06 11:28:57 -0800 Add bug number to ChangeLog bug-73924-20111206141955.patch text/plain 1896 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNWQ4OWQxMjVl M2YyMTgzZWYyYzdjZDg2MTU5MmM5NDU1OTZhYTMyNy4uNjVhZDY3NTBiZWEwMzIyZDczMjY3NjBm YzA3MjA3NmViMjBiMzExMyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEx LTEyLTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIERvIG5vdCBsb3NlIG1lc3NhZ2UgZmxhZ3Mgd2hlbiBjb252ZXJ0aW5nIHRv L2Zyb20gU291cCBSZXF1ZXN0cy9SZXNwb25zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQXBwbHkgdGhlIHNhbWUgY2hhbmdlIGFkZGVkIHRvIHRoZSBH VEsrIHBvcnQgaW4gcjU1MDg2IHRvIHByZXZlbnQKKyAgICAgICAgc291cCBtZXNzYWdlIGZsYWdz IGZyb20gYmVpbmcgbG9zdCBieSB1cGRhdGluZyB0aGUgcmVxdWVzdCBmbGFncyB3aGVuCisgICAg ICAgIGEgcmVzcG9uc2UgaXMgcmVjZWl2ZWQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNs aWVudEVmbDo6ZGlzcGF0Y2hEaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAyMDExLTEyLTA0ICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBGaXggYnJv a2VuIFVURi04IGNoYXJhY3RlcnMgaXNzdWUgb24gZWRpdG9yIGNvbW1hbmQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVm bC5jcHAKaW5kZXggNGRlMWNlY2VmMDllNjA0ZTk0YzMwNmM2NDkzOWVmNTRjYjdkM2FmOS4uMTU0 NjUyMDM5M2NiOWRiNmVkZGI4M2UyYTU4ODI1MzU1NTYwYjg3NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNw cApAQCAtMjMwLDggKzIzMCwxNCBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpmcmFtZUxv YWRlckRlc3Ryb3llZCgpCiAgICAgZGVsZXRlIHRoaXM7CiB9CiAKLXZvaWQgRnJhbWVMb2FkZXJD bGllbnRFZmw6OmRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKERvY3VtZW50TG9hZGVyKiwgdW5z aWduZWQgbG9uZywgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCit2b2lkIEZyYW1l TG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZShEb2N1bWVudExvYWRl ciogbG9hZGVyLCB1bnNpZ25lZCBsb25nLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25z ZSkKIHsKKyNpZiBVU0UoU09VUCkKKyAgICAvLyBVcGRhdGUgb3VyIGtub3dsZWRnZSBvZiByZXF1 ZXN0IHNvdXAgZmxhZ3MgLSBzb21lIGFyZSBvbmx5IHNldAorICAgIC8vIGFmdGVyIHRoZSByZXF1 ZXN0IGlzIGRvbmUuCisgICAgbG9hZGVyLT5yZXF1ZXN0KCkuc2V0U291cE1lc3NhZ2VGbGFncyhy ZXNwb25zZS5zb3VwTWVzc2FnZUZsYWdzKCkpOworI2VuZGlmCisKICAgICBtX3Jlc3BvbnNlID0g cmVzcG9uc2U7CiB9CiAK 118077 2011-12-06 11:29:03 -0800 2011-12-06 11:29:03 -0800 Patch for landing bug-73924-20111206172938.patch text/plain 1940 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNWQ4OWQxMjVl M2YyMTgzZWYyYzdjZDg2MTU5MmM5NDU1OTZhYTMyNy4uMWMyYTliMDdkZjA0OTBkZmZmNzljZDBk NGFkZGY0ZTlhMjljMjJjNSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEx LTEyLTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIERvIG5vdCBsb3NlIG1lc3NhZ2UgZmxhZ3Mgd2hlbiBjb252ZXJ0aW5nIHRv L2Zyb20gU291cCBSZXF1ZXN0cy9SZXNwb25zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTczOTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2 byBOb3JvbmhhIFNpbHZhLgorCisgICAgICAgIEFwcGx5IHRoZSBzYW1lIGNoYW5nZSBhZGRlZCB0 byB0aGUgR1RLKyBwb3J0IGluIHI1NTA4NiB0byBwcmV2ZW50CisgICAgICAgIHNvdXAgbWVzc2Fn ZSBmbGFncyBmcm9tIGJlaW5nIGxvc3QgYnkgdXBkYXRpbmcgdGhlIHJlcXVlc3QgZmxhZ3Mgd2hl bgorICAgICAgICBhIHJlc3BvbnNlIGlzIHJlY2VpdmVkLgorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVM b2FkZXJDbGllbnRFZmw6OmRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAxMS0xMi0w NCAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0g Rml4IGJyb2tlbiBVVEYtOCBjaGFyYWN0ZXJzIGlzc3VlIG9uIGVkaXRvciBjb21tYW5kLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJD bGllbnRFZmwuY3BwCmluZGV4IDRkZTFjZWNlZjA5ZTYwNGU5NGMzMDZjNjQ5MzllZjU0Y2I3ZDNh ZjkuLjY4ODVlODJmY2NlYjhjMjBlMzg5YzUxNWQ3Y2JiMWM3MmIwZDgyZWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEVmbC5jcHAKQEAgLTIzMCw4ICsyMzAsMTYgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6 ZnJhbWVMb2FkZXJEZXN0cm95ZWQoKQogICAgIGRlbGV0ZSB0aGlzOwogfQogCi12b2lkIEZyYW1l TG9hZGVyQ2xpZW50RWZsOjpkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZShEb2N1bWVudExvYWRl ciosIHVuc2lnbmVkIGxvbmcsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQotewor dm9pZCBGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hEaWRSZWNlaXZlUmVzcG9uc2UoRG9j dW1lbnRMb2FkZXIqIGxvYWRlciwgdW5zaWduZWQgbG9uZywgY29uc3QgUmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UpCit7CisjaWYgVVNFKFNPVVApCisgICAgLy8gVXBkYXRlIG91ciBrbm93bGVk Z2Ugb2YgcmVxdWVzdCBzb3VwIGZsYWdzIC0gc29tZSBhcmUgb25seSBzZXQKKyAgICAvLyBhZnRl ciB0aGUgcmVxdWVzdCBpcyBkb25lLgorICAgIGxvYWRlci0+cmVxdWVzdCgpLnNldFNvdXBNZXNz YWdlRmxhZ3MocmVzcG9uc2Uuc291cE1lc3NhZ2VGbGFncygpKTsKKyNlbHNlCisgICAgVU5VU0VE X1BBUkFNKGxvYWRlcik7CisjZW5kaWYKKwogICAgIG1fcmVzcG9uc2UgPSByZXNwb25zZTsKIH0K IAo=