73914 2011-12-06 05:48:36 -0800 [Qt] Fix assertion in QtViewportInteractionEngine.cpp:468 2011-12-06 12:47:51 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ahf webkit-unassigned kenneth webkit.review.bot zoltan oldest_to_newest 515845 0 ahf 2011-12-06 05:48:36 -0800 Error: ASSERTION FAILED: m_suspendCount /scratchbox/users/ahf/home/ahf/swork/src/webkit-trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp(468) : void WebKit::QtViewportInteractionEngine::pinchGestureStarted(const QPointF&) 1 0x7ffff4d40ac4 2 0x7ffff4d2d932 3 0x7ffff4d2c8f0 4 0x7ffff4d31dc5 5 0x7ffff4cd51c1 6 0x7ffff4d2c66f 7 0x7ffff4d2b711 8 0x7ffff4c72db3 9 0x7ffff4c72e1e 10 0x7ffff414ce1a 11 0x7ffff4160ed1 12 0x7ffff415face 13 0x7ffff415f607 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff4d40ac9 in WebKit::QtViewportInteractionEngine::pinchGestureStarted (this=0x71fc80, pinchCenterInContentCoordinates=...) at /scratchbox/users/ahf/home/ahf/swork/src/webkit-trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:468 468 ASSERT(m_suspendCount); Patch coming up. 515848 1 118033 ahf 2011-12-06 05:53:51 -0800 Created attachment 118033 Patch 515861 2 118033 ahf 2011-12-06 06:09:41 -0800 Comment on attachment 118033 Patch Kling pointed out my obvious failure in the ChangeLog entry. 515864 3 118037 ahf 2011-12-06 06:17:29 -0800 Created attachment 118037 Patch 515921 4 118037 webkit.review.bot 2011-12-06 08:08:57 -0800 Comment on attachment 118037 Patch Rejecting attachment 118037 from commit-queue. New failing tests: media/event-attributes.html Full output: http://queues.webkit.org/results/10703674 515942 5 118037 ahf 2011-12-06 08:58:01 -0800 Comment on attachment 118037 Patch This patch only affects Qt and the test-failure was a Chromium only issue. Reasking for cq. 516004 6 118037 jesus 2011-12-06 10:17:57 -0800 Comment on attachment 118037 Patch cq+ as asked by ahf on #qtwebkit. 516168 7 118037 webkit.review.bot 2011-12-06 12:47:46 -0800 Comment on attachment 118037 Patch Clearing flags on attachment: 118037 Committed r102168: <http://trac.webkit.org/changeset/102168> 516169 8 webkit.review.bot 2011-12-06 12:47:51 -0800 All reviewed patches have been landed. Closing bug. 118033 2011-12-06 05:53:51 -0800 2011-12-06 06:17:20 -0800 Patch bug-73914-20111206150023.patch text/plain 1562 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODRkMjdhODhiZmRkYjA4 ZjczMzU4MDZjYWJkNGRiY2E2NjNkZjMzOC4uYTdiMTNkODkyMTVjMzk1OTI3MzFlMDFkMWFlYWQ0 MjFhOWM2YTcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDExLTEyLTA2ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgogCisgICAgICAgIFtR dF0gRml4IGFzc2VydGlvbiBpbiBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwOjQ2OAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX3N1c3BlbmRD b3VudCBzaG91bGQgbmV2ZXIgYmUgbm9uLXplcm8gd2hlbiBhIHBpbmNoIGdlc3R1cmUgaXMKKyAg ICAgICAgc3RhcnRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJh Y3Rpb25FbmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25F bmdpbmU6OnBpbmNoR2VzdHVyZVN0YXJ0ZWQpOgorCisyMDExLTEyLTA2ICBBbGV4YW5kZXIgRsOm csO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gRml4IGFz c2VydGlvbiBpbiBRdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzkwOAogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3Bw CmluZGV4IGY4NWE1YjNlYWNlMzRiZTFiOTY1OTVlZGEzMTk3NmMwMTM3ZTBjYWMuLmY2NTI4ZWE0 NjU4NzU2NWU2YTYzYjM4NGY2NWUwYzNlNWNkMDAzZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3Bw CkBAIC00NjEsNyArNDYxLDcgQEAgYm9vbCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnBp bmNoR2VzdHVyZUFjdGl2ZSgpIGNvbnN0CiAKIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5n aW5lOjpwaW5jaEdlc3R1cmVTdGFydGVkKGNvbnN0IFFQb2ludEYmIHBpbmNoQ2VudGVySW5Db250 ZW50Q29vcmRpbmF0ZXMpCiB7Ci0gICAgQVNTRVJUKG1fc3VzcGVuZENvdW50KTsKKyAgICBBU1NF UlQoIW1fc3VzcGVuZENvdW50KTsKIAogICAgIGlmICghbV9jb25zdHJhaW50cy5pc1VzZXJTY2Fs YWJsZSkKICAgICAgICAgcmV0dXJuOwo= 118037 2011-12-06 06:17:29 -0800 2011-12-06 12:47:46 -0800 Patch bug-73914-20111206152401.patch text/plain 1526 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjU4YTY5MTg5ZDY4MmU5 YmZhMzQxZGUxZjkzNWQ5N2FkZTk3ZGYxNC4uMmQ5ZDk5NjljZWQ0NTYwNWI0OGIwN2IyNzJhYTRh Y2FlMGJmNmRmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTA2ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCisgICAgICAgIFtR dF0gRml4IGFzc2VydGlvbiBpbiBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwOjQ2OAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX3N1c3BlbmRD b3VudCBzaG91bGQgYWx3YXlzIGJlIHplcm8gd2hlbiBhIHBpbmNoIGdlc3R1cmUgaXMgc3RhcnRl ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnBpbmNo R2VzdHVyZVN0YXJ0ZWQpOgorCiAyMDExLTEyLTA1ICBJZ29yIE9saXZlaXJhICA8aWdvci5vbGl2 ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBGcmFtZSBpcyBub3QgYmVp bmcgc2hvd2VkIGluIHRoZSBzY3JlZW4gd2hlbiBmcmFtZUxvYWRDb21wbGV0ZWQgaXMgY2FsbGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVy YWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IGU4YzE4MWY0Mjc5NzI0MmM2YTUxODIwNTBmYjZm OGMwM2M4ZTllYjguLjUxOTgxNzFhMjJkODVmYmU2M2ViNTUyMjY0NjUxNGQ0ZmUyNjY2ZWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUuY3BwCkBAIC00NjEsNyArNDYxLDcgQEAgYm9vbCBRdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmU6OnBpbmNoR2VzdHVyZUFjdGl2ZSgpIGNvbnN0CiAKIHZvaWQgUXRW aWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpwaW5jaEdlc3R1cmVTdGFydGVkKGNvbnN0IFFQb2lu dEYmIHBpbmNoQ2VudGVySW5Db250ZW50Q29vcmRpbmF0ZXMpCiB7Ci0gICAgQVNTRVJUKG1fc3Vz cGVuZENvdW50KTsKKyAgICBBU1NFUlQoIW1fc3VzcGVuZENvdW50KTsKIAogICAgIGlmICghbV9j b25zdHJhaW50cy5pc1VzZXJTY2FsYWJsZSkKICAgICAgICAgcmV0dXJuOwo=