73913 2011-12-06 05:37:40 -0800 [WK2] New tests introduced in r100895 fail 2013-02-06 05:39:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 74295 72674 87008 1 ossy marja abarth ap jochen marja ossy roger_fong sam webkit.review.bot oldest_to_newest 515835 0 ossy 2011-12-06 05:37:40 -0800 Same fails on SL-WK2 and on Qt-WK2: FAIL: Timed out waiting for notifyDone to be called http/tests/security/referrer-policy-https-always.html: http/tests/security/referrer-policy-https-origin.html http/tests/security/referrer-policy-redirect.html http/tests/security/referrer-policy-https-never.html http/tests/security/referrer-policy-https-default.html 515838 1 jochen 2011-12-06 05:41:31 -0800 When did those tests start to fail? 515843 2 ossy 2011-12-06 05:45:07 -0800 (In reply to comment #1) > When did those tests start to fail? Since they are introduced: r100895. 515852 3 ossy 2011-12-06 05:57:15 -0800 I skipped them to make buildbots a little bit happier: http://trac.webkit.org/changeset/102127 515854 4 jochen 2011-12-06 05:57:57 -0800 ok, I will look into why this fails 515934 5 jochen 2011-12-06 08:27:45 -0800 The tests work locally, although they're all pretty slow on WK2. The difference between these and the remaining tests in that CL is that they redirect through https Could this cause the slowness? 519193 6 jochen 2011-12-12 07:49:11 -0800 Actually, it's not slowness, but WebKitTestRunner doesn't load resources over https for whatever reason. Other tests requiring ssl (like all in http/tests/ssl/) are disabled as well 519203 7 ap 2011-12-12 08:07:03 -0800 In Mac case at least, that could be because of a self signed certificate. DRT has code to silence those, while WTR does not. [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"]; [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"]; 519212 8 jochen 2011-12-12 08:28:56 -0800 (In reply to comment #7) > In Mac case at least, that could be because of a self signed certificate. DRT has code to silence those, while WTR does not. > > [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"]; > [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"]; that might be very well true (I've tried to get the tests work on a Mac). I guess that code needs to be run in the same process that does the actual loading. I've put these lines in InjectedBundle/mac/LayoutTestControllerMac::platformInitialize, but the tests still don't work Given that I don't know much about the WebKitTestRunner, this might be the wrong place... I'll continue to look into this 709190 9 roger_fong 2012-08-30 17:28:58 -0700 DRT has similar issues. I''m testing on Windows. Adding to skip list as well. 824385 10 ap 2013-02-04 08:31:39 -0800 > [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"]; > [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"]; WebKitTestRunner now does this in InjectedBundleMac.mm. Are the tests still failing? 826334 11 marja 2013-02-06 04:35:40 -0800 These seem to be passing now afaics. I'll attach a patch to unskip them. 826336 12 186826 marja 2013-02-06 04:37:06 -0800 Created attachment 186826 Patch 826341 13 186826 jochen 2013-02-06 04:39:52 -0800 Comment on attachment 186826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186826&action=review r=me > LayoutTests/ChangeLog:3 > + Unskipping tests which no longer fail. could you add some more details: something like unskipping referrer policy tests now that WTR supports https tests 826342 14 186828 marja 2013-02-06 04:44:26 -0800 Created attachment 186828 Patch 826343 15 186828 marja 2013-02-06 04:46:02 -0800 Comment on attachment 186828 Patch (Added more information in the ChangeLog.) 826368 16 186828 webkit.review.bot 2013-02-06 05:38:58 -0800 Comment on attachment 186828 Patch Clearing flags on attachment: 186828 Committed r141994: <http://trac.webkit.org/changeset/141994> 826369 17 webkit.review.bot 2013-02-06 05:39:03 -0800 All reviewed patches have been landed. Closing bug. 186826 2013-02-06 04:37:06 -0800 2013-02-06 04:44:23 -0800 Patch bug-73913-20130206133342.patch text/plain 1708 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxOTg2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjdhODI3OWQzMTVlYTk3MGMwZTM0 NTgwNzZlMWJkZWJlZjc2NzU0Yy4uYWE0MDg0NzBkOTg0ZDk2NWExNjMwMzJhZjNmOTU3OTc3OTg4 M2FhMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTA2ICBNYXJqYSBIw7ZsdHTDpCAg PG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBVbnNraXBwaW5nIHRlc3RzIHdoaWNoIG5v IGxvbmdlciBmYWlsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzM5MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTAyLTA2ICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiByZWZhY3RvciByZWdpc3RlclNob3J0Y3V0cyBtZXRob2Qgb2YgRFRFCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGUzMjBhMjkwY2Y1NzQyZDc5 ZDY0Y2M5NGI5MjA1MjFlNTM3NjM1YjkuLjQ3MjQ2OWMxZDAwMDI3YWYxNDZmMWYyYzlkODg3NmQ0 YzY0MDRmZjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zCkBA IC0zMDgsMTUgKzMwOCw2IEBAIGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWZpbGVzLXRvLWVkaXRh YmxlLWVsZW1lbnQuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjM4MDYKIGh0dHAvdGVzdHMvY2FjaGUvaGlzdG9yeS1vbmx5LWNhY2hlZC1zdWJyZXNvdXJj ZS1sb2Fkcy1tYXgtYWdlLWh0dHBzLmh0bWwKIAotIyBbV0syXSBOZXcgdGVzdHMgaW50cm9kdWNl ZCBpbiAxMDA4OTUgZmFpbAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzM5MTMKLWh0dHAvdGVzdHMvc2VjdXJpdHkvcmVmZXJyZXItcG9saWN5LWh0dHBzLWFsd2F5 cy5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L3JlZmVycmVyLXBvbGljeS1odHRwcy1vcmlnaW4u aHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9yZWZlcnJlci1wb2xpY3ktcmVkaXJlY3QuaHRtbAot aHR0cC90ZXN0cy9zZWN1cml0eS9yZWZlcnJlci1wb2xpY3ktcmVkaXJlY3QtbGluay5odG1sCi1o dHRwL3Rlc3RzL3NlY3VyaXR5L3JlZmVycmVyLXBvbGljeS1odHRwcy1uZXZlci5odG1sCi1odHRw L3Rlc3RzL3NlY3VyaXR5L3JlZmVycmVyLXBvbGljeS1odHRwcy1kZWZhdWx0Lmh0bWwKLQogIyBG cmFtZTo6ZmluZFN0cmluZyBkb2VzIG5vdGhpbmcgb24gcGFnZXMgdGhhdCBwcmV2ZW50IHNlbGVj dGlvbgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzNjEKIGVk aXRpbmcvdGV4dC1pdGVyYXRvci9maW5kU3RyaW5nLXNlbGVjdGlvbi1kaXNhYmxlZC5odG1sCg== 186828 2013-02-06 04:44:26 -0800 2013-02-06 05:38:58 -0800 Patch bug-73913-20130206134103.patch text/plain 1778 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxOTg2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjdhODI3OWQzMTVlYTk3MGMwZTM0 NTgwNzZlMWJkZWJlZjc2NzU0Yy4uODQ2MGViMzhkOTRmM2VhNDYxYjQxODFkM2E3N2YwYjRmNDA3 NGNkNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTA2ICBNYXJqYSBIw7ZsdHTDpCAg PG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBbV0syXSBOZXcgdGVzdHMgaW50cm9kdWNl ZCBpbiByMTAwODk1IGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTczOTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9jaGVuIEVpc2luZ2VyLgor CisgICAgICAgIFRoZSB0ZXN0cyBub3cgd29yaywgYmVjYXVzZSBXVFIgc3VwcG9ydHMgSFRUUFMg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx My0wMi0wNiAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogcmVmYWN0b3IgcmVnaXN0ZXJTaG9ydGN1dHMgbWV0aG9kIG9m IERURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlMzIw YTI5MGNmNTc0MmQ3OWQ2NGNjOTRiOTIwNTIxZTUzNzYzNWI5Li40NzI0NjljMWQwMDAyN2FmMTQ2 ZjFmMmM5ZDg4NzZkNGM2NDA0ZmYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93 azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMzA4LDE1ICszMDgsNiBAQCBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1m aWxlcy10by1lZGl0YWJsZS1lbGVtZW50Lmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYzODA2CiBodHRwL3Rlc3RzL2NhY2hlL2hpc3Rvcnktb25seS1jYWNo ZWQtc3VicmVzb3VyY2UtbG9hZHMtbWF4LWFnZS1odHRwcy5odG1sCiAKLSMgW1dLMl0gTmV3IHRl c3RzIGludHJvZHVjZWQgaW4gMTAwODk1IGZhaWwKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTczOTEzCi1odHRwL3Rlc3RzL3NlY3VyaXR5L3JlZmVycmVyLXBvbGlj eS1odHRwcy1hbHdheXMuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9yZWZlcnJlci1wb2xpY3kt aHR0cHMtb3JpZ2luLmh0bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkvcmVmZXJyZXItcG9saWN5LXJl ZGlyZWN0Lmh0bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkvcmVmZXJyZXItcG9saWN5LXJlZGlyZWN0 LWxpbmsuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9yZWZlcnJlci1wb2xpY3ktaHR0cHMtbmV2 ZXIuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9yZWZlcnJlci1wb2xpY3ktaHR0cHMtZGVmYXVs dC5odG1sCi0KICMgRnJhbWU6OmZpbmRTdHJpbmcgZG9lcyBub3RoaW5nIG9uIHBhZ2VzIHRoYXQg cHJldmVudCBzZWxlY3Rpb24KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwMzYxCiBlZGl0aW5nL3RleHQtaXRlcmF0b3IvZmluZFN0cmluZy1zZWxlY3Rpb24tZGlz YWJsZWQuaHRtbAo=