73907 2011-12-06 04:28:53 -0800 [qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate 2011-12-06 08:36:01 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michael.bruning michael.bruning kenneth webkit.review.bot zoltan oldest_to_newest 515803 0 michael.bruning 2011-12-06 04:28:53 -0800 The assert happens because the destructor of QQuickWebViewPrivate destroys the interaction engine, which in turn emits a signal that is handled by QQuickWebViewPrivate. 515812 1 118028 michael.bruning 2011-12-06 04:45:07 -0800 Created attachment 118028 Patch to fix assertion. 515814 2 118028 kenneth 2011-12-06 04:47:58 -0800 Comment on attachment 118028 Patch to fix assertion. View in context: https://bugs.webkit.org/attachment.cgi?id=118028&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:79 > +{ > + if (interactionEngine) > + interactionEngine->blockSignals(true); > +} why not disconnect all signals? 515856 3 118035 michael.bruning 2011-12-06 06:02:24 -0800 Created attachment 118035 Updated patch using disconnect instead of blockSignals Update according to Kenneth's comment. 515858 4 118035 michael.bruning 2011-12-06 06:04:23 -0800 Comment on attachment 118035 Updated patch using disconnect instead of blockSignals Updating flags 515871 5 118035 kenneth 2011-12-06 06:34:38 -0800 Comment on attachment 118035 Updated patch using disconnect instead of blockSignals View in context: https://bugs.webkit.org/attachment.cgi?id=118035&action=review > Source/WebKit2/ChangeLog:8 > + * UIProcess/API/qt/qquickwebview.cpp: Block signals from QtViewportInteractionEngine in diconnect 515879 6 118041 michael.bruning 2011-12-06 06:43:19 -0800 Created attachment 118041 Patch with fixed ChangeLog and commit message. Fixed the ChangeLog and commit message. 515938 7 118041 webkit.review.bot 2011-12-06 08:35:57 -0800 Comment on attachment 118041 Patch with fixed ChangeLog and commit message. Clearing flags on attachment: 118041 Committed r102142: <http://trac.webkit.org/changeset/102142> 515939 8 webkit.review.bot 2011-12-06 08:36:01 -0800 All reviewed patches have been landed. Closing bug. 118028 2011-12-06 04:45:07 -0800 2011-12-06 06:03:06 -0800 Patch to fix assertion. 0001-qt-wk2-Tests-of-QQuickWebView-assert-in-debug-builds.patch text/plain 3191 michael.bruning RnJvbSA2MzQ0ZDg1N2U5ZTE1YTBkM2EwYTQ0NGMzZWZmZWE1NjFlOWUzNWY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJydW5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tp YS5jb20+CkRhdGU6IFR1ZSwgNiBEZWMgMjAxMSAxMzozMzoyMCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFtxdF1bd2syXSBUZXN0cyBvZiBRUXVpY2tXZWJWaWV3IGFzc2VydCBpbiBkZWJ1ZyBidWls ZHMgd2hlbiBkZXN0cm95aW5nIFFRdWlja1dlYlZpZXdQcml2YXRlCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiA4Yml0CgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzM5MDcKClBhdGNoIGJ5IE1pY2hhZWwgQnLDvG5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5j b20+IG9uIDIwMTEtMTItMDYKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFVJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6IEJsb2NrIHNpZ25hbHMgZnJvbSBRdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUgaW4KflFRdWlja1dlYlZpZXdQcml2YXRlCihRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6flFRdWlja1dlYlZpZXdQcml2YXRlKToKKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXdfcF9wLmg6IFJlbW92ZSBlbXB0eSBpbmxpbmUgaW1wbGVtZW50YXRpb24gb2YgflFR dWlja1dlYlZpZXdQcml2YXRlLgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgIHwgICAgNiArKysrKysKIC4uLi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaCAgIHwgICAgMiArLQogMyBm aWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCAyNThhNjkxLi5lN2Y0NTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEt MTItMDYgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5pbmdAbm9raWEuY29tPgorCisg ICAgICAgIFtxdF1bd2syXSBUZXN0cyBvZiBRUXVpY2tXZWJWaWV3IGFzc2VydCBpbiBkZWJ1ZyBi dWlsZHMgd2hlbiBkZXN0cm95aW5nIFFRdWlja1dlYlZpZXdQcml2YXRlIAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5MDcgCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXcuY3BwOiBCbG9jayBzaWduYWxzIGZyb20gUXRWaWV3cG9ydEludGVyYWN0aW9u RW5naW5lIGluIAorICAgICAgICB+UVF1aWNrV2ViVmlld1ByaXZhdGUKKyAgICAgICAgKFFRdWlj a1dlYlZpZXdQcml2YXRlOjp+UVF1aWNrV2ViVmlld1ByaXZhdGUpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaDogUmVtb3ZlIGVtcHR5IGlubGluZSBpbXBs ZW1lbnRhdGlvbiBvZiB+UVF1aWNrV2ViVmlld1ByaXZhdGUuCisKIDIwMTEtMTItMDUgIElnb3Ig T2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XVtX SzJdIEZyYW1lIGlzIG5vdCBiZWluZyBzaG93ZWQgaW4gdGhlIHNjcmVlbiB3aGVuIGZyYW1lTG9h ZENvbXBsZXRlZCBpcyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IGIxNDc4ODEuLmUzNWYwYTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtNzIs NiArNzIsMTIgQEAgUVF1aWNrV2ViVmlld1ByaXZhdGU6OlFRdWlja1dlYlZpZXdQcml2YXRlKFFR dWlja1dlYlZpZXcqIHZpZXdwb3J0LCBXS0NvbnRleHRSZWYKICAgICBwYWdlUHJveHktPmluaXQo ZXZlbnRIYW5kbGVyLmRhdGEoKSk7CiB9CiAKK1FRdWlja1dlYlZpZXdQcml2YXRlOjp+UVF1aWNr V2ViVmlld1ByaXZhdGUoKQoreworICAgIGlmIChpbnRlcmFjdGlvbkVuZ2luZSkKKyAgICAgICAg aW50ZXJhY3Rpb25FbmdpbmUtPmJsb2NrU2lnbmFscyh0cnVlKTsKK30KKwogdm9pZCBRUXVpY2tX ZWJWaWV3UHJpdmF0ZTo6ZW5hYmxlTW91c2VFdmVudHMoKQogewogICAgIFFfUShRUXVpY2tXZWJW aWV3KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlld19wX3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vi dmlld19wX3AuaAppbmRleCBmNTRlZmI1Li42MzRlODAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCkBAIC00OSw3ICs0OSw3 IEBAIGNsYXNzIFFRdWlja1dlYlZpZXdQcml2YXRlIHsKIAogcHVibGljOgogICAgIFFRdWlja1dl YlZpZXdQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0LCBXS0NvbnRleHRSZWYgY29udGV4 dFJlZiA9IDAsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cFJlZiA9IDApOwotICAgIHZpcnR1YWwg flFRdWlja1dlYlZpZXdQcml2YXRlKCkgeyB9CisgICAgdmlydHVhbCB+UVF1aWNrV2ViVmlld1By aXZhdGUoKTsgCiAgICAgdm9pZCBzZXRQYWdlUHJveHkoUXRXZWJQYWdlUHJveHkqKTsKICAgICB2 b2lkIGluaXRpYWxpemVUb3VjaChRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCk7CiAgICAgdm9pZCBp bml0aWFsaXplRGVza3RvcChRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCk7Ci0tIAoxLjcuNC4xCgo= 118035 2011-12-06 06:02:24 -0800 2011-12-06 06:43:19 -0800 Updated patch using disconnect instead of blockSignals 0001-qt-wk2-Tests-of-QQuickWebView-assert-in-debug-builds.patch text/plain 3185 michael.bruning RnJvbSA5MjVkOWZhM2Y0N2U3NDU3ZjBjMWUxN2NmOWU0NjljMjk0MmI2MzZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJydW5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tp YS5jb20+CkRhdGU6IFR1ZSwgNiBEZWMgMjAxMSAxMzozMzoyMCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFtxdF1bd2syXSBUZXN0cyBvZiBRUXVpY2tXZWJWaWV3IGFzc2VydCBpbiBkZWJ1ZyBidWls ZHMgd2hlbiBkZXN0cm95aW5nIFFRdWlja1dlYlZpZXdQcml2YXRlCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiA4Yml0CgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzM5MDcKClBhdGNoIGJ5IE1pY2hhZWwgQnLDvG5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5j b20+IG9uIDIwMTEtMTItMDYKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFVJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6IEJsb2NrIHNpZ25hbHMgZnJvbSBRdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUgaW4KflFRdWlja1dlYlZpZXdQcml2YXRlCihRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6flFRdWlja1dlYlZpZXdQcml2YXRlKToKKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXdfcF9wLmg6IFJlbW92ZSBlbXB0eSBpbmxpbmUgaW1wbGVtZW50YXRpb24gb2YgflFR dWlja1dlYlZpZXdQcml2YXRlLgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgIHwgICAgNiArKysrKysKIC4uLi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaCAgIHwgICAgMiArLQogMyBm aWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCAyNThhNjkxLi5lN2Y0NTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEt MTItMDYgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5pbmdAbm9raWEuY29tPgorCisg ICAgICAgIFtxdF1bd2syXSBUZXN0cyBvZiBRUXVpY2tXZWJWaWV3IGFzc2VydCBpbiBkZWJ1ZyBi dWlsZHMgd2hlbiBkZXN0cm95aW5nIFFRdWlja1dlYlZpZXdQcml2YXRlIAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM5MDcgCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXcuY3BwOiBCbG9jayBzaWduYWxzIGZyb20gUXRWaWV3cG9ydEludGVyYWN0aW9u RW5naW5lIGluIAorICAgICAgICB+UVF1aWNrV2ViVmlld1ByaXZhdGUKKyAgICAgICAgKFFRdWlj a1dlYlZpZXdQcml2YXRlOjp+UVF1aWNrV2ViVmlld1ByaXZhdGUpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaDogUmVtb3ZlIGVtcHR5IGlubGluZSBpbXBs ZW1lbnRhdGlvbiBvZiB+UVF1aWNrV2ViVmlld1ByaXZhdGUuCisKIDIwMTEtMTItMDUgIElnb3Ig T2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XVtX SzJdIEZyYW1lIGlzIG5vdCBiZWluZyBzaG93ZWQgaW4gdGhlIHNjcmVlbiB3aGVuIGZyYW1lTG9h ZENvbXBsZXRlZCBpcyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IGIxNDc4ODEuLmQwYTY1MWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtNzIs NiArNzIsMTIgQEAgUVF1aWNrV2ViVmlld1ByaXZhdGU6OlFRdWlja1dlYlZpZXdQcml2YXRlKFFR dWlja1dlYlZpZXcqIHZpZXdwb3J0LCBXS0NvbnRleHRSZWYKICAgICBwYWdlUHJveHktPmluaXQo ZXZlbnRIYW5kbGVyLmRhdGEoKSk7CiB9CiAKK1FRdWlja1dlYlZpZXdQcml2YXRlOjp+UVF1aWNr V2ViVmlld1ByaXZhdGUoKQoreworICAgIGlmIChpbnRlcmFjdGlvbkVuZ2luZSkKKyAgICAgICAg aW50ZXJhY3Rpb25FbmdpbmUtPmRpc2Nvbm5lY3QoKTsKK30KKwogdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6ZW5hYmxlTW91c2VFdmVudHMoKQogewogICAgIFFfUShRUXVpY2tXZWJWaWV3KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll d19wX3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19w X3AuaAppbmRleCBmNTRlZmI1Li42MzRlODAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCkBAIC00OSw3ICs0OSw3IEBAIGNs YXNzIFFRdWlja1dlYlZpZXdQcml2YXRlIHsKIAogcHVibGljOgogICAgIFFRdWlja1dlYlZpZXdQ cml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0LCBXS0NvbnRleHRSZWYgY29udGV4dFJlZiA9 IDAsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cFJlZiA9IDApOwotICAgIHZpcnR1YWwgflFRdWlj a1dlYlZpZXdQcml2YXRlKCkgeyB9CisgICAgdmlydHVhbCB+UVF1aWNrV2ViVmlld1ByaXZhdGUo KTsgCiAgICAgdm9pZCBzZXRQYWdlUHJveHkoUXRXZWJQYWdlUHJveHkqKTsKICAgICB2b2lkIGlu aXRpYWxpemVUb3VjaChRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCk7CiAgICAgdm9pZCBpbml0aWFs aXplRGVza3RvcChRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCk7Ci0tIAoxLjcuNC4xCgo= 118041 2011-12-06 06:43:19 -0800 2011-12-06 08:35:56 -0800 Patch with fixed ChangeLog and commit message. 0001-qt-wk2-Tests-of-QQuickWebView-assert-in-debug-builds.patch text/plain 3195 michael.bruning RnJvbSAwOTIxZjFhM2QwNTc3Y2Q0NTc0YjgwNTU0NWNhNzFiNDgxMWRkMjNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJydW5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tp YS5jb20+CkRhdGU6IFR1ZSwgNiBEZWMgMjAxMSAxMzozMzoyMCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFtxdF1bd2syXSBUZXN0cyBvZiBRUXVpY2tXZWJWaWV3IGFzc2VydCBpbiBkZWJ1ZyBidWls ZHMgd2hlbiBkZXN0cm95aW5nIFFRdWlja1dlYlZpZXdQcml2YXRlCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiA4Yml0CgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzM5MDcKClBhdGNoIGJ5IE1pY2hhZWwgQnLDvG5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5j b20+IG9uIDIwMTEtMTItMDYKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFVJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6IERpc2Nvbm5lY3Qgc2lnbmFscyBmcm9tIFF0Vmll d3BvcnRJbnRlcmFjdGlvbkVuZ2luZSBpbgp+UVF1aWNrV2ViVmlld1ByaXZhdGUKKFFRdWlja1dl YlZpZXdQcml2YXRlOjp+UVF1aWNrV2ViVmlld1ByaXZhdGUpOgoqIFVJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlld19wX3AuaDogUmVtb3ZlIGVtcHR5IGlubGluZSBpbXBsZW1lbnRhdGlvbiBv ZiB+UVF1aWNrV2ViVmlld1ByaXZhdGUuCi0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCAgfCAgICA2ICsrKysrKwogLi4u L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oICAgfCAgICAyICst CiAzIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCmluZGV4IDI1OGE2OTEuLjkxZTYzODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMS0xMi0wNiAgTWljaGFlbCBCcsO8bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5jb20+ CisKKyAgICAgICAgW3F0XVt3azJdIFRlc3RzIG9mIFFRdWlja1dlYlZpZXcgYXNzZXJ0IGluIGRl YnVnIGJ1aWxkcyB3aGVuIGRlc3Ryb3lpbmcgUVF1aWNrV2ViVmlld1ByaXZhdGUgCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzkwNyAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHA6IERpc2Nvbm5lY3Qgc2lnbmFscyBmcm9tCisgICAgICAgIFF0 Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSBpbiB+UVF1aWNrV2ViVmlld1ByaXZhdGUuCisgICAg ICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6flFRdWlja1dlYlZpZXdQcml2YXRlKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6IFJlbW92ZSBlbXB0eSBp bmxpbmUgaW1wbGVtZW50YXRpb24gb2YgflFRdWlja1dlYlZpZXdQcml2YXRlLgorCiAyMDExLTEy LTA1ICBJZ29yIE9saXZlaXJhICA8aWdvci5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAg ICAgIFtRdF1bV0syXSBGcmFtZSBpcyBub3QgYmVpbmcgc2hvd2VkIGluIHRoZSBzY3JlZW4gd2hl biBmcmFtZUxvYWRDb21wbGV0ZWQgaXMgY2FsbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCBiMTQ3ODgxLi5kMGE2NTFjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5j cHAKQEAgLTcyLDYgKzcyLDEyIEBAIFFRdWlja1dlYlZpZXdQcml2YXRlOjpRUXVpY2tXZWJWaWV3 UHJpdmF0ZShRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCwgV0tDb250ZXh0UmVmCiAgICAgcGFnZVBy b3h5LT5pbml0KGV2ZW50SGFuZGxlci5kYXRhKCkpOwogfQogCitRUXVpY2tXZWJWaWV3UHJpdmF0 ZTo6flFRdWlja1dlYlZpZXdQcml2YXRlKCkKK3sKKyAgICBpZiAoaW50ZXJhY3Rpb25FbmdpbmUp CisgICAgICAgIGludGVyYWN0aW9uRW5naW5lLT5kaXNjb25uZWN0KCk7Cit9CisKIHZvaWQgUVF1 aWNrV2ViVmlld1ByaXZhdGU6OmVuYWJsZU1vdXNlRXZlbnRzKCkKIHsKICAgICBRX1EoUVF1aWNr V2ViVmlldyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXdfcF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXdfcF9wLmgKaW5kZXggZjU0ZWZiNS4uNjM0ZTgwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaApAQCAtNDksNyAr NDksNyBAQCBjbGFzcyBRUXVpY2tXZWJWaWV3UHJpdmF0ZSB7CiAKIHB1YmxpYzoKICAgICBRUXVp Y2tXZWJWaWV3UHJpdmF0ZShRUXVpY2tXZWJWaWV3KiB2aWV3cG9ydCwgV0tDb250ZXh0UmVmIGNv bnRleHRSZWYgPSAwLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYgPSAwKTsKLSAgICB2aXJ0 dWFsIH5RUXVpY2tXZWJWaWV3UHJpdmF0ZSgpIHsgfQorICAgIHZpcnR1YWwgflFRdWlja1dlYlZp ZXdQcml2YXRlKCk7IAogICAgIHZvaWQgc2V0UGFnZVByb3h5KFF0V2ViUGFnZVByb3h5Kik7CiAg ICAgdm9pZCBpbml0aWFsaXplVG91Y2goUVF1aWNrV2ViVmlldyogdmlld3BvcnQpOwogICAgIHZv aWQgaW5pdGlhbGl6ZURlc2t0b3AoUVF1aWNrV2ViVmlldyogdmlld3BvcnQpOwotLSAKMS43LjQu MQoK