73890 2011-12-05 23:11:44 -0800 Simplify KURL's checkEncodedString() 2011-12-06 20:25:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73915 1 benjamin benjamin kling ossy webkit.review.bot oldest_to_newest 515673 0 benjamin 2011-12-05 23:11:44 -0800 Simplify KURL's checkEncodedString() 515679 1 117997 benjamin 2011-12-05 23:36:01 -0800 Created attachment 117997 Patch 515683 2 117997 benjamin 2011-12-05 23:42:45 -0800 Comment on attachment 117997 Patch Thanks 515823 3 117997 webkit.review.bot 2011-12-06 05:05:01 -0800 Comment on attachment 117997 Patch Clearing flags on attachment: 117997 Committed r102123: <http://trac.webkit.org/changeset/102123> 515824 4 webkit.review.bot 2011-12-06 05:05:05 -0800 All reviewed patches have been landed. Closing bug. 515842 5 ossy 2011-12-06 05:43:59 -0800 It made all tests fail in debug mode. (GTK and Qt too) ASSERTION FAILED: !url.isEmpty() || isSchemeFirstChar(url[0]) ../../../../Source/WebCore/platform/KURL.cpp(300) : void WebCore::checkEncodedString(const WTF::String&) Could you guys fix it as soon as possible? 515857 6 kling 2011-12-06 06:02:27 -0800 Assertion fixed with <http://trac.webkit.org/changeset/102128> 515966 7 benjamin 2011-12-06 09:31:31 -0800 Thanks Andreas and Ossy. I was a bit too fast on that one... 515986 8 117997 darin 2011-12-06 09:56:17 -0800 Comment on attachment 117997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117997&action=review > Source/WebCore/platform/KURL.cpp:300 > + UNUSED_PARAM(url); > + ASSERT(url.containsOnlyASCII()); > + ASSERT(!url.isEmpty() || isSchemeFirstChar(url[0])); This should use ASSERT_UNUSED instead of a separate UNUSED_PARAM. In the future, UNUSED_PARAM will be changed to warn if the parameter is used, so we don’t want to compile it in, in any cases where the parameter is used. 515991 9 benjamin 2011-12-06 10:02:02 -0800 (In reply to comment #8) > In the future, UNUSED_PARAM will be changed to warn if the parameter is used, so we don’t want to compile it in, in any cases where the parameter is used. I did not know that is the plan. I will update then. 516337 10 benjamin 2011-12-06 16:15:51 -0800 Reopening to attach new patch. 516339 11 118135 benjamin 2011-12-06 16:15:53 -0800 Created attachment 118135 Patch 516469 12 118135 webkit.review.bot 2011-12-06 20:24:58 -0800 Comment on attachment 118135 Patch Clearing flags on attachment: 118135 Committed r102214: <http://trac.webkit.org/changeset/102214> 516470 13 webkit.review.bot 2011-12-06 20:25:03 -0800 All reviewed patches have been landed. Closing bug. 117997 2011-12-05 23:36:01 -0800 2011-12-06 16:15:47 -0800 Patch bug-73890-20111205233600.patch text/plain 1710 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjZGYxZDUzOWFmZjlj YjVjNWUzMWRlNWU3ZjY3MGJkMzRjODgzYS4uNDllMDc1M2FjYzkwYWNiZDJlZDk5YWVhNGVhMWQy YjBmNmYxZWI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTA1ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBTaW1wbGlmeSBL VVJMJ3MgY2hlY2tFbmNvZGVkU3RyaW5nKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIG1ldGhvZCB3YXMgcmVpbXBsZW1lbnRpbmcgU3RyaW5nOjpj b250YWluc09ubHlBU0NJSSgpLgorICAgICAgICBVc2UgdGhlIG1ldGhvZCBmcm9tIFN0cmluZyBh bmQgd2UgY2FuIHJlbW92ZSB0aGUgI2lmIE5ERUJVRy4KKworICAgICAgICAqIHBsYXRmb3JtL0tV UkwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2hlY2tFbmNvZGVkU3RyaW5nKToKKwogMjAxMS0x Mi0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBV cHN0cmVhbSB0aGUgQ3Vyc29yIGltcGxlbWVudGF0aW9uIG9mIGlPUwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9L VVJMLmNwcAppbmRleCAwMjZjMjU3NzgzYjAwZTU0NjNlOGJlODMzMDhhODkxZWY3ZjllNzliLi40 MjQ3ZGMyNjY4YmI2MzBkZjBjZmU5NjFlN2E0NmE2NDVkN2JiZjRhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9LVVJMLmNwcApAQCAtMjkzLDE5ICsyOTMsMTIgQEAgc3RhdGljIGludCBmaW5kRmlyc3RPZihj b25zdCBVQ2hhciogcywgaW50IHNMZW4sIGludCBzdGFydFBvcywgY29uc3QgY2hhciogdG9GaW4K ICAgICByZXR1cm4gLTE7CiB9CiAKLSNpZm5kZWYgTkRFQlVHCi1zdGF0aWMgdm9pZCBjaGVja0Vu Y29kZWRTdHJpbmcoY29uc3QgU3RyaW5nJiB1cmwpCi17Ci0gICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IHVybC5sZW5ndGgoKTsgKytpKQotICAgICAgICBBU1NFUlQoISh1cmxbaV0gJiB+MHg3 RikpOwotCi0gICAgQVNTRVJUKCF1cmwubGVuZ3RoKCkgfHwgaXNTY2hlbWVGaXJzdENoYXIodXJs WzBdKSk7Ci19Ci0jZWxzZQotc3RhdGljIGlubGluZSB2b2lkIGNoZWNrRW5jb2RlZFN0cmluZyhj b25zdCBTdHJpbmcmKQorc3RhdGljIGlubGluZSB2b2lkIGNoZWNrRW5jb2RlZFN0cmluZyhjb25z dCBTdHJpbmcmIHVybCkKIHsKKyAgICBVTlVTRURfUEFSQU0odXJsKTsKKyAgICBBU1NFUlQodXJs LmNvbnRhaW5zT25seUFTQ0lJKCkpOworICAgIEFTU0VSVCghdXJsLmlzRW1wdHkoKSB8fCBpc1Nj aGVtZUZpcnN0Q2hhcih1cmxbMF0pKTsKIH0KLSNlbmRpZgogCiBpbmxpbmUgYm9vbCBLVVJMOjpw cm90b2NvbElzKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBjb25zdCBjaGFyKiBwcm90b2NvbCkKIHsK 118135 2011-12-06 16:15:53 -0800 2011-12-06 20:24:58 -0800 Patch bug-73890-20111206161552.patch text/plain 1505 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQwZGE0ZGQ0ZTM2MGJj M2YyZGE2Nzc3NmZjZGM5MzMwMDY1NTRjNS4uNmVmMzE3YWNjYmJiN2IyYjBjOWQ2MWZlMmYzNGM4 YWEyNjNjMjUzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTA2ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBTaW1wbGlmeSBL VVJMJ3MgY2hlY2tFbmNvZGVkU3RyaW5nKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIE1hY3JvIFVOVVNFRF9QQVJBTSBpcyBub3Qgc3VwcG9zZWQg dG8gYmUgdXNlZCBmb3IgdGhpcyBjYXNlLAorICAgICAgICB1c2UgQVNTRVJUX1VOVVNFRCBpbnN0 ZWFkLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpj aGVja0VuY29kZWRTdHJpbmcpOgorCiAyMDExLTEyLTA2ICBEYXZpZCBSZXZlbWFuICA8cmV2ZW1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBJbXBsZW1lbnQgdGlsZS1zaXpl ZCBwYWludGluZyB1c2luZyBTa1BpY3R1cmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9LVVJMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCmluZGV4 IGFiNTdkODVkNGJkMTc1NjM3ODUxZTgwM2JlYzU5YTYzMzYzNmM3MmUuLjllYjFlMmZjNTFhNjc5 MjhjMGIxNTg4ODJkYWI1M2JmNzdmMDNiYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0tVUkwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCkBA IC0yOTYsOSArMjk2LDggQEAgc3RhdGljIGludCBmaW5kRmlyc3RPZihjb25zdCBVQ2hhciogcywg aW50IHNMZW4sIGludCBzdGFydFBvcywgY29uc3QgY2hhciogdG9GaW4KIAogc3RhdGljIGlubGlu ZSB2b2lkIGNoZWNrRW5jb2RlZFN0cmluZyhjb25zdCBTdHJpbmcmIHVybCkKIHsKLSAgICBVTlVT RURfUEFSQU0odXJsKTsKLSAgICBBU1NFUlQodXJsLmNvbnRhaW5zT25seUFTQ0lJKCkpOwotICAg IEFTU0VSVCh1cmwuaXNFbXB0eSgpIHx8IGlzU2NoZW1lRmlyc3RDaGFyKHVybFswXSkpOworICAg IEFTU0VSVF9VTlVTRUQodXJsLCB1cmwuY29udGFpbnNPbmx5QVNDSUkoKSk7CisgICAgQVNTRVJU X1VOVVNFRCh1cmwsIHVybC5pc0VtcHR5KCkgfHwgaXNTY2hlbWVGaXJzdENoYXIodXJsWzBdKSk7 CiB9CiAKIGlubGluZSBib29sIEtVUkw6OnByb3RvY29sSXMoY29uc3QgU3RyaW5nJiBzdHJpbmcs IGNvbnN0IGNoYXIqIHByb3RvY29sKQo=