73889 2011-12-05 22:18:35 -0800 TextCheckingParagraph::offsetTo should not have side effect. 2011-12-06 03:24:23 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73616 0 shinyak webkit-unassigned morrita shinyak webkit.review.bot oldest_to_newest 515651 0 shinyak 2011-12-05 22:18:35 -0800 TextCheckingParagraph::offsetTo changes m_offsetAsRange. That often caused unexpected bugs, especially when changing Editor and SpellChecker. This side effect should be eliminated. 515671 1 117994 shinyak 2011-12-05 23:03:40 -0800 Created attachment 117994 Patch 515672 2 117994 morrita 2011-12-05 23:09:04 -0800 Comment on attachment 117994 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117994&action=review > Source/WebCore/editing/TextCheckingHelper.cpp:161 > + if (ec) I guess this never fail. you can use ASSERT_NO_EXCEPTION. 515677 3 117996 shinyak 2011-12-05 23:27:25 -0800 Created attachment 117996 Patch 515777 4 117996 webkit.review.bot 2011-12-06 03:24:19 -0800 Comment on attachment 117996 Patch Clearing flags on attachment: 117996 Committed r102118: <http://trac.webkit.org/changeset/102118> 515778 5 webkit.review.bot 2011-12-06 03:24:23 -0800 All reviewed patches have been landed. Closing bug. 117994 2011-12-05 23:03:40 -0800 2011-12-05 23:27:18 -0800 Patch bug-73889-20111206160338.patch text/plain 1726 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4Y2VjMTg1MGVhODE4 NGM4MmRiMGYxMTU2ODhkOGVlNmI3ZGQ3NS4uZDNhYjc2ODFkNDg3YmYwODNjOGRlMWYzODE5YjFj MjIzYmMzMDk0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODg5CisgICAgICAgIFRleHRDaGVja2luZ1Bh cmFncmFwaDo6b2Zmc2V0VG8gc2hvdWxkIG5vdCBoYXZlIGEgc2lkZSBlZmZlY3QuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgVGV4dENoZWNr aW5nUGFyYWdyYXBoOjpvZmZzZXRUbyBoYWQgYSBzaWRlIGVmZmVjdCwgaXRzIGNhY2hlIG9mdGVu IGJlY2FtZSBpbmNvbnNpc3RlbnQuCisgICAgICAgIFRoaXMgaXMgbGlrZWx5IHRvIGNhdXNlIGEg YnVnIHdoZW4gY2hhbmdpbmcgU3BlbGxDaGVja2VyIGFuZCBFZGl0b3IuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZWRpdGlu Zy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dENoZWNraW5n UGFyYWdyYXBoOjpvZmZzZXRUbyk6CisKIDIwMTEtMTItMDUgIE5vZWwgR29yZG9uICA8bm9lbC5n b3Jkb25AZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEdJRiBpbWFnZSB0ZXN0IGNyYXNoZXMg b24gMzItIGFuZCA2NC1iaXQgUmVsZWFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0 Q2hlY2tpbmdIZWxwZXIuY3BwCmluZGV4IGUyNTRmMjRlNjlmMmU1MGE5Nzc5NGZlOTA0ZmNlMjhh MTQzYzVjODcuLjBiMDk2YTFhMjUwYzYzYWZiYjVjYjYxOWMyMmM3Y2E1ZGY0OWFjYjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHAKQEAgLTE1Nyw3 ICsxNTcsOSBAQCBQYXNzUmVmUHRyPFJhbmdlPiBUZXh0Q2hlY2tpbmdQYXJhZ3JhcGg6OnN1YnJh bmdlKGludCBjaGFyYWN0ZXJPZmZzZXQsIGludCBjaGFyYQogaW50IFRleHRDaGVja2luZ1BhcmFn cmFwaDo6b2Zmc2V0VG8oY29uc3QgUG9zaXRpb24mIHBvc2l0aW9uLCBFeGNlcHRpb25Db2RlJiBl YykgY29uc3QKIHsKICAgICBBU1NFUlQobV9jaGVja2luZ1JhbmdlKTsKLSAgICBSZWZQdHI8UmFu Z2U+IHJhbmdlID0gb2Zmc2V0QXNSYW5nZSgpOworICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBv ZmZzZXRBc1JhbmdlKCktPmNsb25lUmFuZ2UoZWMpOworICAgIGlmIChlYykKKyAgICAgICAgcmV0 dXJuIDA7CiAgICAgcmFuZ2UtPnNldEVuZChwb3NpdGlvbi5jb250YWluZXJOb2RlKCksIHBvc2l0 aW9uLmNvbXB1dGVPZmZzZXRJbkNvbnRhaW5lck5vZGUoKSwgZWMpOwogICAgIGlmIChlYykKICAg ICAgICAgcmV0dXJuIDA7Cg== 117996 2011-12-05 23:27:25 -0800 2011-12-06 03:24:19 -0800 Patch bug-73889-20111206162723.patch text/plain 1711 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4Y2VjMTg1MGVhODE4 NGM4MmRiMGYxMTU2ODhkOGVlNmI3ZGQ3NS4uZDNhYjc2ODFkNDg3YmYwODNjOGRlMWYzODE5YjFj MjIzYmMzMDk0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTA1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODg5CisgICAgICAgIFRleHRDaGVja2luZ1Bh cmFncmFwaDo6b2Zmc2V0VG8gc2hvdWxkIG5vdCBoYXZlIGEgc2lkZSBlZmZlY3QuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgVGV4dENoZWNr aW5nUGFyYWdyYXBoOjpvZmZzZXRUbyBoYWQgYSBzaWRlIGVmZmVjdCwgaXRzIGNhY2hlIG9mdGVu IGJlY2FtZSBpbmNvbnNpc3RlbnQuCisgICAgICAgIFRoaXMgaXMgbGlrZWx5IHRvIGNhdXNlIGEg YnVnIHdoZW4gY2hhbmdpbmcgU3BlbGxDaGVja2VyIGFuZCBFZGl0b3IuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZWRpdGlu Zy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dENoZWNraW5n UGFyYWdyYXBoOjpvZmZzZXRUbyk6CisKIDIwMTEtMTItMDUgIE5vZWwgR29yZG9uICA8bm9lbC5n b3Jkb25AZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEdJRiBpbWFnZSB0ZXN0IGNyYXNoZXMg b24gMzItIGFuZCA2NC1iaXQgUmVsZWFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0 Q2hlY2tpbmdIZWxwZXIuY3BwCmluZGV4IGUyNTRmMjRlNjlmMmU1MGE5Nzc5NGZlOTA0ZmNlMjhh MTQzYzVjODcuLjk3NjFjNzU0NGU0YTNiYjNhZjE1NDFmYWFhODhjOGRjNmVjMTk3ZGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHAKQEAgLTE1Nyw3 ICsxNTcsNyBAQCBQYXNzUmVmUHRyPFJhbmdlPiBUZXh0Q2hlY2tpbmdQYXJhZ3JhcGg6OnN1YnJh bmdlKGludCBjaGFyYWN0ZXJPZmZzZXQsIGludCBjaGFyYQogaW50IFRleHRDaGVja2luZ1BhcmFn cmFwaDo6b2Zmc2V0VG8oY29uc3QgUG9zaXRpb24mIHBvc2l0aW9uLCBFeGNlcHRpb25Db2RlJiBl YykgY29uc3QKIHsKICAgICBBU1NFUlQobV9jaGVja2luZ1JhbmdlKTsKLSAgICBSZWZQdHI8UmFu Z2U+IHJhbmdlID0gb2Zmc2V0QXNSYW5nZSgpOworICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBv ZmZzZXRBc1JhbmdlKCktPmNsb25lUmFuZ2UoQVNTRVJUX05PX0VYQ0VQVElPTik7CiAgICAgcmFu Z2UtPnNldEVuZChwb3NpdGlvbi5jb250YWluZXJOb2RlKCksIHBvc2l0aW9uLmNvbXB1dGVPZmZz ZXRJbkNvbnRhaW5lck5vZGUoKSwgZWMpOwogICAgIGlmIChlYykKICAgICAgICAgcmV0dXJuIDA7 Cg==