73888 2011-12-05 21:24:18 -0800 REGRESSION (WebKit2): Kill ring is not cleared when selection changes 2011-12-06 10:55:26 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap ap dglazkov eoconnor mrowe webkit.review.bot oldest_to_newest 515632 0 ap 2011-12-05 21:24:18 -0800 Pressing Ctrl+K twice should only add to kill ring if nothing else happens in between. <rdar://problem/10532310> 515636 1 117988 ap 2011-12-05 21:39:35 -0800 Created attachment 117988 proposed fix 515638 2 117988 ap 2011-12-05 21:41:25 -0800 Comment on attachment 117988 proposed fix Landing via commit queue to give bots time to complain. 515643 3 117988 webkit.review.bot 2011-12-05 21:58:00 -0800 Comment on attachment 117988 proposed fix Attachment 117988 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10736565 515670 4 ap 2011-12-05 23:03:11 -0800 > Attachment 117988 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10736565 The error doesn't appear related to this patch. 515735 5 117988 webkit.review.bot 2011-12-06 01:59:13 -0800 Comment on attachment 117988 proposed fix Rejecting attachment 117988 from commit-queue. New failing tests: editing/pasteboard/emacs-ctrl-k-with-move.html Full output: http://queues.webkit.org/results/10733906 515975 6 ap 2011-12-06 09:38:07 -0800 Committed <http://trac.webkit.org/changeset/102148>. Added the new test to fail lists of platforms that failed existing emacs tests. 117988 2011-12-05 21:39:35 -0800 2011-12-06 01:59:13 -0800 proposed fix CtrlK.txt text/plain 6098 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjA5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTA1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKFdlYktp dDIpOiBLaWxsIHJpbmcgaXMgbm90IGNsZWFyZWQgd2hlbiBzZWxlY3Rpb24gY2hhbmdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM4ODgKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzEwNTMyMzEwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvcGFzdGVib2FyZC9lbWFjcy1jdHJs LWstd2l0aC1tb3ZlLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDogKFdlYkNv cmU6OkVkaXRvcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbik6IE1vdmVkIHRoZSBjb2RlIHRv IGNsZWFyCisgICAgICAgIGtpbGwgcmluZyBmcm9tIE1hYyBXZWJLaXQsIGFzIGl0J3MgbmVlZGVk IGluIGFsbCBNYWMgcG9ydHMgYXQgbGVhc3QuCisKIDIwMTEtMTItMDUgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTczNjgzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxMDEx OTcpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ4NCw2ICs0ODQsNyBAQCB2b2lkIEVkaXRvcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlv bihjCiB7CiAgICAgaWYgKGNsaWVudCgpKQogICAgICAgICBjbGllbnQoKS0+cmVzcG9uZFRvQ2hh bmdlZFNlbGVjdGlvbihtX2ZyYW1lKTsKKyAgICBzZXRTdGFydE5ld0tpbGxSaW5nU2VxdWVuY2Uo dHJ1ZSk7CiAgICAgbV9kZWxldGVCdXR0b25Db250cm9sbGVyLT5yZXNwb25kVG9DaGFuZ2VkU2Vs ZWN0aW9uKG9sZFNlbGVjdGlvbik7CiAgICAgbV9zcGVsbGluZ0NvcnJlY3Rvci0+cmVzcG9uZFRv Q2hhbmdlZFNlbGVjdGlvbihvbGRTZWxlY3Rpb24pOwogfQpJbmRleDogU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwko cmV2aXNpb24gMTAyMDkyKQorKysgU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTItMDUgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoV2ViS2l0Mik6IEtpbGwgcmlu ZyBpcyBub3QgY2xlYXJlZCB3aGVuIHNlbGVjdGlvbiBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mzg4OAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMTA1MzIzMTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAgICAgICAoLVtXZWJIVE1MVmll dyBiZWNvbWVGaXJzdFJlc3BvbmRlcl0pOiBBZGRlZCBhIEZJWE1FIGNvbW1lbnQuCisgICAgICAg ICgtW1dlYkhUTUxWaWV3IF9zZWxlY3Rpb25DaGFuZ2VkXSk6IE1vdmVkIHRoZSBjb2RlIHRvIGNs ZWFyIGtpbGwgcmluZyB0byBXZWJDb3JlLiBUaGUgcmVzdAorICAgICAgICBvZiBraWxsIHJpbmcg aW1wbGVtZW50YXRpb24gaXMgdGhlcmUsIHNvIGl0IG1ha2VzIG5vIHNlbnNlIHRvIGhhdmUgdGhp cyBjYWxsIGluIFdlYktpdHMuCisKIDIwMTEtMTItMDUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIExheWVyRmx1c2hTY2hlZHVsZXJDbGllbnQ6 OmZsdXNoTGF5ZXJzIGluZGljYXRlIHdoZXRoZXIgdGhlIGZsdXNoIHdhcyBzdWNjZXNzZnVsIG9y IG5vdApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCShyZXZp c2lvbiAxMDExOTcpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1t CSh3b3JraW5nIGNvcHkpCkBAIC0zNzYxLDYgKzM3NjEsNyBAQCAtIChCT09MKWJlY29tZUZpcnN0 UmVzcG9uZGVyCiAgICAgW3NlbGYgX3VwZGF0ZVNlY3VyZUlucHV0U3RhdGVdOwogICAgIF9wcml2 YXRlLT5fZm9yY2VVcGRhdGVTZWN1cmVJbnB1dFN0YXRlID0gTk87CiAKKyAgICAvLyBGSVhNRTog S2lsbCByaW5nIGhhbmRsaW5nIGlzIG1vc3RseSBpbiBXZWJDb3JlLCBzbyB0aGlzIGNhbGwgc2hv dWxkIGFsc28gYmUgbW92ZWQgdGhlcmUuCiAgICAgZnJhbWUtPmVkaXRvcigpLT5zZXRTdGFydE5l d0tpbGxSaW5nU2VxdWVuY2UodHJ1ZSk7CiAKICAgICBQYWdlKiBwYWdlID0gZnJhbWUtPnBhZ2Uo KTsKQEAgLTUwMDEsOCArNTAwMiw2IEBAIC0gKHZvaWQpX3NlbGVjdGlvbkNoYW5nZWQKIHsKICAg ICBbc2VsZiBfdXBkYXRlU2VsZWN0aW9uRm9ySW5wdXRNYW5hZ2VyXTsKICAgICBbc2VsZiBfdXBk YXRlRm9udFBhbmVsXTsKLSAgICBpZiAoRnJhbWUqIGNvcmVGcmFtZSA9IGNvcmUoW3NlbGYgX2Zy YW1lXSkpCi0gICAgICAgIGNvcmVGcmFtZS0+ZWRpdG9yKCktPnNldFN0YXJ0TmV3S2lsbFJpbmdT ZXF1ZW5jZSh0cnVlKTsKIH0KIAogLSAodm9pZClfdXBkYXRlRm9udFBhbmVsCkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxMDIwOTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMi0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFw cGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChXZWJLaXQyKTogS2lsbCByaW5nIGlzIG5v dCBjbGVhcmVkIHdoZW4gc2VsZWN0aW9uIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODg4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x MDUzMjMxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGVkaXRpbmcvcGFzdGVib2FyZC9lbWFjcy1jdHJsLWstd2l0aC1tb3ZlLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9wYXN0ZWJvYXJkL2VtYWNzLWN0cmwtay13aXRo LW1vdmUuaHRtbDogQWRkZWQuCisKIDIwMTEtMTItMDUgIEZsb3JpbiBNYWxpdGEgIDxmbWFsaXRh QGdvb2dsZS5jb20+CiAKICAgICAgICAgSGVhcC1idWZmZXItb3ZlcmZsb3cgaW4gV2ViQ29yZTo6 SFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzRW5kVGFnCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5n L3Bhc3RlYm9hcmQvZW1hY3MtY3RybC1rLXdpdGgtbW92ZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2VtYWNzLWN0cmwtay13aXRoLW1v dmUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0 ZWJvYXJkL2VtYWNzLWN0cmwtay13aXRoLW1vdmUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDE0IEBACitUZXN0IGZvciBidWcgNzM4ODg6IEtpbGwgcmluZyBpcyBub3QgY2xl YXJlZCB3aGVuIHNlbGVjdGlvbiBjaGFuZ2VzLgorCitvbmUKK3RocmVlCitmaXZlCitmb3VyCisK K0V4cGVjdGVkIHJlc3VsdDoKK29uZQordGhyZWUKK2ZpdmUKK2ZvdXIKKworCgpQcm9wZXJ0eSBj aGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvZW1hY3MtY3RybC1rLXdp dGgtbW92ZS1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOm1pbWUtdHlwZQogICAr IHRleHQvcGxhaW4KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvZW1hY3MtY3RybC1rLXdpdGgtbW92ZS5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9lbWFjcy1jdHJsLWst d2l0aC1tb3ZlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3Rl Ym9hcmQvZW1hY3MtY3RybC1rLXdpdGgtbW92ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDM2IEBACis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzM4ODgiPmJ1ZyA3Mzg4ODwvYT46CitLaWxsIHJpbmcgaXMgbm90IGNsZWFy ZWQgd2hlbiBzZWxlY3Rpb24gY2hhbmdlcy48L3A+CisKKzxkaXYgY29udGVudGVkaXRhYmxlIGlk PWNlPgorb25lCis8ZGl2PnR3bzwvZGl2PgorPGRpdj50aHJlZTwvZGl2PgorPGRpdj5mb3VyPC9k aXY+Cis8ZGl2PmZpdmU8L2Rpdj4KKzxkaXY+PGJyPjwvZGl2PgorPC9kaXY+CisKKzxkaXY+CitF eHBlY3RlZCByZXN1bHQ6Cis8ZGl2Pm9uZTwvZGl2PgorPGRpdj50aHJlZTwvZGl2PgorPGRpdj5m aXZlPC9kaXY+Cis8ZGl2PmZvdXI8L2Rpdj4KKzxkaXY+PGJyPjwvZGl2PgorPC9kaXY+CisKKzxz Y3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJj ZSIpLmZvY3VzKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXhlY0NvbW1hbmQoIm1vdmVE b3duIik7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXhlY0NvbW1hbmQoImRlbGV0ZVRvRW5k T2ZQYXJhZ3JhcGgiKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5leGVjQ29tbWFuZCgiZGVs ZXRlVG9FbmRPZlBhcmFncmFwaCIpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmV4ZWNDb21t YW5kKCJtb3ZlRG93biIpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmV4ZWNDb21tYW5kKCJk ZWxldGVUb0VuZE9mUGFyYWdyYXBoIik7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXhlY0Nv bW1hbmQoImRlbGV0ZVRvRW5kT2ZQYXJhZ3JhcGgiKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5leGVjQ29tbWFuZCgibW92ZURvd24iKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5leGVj Q29tbWFuZCgieWFuayIpOworfSBlbHNlCisgICAgZG9jdW1lbnQud3JpdGUoIlRoaXMgdGVzdCBv bmx5IHJ1bnMgaW4gYXV0b21hdGljIG1vZGUiKTsKKzwvc2NyaXB0PgoKUHJvcGVydHkgY2hhbmdl cyBvbjogTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2VtYWNzLWN0cmwtay13aXRoLW1v dmUuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCgo=