73878 2011-12-05 16:48:53 -0800 webkit.py: Really fix the printing of StringImpl now that 8 bit strings are present 2011-12-05 18:09:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco mitz simon.fraser tony oldest_to_newest 515499 0 rakuco 2011-12-05 16:48:53 -0800 r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}. r98785 made webkit.py always use m_data16, which does not work when the string is an 8-bit string (such as KURL::string()). I was not able to directly call StringImpl::is8Bit() in the Python code, so I just reproduced the implementation there. 515502 1 117956 rakuco 2011-12-05 16:54:00 -0800 Created attachment 117956 Patch 515511 2 117956 tony 2011-12-05 17:04:50 -0800 Comment on attachment 117956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117956&action=review > Tools/gdb/webkit.py:112 > + return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \ > + self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer'] The line wrapping is wrong (incorrect indention), but I would either just make this a single line. > Tools/gdb/webkit.py:136 > + return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \ > + self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer'] Ditto. 515567 3 rakuco 2011-12-05 18:09:20 -0800 Committed r102083: <http://trac.webkit.org/changeset/102083> 117956 2011-12-05 16:54:00 -0800 2011-12-05 17:04:50 -0800 Patch bug-73878-20111205225435.patch text/plain 2890 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzE2MTQyMjRjZjY4MjQ4YWM3ZTE4ZWVhZWI0MGEyMDZk MmEzMmU5NS4uYWM3YzVhYzYwOWYxMWEyZWU2MjY2NzBkZmU3YTdmZGE4NTUwMjIwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1 IEBACiAyMDExLTEyLTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5t b2JpPgogCisgICAgICAgIHdlYmtpdC5weTogUmVhbGx5IGZpeCB0aGUgcHJpbnRpbmcgb2YgU3Ry aW5nSW1wbCBub3cgdGhhdCA4LWJpdCBzdHJpbmdzIGFyZSBwcmVzZW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM4NzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByOTg2MjQgdHVybmVkIFN0cmluZ0lt cGw6Om1fZGF0YSBpbnRvIFN0cmluZ0ltcGw6OnttX2RhdGE4LG1fZGF0YTE2fS4KKyAgICAgICAg cjk4Nzg1IG1hZGUgd2Via2l0LnB5IGFsd2F5cyB1c2UgbV9kYXRhMTYsIHdoaWNoIGRvZXMgbm90 IHdvcmsgd2hlbgorICAgICAgICB0aGUgc3RyaW5nIGlzIGFuIDgtYml0IHN0cmluZyAoc3VjaCBh cyBLVVJMOjpzdHJpbmcoKSkuCisKKyAgICAgICAgSSB3YXMgbm90IGFibGUgdG8gZGlyZWN0bHkg Y2FsbCBTdHJpbmdJbXBsOjppczhCaXQoKSBpbiB0aGUgUHl0aG9uCisgICAgICAgIGNvZGUsIHNv IEkganVzdCByZXByb2R1Y2VkIHRoZSBpbXBsZW1lbnRhdGlvbiB0aGVyZS4KKworICAgICAgICAq IGdkYi93ZWJraXQucHk6CisgICAgICAgIChXVEZTdHJpbmdQcmludGVyLmlzXzhiaXQpOiBSZXBy b2R1Y2VkIFN0cmluZ0ltcGw6OmlzOEJpdCgpLgorICAgICAgICAoV1RGU3RyaW5nUHJpbnRlci50 b19zdHJpbmcpOgorICAgICAgICAoSlNDVVN0cmluZ1ByaW50ZXIuaXNfOGJpdCk6IFJlcHJvZHVj ZWQgU3RyaW5nSW1wbDo6aXM4Qml0KCkuCisgICAgICAgIChKU0NVU3RyaW5nUHJpbnRlci50b19z dHJpbmcpOgorCisyMDExLTEyLTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1 c2lvbi5tb2JpPgorCiAgICAgICAgIEFkZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCiAKICAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weToKZGlmZiAt LWdpdCBhL1Rvb2xzL2dkYi93ZWJraXQucHkgYi9Ub29scy9nZGIvd2Via2l0LnB5CmluZGV4IDgz YTNlOGFmNGIzYzhjMGM2NGZhYzAyOGU0YzNiN2U3MzllY2Y2ODEuLjBlZDYzZWI2YmYyZDk0MGRj NTkyMzE2MzI3YTc1Zjc4YjA0MmQ4NTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2dkYi93ZWJraXQucHkK KysrIGIvVG9vbHMvZ2RiL3dlYmtpdC5weQpAQCAtMTA3LDExICsxMDcsMjAgQEAgY2xhc3MgV1RG U3RyaW5nUHJpbnRlcihTdHJpbmdQcmludGVyKToKICAgICAgICAgICAgIHJldHVybiAwCiAgICAg ICAgIHJldHVybiBzZWxmLnZhbFsnbV9pbXBsJ11bJ21fcHRyJ11bJ21fbGVuZ3RoJ10KIAorICAg IGRlZiBpc184Yml0KHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi52YWxbJ21faW1wbCddWydt X3B0ciddWydtX2hhc2hBbmRGbGFncyddICYgXAorICAgICAgICAgICAgICAgc2VsZi52YWxbJ21f aW1wbCddWydtX3B0ciddWydzX2hhc2hGbGFnOEJpdEJ1ZmZlciddCisKICAgICBkZWYgdG9fc3Ry aW5nKHNlbGYpOgogICAgICAgICBpZiBzZWxmLmdldF9sZW5ndGgoKSA9PSAwOgogICAgICAgICAg ICAgcmV0dXJuICcobnVsbCknCiAKLSAgICAgICAgcmV0dXJuIHVzdHJpbmdfdG9fc3RyaW5nKHNl bGYudmFsWydtX2ltcGwnXVsnbV9wdHInXVsnbV9kYXRhMTYnXSwKKyAgICAgICAgaWYgc2VsZi5p c184Yml0KCk6CisgICAgICAgICAgICBkYXRhX21lbWJlciA9ICdtX2RhdGE4JworICAgICAgICBl bHNlOgorICAgICAgICAgICAgZGF0YV9tZW1iZXIgPSAnbV9kYXRhMTYnCisKKyAgICAgICAgcmV0 dXJuIHVzdHJpbmdfdG9fc3RyaW5nKHNlbGYudmFsWydtX2ltcGwnXVsnbV9wdHInXVtkYXRhX21l bWJlcl0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLmdldF9sZW5ndGgo KSkKIAogCkBAIC0xMjIsMTEgKzEzMSwyMCBAQCBjbGFzcyBKU0NVU3RyaW5nUHJpbnRlcihTdHJp bmdQcmludGVyKToKICAgICAgICAgICAgIHJldHVybiAwCiAgICAgICAgIHJldHVybiBzZWxmLnZh bFsnbV9pbXBsJ11bJ21fcHRyJ11bJ21fbGVuZ3RoJ10KIAorICAgIGRlZiBpc184Yml0KHNlbGYp OgorICAgICAgICByZXR1cm4gc2VsZi52YWxbJ21faW1wbCddWydtX3B0ciddWydtX2hhc2hBbmRG bGFncyddICYgXAorICAgICAgICAgICAgICAgc2VsZi52YWxbJ21faW1wbCddWydtX3B0ciddWydz X2hhc2hGbGFnOEJpdEJ1ZmZlciddCisKICAgICBkZWYgdG9fc3RyaW5nKHNlbGYpOgogICAgICAg ICBpZiBzZWxmLmdldF9sZW5ndGgoKSA9PSAwOgogICAgICAgICAgICAgcmV0dXJuICcnCiAKLSAg ICAgICAgcmV0dXJuIHVzdHJpbmdfdG9fc3RyaW5nKHNlbGYudmFsWydtX2ltcGwnXVsnbV9wdHIn XVsnbV9kYXRhMTYnXSwKKyAgICAgICAgaWYgc2VsZi5pc184Yml0KCk6CisgICAgICAgICAgICBk YXRhX21lbWJlciA9ICdtX2RhdGE4JworICAgICAgICBlbHNlOgorICAgICAgICAgICAgZGF0YV9t ZW1iZXIgPSAnbV9kYXRhMTYnCisKKyAgICAgICAgcmV0dXJuIHVzdHJpbmdfdG9fc3RyaW5nKHNl bGYudmFsWydtX2ltcGwnXVsnbV9wdHInXVtkYXRhX21lbWJlcl0sCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzZWxmLmdldF9sZW5ndGgoKSkKIAogCg==