73871 2011-12-05 15:38:06 -0800 Create StringImpl::empty() as an 8 bit string 2011-12-06 09:21:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 73236 1 msaboff msaboff darin oldest_to_newest 515456 0 msaboff 2011-12-05 15:38:06 -0800 The zero length empty string returned by the static method StringImpl ::empty() should be created as an 8 bit string. This will help performance when concatenated with other strings. 515553 1 117968 msaboff 2011-12-05 17:50:30 -0800 Created attachment 117968 Patch This patch provides no performance benefit by itself, but allows for future changes that concat null strings to use an 8 bit path. 515564 2 msaboff 2011-12-05 18:07:02 -0800 Committed r102082: <http://trac.webkit.org/changeset/102082> 515956 3 117968 darin 2011-12-06 09:21:01 -0800 Comment on attachment 117968 Patch Why? 515959 4 darin 2011-12-06 09:21:32 -0800 (In reply to comment #3) > Why? Oh, I see now. The rationale is in the bug, but not the patch. Next time please put it in the patch. 117968 2011-12-05 17:50:30 -0800 2011-12-06 09:21:01 -0800 Patch 73871.patch text/plain 1486 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAyMDc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDExLTEyLTA1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENyZWF0ZSBTdHJpbmdJbXBsOjplbXB0eSgpIGFzIGFuIDggYml0IHN0cmluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM4NzEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmlu Z1N0YXRpY3MuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjplbXB0eSk6IENoYW5nZWQg dG8gYmUgYW4gOCBiaXQgc3RyaW5nLgorCiAyMDExLTEyLTA1ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBDb252ZXJ0IEpTQ2xhc3NSZWYgdG8gdXNlIEhhc2hNYXA8 T3duUHRyPgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ1N0YXRp Y3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJp bmdTdGF0aWNzLmNwcAkocmV2aXNpb24gMTAyMDE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L1N0cmluZ1N0YXRpY3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw4ICs0Niw4 IEBAIFN0cmluZ0ltcGwqIFN0cmluZ0ltcGw6OmVtcHR5KCkKICAgICAvLyBpbnRvIHRoZSB6ZXJv LXBhZ2UuCiAgICAgLy8gUmVwbGFjZSB0aGlzIHdpdGggJ3JlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIq PihzdGF0aWNfY2FzdDxpbnRwdHJfdD4oMSkpJyBvbmNlCiAgICAgLy8gUENSRSBnb2VzIGF3YXku Ci0gICAgc3RhdGljIFVDaGFyIGVtcHR5VUNoYXJEYXRhID0gMDsKLSAgICBERUZJTkVfU1RBVElD X0xPQ0FMKFN0cmluZ0ltcGwsIGVtcHR5U3RyaW5nLCAoJmVtcHR5VUNoYXJEYXRhLCAwLCBDb25z dHJ1Y3RTdGF0aWNTdHJpbmcpKTsKKyAgICBzdGF0aWMgTENoYXIgZW1wdHlMQ2hhckRhdGEgPSAw OworICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nSW1wbCwgZW1wdHlTdHJpbmcsICgmZW1w dHlMQ2hhckRhdGEsIDAsIENvbnN0cnVjdFN0YXRpY1N0cmluZykpOwogICAgIFdURl9BTk5PVEFU RV9CRU5JR05fUkFDRSgmZW1wdHlTdHJpbmcsICJCZW5pZ24gcmFjZSBvbiBTdHJpbmdJbXBsOjpl bXB0eVN0cmluZyByZWZlcmVuY2UgY291bnRlciIpOwogICAgIHJldHVybiAmZW1wdHlTdHJpbmc7 CiB9Cg==