73863 2011-12-05 14:05:14 -0800 [Qt] MiniBrowser should default to touch behavior 2011-12-05 21:55:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ahf webkit-unassigned hausmann kenneth webkit.review.bot oldest_to_newest 515377 0 ahf 2011-12-05 14:05:14 -0800 Currently, the Qt MiniBrowser defaults to traditional desktop behavior instead of touch behavior. 515390 1 117938 ahf 2011-12-05 14:18:13 -0800 Created attachment 117938 Patch 515397 2 117938 cshu 2011-12-05 14:26:32 -0800 Comment on attachment 117938 Patch Agree with the switch. 515641 3 117938 webkit.review.bot 2011-12-05 21:55:33 -0800 Comment on attachment 117938 Patch Clearing flags on attachment: 117938 Committed r102093: <http://trac.webkit.org/changeset/102093> 515642 4 webkit.review.bot 2011-12-05 21:55:37 -0800 All reviewed patches have been landed. Closing bug. 117938 2011-12-05 14:18:13 -0800 2011-12-05 21:55:33 -0800 Patch bug-73863-20111205231811.patch text/plain 4967 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDFiY2NmOGZkNDM4YjM1M2M4MWQ5NWFiNWI5MDVkMzYx ZmU4MWYxMi4uYjU5OGQ0NWZmMDI0MmU4YzQwY2MxNTVmNTFlMTEwYzYyNTIyZDMxOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDExLTEyLTA1ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r aWEuY29tPgorCisgICAgICAgIFtRdF0gTWluaUJyb3dzZXIgc2hvdWxkIGRlZmF1bHQgdG8gdG91 Y2ggYmVoYXZpb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTczODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWluaUJyb3dzZXIgY3VycmVudGx5IGRlZmF1bHRzIHRvIHRoZSB0cmFkaXRpb25hbCBkZXNr dG9wIGJlaGF2aW91cgorICAgICAgICBpbnN0ZWFkIG9mIHRvdWNoIGJlaGF2aW91ciB3aGljaCBp cyBwcmVmZXJlZC4KKworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3Bw OgorICAgICAgICAoQnJvd3NlcldpbmRvdzo6QnJvd3NlcldpbmRvdyk6CisgICAgICAgICogTWlu aUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5jcHA6CisgICAgICAgIChwcmludEhl bHApOgorICAgICAgICAoTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6aGFuZGxlVXNlck9wdGlvbnMp OgorICAgICAgICAqIE1pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaDoKKyAg ICAgICAgKFdpbmRvd09wdGlvbnM6OldpbmRvd09wdGlvbnMpOgorICAgICAgICAoV2luZG93T3B0 aW9uczo6c2V0VXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVoYXZpb3IpOgorICAgICAgICAoV2luZG93 T3B0aW9uczo6dXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVoYXZpb3IpOgorCiAyMDExLTEyLTA1ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFRlbXBvcmFyaWx5IHNl dCAtLWNoaWxkLXByb2Nlc3M9MSBvbiBNYWMgYmVjYXVzZSAyMCsgdGVzdHMgYXJlIHRpbWluZyBv dXQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwIGIv VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKaW5kZXggMGQ5M2Q3YWVlNmRh ZGQ1NjU5NjNiODM1YmUyM2JmOTI4NTE2MTViZC4uY2FkNTViMWZmM2FiODE1OWI5NmU2ZGQ1ZGZl MzUyMjk3Yjk3ZjVkNyAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3Nlcldp bmRvdy5jcHAKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAKQEAg LTUxLDcgKzUxLDcgQEAgQnJvd3NlcldpbmRvdzo6QnJvd3NlcldpbmRvdyhXaW5kb3dPcHRpb25z KiBvcHRpb25zKQogICAgIGVuZ2luZSgpLT5yb290Q29udGV4dCgpLT5zZXRDb250ZXh0UHJvcGVy dHkoIm9wdGlvbnMiLCBvcHRpb25zKTsKICAgICBzZXRTb3VyY2UoUVVybCgicXJjOi9xbWwvQnJv d3NlcldpbmRvdy5xbWwiKSk7CiAgICAgY29ubmVjdChyb290T2JqZWN0KCksIFNJR05BTChwYWdl VGl0bGVDaGFuZ2VkKFFTdHJpbmcpKSwgdGhpcywgU0xPVChzZXRXaW5kb3dUaXRsZShRU3RyaW5n KSkpOwotICAgIGlmICghb3B0aW9ucy0+dXNlVG91Y2hXZWJWaWV3KCkpCisgICAgaWYgKG9wdGlv bnMtPnVzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW9yKCkpCiAgICAgICAgIHdlYlZpZXcoKS0+ ZXhwZXJpbWVudGFsKCktPnNldFVzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW91cih0cnVlKTsK ICAgICBpZiAob3B0aW9ucy0+c3RhcnRGdWxsU2NyZWVuKCkpCiAgICAgICAgIHNob3dGdWxsU2Ny ZWVuKCk7CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxp Y2F0aW9uLmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24u Y3BwCmluZGV4IDZhYWQwNDJlYThmYjA5Y2VmZWIwZDFhOWQ2ZjU5MTJmOTdhN2JmMzkuLmM3NGQw ZTI5NmE3MGY4NWNjOThiYTlmMzdmMjg2OGE2Y2RhODFjNWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p bmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCkBAIC0xNjgsNyArMTY4LDcgQEAg dm9pZCBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpzZW5kVG91Y2hFdmVudChRV2luZG93KiB0YXJn ZXRXaW5kb3cpCiBzdGF0aWMgdm9pZCBwcmludEhlbHAoY29uc3QgUVN0cmluZyYgcHJvZ3JhbU5h bWUpCiB7CiAgICAgcURlYnVnKCkgPDwgIlVzYWdlOiIgPDwgcHJvZ3JhbU5hbWUudG9MYXRpbjEo KS5kYXRhKCkKLSAgICAgICAgIDw8ICJbLS10b3VjaF0iCisgICAgICAgICA8PCAiWy0tZGVza3Rv cF0iCiAgICAgICAgICA8PCAiWy1yIGxpc3RdIgogICAgICAgICAgPDwgIlstLXJvYm90LXRpbWVv dXQgc2Vjb25kc10iCiAgICAgICAgICA8PCAiWy0tcm9ib3QtZXh0cmEtdGltZSBzZWNvbmRzXSIK QEAgLTE5Miw3ICsxOTIsNyBAQCB2b2lkIE1pbmlCcm93c2VyQXBwbGljYXRpb246OmhhbmRsZVVz ZXJPcHRpb25zKCkKICAgICAgICAgYXBwUXVpdCgwKTsKICAgICB9CiAKLSAgICBtX3dpbmRvd09w dGlvbnMuc2V0VXNlVG91Y2hXZWJWaWV3KHRha2VPcHRpb25GbGFnKCZhcmdzLCAiLS10b3VjaCIp KTsKKyAgICBtX3dpbmRvd09wdGlvbnMuc2V0VXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVoYXZpb3Io dGFrZU9wdGlvbkZsYWcoJmFyZ3MsICItLWRlc2t0b3AiKSk7CiAgICAgbV93aW5kb3dPcHRpb25z LnNldFByaW50TG9hZGVkVXJscyh0YWtlT3B0aW9uRmxhZygmYXJncywgIi12IikpOwogICAgIG1f d2luZG93T3B0aW9ucy5zZXRTdGFydE1heGltaXplZCh0YWtlT3B0aW9uRmxhZygmYXJncywgIi0t bWF4aW1pemUiKSk7CiAgICAgbV93aW5kb3dPcHRpb25zLnNldFN0YXJ0RnVsbFNjcmVlbih0YWtl T3B0aW9uRmxhZygmYXJncywgIi1mIikpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIv cXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJy b3dzZXJBcHBsaWNhdGlvbi5oCmluZGV4IGRhMjFhMmJmNTY5MDQ0MDYyZWQyYTYwYmY1ODA0YjVh NmI0NWUxMzYuLmNmZmJmNDg1MDUzODI4OTE1YTYzMTE3OWJiOTlhODM2YzA1ZWE1ODggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmgKQEAgLTQxLDE0 ICs0MSwxNCBAQAogY2xhc3MgV2luZG93T3B0aW9ucyA6IHB1YmxpYyBRT2JqZWN0IHsKICAgICBR X09CSkVDVAogICAgIFFfUFJPUEVSVFkoYm9vbCBwcmludExvYWRlZFVybHMgUkVBRCBwcmludExv YWRlZFVybHMpCi0gICAgUV9QUk9QRVJUWShib29sIHVzZVRvdWNoV2ViVmlldyBSRUFEIHVzZVRv dWNoV2ViVmlldykKKyAgICBRX1BST1BFUlRZKGJvb2wgdXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVo YXZpb3IgUkVBRCB1c2VUcmFkaXRpb25hbERlc2t0b3BCZWhhdmlvcikKICAgICBRX1BST1BFUlRZ KGJvb2wgc3RhcnRNYXhpbWl6ZWQgUkVBRCBzdGFydE1heGltaXplZCkKIAogcHVibGljOgogICAg IFdpbmRvd09wdGlvbnMoUU9iamVjdCogcGFyZW50ID0gMCkKICAgICAgICAgOiBRT2JqZWN0KHBh cmVudCkKICAgICAgICAgLCBtX3ByaW50TG9hZGVkVXJscyhmYWxzZSkKLSAgICAgICAgLCBtX3Vz ZVRvdWNoV2ViVmlldyhmYWxzZSkKKyAgICAgICAgLCBtX3VzZVRyYWRpdGlvbmFsRGVza3RvcEJl aGF2aW9yKGZhbHNlKQogICAgICAgICAsIG1fc3RhcnRNYXhpbWl6ZWQoZmFsc2UpCiAgICAgICAg ICwgbV93aW5kb3dTaXplKFFTaXplKDk4MCwgNzM1KSkKICAgICB7CkBAIC01Niw4ICs1Niw4IEBA IHB1YmxpYzoKIAogICAgIHZvaWQgc2V0UHJpbnRMb2FkZWRVcmxzKGJvb2wgZW5hYmxlZCkgeyBt X3ByaW50TG9hZGVkVXJscyA9IGVuYWJsZWQ7IH0KICAgICBib29sIHByaW50TG9hZGVkVXJscygp IGNvbnN0IHsgcmV0dXJuIG1fcHJpbnRMb2FkZWRVcmxzOyB9Ci0gICAgdm9pZCBzZXRVc2VUb3Vj aFdlYlZpZXcoYm9vbCBlbmFibGVkKSB7IG1fdXNlVG91Y2hXZWJWaWV3ID0gZW5hYmxlZDsgfQot ICAgIGJvb2wgdXNlVG91Y2hXZWJWaWV3KCkgY29uc3QgeyByZXR1cm4gbV91c2VUb3VjaFdlYlZp ZXc7IH0KKyAgICB2b2lkIHNldFVzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW9yKGJvb2wgZW5h YmxlZCkgeyBtX3VzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW9yID0gZW5hYmxlZDsgfQorICAg IGJvb2wgdXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVoYXZpb3IoKSBjb25zdCB7IHJldHVybiBtX3Vz ZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW9yOyB9CiAgICAgdm9pZCBzZXRTdGFydE1heGltaXpl ZChib29sIGVuYWJsZWQpIHsgbV9zdGFydE1heGltaXplZCA9IGVuYWJsZWQ7IH0KICAgICBib29s IHN0YXJ0TWF4aW1pemVkKCkgY29uc3QgeyByZXR1cm4gbV9zdGFydE1heGltaXplZDsgfQogICAg IHZvaWQgc2V0U3RhcnRGdWxsU2NyZWVuKGJvb2wgZW5hYmxlZCkgeyBtX3N0YXJ0RnVsbFNjcmVl biA9IGVuYWJsZWQ7IH0KQEAgLTY3LDcgKzY3LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAg IGJvb2wgbV9wcmludExvYWRlZFVybHM7Ci0gICAgYm9vbCBtX3VzZVRvdWNoV2ViVmlldzsKKyAg ICBib29sIG1fdXNlVHJhZGl0aW9uYWxEZXNrdG9wQmVoYXZpb3I7CiAgICAgYm9vbCBtX3N0YXJ0 TWF4aW1pemVkOwogICAgIGJvb2wgbV9zdGFydEZ1bGxTY3JlZW47CiAgICAgUVNpemUgbV93aW5k b3dTaXplOwo=