73859 2011-12-05 13:21:02 -0800 REGRESSION(r101949): css3/bdi-element.html fails on Lion 2011-12-05 15:59:18 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin eric mitz oldest_to_newest 515342 0 rniwa 2011-12-05 13:21:02 -0800 css3/bdi-element.html fails because: https://bugs.webkit.org/show_bug.cgi?id=73680 Comment #9 From mitz@webkit.org 2011-12-04 15:00:59 PST (-) [reply] (In reply to comment #8) > On Mac Lion, css3/bdi-element.html is now failing. > > The text ": 3 posts" is 1 pixel further to the left in the reference rendering compared to the test result. > > The technique we are using here may be incorrect. Right, an inline can have a non-integral width, but the reference rendering uses an inline block, whose width is always rounded up. 515347 1 117931 rniwa 2011-12-05 13:28:02 -0800 Created attachment 117931 fixes the expected result 515469 2 rniwa 2011-12-05 15:57:32 -0800 Committed r102060: <http://trac.webkit.org/changeset/102060> 515471 3 rniwa 2011-12-05 15:59:18 -0800 Thanks for the review! Sorry it took so long. Had an issue on laptop's svn checkout so had to wait 'til this morning to create the patch :( 117931 2011-12-05 13:28:02 -0800 2011-12-05 14:50:23 -0800 fixes the expected result bug-73859-20111205132801.patch text/plain 1709 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMjAzNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDExLTEyLTA1ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEwMTk0OSk6IGNzczMvYmRp LWVsZW1lbnQuaHRtbCBmYWlscyBvbiBMaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Mzg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBmYWlsdXJlIHdhcyBjYXVzZWQgYnkgc3BhbiB0aGF0IGNv bnRhaW5zIHRoZSB0ZXh0IGluc2lkZSBiZGkgaW4gdGhlIHJlZmVyZW5jZSBmaWxlCisgICAgICAg IHdhcyB1c2luZyBkaXNwbGF5OiBpbmxpbmUtYmxvY2suIEJlY2F1c2UgdGhlIHdpZHRoIG9mIGFu IGlubGluZS1ibG9jayBpcyBhbHdheXMgcm91bmRlZCB1cAorICAgICAgICBsaWtlIGFueSBvdGhl ciBpbmxpbmUgZWxlbWVudCwgaXQgY2F1c2VzIHRoZSB0ZXh0IGluIHRoZSByZWZlcmVuY2UgZmls ZSB0byBiZSBvbmUgcGl4ZWwKKyAgICAgICAgbG9uZ2VyIHRoYW4gdGhlIG9uZSBpbiB0aGUgdGVz dCBmaWxlIGluIGNlcnRhaW4gY2FzZXMuCisKKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSB1c2lu ZyB1bmljb2RlLWJpZGk6IG92ZXJyaWRlIGluc3RlYWQgb2YgZGlzcGxheTogaW5saW5lLWJsb2Nr IGluCisgICAgICAgIHRoZSByZWZlcmVuY2UgZmlsZS4KKworICAgICAgICAqIGNzczMvYmRpLWVs ZW1lbnQtZXhwZWN0ZWQuaHRtbDoKKwogMjAxMS0xMi0wNSAgQWxvayBQcml5YWRhcnNoaSAgPGFs b2twQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIExheW91dCBUZXN0IGNvbXBv c2l0aW5nL3NoYWRvd3Mvc2hhZG93LWRyYXdpbmcuaHRtbCBpcyBmYWlsaW5nCkluZGV4OiBMYXlv dXRUZXN0cy9jc3MzL2JkaS1lbGVtZW50LWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvY3NzMy9iZGktZWxlbWVudC1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAxMDIwMjkp CisrKyBMYXlvdXRUZXN0cy9jc3MzL2JkaS1lbGVtZW50LWV4cGVjdGVkLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTEzLDcgKzEzLDcgQEAgSW4gdGhpcyBleGFtcGxlLCB1c2VybmFtZXMgYXJlIHNo b3duIGFsbwogPHVsPgogIDxsaT5Vc2VyIGpjcmFubWVyOiAxMiBwb3N0cy4KICA8bGk+VXNlciBo b2JlcjogNSBwb3N0cy4KLSA8bGk+VXNlciA8c3BhbiBzdHlsZT0iZGlzcGxheTogaW5saW5lLWJs b2NrOyI+2KXZitin2YY8L3NwYW4+PHNwYW4gZGlyPSJsdHIiPjogMyBwb3N0cy48L3NwYW4+PC9z cGFuPgorIDxsaT5Vc2VyIDxzcGFuIHN0eWxlPSJ1bmljb2RlLWJpZGk6IGVtYmVkOyI+2KXZitin 2YY8L3NwYW4+PHNwYW4gc3R5bGU9ImRpcmVjdGlvbjogbHRyOyB1bmljb2RlLWJpZGk6IG92ZXJy aWRlOyI+OiAzIHBvc3RzLjwvc3Bhbj48L3NwYW4+CiA8L3VsPgogPC9ib2R5PgogPC9odG1sPgo=