73857 2011-12-05 12:48:11 -0800 AX: aria-hidden doesn't work on iframe elements 2011-12-05 14:44:49 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin webkit.review.bot oldest_to_newest 515317 0 cfleizach 2011-12-05 12:48:11 -0800 aria-hidden does not seem to work on iframe elements. 515401 1 117940 cfleizach 2011-12-05 14:38:11 -0800 Created attachment 117940 patch 515402 2 cfleizach 2011-12-05 14:38:34 -0800 rdar://10451054 515407 3 117940 darin 2011-12-05 14:41:59 -0800 Comment on attachment 117940 patch View in context: https://bugs.webkit.org/attachment.cgi?id=117940&action=review > Source/WebCore/accessibility/AccessibilityScrollView.cpp:135 > + AccessibilityObject *webArea = webAreaObject(); The * should be next to the type. 515408 4 webkit.review.bot 2011-12-05 14:42:10 -0800 Attachment 117940 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/mac/accessibility/ifr..." exit_code: 1 Source/WebCore/accessibility/AccessibilityScrollView.cpp:135: Declaration has space between type name and * in AccessibilityObject *webArea [whitespace/declaration] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 515411 5 cfleizach 2011-12-05 14:44:49 -0800 http://trac.webkit.org/changeset/102051 117940 2011-12-05 14:38:11 -0800 2011-12-05 14:41:59 -0800 patch patch.txt text/plain 6858 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjA0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTA1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGFyaWEtaGlkZGVu IGRvZXNuJ3Qgd29yayBvbiBpZnJhbWUgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkv aWZyYW1lLWFyaWEtaGlkZGVuLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5 UmVuZGVyT2JqZWN0OjphZGRBdHRhY2htZW50Q2hpbGRyZW4pOgorICAgICAgICAoV2ViQ29yZTo6 QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWRkQ2hpbGRyZW4pOgorICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oOgorICAgICAgICAqIGFjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVNjcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNj ZXNzaWJpbGl0eVNjcm9sbFZpZXc6OmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQpOgorICAgICAgICAo V2ViQ29yZTo6QWNjZXNzaWJpbGl0eVNjcm9sbFZpZXc6OmFkZENoaWxkcmVuKToKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlTY3JvbGxWaWV3Lmg6CisKIDIwMTEtMTItMDUg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIExh eWVyRmx1c2hTY2hlZHVsZXJDbGllbnQ6OmZsdXNoTGF5ZXJzIGluZGljYXRlIHdoZXRoZXIgdGhl IGZsdXNoIHdhcyBzdWNjZXNzZnVsIG9yIG5vdApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5U2Nyb2xsVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNjcm9sbFZpZXcuaAkocmV2aXNpb24g MTAyMDMwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5U2Ny b2xsVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBACiBwcml2YXRlOgogICAg IEFjY2Vzc2liaWxpdHlTY3JvbGxWaWV3KFNjcm9sbFZpZXcqKTsKICAgICAKLSAgICB2aXJ0dWFs IGJvb2wgYWNjZXNzaWJpbGl0eUlzSWdub3JlZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Cisg ICAgdmlydHVhbCBib29sIGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKSBjb25zdDsKICAgICB2aXJ0 dWFsIGJvb2wgaXNBY2Nlc3NpYmlsaXR5U2Nyb2xsVmlldygpIGNvbnN0IHsgcmV0dXJuIHRydWU7 IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQog ICAgIApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmgJKHJldmlzaW9uIDEwMjAzMCkKKysrIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMDMsNiArMzAzLDcgQEAKIAogICAgIHZvaWQgYWRkVGV4dEZpZWxkQ2hpbGRy ZW4oKTsKICAgICB2b2lkIGFkZEltYWdlTWFwQ2hpbGRyZW4oKTsKKyAgICB2b2lkIGFkZEF0dGFj aG1lbnRDaGlsZHJlbigpOwogICAgIAogICAgIHZvaWQgYXJpYVNlbGVjdGVkUm93cyhBY2Nlc3Np YmlsaXR5Q2hpbGRyZW5WZWN0b3ImKTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVNjcm9sbFZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNjcm9sbFZpZXcuY3BwCShyZXZp c2lvbiAxMDIwMzApCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlTY3JvbGxWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDE0ICsxMjksMjMgQEAKICAg ICBtX3ZlcnRpY2FsU2Nyb2xsYmFyID0gMDsKICAgICBtX2hvcml6b250YWxTY3JvbGxiYXIgPSAw OwogfQorCitib29sIEFjY2Vzc2liaWxpdHlTY3JvbGxWaWV3OjphY2Nlc3NpYmlsaXR5SXNJZ25v cmVkKCkgY29uc3QKK3sKKyAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0ICp3ZWJBcmVhID0gd2ViQXJl YU9iamVjdCgpOworICAgIGlmICghd2ViQXJlYSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg CisgICAgcmV0dXJuIHdlYkFyZWEtPmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKTsKK30KKwogdm9p ZCBBY2Nlc3NpYmlsaXR5U2Nyb2xsVmlldzo6YWRkQ2hpbGRyZW4oKQogewogICAgIEFTU0VSVCgh bV9oYXZlQ2hpbGRyZW4pOwogICAgIG1faGF2ZUNoaWxkcmVuID0gdHJ1ZTsKICAgICAKICAgICBB Y2Nlc3NpYmlsaXR5T2JqZWN0KiB3ZWJBcmVhID0gd2ViQXJlYU9iamVjdCgpOwotICAgIGlmICh3 ZWJBcmVhKQorICAgIGlmICh3ZWJBcmVhICYmICF3ZWJBcmVhLT5hY2Nlc3NpYmlsaXR5SXNJZ25v cmVkKCkpCiAgICAgICAgIG1fY2hpbGRyZW4uYXBwZW5kKHdlYkFyZWEpOwogICAgIAogICAgIHVw ZGF0ZVNjcm9sbGJhcnMoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMTAy MDMwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUwMCw2ICszNTAwLDIxIEBACiAgICAgbV9j aGlsZHJlbi5hcHBlbmQoYXhTcGluQnV0dG9uKTsKIH0KIAordm9pZCBBY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0OjphZGRBdHRhY2htZW50Q2hpbGRyZW4oKQoreworICAgIGlmICghaXNBdHRhY2ht ZW50KCkpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIEZyYW1lVmlldydzIG5lZWQgdG8gYmUg aW5zZXJ0ZWQgaW50byB0aGUgQVggaGllcmFyY2h5IHdoZW4gZW5jb3VudGVyZWQuCisgICAgV2lk Z2V0KiB3aWRnZXQgPSB3aWRnZXRGb3JBdHRhY2htZW50VmlldygpOworICAgIGlmICghd2lkZ2V0 IHx8ICF3aWRnZXQtPmlzRnJhbWVWaWV3KCkpCisgICAgICAgIHJldHVybjsKKyAgICAKKyAgICBB Y2Nlc3NpYmlsaXR5T2JqZWN0KiBheFdpZGdldCA9IGF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVh dGUod2lkZ2V0KTsKKyAgICBpZiAoIWF4V2lkZ2V0LT5hY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkp CisgICAgICAgIG1fY2hpbGRyZW4uYXBwZW5kKGF4V2lkZ2V0KTsKK30KKyAgICAKIHZvaWQgQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWRkQ2hpbGRyZW4oKQogewogICAgIC8vIElmIHRoZSBu ZWVkIHRvIGFkZCBtb3JlIGNoaWxkcmVuIGluIGFkZGl0aW9uIHRvIGV4aXN0aW5nIGNoaWxkcmVu IGFyaXNlcywgCkBAIC0zNTM0LDEzICszNTQ5LDcgQEAKICAgICAgICAgfQogICAgIH0KICAgICAK LSAgICAvLyBGcmFtZVZpZXcncyBuZWVkIHRvIGJlIGluc2VydGVkIGludG8gdGhlIEFYIGhpZXJh cmNoeSB3aGVuIGVuY291bnRlcmVkLgotICAgIGlmIChpc0F0dGFjaG1lbnQoKSkgewotICAgICAg ICBXaWRnZXQqIHdpZGdldCA9IHdpZGdldEZvckF0dGFjaG1lbnRWaWV3KCk7Ci0gICAgICAgIGlm ICh3aWRnZXQgJiYgd2lkZ2V0LT5pc0ZyYW1lVmlldygpKQotICAgICAgICAgICAgbV9jaGlsZHJl bi5hcHBlbmQoYXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZSh3aWRnZXQpKTsKLSAgICB9Ci0g ICAgCisgICAgYWRkQXR0YWNobWVudENoaWxkcmVuKCk7CiAgICAgYWRkSW1hZ2VNYXBDaGlsZHJl bigpOwogICAgIGFkZFRleHRGaWVsZENoaWxkcmVuKCk7CiB9CkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9pZnJhbWUtYXJpYS1oaWRkZW4uaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9pZnJhbWUtYXJp YS1oaWRkZW4uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9h Y2Nlc3NpYmlsaXR5L2lmcmFtZS1hcmlhLWhpZGRlbi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDQwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+ Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0PgordmFyIHN1Y2Nl c3NmdWxseVBhcnNlZCA9IGZhbHNlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4v ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHkgaWQ9ImJvZHkiPgorCis8aWZyYW1lIGFyaWEtaGlkZGVuPSJ0cnVlIiBpZD0iaWZyYW1lIiBz cmM9InJlc291cmNlcy9jYWtlLnBuZyIgd2lkdGg9IjQwMCIgaGVpZ2h0PSI1MDAiIHNjcm9sbGlu Zz0iYXV0byIgZnJhbWVib3JkZXI9IjEiPmZhbGwgYmFjayBjb250ZW50PC9pZnJhbWU+CisKKzxw IGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3Jp cHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGFyaWEtaGlkZGVuIHdpbGwg YWZmZWN0IHRoZSB2aXNpYmlsaXR5IG9mIHRoZSB3ZWIgYXJlYSBhbmQgc2Nyb2xsIHZpZXcuIik7 CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJvZHkiKS5mb2N1cygpOworCisgICAgICAgIC8vIEdl dCB0aGUgaWZyYW1lIHJlZmVyZW5jZS4KKyAgICAgICAgdmFyIGJvZHkgPSBhY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKyAgICAgICAgc2hvdWxkQmUoImJvZHkuY2hpbGRy ZW5Db3VudCIsICIzIik7CisgICAgICAgIHNob3VsZEJlKCJib2R5LmNoaWxkQXRJbmRleCgwKS5j aGlsZHJlbkNvdW50IiwgIjAiKTsKKworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi aWZyYW1lIikuc2V0QXR0cmlidXRlKCJhcmlhLWhpZGRlbiIsICJmYWxzZSIpOworICAgICAgICBz aG91bGRCZSgiYm9keS5jaGlsZHJlbkNvdW50IiwgIjQiKTsKKyAgICAgICAgc2hvdWxkQmUoImJv ZHkuY2hpbGRBdEluZGV4KDApLmNoaWxkQXRJbmRleCgwKS5jaGlsZEF0SW5kZXgoMCkucm9sZSIs ICInQVhSb2xlOiBBWFdlYkFyZWEnIik7CisgICAgfQorCisgICAgc3VjY2Vzc2Z1bGx5UGFyc2Vk ID0gdHJ1ZTsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2lmcmFtZS1hcmlhLWhpZGRl bi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvaWZyYW1lLWFyaWEtaGlkZGVuLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2lmcmFtZS1hcmlhLWhp ZGRlbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKKworVGhpcyB0 ZXN0cyB0aGF0IGFyaWEtaGlkZGVuIHdpbGwgYWZmZWN0IHRoZSB2aXNpYmlsaXR5IG9mIHRoZSB3 ZWIgYXJlYSBhbmQgc2Nyb2xsIHZpZXcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIGJvZHkuY2hpbGRyZW5Db3VudCBpcyAzCitQQVNTIGJvZHkuY2hpbGRBdEluZGV4KDAp LmNoaWxkcmVuQ291bnQgaXMgMAorUEFTUyBib2R5LmNoaWxkcmVuQ291bnQgaXMgNAorUEFTUyBi b2R5LmNoaWxkQXRJbmRleCgwKS5jaGlsZEF0SW5kZXgoMCkuY2hpbGRBdEluZGV4KDApLnJvbGUg aXMgJ0FYUm9sZTogQVhXZWJBcmVhJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisK