73851 2011-12-05 12:21:53 -0800 [MutationObservers] Enable in Chromium trunk 2011-12-13 08:40:21 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73919 73937 68729 1 rafaelw rafaelw adamk darin fishd jarek ojan rniwa sam vsevik webkit.review.bot oldest_to_newest 515279 0 rafaelw 2011-12-05 12:21:53 -0800 Mutation observers is now functionally complete on the chromium port (some work in JSC remains for completeness). We'd like to now parallelize getting developer feedback and completing the development work. In particular, we plan to invite chrome extension developers who are currently using DOM Mutation Events to experiment with re-implementing using Mutation Observers. Note that there is currently no plan to release Mutation Observers to chrome beta or release channel, and doing so is predicated on (at minimum) completing all blocking work on the webkit Mutation Observers meta bug (68729). 515551 1 117967 rafaelw 2011-12-05 17:47:24 -0800 Created attachment 117967 Patch 515685 2 117967 webkit.review.bot 2011-12-05 23:50:04 -0800 Comment on attachment 117967 Patch Clearing flags on attachment: 117967 Committed r102102: <http://trac.webkit.org/changeset/102102> 515686 3 webkit.review.bot 2011-12-05 23:50:10 -0800 All reviewed patches have been landed. Closing bug. 515935 4 vsevik 2011-12-06 08:28:30 -0800 This patch caused a lot of failures. 1) https://bugs.webkit.org/show_bug.cgi?id=73919 Layout Test inspector/debugger/dom-breakpoints.html is failing on chromium linux debug 2) This patch caused compile failures on all chromium.webkit win builder bots once another patch triggered recompilation of WebKit.cpp. Compile failures were fixed by clobbering builder bots. 3) https://bugs.webkit.org/show_bug.cgi?id=73925 REGRESSION(r102102): Causes segmentation fault on chromium unit_tests, content_unittests, sync_unit_tests (Requested by vsevik on #webkit). ----- Please run chromium try bots before landing this patch next time. http://www.chromium.org/developers/testing/try-server-usage#TOC-Simultaneously-patch-code-in-the-We describes how to do that using --sub_rep. I think you should also notify chromium/webkit sheriffs before landing this patch because rolling webkit DEPS with this patch can potentially break chromium tree (win builders) 515955 5 adamk 2011-12-06 09:17:09 -0800 (In reply to comment #4) > This patch caused a lot of failures. Sorry the trouble. > 1) > https://bugs.webkit.org/show_bug.cgi?id=73919 > Layout Test inspector/debugger/dom-breakpoints.html is failing on chromium linux debug > > 2) > This patch caused compile failures on all chromium.webkit win builder bots once another patch triggered recompilation of WebKit.cpp. > Compile failures were fixed by clobbering builder bots. Here's the failure: http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/13012/steps/compile/logs/stdio It's not clear to me whether there's anything we can do here besides clobbering (haven't seen these errors on Linux or Mac builds). > 3) > https://bugs.webkit.org/show_bug.cgi?id=73925 > REGRESSION(r102102): Causes segmentation fault on chromium unit_tests, content_unittests, sync_unit_tests (Requested by vsevik on #webkit). Do you have a stack trace for these segfaults? I don't see any output from the bots. > > ----- > > Please run chromium try bots before landing this patch next time. > http://www.chromium.org/developers/testing/try-server-usage#TOC-Simultaneously-patch-code-in-the-We describes how to do that using --sub_rep. > > I think you should also notify chromium/webkit sheriffs before landing this patch because rolling webkit DEPS with this patch can potentially break chromium tree (win builders) 515962 6 vsevik 2011-12-06 09:29:14 -0800 > > 3) > > https://bugs.webkit.org/show_bug.cgi?id=73925 > > REGRESSION(r102102): Causes segmentation fault on chromium unit_tests, content_unittests, sync_unit_tests (Requested by vsevik on #webkit). > > Do you have a stack trace for these segfaults? I don't see any output from the bots. No. The bots didn't have anything. I've just built everything release configuration locally and bisected to find the failure reason, so I don't have a stack trace. It reproduces locally easily (I did it on linux). 516049 7 adamk 2011-12-06 11:08:12 -0800 (In reply to comment #6) > > > 3) > > > https://bugs.webkit.org/show_bug.cgi?id=73925 > > > REGRESSION(r102102): Causes segmentation fault on chromium unit_tests, content_unittests, sync_unit_tests (Requested by vsevik on #webkit). > > > > Do you have a stack trace for these segfaults? I don't see any output from the bots. > No. The bots didn't have anything. I've just built everything release configuration locally and bisected to find the failure reason, so I don't have a stack trace. > It reproduces locally easily (I did it on linux). Reproduces locally, the problem is WebKit::initialize() is called with WebKitPlatformSupport::currentThread() NULL. Patch on the way. 516912 8 118276 adamk 2011-12-07 14:11:18 -0800 Created attachment 118276 Patch 516936 9 adamk 2011-12-07 14:46:32 -0800 Committed r102275: <http://trac.webkit.org/changeset/102275> 520047 10 jarek 2011-12-13 05:48:24 -0800 I'm interested in testing this feature, but window.MutationObserver object is not present in current Chromium snapashot (http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?path=Linux_x64/114205/) Do I need some additional flag to enable it? 520097 11 adamk 2011-12-13 08:40:21 -0800 (In reply to comment #10) > I'm interested in testing this feature, but window.MutationObserver object is not present in current Chromium snapashot (http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?path=Linux_x64/114205/) > > Do I need some additional flag to enable it? It's vendor-prefixed: look for window.WebKitMutationObserver. 117967 2011-12-05 17:47:24 -0800 2011-12-07 14:11:15 -0800 Patch bug-73851-20111205174723.patch text/plain 1263 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQwNmE4YjM0ZGIxNzk1MzU2OWRlMDQ1MTNmMDA5NDlhZmQ0MjhmMmIuLjVjNTU0MWFiZTc2Zjg1 MzVjYzFlODY3ZDI5OTU0NjA4NzdiNmQwNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMTItMDUgIFJhZmFlbCBXZWluc3RlaW4gIDxyYWZhZWx3QGNo cm9taXVtLm9yZz4KKworICAgICAgICBbTXV0YXRpb25PYnNlcnZlcnNdIEVuYWJsZSBpbiBDaHJv bWl1bSB0cnVuaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzM4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZlYXR1cmVzLmd5cGk6CisKIDIwMTEtMTItMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIENocm9taXVtIGZhaWxzIHRvIGNvbXBpbGUg ZHVlIHRvIG1pc3NpbmcgV2ViQ29udGVudExheWVyQ2xpZW50LmgKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v ZmVhdHVyZXMuZ3lwaQppbmRleCBlMDhmNjVhNWMyZGM5YzdjNzRmNjNjZDY5NjBjMjk4YjQxMDgz MWY0Li41MDczZDQzNGMxOTQ0MTU1ODc4MTRhNjExOThmYTdjOTA1NjRlMjA2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCkBAIC0xMTUsNyArMTE1LDcgQEAKICAgICAgICdlbmFi bGVfdG91Y2hfZXZlbnRzJSc6IDEsCiAgICAgICAndXNlX3NraWElJzogMCwKICAgICAgICdlbmFi bGVfdG91Y2hfaWNvbl9sb2FkaW5nJScgOiAwLAotICAgICAgJ2VuYWJsZV9tdXRhdGlvbl9vYnNl cnZlcnMlJzogMCwKKyAgICAgICdlbmFibGVfbXV0YXRpb25fb2JzZXJ2ZXJzJSc6IDEsCiAgICAg fSwKICAgICAndXNlX2FjY2VsZXJhdGVkX2NvbXBvc2l0aW5nJSc6ICc8KHVzZV9hY2NlbGVyYXRl ZF9jb21wb3NpdGluZyknLAogICAgICdlbmFibGVfc2tpYV90ZXh0JSc6ICc8KGVuYWJsZV9za2lh X3RleHQpJywK 118276 2011-12-07 14:11:18 -0800 2011-12-07 14:44:08 -0800 Patch bug-73851-20111207141117.patch text/plain 2732 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY5Nzk5NWZlMTY4MTQ1YjJjZDA5ZjlhYmUwMzliYzhkMWFlYTQzNTQuLmExNDU5NWIzNDI5MTAw ZTJkMzg3YTcyMjc3YTFiY2QyZmMyOGI2YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMTItMDcgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBFbmFibGUgaW4gQ2hyb21pdW0gdHJ1 bmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczODUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmUtbGFu ZGluZyBhZnRlciBmaXhpbmcgQ2hyb21pdW0gdW5pdCB0ZXN0IGNyYXNoZXMgaW4gcjEwMjE3MQor ICAgICAgICBhbmQgaW5zcGVjdG9yIGRlYnVnZ2VyIGNyYXNoIGluIHIxMDIyNjQuCisKKyAgICAg ICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDExLTEyLTA3ICBKb25hdGhhbiBCYWNrZXIgIDxiYWNr ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUGx1bWIgZGFtYWdlIGZyb20g V2ViRXh0ZXJuYWxUZXh0dXJlTGF5ZXIgYW5kIFdlYlBsdWdpbkNvbnRhaW5lciB0byBDQ0RhbWFn ZVRyYWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lw aSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCBlMDhmNjVhNWMy ZGM5YzdjNzRmNjNjZDY5NjBjMjk4YjQxMDgzMWY0Li41MDczZDQzNGMxOTQ0MTU1ODc4MTRhNjEx OThmYTdjOTA1NjRlMjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1 cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCkBAIC0x MTUsNyArMTE1LDcgQEAKICAgICAgICdlbmFibGVfdG91Y2hfZXZlbnRzJSc6IDEsCiAgICAgICAn dXNlX3NraWElJzogMCwKICAgICAgICdlbmFibGVfdG91Y2hfaWNvbl9sb2FkaW5nJScgOiAwLAot ICAgICAgJ2VuYWJsZV9tdXRhdGlvbl9vYnNlcnZlcnMlJzogMCwKKyAgICAgICdlbmFibGVfbXV0 YXRpb25fb2JzZXJ2ZXJzJSc6IDEsCiAgICAgfSwKICAgICAndXNlX2FjY2VsZXJhdGVkX2NvbXBv c2l0aW5nJSc6ICc8KHVzZV9hY2NlbGVyYXRlZF9jb21wb3NpdGluZyknLAogICAgICdlbmFibGVf c2tpYV90ZXh0JSc6ICc8KGVuYWJsZV9za2lhX3RleHQpJywKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMDAzOWM2NWRhMjI0 MDAzOTIxYjdhNTgzMWEyYmJiYTcxYmI5ZTcyLi5jNzgwNTIxZTNmMzhhN2Y0NmRlYzQ5ZGYzZmMy ZGM5MDI4YmQ1ZmVjIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTItMDcgIEFkYW0gS2xl aW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBF bmFibGUgaW4gQ2hyb21pdW0gdHJ1bmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTczODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6 IFN0b3Agc2tpcHBpbmcgZmFzdC9tdXRhdGlvbiB0ZXN0cy4KKwogMjAxMS0xMi0wNyAgSm9zaHVh IEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQiBkZWxldGVJ bmRleCBzaG91bGQgdGhyb3cgTk9UX0FMTE9XRURfRVJSIGlmIGNhbGxlZCBvdXRzaWRlIGEgVkVS U0lPTl9DSEFOR0UgdHJhbnNhY3Rpb24gY2FsbGJhY2sKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBmMDA1OWQ5ZDM5N2M3 YTAxZTE5ZThjNGE5ZjE0M2EyZjVmMjEwNzQ1Li5iNDRkOWM2NTNmY2Q1ZTc5Nzg4NzVkMjc4OWQ1 NTBjOTAyODdjMTFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v dGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0zMTk4LDkgKzMxOTgsNiBAQCBCVUdXSzU3MzEyIDog ZmFzdC9yZWdpb25zID0gUEFTUyBGQUlMIE1JU1NJTkcKIC8vIENTUyBGaWx0ZXJzIHN1cHBvcnQg bm90IHlldCBlbmFibGVkCiBCVUdXSzY4NDY5IFNLSVAgOiBjc3MzL2ZpbHRlcnMgPSBQQVNTCiAK LS8vIE11dGF0aW9uT2JzZXJ2ZXJzIG5vdCB5ZXQgZW5hYmxlZC4KLUJVR1dLNjg3MjkgU0tJUCA6 IGZhc3QvbXV0YXRpb24gPSBQQVNTCi0KIC8vIDxzdHlsZSBzY29wZWQ+IG5vdCB5ZXQgZW5hYmxl ZC4KIEJVR1dLNDkxNDIgU0tJUCA6IGZhc3QvY3NzL3N0eWxlLXNjb3BlZCA9IFBBU1MKIAo=