73841 2011-12-05 10:32:01 -0800 On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer 2011-12-05 10:47:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sfalken sfalken oldest_to_newest 515172 0 sfalken 2011-12-05 10:32:01 -0800 On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer 515174 1 117896 sfalken 2011-12-05 10:33:03 -0800 Created attachment 117896 Patch 515179 2 117896 aroben 2011-12-05 10:39:53 -0800 Comment on attachment 117896 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117896&action=review > Source/WebCore/ChangeLog:9 > + No new tests. (OOPS!) You should mention why this is. > Source/WebCore/platform/win/ClipboardWin.cpp:575 > - files->append(File::create((*it).characters())); > + files->append(File::create(*it)); It would be nice to explain in your ChangeLog why this fixes things. It took me a while to realize the problem must have been due to characters() not being null-terminated. 515192 3 sfalken 2011-12-05 10:47:04 -0800 Committed r102016: <http://trac.webkit.org/changeset/102016> 117896 2011-12-05 10:33:03 -0800 2011-12-05 10:39:53 -0800 Patch bug-73841-20111205103244.patch text/plain 1416 sfalken SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMjAxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTA1ICBTdGV2ZSBG YWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgT24gV2luZG93cywgZmlsZW5hbWVzIG5vdCBwcm9wZXJs eSBwcmVzZXJ2ZWQgd2hlbiBjb3BpZWQgaW50byBhIGZpbGUgbGlzdCBleHBvc2VkIGJ5IEV2ZW50 LmRhdGFUcmFuc2ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzM4NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwNTIxODc5PgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vd2luL0NsaXBib2Fy ZFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRXaW46OmZpbGVzKToKKwogMjAx MS0xMS0xOCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEwNDY2MTcwPiBSZWdyZXNzaW9uOiBTY3JvbGwgYmFycyBkaXNhcHBlYXIgYW5k IGRvbid0IGNvbWUgYmFjawpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBi b2FyZFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0Ns aXBib2FyZFdpbi5jcHAJKHJldmlzaW9uIDEwMTI3MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzIsNyArNTcyLDcg QEAgUGFzc1JlZlB0cjxGaWxlTGlzdD4gQ2xpcGJvYXJkV2luOjpmaWxlcwogICAgICAgICByZXR1 cm4gZmlsZXMucmVsZWFzZSgpOwogICAgIFZlY3RvcjxTdHJpbmc+IGZpbGVzVmVjdG9yID0gbV9k cmFnRGF0YU1hcC5nZXQoY2ZIRHJvcEZvcm1hdCgpLT5jZkZvcm1hdCk7CiAgICAgZm9yIChWZWN0 b3I8U3RyaW5nPjo6aXRlcmF0b3IgaXQgPSBmaWxlc1ZlY3Rvci5iZWdpbigpOyBpdCAhPSBmaWxl c1ZlY3Rvci5lbmQoKTsgKytpdCkKLSAgICAgICAgZmlsZXMtPmFwcGVuZChGaWxlOjpjcmVhdGUo KCppdCkuY2hhcmFjdGVycygpKSk7CisgICAgICAgIGZpbGVzLT5hcHBlbmQoRmlsZTo6Y3JlYXRl KCppdCkpOwogICAgIHJldHVybiBmaWxlcy5yZWxlYXNlKCk7CiAjZW5kaWYKIH0K